April 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestE...

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36647?usp=email ) Change subject: SGP32Definitions_Templates: improve ts_initiateAuthenticationRequestEsipa ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97aa039810ad9fffea4226254fa675fd24647de1 Gerrit-Change-Number: 36647 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 Apr 2024 12:15:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in docker-playground[master]: asterisk-master: Use pjproject from external git repo

by laforge

Attention is currently required from: jolly, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email ) Change subject: asterisk-master: Use pjproject from external git repo ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm wondering if we should have this [as a commit] in our forked asterisk.git, so that even manual builds [from our fork/branch] will use and build right/matching pjproject.git So basically make this work not just for the docker container here, but for all builds? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I73f3323db1b6897fc43215578b0a011fdb6909c5 Gerrit-Change-Number: 36649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 Apr 2024 12:12:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in docker-playground[master]: asterisk-master: Use pjproject from external git repo

by laforge

Attention is currently required from: jolly, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email ) Change subject: asterisk-master: Use pjproject from external git repo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I73f3323db1b6897fc43215578b0a011fdb6909c5 Gerrit-Change-Number: 36649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 28 Apr 2024 12:11:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-e1d[master]: iCE1usb: Add support to configure CRC4 mode for TX/RX

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email ) Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/vty.c: https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/434e2f31_60b6ae9d PS1, Line 434: framing-tx (no-crc4|crc4)", this could be one command for both rx and tx like "framing (rx|tx) (no-crc4|crc4)". Not critical, just a thought. Especially since both the functions are 99% identical. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb Gerrit-Change-Number: 36653 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Sun, 28 Apr 2024 11:24:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-e1d[master]: iCE1usb: Add support to configure CRC4 mode for TX/RX

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email ) Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX ...................................................................... iCE1usb: Add support to configure CRC4 mode for TX/RX Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb --- M src/e1d.h M src/usb.c M src/vty.c 3 files changed, 84 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/53/36653/1 diff --git a/src/e1d.h b/src/e1d.h index bf1cbdf..55e5415 100644 --- a/src/e1d.h +++ b/src/e1d.h @@ -78,6 +78,11 @@ }; extern const struct value_string e1_ts_mode_names[]; +enum e1_framing_mode { + E1_FRAMING_MODE_CRC4 = 0, + E1_FRAMING_MODE_NO_CRC4, +}; + struct e1_ts { struct e1_line *line; uint8_t id; @@ -160,6 +165,14 @@ uint32_t rx_bytes; } watchdog; + /* driver specific data */ + struct { + struct { + enum e1_framing_mode tx; + enum e1_framing_mode rx; + } framing; + } usb; + void *e1gen_priv; }; diff --git a/src/usb.c b/src/usb.c index 8d431f5..3b77b94 100644 --- a/src/usb.c +++ b/src/usb.c @@ -1036,14 +1036,29 @@ goto next_interface; } - /* Create data flows and start the line */ + /* Configure, create data flows and start the line */ /* all supported devices have an IN endpoint */ + e1_usb_ctrl_set_rx_cfg(line, + (line->usb.framing.rx == E1_FRAMING_MODE_CRC4) ? + ICE1USB_RX_MODE_MULTIFRAME : + ICE1USB_RX_MODE_FRAME + ); + line_data->flow_in = e1uf_create(line, e1_usb_xfer_in, line_data->ep_in, 4, line_data->pkt_size, 4); e1uf_start(line_data->flow_in); /* e1-tracer has no OUT or FEEDBACK endpoint */ if (!is_tracer) { + e1_usb_ctrl_set_tx_cfg(line, + (line->usb.framing.tx == E1_FRAMING_MODE_CRC4) ? + ICE1USB_TX_MODE_TS0_CRC4_E : + ICE1USB_TX_MODE_TS0, + ICE1USB_TX_TIME_SRC_LOCAL, + ICE1USB_TX_EXT_LOOPBACK_OFF, + 0x00 + ); + line_data->flow_out = e1uf_create(line, e1_usb_xfer_out, line_data->ep_out, 4, line_data->pkt_size, 4); e1uf_start(line_data->flow_out); line_data->flow_fb = e1uf_create(line, e1_usb_xfer_fb, line_data->ep_fb, 2, 3, 1); diff --git a/src/vty.c b/src/vty.c index 5b4ca47..5083153 100644 --- a/src/vty.c +++ b/src/vty.c @@ -168,6 +168,12 @@ { 0, NULL } }; +const struct value_string e1_framing_mode_names[] = { + { E1_FRAMING_MODE_CRC4, "crc4" }, + { E1_FRAMING_MODE_NO_CRC4, "no-crc4" }, + { 0, NULL } +}; + static void vty_dump_line(struct vty *vty, const struct e1_line *line) { unsigned int tn; @@ -424,12 +430,49 @@ return CMD_SUCCESS; } +DEFUN(cfg_e1d_if_line_framing_tx, cfg_e1d_if_line_framing_tx_cmd, + "framing-tx (no-crc4|crc4)", + NO_STR "Sets the transmitted E1 framing mode\n") +{ + struct e1_line *line = vty->index; + + if (line->intf->drv != E1_DRIVER_USB) + return CMD_WARNING; + + enum e1_framing_mode new_mode = get_string_value(e1_framing_mode_names, argv[0]); + line->usb.framing.tx = new_mode; + + return CMD_SUCCESS; + +} + +DEFUN(cfg_e1d_if_line_framing_rx, cfg_e1d_if_line_framing_rx_cmd, + "framing-rx (no-crc4|crc4)", + NO_STR "Sets the expected received E1 framing mode\n") +{ + struct e1_line *line = vty->index; + + if (line->intf->drv != E1_DRIVER_USB) + return CMD_WARNING; + + enum e1_framing_mode new_mode = get_string_value(e1_framing_mode_names, argv[0]); + line->usb.framing.rx = new_mode; + + return CMD_SUCCESS; +} + + static int config_write_line(struct vty *vty, struct e1_line *line) { vty_out(vty, " line %u%s", line->id, VTY_NEWLINE); vty_out(vty, " mode %s%s", get_value_string(e1_line_mode_names, line->mode), VTY_NEWLINE); + if (line->intf->drv == E1_DRIVER_USB) { + vty_out(vty, " framing-tx %s%s", get_value_string(e1_framing_mode_names, line->usb.framing.tx), VTY_NEWLINE); + vty_out(vty, " framing-rx %s%s", get_value_string(e1_framing_mode_names, line->usb.framing.tx), VTY_NEWLINE); + } + return 0; } @@ -521,4 +564,6 @@ install_node(&line_node, NULL); install_element(LINE_NODE, &cfg_e1d_if_line_mode_cmd); + install_element(LINE_NODE, &cfg_e1d_if_line_framing_tx_cmd); + install_element(LINE_NODE, &cfg_e1d_if_line_framing_rx_cmd); } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb Gerrit-Change-Number: 36653 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Add README.md

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email ) Change subject: epdg: Add README.md ...................................................................... epdg: Add README.md Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 --- A epdg/README.md 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/epdg/README.md b/epdg/README.md new file mode 100644 index 0000000..6f5ea70 --- /dev/null +++ b/epdg/README.md @@ -0,0 +1,26 @@ +# EPDG_Tests.ttcn + +* external interfaces + * CEAI: GSUP (emulates strongswan) + * SWx: Diameter (emulates HSS) + * S6b: Diameter (emulates SMF) + * S2b: GTPv2C (emulates SMF) + * Emulates userplane IPsec decapsulated IP traffic at strongswan + * Emulates userplane GTPv1U encapsulated IP traffic at UPF + +{% dot epdg_tests.svg +digraph G { + rankdir=LR; + ATS [label="ATS\nEPDG_Tests.ttcn"]; + EPDG [label="EPDG\nosmo-epdg",shape="box", color=red]; + GTP_KERN [label="gtp\nkernel-module", shape="box"]; + + ATS -> EPDG [label="CEAI (GSUP)"]; + ATS -> EPDG [label="S6b (Diameter)"]; + EPDG -> ATS [label="SWx (Diameter)"] + EPDG -> ATS [label="S2b (GTPv2C)"]; + ATS -> EPDG [label="IP traffic (to/from strongswan ipsec)", style=dashed]; + EPDG -> GTP_KERN [label="netlink"] + GTP_KERN -> ATS [label="IP traffic (GTPv1U to/from UPF)", style=dashed] +} +%} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 Gerrit-Change-Number: 36637 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: drop legacy hack: do not start MGW endp in loopback mode

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email ) Change subject: drop legacy hack: do not start MGW endp in loopback mode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 Gerrit-Change-Number: 36634 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Apr 2024 19:16:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Configure new IMS ConnHdlr

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36643?usp=email ) Change subject: ttcn3-asterisk: Configure new IMS ConnHdlr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0ee6cb8955fc4f7dec3db97c768430905374f115 Gerrit-Change-Number: 36643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Apr 2024 19:15:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-sgsn[master]: contrib/osmo-sgsn.spec: fix build for almalinux:8

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36648?usp=email ) Change subject: contrib/osmo-sgsn.spec: fix build for almalinux:8 ...................................................................... contrib/osmo-sgsn.spec: fix build for almalinux:8 Add the missing "%if 0%{?suse_version}" around %service_del/add commands, as these are only available on opensuse. Fix for: error: line 106: Too many names: %preun -n osmo-gtphub %service_del_preun osmo-gtphub.service Fixes: a07e6d9c (".deb/.rpm: add osmocom user during package install") Change-Id: I89802f926bfccc0f7b4bb1ff64115b232b1db022 --- M contrib/osmo-sgsn.spec.in 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/osmo-sgsn.spec.in b/contrib/osmo-sgsn.spec.in index d1382cb..031cd14 100644 --- a/contrib/osmo-sgsn.spec.in +++ b/contrib/osmo-sgsn.spec.in @@ -100,10 +100,12 @@ chown root:osmocom /etc/osmocom chmod 2775 /etc/osmocom +%if 0%{?suse_version} %preun -n osmo-gtphub %service_del_preun osmo-gtphub.service %postun -n osmo-gtphub %service_del_postun osmo-gtphub.service %pre -n osmo-gtphub %service_add_pre osmo-gtphub.service %post -n osmo-gtphub %service_add_post osmo-gtphub.service +%endif %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36648?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I89802f926bfccc0f7b4bb1ff64115b232b1db022 Gerrit-Change-Number: 36648 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-sgsn[master]: contrib/osmo-sgsn.spec: fix build for almalinux:8

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36648?usp=email ) Change subject: contrib/osmo-sgsn.spec: fix build for almalinux:8 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36648?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I89802f926bfccc0f7b4bb1ff64115b232b1db022 Gerrit-Change-Number: 36648 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Apr 2024 19:15:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024