Attention is currently required from: dexter, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36004?usp=email )
Change subject: Fix license headers: Should have been AGPLv3+, not GPLv2+
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36004?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I42ea544ae4e5c4d3bedad12ddb55cf3c26a30919
Gerrit-Change-Number: 36004
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Feb 2024 20:14:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36005?usp=email )
Change subject: Fix license headers: Should have been AGPLv3+, not GPLv2+
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36005?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Ie28c32022a9cbc42b55195f7dbb513228857a3cd
Gerrit-Change-Number: 36005
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Feb 2024 20:14:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35733?usp=email )
Change subject: saip: profile processing; merging with templates
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35733?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib1674920e488ade9597cb039e4e2047dcbc7864e
Gerrit-Change-Number: 35733
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 18 Feb 2024 18:49:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36009?usp=email )
Change subject: utils: Add function to verify Luhn check digits and to sanitize ICCIDs
......................................................................
Patch Set 1:
(1 comment)
File tests/test_utils.py:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14478):
https://gerrit.osmocom.org/c/pysim/+/36009/comment/930018f8_33eb9a92
PS1, Line 251: # 19 digits without correct luhn; we expect chck digit to be added
'chck' may be misspelled - perhaps 'check'?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36009?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7812420cf97984dd834fca6a38c5e5ae113243cb
Gerrit-Change-Number: 36009
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 18 Feb 2024 18:49:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment