lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

February 2024

  • 1 participants
  • 1748 discussions
[S] Change in pysim[master]: pylint: sysmocom_sja2.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35839?usp=email ) Change subject: pylint: sysmocom_sja2.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e5b5c6f3179f9710464af4cba91d682412b8a09 Gerrit-Change-Number: 35839 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:03:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in pysim[master]: pylint: cdma_ruim.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35838?usp=email ) Change subject: pylint: cdma_ruim.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4c384f37a6a317c6eddef8742572fcfa76a5fc20 Gerrit-Change-Number: 35838 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:03:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in pysim[master]: pylint: global_platform/scp.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35837?usp=email ) Change subject: pylint: global_platform/scp.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd2b779a6628c88d9a48c94b8581525209824426 Gerrit-Change-Number: 35837 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:03:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in pysim[master]: pylint: esim/saip/oid.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35836?usp=email ) Change subject: pylint: esim/saip/oid.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I65c9cd1bb2b6a1747a7fbb25052adc75605bc870 Gerrit-Change-Number: 35836 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in pysim[master]: pylint: esim/saip/templates.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35835?usp=email ) Change subject: pylint: esim/saip/templates.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I181578ba630c8bdb558297e990411b59593652a0 Gerrit-Change-Number: 35835 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:02:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in libosmo-gprs[master]: rlcmac: uncomment RLC/MAC msg_type checking in DATA.cnf
by fixeria 05 Feb '24

05 Feb '24
Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35858?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: rlcmac: uncomment RLC/MAC msg_type checking in DATA.cnf ...................................................................... rlcmac: uncomment RLC/MAC msg_type checking in DATA.cnf Change-Id: I4a0c553201d51453d9197d254f796f6574a2dab0 --- M src/rlcmac/rlcmac_prim.c M tests/rlcmac/rlcmac_prim_test.c 2 files changed, 13 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/58/35858/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I4a0c553201d51453d9197d254f796f6574a2dab0 Gerrit-Change-Number: 35858 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in libosmo-gprs[master]: rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window()
by fixeria 05 Feb '24

05 Feb '24
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35861?usp=email ) Change subject: rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() ...................................................................... rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() * drop unused variable 'i' (fixes -Wunused-but-set-variable) * reduce nesting in the for-loop Change-Id: Ic0efd2f84a17d287b73261c102bca84e8274bb2a --- M src/rlcmac/rlc_window_ul.c 1 file changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/61/35861/1 diff --git a/src/rlcmac/rlc_window_ul.c b/src/rlcmac/rlc_window_ul.c index af1c32b..e8c07e6 100644 --- a/src/rlcmac/rlc_window_ul.c +++ b/src/rlcmac/rlc_window_ul.c @@ -291,18 +291,16 @@ unsigned int gprs_rlcmac_rlc_ul_window_move_window(struct gprs_rlcmac_rlc_ul_window *ulw) { struct gprs_rlcmac_rlc_window *w = rlc_ulw_as_w(ulw); - unsigned int i; - uint16_t bsn; unsigned int moved = 0; + uint16_t bsn; - for (i = 0, bsn = gprs_rlcmac_rlc_ul_window_v_a(ulw); + for (bsn = gprs_rlcmac_rlc_ul_window_v_a(ulw); bsn != gprs_rlcmac_rlc_ul_window_v_s(ulw); - i++, bsn = gprs_rlcmac_rlc_window_mod_sns_bsn(w, bsn + 1)) { - if (gprs_rlcmac_rlc_v_b_is_acked(&ulw->v_b, bsn)) { - gprs_rlcmac_rlc_v_b_mark_invalid(&ulw->v_b, bsn); - moved += 1; - } else + bsn = gprs_rlcmac_rlc_window_mod_sns_bsn(w, bsn + 1)) { + if (!gprs_rlcmac_rlc_v_b_is_acked(&ulw->v_b, bsn)) break; + moved += 1; + gprs_rlcmac_rlc_v_b_mark_invalid(&ulw->v_b, bsn); } return moved; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic0efd2f84a17d287b73261c102bca84e8274bb2a Gerrit-Change-Number: 35861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in pysim[master]: pylint: esim/saip/personalization.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35834?usp=email ) Change subject: pylint: esim/saip/personalization.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I70b3e266bbafabbfcec3d48027d50b45c2c17809 Gerrit-Change-Number: 35834 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:02:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in pysim[master]: pylint: esim/rsp.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35833?usp=email ) Change subject: pylint: esim/rsp.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id87dbf82cd41ce6e5276e5bdd7af1877d77e3fab Gerrit-Change-Number: 35833 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:02:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in pysim[master]: pylint: esim/x509_cert.py
by laforge 05 Feb '24

05 Feb '24
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35832?usp=email ) Change subject: pylint: esim/x509_cert.py ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic435c9a7cfcc18cacec3a3d872925bd737fb5cd9 Gerrit-Change-Number: 35832 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Feb 2024 17:02:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 137
  • 138
  • 139
  • 140
  • 141
  • 142
  • 143
  • ...
  • 175
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.