February 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: mobile: assert() values returned by get_string_value()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email ) Change subject: mobile: assert() values returned by get_string_value() ...................................................................... mobile: assert() values returned by get_string_value() Change-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index a4da22a..87c8045 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -2721,6 +2721,8 @@ struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; int val = get_string_value(tch_voice_io_handler_names, argv[0]); + OSMO_ASSERT(val >= 0); + if (val == TCH_VOICE_IOH_MNCC_SOCK) { if (ms->settings.mncc_handler != MNCC_HANDLER_INTERNAL) { vty_out(vty, "TCH voice I/O handler 'mncc-sock' can only be used " @@ -2755,12 +2757,13 @@ struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; + OSMO_ASSERT(val >= 0); + if (set->tch_voice.io_handler != TCH_VOICE_IOH_GAPK) { vty_out(vty, "This parameter is only valid for GAPK%s", VTY_NEWLINE); return CMD_WARNING; } - OSMO_ASSERT(val >= 0); set->tch_voice.io_format = val; return CMD_SUCCESS; @@ -2828,6 +2831,8 @@ { int val = get_string_value(tch_data_io_handler_names, argv[0]); + OSMO_ASSERT(val >= 0); + return set_tch_data_io_handler(vty, val); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e Gerrit-Change-Number: 35868 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email ) Change subject: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo' ...................................................................... mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo' Change-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d --- M src/host/layer23/src/mobile/vty_interface.c 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index b0457e3..a4da22a 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -2695,7 +2695,7 @@ static int set_tch_voice_io_handler(struct vty *vty, enum tch_voice_io_handler val) { - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; /* Don't restart on unchanged value */ @@ -2718,7 +2718,7 @@ "External MNCC application (e.g. LCR) via MNCC socket\n" "Return TCH frame payload back to sender\n") { - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; int val = get_string_value(tch_voice_io_handler_names, argv[0]); if (val == TCH_VOICE_IOH_MNCC_SOCK) { @@ -2752,7 +2752,7 @@ "Texas Instruments format, used by Calypso based phones (e.g. Motorola C1xx)\n") { int val = get_string_value(tch_voice_io_format_names, argv[0]); - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; if (set->tch_voice.io_handler != TCH_VOICE_IOH_GAPK) { @@ -2804,7 +2804,7 @@ static int set_tch_data_io_handler(struct vty *vty, enum tch_data_io_handler val) { - struct osmocom_ms *ms = (struct osmocom_ms *) vty->index; + struct osmocom_ms *ms = (struct osmocom_ms *)vty->index; struct gsm_settings *set = &ms->settings; /* Don't restart on unchanged value */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d Gerrit-Change-Number: 35867 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: disable TCH/F14.4 (not implemented)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35738?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mobile: disable TCH/F14.4 (not implemented) ...................................................................... mobile: disable TCH/F14.4 (not implemented) Change-Id: Ia8dff81d4b56c9d6599059f3a5a2964d3cd95829 Related: OS#4396, OS#6346 --- M doc/examples/mobile/default.cfg M src/host/layer23/src/common/support.c 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified jolly: Looks good to me, approved diff --git a/doc/examples/mobile/default.cfg b/doc/examples/mobile/default.cfg index 3b46a85..676c76f 100644 --- a/doc/examples/mobile/default.cfg +++ b/doc/examples/mobile/default.cfg @@ -53,6 +53,12 @@ full-speech-v1 full-speech-v2 half-speech-v1 + no full-data-14400 + full-data-9600 + full-data-4800 + half-data-4800 + full-data-2400 + half-data-2400 min-rxlev -106 dsc-max 90 no skip-max-per-band diff --git a/src/host/layer23/src/common/support.c b/src/host/layer23/src/common/support.c index ed51465..a31b456 100644 --- a/src/host/layer23/src/common/support.c +++ b/src/host/layer23/src/common/support.c @@ -99,7 +99,7 @@ sup->half_v3 = 0; /* CSD modes */ - sup->csd_tch_f144 = 1; + sup->csd_tch_f144 = 0; sup->csd_tch_f96 = 1; sup->csd_tch_f48 = 1; sup->csd_tch_h48 = 1; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia8dff81d4b56c9d6599059f3a5a2964d3cd95829 Gerrit-Change-Number: 35738 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: assert() values returned by get_string_value()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email ) Change subject: mobile: assert() values returned by get_string_value() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e Gerrit-Change-Number: 35868 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 09:22:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email ) Change subject: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d Gerrit-Change-Number: 35867 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 09:22:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-msc[master]: cosmetic: rename to sdp_audio_codecs_foreach()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35880?usp=email ) Change subject: cosmetic: rename to sdp_audio_codecs_foreach() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia96190e0bdb513886663be1c8c12be3b403b71c9 Gerrit-Change-Number: 35880 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 09:21:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-msc[master]: tweak apidoc for sdp_audio_codecs_remove()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35877?usp=email ) Change subject: tweak apidoc for sdp_audio_codecs_remove() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1d281f61497336783126aef39165426523b22112 Gerrit-Change-Number: 35877 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 09:21:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-msc[master]: cosmetic: tweak sdp_audio_codecs_by_payload_type()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35876?usp=email ) Change subject: cosmetic: tweak sdp_audio_codecs_by_payload_type() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3c4e29cb240e2a9a00bc9dd065ec85a5e8d8fe38 Gerrit-Change-Number: 35876 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 09:19:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-msc[master]: cosmetic: move check for CSD further above

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35875?usp=email ) Change subject: cosmetic: move check for CSD further above ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibd21f0bb46c66a406904105564ce961a8760cbe7 Gerrit-Change-Number: 35875 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 09:18:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-msc[master]: fix misnomer in msc_a.c: codec_cn -> codec_assigned

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35874?usp=email ) Change subject: fix misnomer in msc_a.c: codec_cn -> codec_assigned ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie7966099c5565013018734b0c2028484c24341a7 Gerrit-Change-Number: 35874 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Feb 2024 09:18:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024