December 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_modify & TC_e_rab_modify_multi

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39077?usp=email ) Change subject: s1gw: add TC_e_rab_modify & TC_e_rab_modify_multi ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39077/comment/ab9a3287_055d… : PS1, Line 163: pfcp_rem_seid := omit /* assigned by S1GW */ core_far_id and access_far_id here? (from comment in previous patch) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I58b9964bae24b5aac526ee0c0c8ac8798f351e05 Gerrit-Change-Number: 39077 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 09:56:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email ) Change subject: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076/comment/4467ab58_1d2a… : PS1, Line 739: far_id := 1); looks like instead we may want to store far_id in erabs[i]? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52317e79ac02cb4e321b49c2cd824de28e25a1c6 Gerrit-Change-Number: 39076 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 09:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: add E-RAB MODIFY REQ/RSP templates

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39075?usp=email ) Change subject: library/s1ap: add E-RAB MODIFY REQ/RSP templates ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39075?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id38cd51698c1388311a41f045ff08ec7f8a85146 Gerrit-Change-Number: 39075 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 09:52:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: f_tr_S1AP_RABSetupRsp(): use ispresent()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39074?usp=email ) Change subject: library/s1ap: f_tr_S1AP_RABSetupRsp(): use ispresent() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ee1246ef9f32ac7d5ce107d3ba9ea11ed87af20 Gerrit-Change-Number: 39074 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 09:51:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 3: -Code-Review (1 comment) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/e1aadf5b_ced8… : PS3, Line 512: istemplatekind(cause, "*")) > This is impossible because the template restriction of the function argument is `(omit)`, meaning th […] Indeed, good catch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Dec 2024 09:50:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email ) Change subject: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a Gerrit-Change-Number: 39073 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Dec 2024 09:49:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: segmented_read: Avoid triggering read events if user unregis...

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39072?usp=email ) Change subject: osmo_io: segmented_read: Avoid triggering read events if user unregisters ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: BSC_Tests both with poll and io-uring backend is running fully correctly with this patchset applied. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2199b9aa805cc7e7793c1a8aecd10b61f2b4c90 Gerrit-Change-Number: 39072 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 09:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_modify & TC_e_rab_modify_multi

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39077?usp=email ) Change subject: s1gw: add TC_e_rab_modify & TC_e_rab_modify_multi ...................................................................... s1gw: add TC_e_rab_modify & TC_e_rab_modify_multi Test the E-RAB Modify procedure (MME initiated), which is defined in 3GPP TS 36.413 section 8.2.2. Change-Id: I58b9964bae24b5aac526ee0c0c8ac8798f351e05 --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M s1gw/expected-results.xml 3 files changed, 217 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/39077/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 4634064..c1c1701 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -281,6 +281,7 @@ } /* 256 is maxnoofE-RABs (see S1AP_Constants.asn) */ +type record length(0..256) of E_RAB_ID ERabIdList; type record length(1..256) of ERab ERabList; type record ERab { E_RAB_ID erab_id, /* ::= INTEGER (0..15, ...) */ @@ -288,6 +289,7 @@ ERabParams c2u, /* Core -> UPF params */ ERabParams a2u, /* Access -> UPF params */ ERabParams u2a, /* UPF -> Access params */ + ERabParams u2cm, /* UPF -> Core params (modified) */ OCT8 pfcp_loc_seid, OCT8 pfcp_rem_seid optional }; @@ -390,6 +392,129 @@ return pdu; } +function f_ConnHdlr_tx_erab_modify_req(in ERabList erabs, + boolean transport_info := true) +runs on ConnHdlr { + var template (value) E_RABToBeModifiedListBearerModReq items; + var template (value) E_RABLevelQoSParameters qos_params; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + + qos_params := valueof(ts_E_RABLevelQoSParameters); + + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + var template (value) E_RABToBeModifiedItemBearerModReq item; + + if (transport_info) { + var template (value) TransportLayerAddress tla; + var ERabParams epars := erabs[i].u2cm; + + tla := oct2bit(f_inet_addr(epars.tla)); + item := ts_E_RABToBeModifiedItemBearerModReqExt(rab_id := erabs[i].erab_id, + qos_params := qos_params, + nas_pdu := ''O, + tla := tla, + gtp_teid := epars.teid); + } else { + item := ts_E_RABToBeModifiedItemBearerModReq(rab_id := erabs[i].erab_id, + qos_params := qos_params, + nas_pdu := ''O); + } + + items[i] := ts_E_RABToBeModifiedListBearerModReq(item)[0]; + } + + f_ConnHdlr_tx_s1ap_from_mme(ts_S1AP_RABModifyReq(g_pars.mme_ue_id, enb_ue_id, + rab_modify_items := items)); +} + +function f_ConnHdlr_rx_erab_modify_req(in ERabList erabs, + boolean transport_info := true) +runs on ConnHdlr return S1AP_PDU { + var template (present) E_RABToBeModifiedListBearerModReq items; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var S1AP_PDU pdu; + + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + var template (present) E_RABToBeModifiedItemBearerModReq item; + + if (transport_info) { + var template (present) TransportLayerAddress tla; + var ERabParams epars := erabs[i].a2u; + + tla := oct2bit(f_inet_addr(epars.tla)); + item := tr_E_RABToBeModifiedItemBearerModReqExt(rab_id := erabs[i].erab_id, + qos_params := ?, + nas_pdu := ''O, + tla := tla, + gtp_teid := epars.teid); + } else { + item := tr_E_RABToBeModifiedItemBearerModReq(rab_id := erabs[i].erab_id, + qos_params := ?, + nas_pdu := ''O); + } + + items[i] := tr_E_RABToBeModifiedListBearerModReq(item)[0]; + } + + f_ConnHdlr_rx_s1ap_from_mme(pdu, tr_S1AP_RABModifyReq(g_pars.mme_ue_id, enb_ue_id, + rab_modify_items := items)); + return pdu; +} + +function f_ConnHdlr_tx_erab_modify_rsp(in ERabIdList erabs_modified, + in ERabIdList erabs_failed) +runs on ConnHdlr { + var template (value) E_RABModifyListBearerModRes items_modified; + var template (omit) E_RABList items_failed := omit; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var template (value) E_RABModifyItemBearerModRes item; + + item := ts_E_RABModifyItemBearerModRes(erabs_modified[i]); + items_modified[i] := ts_E_RABModifyListBearerModRes(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) { + var template (value) E_RABItem item; + + item := ts_E_RABItem(erabs_failed[i]); + items_failed[i] := ts_E_RABList(item)[0]; + } + + f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_RABModifyRsp(g_pars.mme_ue_id, enb_ue_id, + rab_modified_items := items_modified, + rab_failed_items := items_failed)); +} + +function f_ConnHdlr_rx_erab_modify_rsp(in ERabIdList erabs_modified, + in ERabIdList erabs_failed) +runs on ConnHdlr return S1AP_PDU { + var template (present) E_RABModifyListBearerModRes items_modified; + var template E_RABList items_failed; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var S1AP_PDU pdu; + + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var template (present) E_RABModifyItemBearerModRes item; + + item := tr_E_RABModifyItemBearerModRes(erabs_modified[i]); + items_modified[i] := tr_E_RABModifyListBearerModRes(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) { + var template (present) E_RABItem item; + + item := tr_E_RABItem(erabs_failed[i]); + items_failed[i] := tr_E_RABList(item)[0]; + } + + f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_RABModifyRsp(g_pars.mme_ue_id, enb_ue_id, + rab_modified_items := items_modified, + rab_failed_items := items_failed)); + return pdu; +} + private function f_ts_E_RABList(in ERabList erabs, S1AP_IEs.Cause cause) return template (value) E_RABList { @@ -791,6 +916,49 @@ f_ConnHdlr_rx_erab_setup_rsp(erabs); } +function f_ConnHdlr_erab_modify_req(in ERabList erabs) +runs on ConnHdlr { + log("eNB <- [S1GW <- MME]: E-RAB MODIFY REQUEST"); + f_ConnHdlr_tx_erab_modify_req(erabs); + /* Expect the S1GW to modify FARs (id=2) of the respective PFCP sessions */ + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + log("UPF <- S1GW: PFCP Session Modification Request for E-RAB ID ", erabs[i].erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(epars := erabs[i].u2cm, + seid := erabs[i].pfcp_loc_seid, + far_id := 2); /* Access -> Core */ + log("UPF -> S1GW: PFCP Session Modification Response for E-RAB ID ", erabs[i].erab_id); + f_ConnHdlr_tx_session_modify_resp(erabs[i], pdu); + } + log("[eNB <- S1GW] <- MME: E-RAB MODIFY REQUEST"); + f_ConnHdlr_rx_erab_modify_req(erabs); +} + +function f_ConnHdlr_erab_modify_rsp(in ERabIdList erabs_modified, + in ERabIdList erabs_failed) +runs on ConnHdlr { + log("[eNB -> S1GW] -> MME: E-RAB MODIFY RESPONSE"); + f_ConnHdlr_tx_erab_modify_rsp(erabs_modified, erabs_failed); + /* For successfully modified E-RABs, U2CM becomes U2C */ + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var E_RAB_ID erab_id := erabs_modified[i]; + g_pars.erabs[erab_id].u2c := g_pars.erabs[erab_id].u2cm; + } + /* Expect the S1GW to modify (revert) FARs (id=2) for failed E-RABs */ + for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) { + var E_RAB_ID erab_id := erabs_failed[i]; + var ERab erab := g_pars.erabs[erab_id]; + + log("UPF <- S1GW: PFCP Session Modification Request for E-RAB ID ", erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(epars := erab.u2c, + seid := erab.pfcp_loc_seid, + far_id := 2); /* Access -> Core */ + log("UPF -> S1GW: PFCP Session Modification Response for E-RAB ID ", erab_id); + f_ConnHdlr_tx_session_modify_resp(erab, pdu); + } + log("eNB -> [S1GW -> MME]: E-RAB MODIFY RESPONSE"); + f_ConnHdlr_rx_erab_modify_rsp(erabs_modified, erabs_failed); +} + function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) runs on ConnHdlr { diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 729bc77..9cd1e6a 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -158,6 +158,7 @@ c2u := {'0101'O & uid, "127.0.1.1"}, a2u := {'0202'O & uid, "127.0.2.2"}, u2a := {'0002'O & uid, "127.0.0.2"}, + u2cm := {'0011'O & uid, "127.127.0.1"}, pfcp_loc_seid := seid_prefix & uid, pfcp_rem_seid := omit /* assigned by S1GW */ }; @@ -427,6 +428,49 @@ vc_conn.done; } +/* Test E-RAB MODIFY Req/Rsp procedure */ +function f_TC_e_rab_modify(charstring id) runs on ConnHdlr { + f_ConnHdlr_s1ap_register(g_pars.genb_id); + f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); + f_ConnHdlr_s1ap_setup(g_pars.genb_id); + + f_ConnHdlr_erab_setup_req(g_pars.erabs); + f_ConnHdlr_erab_setup_rsp(g_pars.erabs); + + /* MME orders eNB to modify all 4 E-RABs */ + f_ConnHdlr_erab_modify_req(g_pars.erabs); + /* eNB modifies E-RABs 1 and 3, but not E-RAB 0 and 2 */ + f_ConnHdlr_erab_modify_rsp(erabs_modified := {1, 3}, + erabs_failed := {0, 2}); + + f_ConnHdlr_erab_release_cmd(g_pars.erabs); + f_ConnHdlr_erab_release_rsp(g_pars.erabs); + + f_ConnHdlr_s1ap_disconnect(); + f_ConnHdlr_s1ap_unregister(g_pars.genb_id); +} +private function TC_e_rab_modify_exec(integer num_enbs) +runs on test_CT { + var ConnHdlrList vc_conns; + + f_init(); + + for (var integer i := 0; i < num_enbs; i := i + 1) { + var ConnHdlrPars pars := valueof(t_ConnHdlrPars(i, num_erabs := 4)); + vc_conns[i] := f_ConnHdlr_spawn(refers(f_TC_e_rab_modify), pars); + } + + f_ConnHdlrList_all_done(vc_conns); +} +/* 4 E-RABs at a time, single eNB */ +testcase TC_e_rab_modify() runs on test_CT { + TC_e_rab_modify_exec(num_enbs := 1); +} +/* 4 E-RABs at a time, multiple eNB connections */ +testcase TC_e_rab_modify_multi() runs on test_CT { + TC_e_rab_modify_exec(num_enbs := mp_multi_enb_num); +} + /* Test INITIAL CONTEXT SETUP procedure (successful case) */ function f_TC_initial_ctx_setup(charstring id) runs on ConnHdlr { f_ConnHdlr_s1ap_register(g_pars.genb_id); @@ -545,6 +589,8 @@ execute( TC_e_rab_setup3_multi() ); execute( TC_e_rab_release_ind() ); execute( TC_e_rab_setup_failure() ); + execute( TC_e_rab_modify() ); + execute( TC_e_rab_modify_multi() ); execute( TC_initial_ctx_setup() ); execute( TC_initial_ctx_setup3() ); execute( TC_initial_ctx_setup_multi() ); diff --git a/s1gw/expected-results.xml b/s1gw/expected-results.xml index c6995c9..34d98a8 100644 --- a/s1gw/expected-results.xml +++ b/s1gw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='S1GW_Tests' tests='16' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='S1GW_Tests' tests='17' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='S1GW_Tests' name='TC_setup' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_setup_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_conn_term_by_mme' time='MASKED'/> @@ -10,6 +10,8 @@ <testcase classname='S1GW_Tests' name='TC_e_rab_setup3_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_e_rab_release_ind' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_e_rab_setup_failure' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_e_rab_modify' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_e_rab_modify_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_initial_ctx_setup' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_initial_ctx_setup3' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_initial_ctx_setup_multi' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I58b9964bae24b5aac526ee0c0c8ac8798f351e05 Gerrit-Change-Number: 39077 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email ) Change subject: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible ...................................................................... s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible Allow the caller to pass FAR ID, SEID, and E-RAB parameters (F-TEID), so that it can also be used for testing the E-RAB MODIFY procedure. Change-Id: I52317e79ac02cb4e321b49c2cd824de28e25a1c6 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/39076/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 453eff5..4634064 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -664,25 +664,27 @@ PFCP.send(resp); } -function f_ConnHdlr_rx_session_modify_req(in ERab erab) +function f_ConnHdlr_rx_session_modify_req(in ERabParams epars, + template (present) OCT8 seid := ?, + template (present) LIN4_BO_LAST far_id := ?) runs on ConnHdlr return PDU_PFCP { /* Forwarding Action Rules */ - var template (present) Outer_Header_Creation ohc1; - var template (present) Update_Forwarding_Parameters fpars1; - var template (present) Update_FAR far1; + var template (present) Outer_Header_Creation ohc; + var template (present) Update_Forwarding_Parameters fpars; + var template (present) Update_FAR far; - ohc1 := tr_PFCP_Outer_Header_Creation_GTP_ipv4(erab.u2a.teid, - f_inet_addr(erab.u2a.tla)); - fpars1 := tr_PFCP_Update_Forwarding_Parameters(ohc := ohc1); + ohc := tr_PFCP_Outer_Header_Creation_GTP_ipv4(epars.teid, + f_inet_addr(epars.tla)); + fpars := tr_PFCP_Update_Forwarding_Parameters(ohc := ohc); - far1 := tr_PFCP_Update_FAR(far_id := 1, /* -- for Core -> Access */ - aa := tr_PFCP_Apply_Action_FORW, - fp := fpars1); + far := tr_PFCP_Update_FAR(far_id := far_id, + aa := tr_PFCP_Apply_Action_FORW, + fp := fpars); /* The final Session Modification Request PDU */ var template (present) PDU_PFCP tr_pdu; - tr_pdu := tr_PFCP_Session_Mod_Req(seid := erab.pfcp_loc_seid, - update_far := far1); + tr_pdu := tr_PFCP_Session_Mod_Req(seid := seid, + update_far := far); return f_ConnHdlr_pfcp_expect(tr_pdu); } @@ -732,7 +734,9 @@ runs on ConnHdlr { for (var integer i := 0; i < lengthof(erabs); i := i + 1) { log("UPF <- S1GW: PFCP Session Modification Request for E-RAB ID ", erabs[i].erab_id); - var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(erabs[i]); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(epars := erabs[i].u2a, + seid := erabs[i].pfcp_loc_seid, + far_id := 1); log("UPF -> S1GW: PFCP Session Modification Response for E-RAB ID ", erabs[i].erab_id); f_ConnHdlr_tx_session_modify_resp(erabs[i], pdu); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52317e79ac02cb4e321b49c2cd824de28e25a1c6 Gerrit-Change-Number: 39076 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: f_tr_S1AP_RABSetupRsp(): use ispresent()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39074?usp=email ) Change subject: library/s1ap: f_tr_S1AP_RABSetupRsp(): use ispresent() ...................................................................... library/s1ap: f_tr_S1AP_RABSetupRsp(): use ispresent() Change-Id: I6ee1246ef9f32ac7d5ce107d3ba9ea11ed87af20 --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/39074/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 0a91935..58722e5 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -1301,7 +1301,7 @@ }; var integer idx := lengthof(rsp.protocolIEs); - if (isvalue(rab_setup_items) or istemplatekind(rab_setup_items, "?")) { + if (ispresent(rab_setup_items)) { rsp.protocolIEs[idx] := { id := S1AP_Constants.id_E_RABSetupListBearerSURes, criticality := ignore, @@ -1309,7 +1309,7 @@ }; idx := idx + 1; } - if (isvalue(rab_failed_items) or istemplatekind(rab_failed_items, "?")) { + if (ispresent(rab_failed_items)) { rsp.protocolIEs[idx] := { id := S1AP_Constants.id_E_RABFailedToSetupListBearerSURes, criticality := ignore, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ee1246ef9f32ac7d5ce107d3ba9ea11ed87af20 Gerrit-Change-Number: 39074 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024