December 2024 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: use erab_uid() to log unique E-RAB ID

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39109?usp=email ) Change subject: s1ap_proxy: use erab_uid() to log unique E-RAB ID ...................................................................... s1ap_proxy: use erab_uid() to log unique E-RAB ID Change-Id: I89d8bedcd6acc1d8cdd6f56bf36ffa3001f2c8c2 --- M src/s1ap_proxy.erl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/09/39109/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index ec729d0..86c2bed 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -438,7 +438,7 @@ {{error, Reason}, S} end; error -> - ?LOG_ERROR("E-RAB-ID ~p is not registered", [ERABId]), + ?LOG_ERROR("E-RAB-ID ~p is not registered", [erab_uid(ERABId, S)]), {{error, erab_not_registered}, S} end; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I89d8bedcd6acc1d8cdd6f56bf36ffa3001f2c8c2 Gerrit-Change-Number: 39109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: rework handle_ie/2 into handle_ie/3

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39111?usp=email ) Change subject: s1ap_proxy: rework handle_ie/2 into handle_ie/3 ...................................................................... s1ap_proxy: rework handle_ie/2 into handle_ie/3 This patch prepares for a follow-up change adding E-RAB MODIFY REQ/RSP. Instead of passing the whole record #'ProtocolIE-Field' to handle_ie(), pass the IEI ('id' field) and IE content ('value' field) as separate arguments. This split-up allows to pass the full IEI path to handle_ie() in a follow-up change, and also allows to expand some fields of the IE content right in the function header. Change-Id: Ic71c8c07739b0e354ca9c9b03c000a366d8c2c43 --- M src/s1ap_proxy.erl 1 file changed, 58 insertions(+), 67 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/11/39111/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 5cacb59..4d78b29 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -60,7 +60,7 @@ -type s1ap_pdu() :: {initiatingMessage, #'InitiatingMessage'{}} | {successfulOutcome, #'SuccessfulOutcome'{}} | {unsuccessfulOutcome, #'UnsuccessfulOutcome'{}}. --type s1ap_ie() :: #'ProtocolIE-Field'{}. +-type s1ap_ie_id() :: non_neg_integer(). -type s1ap_ie_val() :: tuple(). -type mme_ue_id() :: 0..16#ffffffff. @@ -392,20 +392,23 @@ %% Handle a single IE (Information Element) -type handle_ie_result() :: {ok, s1ap_ie_val()} | {error, term()}. --spec handle_ie(s1ap_ie(), proxy_state()) -> {handle_ie_result(), proxy_state()}. +-spec handle_ie(IEI, C, S) -> Result + when IEI :: s1ap_ie_id(), + C :: s1ap_ie_val(), + S :: proxy_state(), + Result :: {handle_ie_result(), + proxy_state()}. %% E-RAB SETUP REQUEST related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupListBearerSUReq', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeSetupListBearerSUReq', C, S) -> %% This IE contains a list of BearerSUReq, so patch inner IEs - handle_ies(Content, ?'id-E-RABToBeSetupItemBearerSUReq', S); + handle_ies(C, ?'id-E-RABToBeSetupItemBearerSUReq', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupItemBearerSUReq', - value = C0}, S0) -> +handle_ie(?'id-E-RABToBeSetupItemBearerSUReq', + #'E-RABToBeSetupItemBearerSUReq'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S0) -> %% start and register an E-RAB FSM - #'E-RABToBeSetupItemBearerSUReq'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, {Pid, S1} = erab_fsm_start_reg(ERABId, S0), case erab_fsm:erab_setup_req(Pid, {TEID_In, TLA_In}) of {ok, {TEID_Out, TLA_Out}} -> @@ -417,17 +420,15 @@ end; %% E-RAB SETUP RESPONSE related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupListBearerSURes', - value = Content}, S) -> +handle_ie(?'id-E-RABSetupListBearerSURes', C, S) -> %% This IE contains a list of BearerSURes, so patch inner IEs - handle_ies(Content, ?'id-E-RABSetupItemBearerSURes', S); + handle_ies(C, ?'id-E-RABSetupItemBearerSURes', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupItemBearerSURes', - value = C0}, S) -> +handle_ie(?'id-E-RABSetupItemBearerSURes', + #'E-RABSetupItemBearerSURes'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S) -> %% poke E-RAB FSM - #'E-RABSetupItemBearerSURes'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, case erab_fsm_find(ERABId, S) of {ok, Pid} -> case erab_fsm:erab_setup_rsp(Pid, {TEID_In, TLA_In}) of @@ -444,18 +445,17 @@ end; %% 9.1.3.5 E-RAB RELEASE COMMAND related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeReleasedList', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeReleasedList', C, S) -> %% This IE contains a list of E-RABItem - handle_ies(Content, ?'id-E-RABItem', S); + handle_ies(C, ?'id-E-RABItem', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABItem', - value = C}, S) -> +handle_ie(?'id-E-RABItem', + #'E-RABItem'{'e-RAB-ID' = ERABId} = C, + #proxy_state{rel_kind = RelKind} = S) -> %% poke E-RAB FSM - #'E-RABItem'{'e-RAB-ID' = ERABId} = C, case erab_fsm_find(ERABId, S) of {ok, Pid} -> - ok = erab_fsm:erab_release(Pid, S#proxy_state.rel_kind), + ok = erab_fsm:erab_release(Pid, RelKind), {{ok, C}, S}; error -> ?LOG_ERROR("E-RAB ~p is not registered", [erab_uid(ERABId, S)]), @@ -463,15 +463,13 @@ end; %% 9.1.3.6 E-RAB RELEASE RESPONSE related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABReleaseListBearerRelComp', - value = Content}, S) -> +handle_ie(?'id-E-RABReleaseListBearerRelComp', C, S) -> %% This IE contains a list of E-RABReleaseItemBearerRelComp - handle_ies(Content, ?'id-E-RABReleaseItemBearerRelComp', S); + handle_ies(C, ?'id-E-RABReleaseItemBearerRelComp', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABReleaseItemBearerRelComp', - value = C}, S) -> +handle_ie(?'id-E-RABReleaseItemBearerRelComp', + #'E-RABReleaseItemBearerRelComp'{'e-RAB-ID' = ERABId} = C, S) -> %% poke E-RAB FSM - #'E-RABReleaseItemBearerRelComp'{'e-RAB-ID' = ERABId} = C, case erab_fsm_find(ERABId, S) of {ok, Pid} -> ok = erab_fsm:erab_release_rsp(Pid), @@ -482,44 +480,39 @@ end; %% 9.1.3.7 E-RAB RELEASE INDICATION related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABReleasedList', - value = Content}, S) -> +handle_ie(?'id-E-RABReleasedList', C, S) -> %% This IE contains a list of E-RABItem - handle_ies(Content, ?'id-E-RABItem', S); + handle_ies(C, ?'id-E-RABItem', S); %% E-RAB MODIFICATION INDICATION related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeModifiedListBearerModInd', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeModifiedListBearerModInd', C, S) -> %% This IE contains a list of BearerModInd, so patch inner IEs - handle_ies(Content, ?'id-E-RABToBeModifiedItemBearerModInd', S); + handle_ies(C, ?'id-E-RABToBeModifiedItemBearerModInd', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeModifiedItemBearerModInd', - value = C}, S) -> +handle_ie(?'id-E-RABToBeModifiedItemBearerModInd', + #'E-RABToBeModifiedItemBearerModInd'{} = C, S) -> %% TODO: find and poke an E-RAB FSM associated with this E-RAB {{ok, C}, S}; -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABNotToBeModifiedListBearerModInd', - value = Content}, S) -> +handle_ie(?'id-E-RABNotToBeModifiedListBearerModInd', C, S) -> %% This IE contains a list of BearerModInd, so patch inner IEs - handle_ies(Content, ?'id-E-RABNotToBeModifiedItemBearerModInd', S); + handle_ies(C, ?'id-E-RABNotToBeModifiedItemBearerModInd', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABNotToBeModifiedItemBearerModInd', - value = C}, S) -> +handle_ie(?'id-E-RABNotToBeModifiedItemBearerModInd', + #'E-RABNotToBeModifiedItemBearerModInd'{} = C, S) -> %% TODO: find and poke an E-RAB FSM associated with this E-RAB {{ok, C}, S}; %% INITIAL CONTEXT SETUP REQUEST related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupListCtxtSUReq', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeSetupListCtxtSUReq', C, S) -> %% This IE contains a list of CtxtSUReq, so patch inner IEs - handle_ies(Content, ?'id-E-RABToBeSetupItemCtxtSUReq', S); + handle_ies(C, ?'id-E-RABToBeSetupItemCtxtSUReq', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupItemCtxtSUReq', - value = C0}, S0) -> +handle_ie(?'id-E-RABToBeSetupItemCtxtSUReq', + #'E-RABToBeSetupItemCtxtSUReq'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S0) -> %% start and register an E-RAB FSM - #'E-RABToBeSetupItemCtxtSUReq'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, {Pid, S1} = erab_fsm_start_reg(ERABId, S0), case erab_fsm:erab_setup_req(Pid, {TEID_In, TLA_In}) of {ok, {TEID_Out, TLA_Out}} -> @@ -531,17 +524,15 @@ end; %% INITIAL CONTEXT SETUP RESPONSE related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupListCtxtSURes', - value = Content}, S) -> +handle_ie(?'id-E-RABSetupListCtxtSURes', C, S) -> %% This IE contains a list of CtxtSURes, so patch inner IEs - handle_ies(Content, ?'id-E-RABSetupItemCtxtSURes', S); + handle_ies(C, ?'id-E-RABSetupItemCtxtSURes', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupItemCtxtSURes', - value = C0}, S) -> +handle_ie(?'id-E-RABSetupItemCtxtSURes', + #'E-RABSetupItemCtxtSURes'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S) -> %% poke E-RAB FSM - #'E-RABSetupItemCtxtSURes'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, case erab_fsm_find(ERABId, S) of {ok, Pid} -> case erab_fsm:erab_setup_rsp(Pid, {TEID_In, TLA_In}) of @@ -558,8 +549,8 @@ end; %% Catch-all variant, which should not be called normally -handle_ie(#'ProtocolIE-Field'{} = IE, S) -> - ?LOG_ERROR("[BUG] Unhandled S1AP IE: ~p", [IE]), +handle_ie(IEI, C, S) -> + ?LOG_ERROR("[BUG] Unhandled S1AP IE: ~p, ~p", [IEI, C]), {{error, unhandled_ie}, S}. @@ -567,16 +558,16 @@ %% calling function handle_ie/1 for IEs matching the given IEI. %% Additionally look for {MME,eNB}-UE-S1AP-ID IEs and store their values. -type handle_ies_result() :: {ok, list()} | {error, term()}. --spec handle_ies(list(), integer(), proxy_state()) -> {handle_ies_result(), proxy_state()}. +-spec handle_ies(list(), s1ap_ie_id(), proxy_state()) -> {handle_ies_result(), proxy_state()}. handle_ies(IEs, IEI, S) -> handle_ies([], IEs, IEI, S). handle_ies(Acc, [IE | IEs], IEI, S0) -> case IE of - #'ProtocolIE-Field'{id = IEI} -> - case handle_ie(IE, S0) of - {{ok, C}, S1} -> - NewIE = IE#'ProtocolIE-Field'{value = C}, + #'ProtocolIE-Field'{id = IEI, value = C0} -> + case handle_ie(IEI, C0, S0) of + {{ok, C1}, S1} -> + NewIE = IE#'ProtocolIE-Field'{value = C1}, handle_ies([NewIE | Acc], IEs, IEI, S1); {{error, Reason}, S1} -> {{error, Reason}, S1} -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic71c8c07739b0e354ca9c9b03c000a366d8c2c43 Gerrit-Change-Number: 39111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-iuh[master]: jenkins.sh: No need to build libosmo-sigtran with doxygen

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/39097?usp=email ) Change subject: jenkins.sh: No need to build libosmo-sigtran with doxygen ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/39097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1e2ac9dfbc81b858c5e818963fcc032748816126 Gerrit-Change-Number: 39097 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 18:12:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-iuh[master]: jenkins.sh: Skip building unneeded libosmo-abis

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/39089?usp=email ) Change subject: jenkins.sh: Skip building unneeded libosmo-abis ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/39089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6edbbdbe06e2e10a3d9fd2fd9a7403a6b738948e Gerrit-Change-Number: 39089 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 18:12:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-cbc[master]: jenkins.sh: Skip building unneeded libosmo-abis

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-cbc/+/39091?usp=email ) Change subject: jenkins.sh: Skip building unneeded libosmo-abis ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/39091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ia8d93b276ace5798778354f25c4e8980e3412413 Gerrit-Change-Number: 39091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 18:12:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-smlc[master]: jenkins.sh: No need to build libosmo-sigtran with doxygen

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/39100?usp=email ) Change subject: jenkins.sh: No need to build libosmo-sigtran with doxygen ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/39100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ic63fbd92cc6e1a5f784ced2ccb5f998e6cabaf27 Gerrit-Change-Number: 39100 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 18:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-smlc[master]: jenkins.sh: Skip building unneeded libosmo-abis

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/39092?usp=email ) Change subject: jenkins.sh: Skip building unneeded libosmo-abis ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/39092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I9e763963f22e7fb425faef3b70b821ebd7e7ce60 Gerrit-Change-Number: 39092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 18:11:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmocom-bb[master]: jenkins.sh: Use --disable-doxygen configure param

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39107?usp=email ) Change subject: jenkins.sh: Use --disable-doxygen configure param ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I09eab54587e5d310143faaa57257fe05e4f0e7f6 Gerrit-Change-Number: 39107 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 18:10:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email ) Change subject: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id9784c69f1524872053436b59712f67ad5fbfe94 Gerrit-Change-Number: 39044 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 18:10:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39064?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack ...................................................................... RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack When changweights of a NS-VC via SNS, the SNS Ack should only contains the IEs "List of IP4/6 elements" if the cause code is Unknown IP endpoint. However the libosmocore/ns2 code isn't following this behavior yet. Change-Id: Ibf00cbab0c6691cdb72fe592ee30e122dd8f4783 --- M library/RAW_NS.ttcnpp 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp index 5f0e421..a7cdb8a 100644 --- a/library/RAW_NS.ttcnpp +++ b/library/RAW_NS.ttcnpp @@ -579,13 +579,13 @@ nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit, omit)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf00cbab0c6691cdb72fe592ee30e122dd8f4783 Gerrit-Change-Number: 39064 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024