November 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: ipaccess: Deprecate ipa_msg_push_header() API

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38814?usp=email ) Change subject: ipaccess: Deprecate ipa_msg_push_header() API ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I59b216c8a5e5a8744d337773ccf6f8d674b9513d Gerrit-Change-Number: 38814 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 08:53:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[M] Change in libosmo-abis[master]: ipaccess: Replace ipa_bts_id_resp() with libosmocore ipa_ccm_make_id_...

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38813?usp=email ) Change subject: ipaccess: Replace ipa_bts_id_resp() with libosmocore ipa_ccm_make_id_resp_from_req() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7f32231bff792b01e33f604bbb8b68fe22876abb Gerrit-Change-Number: 38813 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 08:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: add android-apdu-proxy

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38822?usp=email ) Change subject: jobs/gerrit-verifications: add android-apdu-proxy ...................................................................... jobs/gerrit-verifications: add android-apdu-proxy Related: OS#6367 Change-Id: I688a78ce944e68e97a229df01ced32b7cbd10cc4 --- M jobs/gerrit-verifications.yml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index c91eb95..fdec2e8 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -84,6 +84,7 @@ -v "$CCACHE_DIR:/ccache" \ docker_img: '$USER/debian-bookworm-build' docker_img_erlang: '$USER/debian-bookworm-erlang' + docker_img_android: 'registry.osmocom.org/osmocom-build/debian-bookworm-android' timeout_cmd: '/usr/bin/timeout 30m' cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' gerrit_url: 'ssh://jenkins@gerrit.osmocom.org:29418' @@ -96,6 +97,19 @@ # in alphabetical order repos: + - android-apdu-proxy: + pipeline_binpkgs: "" + concurrent: false # might cause problems with shared cache + cmd: | + ANDROID_CACHE="$HOME/android-cache/gerrit-verifications/android" + GRADLE_CACHE="$HOME/android-cache/gerrit-verifications/gradle" + mkdir -p "$ANDROID_CACHE" "$GRADLE_CACHE" + docker pull {docker_img_android} + {docker_run} \ + -v "$ANDROID_CACHE":/build/.android \ + -v "$GRADLE_CACHE":/build/.gradle \ + {docker_img_android} {timeout_cmd} contrib/jenkins.sh + - asn1c: pipeline_binpkgs: "" pipeline_lint: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I688a78ce944e68e97a229df01ced32b7cbd10cc4 Gerrit-Change-Number: 38822 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master-builds: android-apdu-proxy -> gerrit

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38821?usp=email ) Change subject: jobs/master-builds: android-apdu-proxy -> gerrit ...................................................................... jobs/master-builds: android-apdu-proxy -> gerrit The repository is now in gerrit. Related: OS#6367 Change-Id: I102957f8b23653bdf2e414fcb7fec0f2f78feb2e --- M jobs/master-builds.yml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index e37d1d2..f15386b 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -83,7 +83,6 @@ # in alphabetical order repos: - android-apdu-proxy: - repos_url: '{gitea_url}/sim-card/android-apdu-proxy' branch: master cmd: | ANDROID_CACHE="$HOME/android-cache/master-builds/android" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I102957f8b23653bdf2e414fcb7fec0f2f78feb2e Gerrit-Change-Number: 38821 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-sgsn[master]: gmm: Fix reject small size RAU request

by lynxis lazus

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email ) Change subject: gmm: Fix reject small size RAU request ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: 24.008 9.4.14: Table 9.4.14/3GPP TS 24.008: ROUTING AREA UPDATE REQUEST message content says it should be 16. Is it allowed to send such small radio access caps? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I49210a04b16e6e2fc9d799b99c2fa415f28ddbba Gerrit-Change-Number: 38834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 00:58:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 1 week

1
0
0 0

[S] Change in osmo-sgsn[master]: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully

by pespin

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email ) Change subject: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229 Gerrit-Change-Number: 38835 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Nov 2024 19:17:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-sgsn[master]: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully

by fixeria

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. Hello Jenkins Builder, daniel, lynxis lazus, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified-1 by Jenkins Builder Change subject: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully ...................................................................... gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully We should not reject a RAU request if it contains optional IEs that are not known to our implementation. Just ignore them. Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229 Related: SYS#7195 --- M src/sgsn/gprs_gmm_util.c 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/35/38835/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229 Gerrit-Change-Number: 38835 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months, 1 week

1
0
0 0

[S] Change in osmo-sgsn[master]: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully

by pespin

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email ) Change subject: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229 Gerrit-Change-Number: 38835 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 19 Nov 2024 19:05:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-sgsn[master]: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email ) Change subject: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully ...................................................................... gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully We should not reject a RAU request if it contains optional IEs that are not known to our implementation. Just ignore them. Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229 Related: SYS#7195 --- M src/sgsn/gprs_gmm_util.c 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/35/38835/1 diff --git a/src/sgsn/gprs_gmm_util.c b/src/sgsn/gprs_gmm_util.c index 0cf730f..aad61db 100644 --- a/src/sgsn/gprs_gmm_util.c +++ b/src/sgsn/gprs_gmm_util.c @@ -102,10 +102,13 @@ return 0; ret = tlv_parse(&rau_req->tlv, &gsm48_gmm_ie_tlvdef, - cur, msgb_l3len(msg) - mandatory_fields_len, 0, 0); - - if (ret < 0) - return GMM_CAUSE_COND_IE_ERR; + cur, msgb_l3len(msg) - mandatory_fields_len, 0, 0); + if (ret < 0) { + LOGP(DMM, LOGL_NOTICE, "%s(): tlv_parse() failed (%d)\n", __func__, ret); + /* gracefully handle unknown IEs (partial parsing) */ + if (ret != OSMO_TLVP_ERR_UNKNOWN_TLV_TYPE) + return GMM_CAUSE_COND_IE_ERR; + } return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229 Gerrit-Change-Number: 38835 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-sgsn[master]: gmm: Fix reject small size RAU request

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email ) Change subject: gmm: Fix reject small size RAU request ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I49210a04b16e6e2fc9d799b99c2fa415f28ddbba Gerrit-Change-Number: 38834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Nov 2024 18:55:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024