November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcu[master]: pcuif: add comment on TXT_IND/PCU_VERSION BTS initialization behavior
by dexter 26 Nov '24

26 Nov '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/38954?usp=email ) Change subject: pcuif: add comment on TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... pcuif: add comment on TXT_IND/PCU_VERSION BTS initialization behavior The PCU sends a TXT_IND with the PCU_VERSION as the first message after the socket connection is established. The BTS/BSC uses those messages to trigger some initialization (allocate BTS object inside the PCU, send SI to the PCU). Unfortunately the PCU will send the TXT_IND with the PCU_VERSION always with to BTS 0. The 0 in this case is a hardcoded fake BTS number (There is no BTS object allocated under this number in the PCU at this point). However, the BTS/BSC will then do the initialization process for BTS 0, which works by chance for the BTS where the BTS number is always 0, in the case of the BSC there may be multiple BTS configured, so there may be arbitrary BTS numbers. Let's fix this design error by agreeing that a TXT_IND that has the type PCU_VERSION is always addressing the receiving process as a whole and therefore the BTS number in the indication must be ignored. Related: OS#6507 Change-Id: Ib3f340ae9450151549ce61d34b28253d499ae04a --- M src/pcu_l1_if.cpp 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/38954/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index fb44bd8..630c244 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -124,6 +124,13 @@ struct gsm_pcu_if_txt_ind *txt; va_list ap; char *rep; + + /* In case the caller sends a TXT indication of type PCU_VERSION, the bts_nr will always be 0. Also the receiver + * is expected to ignore the bts_nr when receiving a TXT indication of type PCU_VERSION. The rationale is that + * the information about the PCU version number is only useful to the receiving process as a whole (be it osmo-bsc + * or osmo-bts). */ + /* TODO: add support for sending other TXT indication types than PCU_VERSION */ + OSMO_ASSERT(t == PCU_VERSION); struct msgb *msg = pcu_msgb_alloc(PCU_IF_MSG_TXT_IND, 0); if (!msg) return -ENOMEM; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/38954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib3f340ae9450151549ce61d34b28253d499ae04a Gerrit-Change-Number: 38954 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-pcu[master]: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior
by dexter 26 Nov '24

26 Nov '24

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/38092?usp=email ) Change subject: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... Abandoned We have found a simpler solution. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/38092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id01966a1ee52d0f5e465dc2e0eaf85e5b7942f81 Gerrit-Change-Number: 38092 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.7
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: dexter, laforge, pespin. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email ) Change subject: Bump version to 0.0.7 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68 Gerrit-Change-Number: 38951 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 16:28:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: update titan.ProtocolModules.RTP
by dexter 26 Nov '24

26 Nov '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email ) Change subject: deps/Makefile: update titan.ProtocolModules.RTP ...................................................................... deps/Makefile: update titan.ProtocolModules.RTP The module titan.ProtocolModules.RTP received a fix that avoids crashing (segfault) on the reception of short RTP packets. Let's make sure that this fix is included in our builds as well. Related: OS#4005 Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index b98fc1e..d57e37a 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -108,7 +108,7 @@ titan.ProtocolModules.MobileL3_v13.4.0_commit= b6602eb357673f097ea1a1d22edd568ecd239da1 titan.ProtocolModules.NAS_EPS_15.2.0.1_commit= R.1.A-2-g2ba853c titan.ProtocolModules.NS_v7.3.0_commit= R.2.A-6-gf73f195 -titan.ProtocolModules.RTP_commit= R.5.A-4-g83ee83a +titan.ProtocolModules.RTP_commit= R.5.A-8-g5157e9d titan.ProtocolModules.DIAMETER_ProtocolModule_Generator_commit= ffd939595a08da1b8c8176aaa1f8578bfe02a912 titan.ProtocolModules.ROSE_commit= R.1.C-5-g0f6774c titan.ProtocolModules.SCTP_commit= R.2.A-5-g556ef3f -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c Gerrit-Change-Number: 38950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_rab_release: Fix race condition stats checked too early
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38953?usp=email ) Change subject: hnbgw: TC_rab_release: Fix race condition stats checked too early ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica53d956ee8aed760854d3148af170144234e6b2 Gerrit-Change-Number: 38953 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 15:45:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38952?usp=email ) Change subject: bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I492607aca0e42a823836f4a714ea818c5a897855 Gerrit-Change-Number: 38952 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 15:44:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-shell: change Prompt character to "#" after "verify_adm"
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38884?usp=email ) Change subject: pySim-shell: change Prompt character to "#" after "verify_adm" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I957b9df7b5069b6fce5bf958c94e8ffda833c77f Gerrit-Change-Number: 38884 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 15:39:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-netif[master]: stream_cli: Support destroy object within user callback
by pespin 26 Nov '24

26 Nov '24

Attention is currently required from: daniel, fixeria, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by daniel, Verified+1 by Jenkins Builder Change subject: stream_cli: Support destroy object within user callback ...................................................................... stream_cli: Support destroy object within user callback This commit improves the code in stream_cli to allow the user calling osmo_stream_cli_destroy() while in a callback. For instance, the following scenario: read_cb(len=0) osmo_stream_cli_reconnect() osmo_stream_cli_close() disconnect_cb [user calls osmo_stream_cli_destroy()] [popped stack does read_cb()] [user uses freed msg] This allows using stream_cli by users handling destruction and reconnect of stream_ci objects on their own, such as libosmo-abis e1_input/sign_link stack. Change-Id: I952938474fa2780bf3c906cbdffb2d024b03c1b7 --- M src/stream_cli.c M tests/stream/stream_test.err 2 files changed, 149 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/11/38911/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I952938474fa2780bf3c906cbdffb2d024b03c1b7 Gerrit-Change-Number: 38911 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: update titan.ProtocolModules.RTP
by fixeria 26 Nov '24

26 Nov '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email ) Change subject: deps/Makefile: update titan.ProtocolModules.RTP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c Gerrit-Change-Number: 38950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 15:34:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_rab_release: Fix race condition stats checked too early
by pespin 26 Nov '24

26 Nov '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38953?usp=email ) Change subject: hnbgw: TC_rab_release: Fix race condition stats checked too early ...................................................................... hnbgw: TC_rab_release: Fix race condition stats checked too early It could happen sometimes that the stats report was requested before the hnbgw received the message increasing the counter. Change-Id: Ica53d956ee8aed760854d3148af170144234e6b2 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/38953/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 3db72bf..ab6a09e 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1226,11 +1226,6 @@ tx := valueof(ts_RANAP_RabAssReq(rab_rl := ts_RAB_RL(t_RAB_id(23), g_pars.rab_rel_cause))); BSSAP.send(tx); - expect := { - {name := hnb0_ctr_prefix & ctr_name, mtype := "c", min := 1, max := 1} - }; - f_statsd_expect(expect); - T.start; alt { @@ -1242,6 +1237,11 @@ T.stop; f_rua_expect(tx); + + expect := { + {name := hnb0_ctr_prefix & ctr_name, mtype := "c", min := 1, max := 1} + }; + f_statsd_expect(expect); } /* RAB release with Cause NAS/Normal (successful/orderly release) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica53d956ee8aed760854d3148af170144234e6b2 Gerrit-Change-Number: 38953 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2024