Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: deps/Makefile: update titan.ProtocolModules.RTP
......................................................................
deps/Makefile: update titan.ProtocolModules.RTP
The module titan.ProtocolModules.RTP received a fix that avoids crashing
(segfault) on the reception of short RTP packets. Let's make sure that
this fix is included in our builds as well.
Related: OS#4005
Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c
---
M deps/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/38950/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38950?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ica445c1058f3afa1e0615986ca5240eeacb02e8c
Gerrit-Change-Number: 38950
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38952?usp=email )
Change subject: bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect
......................................................................
bsc: Fix missing teardown in TC_ho_in_fail_msc_clears_after_ho_detect
Missing handling of teardown messages made the test fail sporadically
due to ttcn3 side already closing the SCCP connection when it was still
expected to receive messages.
Change-Id: I492607aca0e42a823836f4a714ea818c5a897855
---
M bsc/BSC_Tests.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/38952/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 83389a6..1badaa5 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -6962,7 +6962,13 @@
BSSAP.send(ts_BSSMAP_ClearCommand(cause));
f_expect_dlcx_conns();
+ RSL.receive(tr_RSL_DEACT_SACCH(new_chan_nr));
+ RSL.receive(tr_RSL_RF_CHAN_REL(new_chan_nr));
+ RSL.send(ts_RSL_RF_CHAN_REL_ACK(new_chan_nr));
+ f_rslem_unregister(0, new_chan_nr);
+
BSSAP.receive(tr_BSSMAP_ClearComplete);
+ BSSAP.receive(tr_BSSMAP_HandoverFailure);
BSSAP.send(ts_MSC_CONN_PRIM_DISC_REQ);
f_sleep(1.0);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38952?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I492607aca0e42a823836f4a714ea818c5a897855
Gerrit-Change-Number: 38952
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email )
Change subject: Bump version to 0.0.7
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
(a user with the appropriate access rights must delete the -1 from jenkins, since I do not have the access rights for that.)
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68
Gerrit-Change-Number: 38951
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Nov 2024 13:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email )
Change subject: Bump version to 0.0.7
......................................................................
Patch Set 1: Verified+1
(1 comment)
Patchset:
PS1:
This build fails because the topmost patch in current master breaks the pySim unittests. (We run the pySim tests as part of the verification of pyosmocom) This is expected and pySim will be fixed as soon as the new release of pyosmocom is released to pypi.
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68
Gerrit-Change-Number: 38951
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Nov 2024 13:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38943?usp=email )
Change subject: contrib/esim-qrcode.py: Small command line tool to encode eSIM QR codes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/38943?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7983de79937124cc258efd459c51f812f5fa79cb
Gerrit-Change-Number: 38943
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 26 Nov 2024 13:21:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email )
Change subject: gsmtap: Increase txqueue max_length from 64 to 1024
......................................................................
gsmtap: Increase txqueue max_length from 64 to 1024
The default value may be too low for main loop iterations writing a lot
of output. Increase it to a saner value.
Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9
---
M src/core/gsmtap_util.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c
index b64c7b0..62d3ffa 100644
--- a/src/core/gsmtap_util.c
+++ b/src/core/gsmtap_util.c
@@ -496,8 +496,8 @@
if (osmo_iofd_register(gti->out, gti->wq.bfd.fd) < 0)
goto err_cleanup;
- /* osmo write queue previously used was set up with value of 64 */
- osmo_iofd_set_txqueue_max_length(gti->out, 64);
+ /* Use a big enough tx queue to avoid gsmtap messages being dropped: */
+ osmo_iofd_set_txqueue_max_length(gti->out, 1024);
}
return gti;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38887?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9
Gerrit-Change-Number: 38887
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>