November 2024 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: contrib/suci-keytool.py: Convenience tool for SUCI key generation

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38959?usp=email ) Change subject: contrib/suci-keytool.py: Convenience tool for SUCI key generation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38959?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e92bbba7f700e160ea9c58da5f23fa4c31d40c6 Gerrit-Change-Number: 38959 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Nov 2024 07:12:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 4 weeks

1
0
0 0

[S] Change in pysim[master]: contrib/esim-qrcode.py: Small command line tool to encode eSIM QR codes

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38943?usp=email ) Change subject: contrib/esim-qrcode.py: Small command line tool to encode eSIM QR codes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7983de79937124cc258efd459c51f812f5fa79cb Gerrit-Change-Number: 38943 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Nov 2024 07:12:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 4 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email ) Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38957/comment/11826e0d_02b11a73?usp… : PS3, Line 729: ENSURE_BTS_OBJECT Maybe move it below the `CHECK_IF_MSG_SIZE`? Checking prim size first looks more logical. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3fbf5430db8b8ea29efb147bd162706990453fc5 Gerrit-Change-Number: 38957 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 21:05:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 4 weeks

1
0
0 0

[XS] Change in osmo-pcu[master]: pcuif: add comment on TXT_IND/PCU_VERSION BTS initialization behavior

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-pcu/+/38954?usp=email ) Change subject: pcuif: add comment on TXT_IND/PCU_VERSION BTS initialization behavior ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/38954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib3f340ae9450151549ce61d34b28253d499ae04a Gerrit-Change-Number: 38954 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 21:01:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38912?usp=email ) Change subject: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based ...................................................................... esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based In case the fileDescriptor of EF.IMSI is purely template based and only the file content is given in the actual profile, we must pass a template reference to the File() constructor before we can read the IMSI. This fixes the following exception for some profiles: ValueError: File(ef-imsi): No fileDescriptor found in tuple, and none set by template before Change-Id: I14157a7b62ccd9b5b42de9b8060f2ebc5f91ebb3 --- M pySim/esim/saip/__init__.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 2552c8e..64ea7cb 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1130,7 +1130,8 @@ @property def imsi(self) -> Optional[str]: - f = File('ef-imsi', self.decoded['ef-imsi']) + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + f = File('ef-imsi', self.decoded['ef-imsi'], template.files_by_pename.get('ef-imsi', None)) return dec_imsi(b2h(f.body)) class ProfileElementOptUSIM(FsProfileElement): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I14157a7b62ccd9b5b42de9b8060f2ebc5f91ebb3 Gerrit-Change-Number: 38912 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 4 weeks

1
0
0 0

[M] Change in pysim[master]: docs: Add documentation about contrib/sim-rest-{server,client}

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38939?usp=email ) Change subject: docs: Add documentation about contrib/sim-rest-{server,client} ...................................................................... docs: Add documentation about contrib/sim-rest-{server,client} Those programs have been around since 2021 but we never had any documentation here. Let's fix that. Change-Id: I7c471cac9500db063a0c8f5c5eb7b6861b3234ed --- M docs/index.rst A docs/sim-rest.rst 2 files changed, 119 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve jolly: Looks good to me, but someone else must approve diff --git a/docs/index.rst b/docs/index.rst index bcbc7f0..228fb79 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -43,6 +43,7 @@ legacy library osmo-smdpp + sim-rest Indices and tables diff --git a/docs/sim-rest.rst b/docs/sim-rest.rst new file mode 100644 index 0000000..41a6d1d --- /dev/null +++ b/docs/sim-rest.rst @@ -0,0 +1,118 @@ +sim-rest-server +=============== + +Sometimes there are use cases where a [remote] application will need +access to a USIM for authentication purposes. This is, for example, in +case an IMS test client needs to perform USIM based authentication +against an IMS core. + +The pysim repository contains two programs: `sim-rest-server.py` and +`sim-rest-client.py` that implement a simple approach to achieve the +above: + +`sim-rest-server.py` speaks to a [usually local] USIM via the PC/SC +API and provides a high-level REST API towards [local or remote] +applications that wish to perform UMTS AKA using the USIM. + +`sim-rest-client.py` implements a small example client program to +illustrate how the REST API provided by `sim-rest-server.py` can be +used. + +REST API Calls +-------------- + +POST /sim-auth-api/v1/slot/SLOT_NR +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +where SLOT_NR is the integer-encoded slot number (corresponds to PC/SC +reader number). When using a single sysmoOCTSIM board, this is in the range of 0..7 + +Example: `/sim-auth-api/v1/slot/0` for the first slot. + +Request Body +############ + +The request body is a JSON document, comprising of + 1. the RAND and AUTN parameters as hex-encoded string + 2. the application against which to authenticate (USIM, ISIM) + +Example: +:: + + { + "rand": "bb685a4b2fc4d697b9d6a129dd09a091", + "autn": "eea7906f8210000004faf4a7df279b56" + } + +HTTP Status Codes +################# + +HTTP status codes are used to represent errors within the REST server +and the SIM reader hardware. They are not used to communicate protocol +level errors reported by the SIM Card. An unsuccessful authentication +will hence have a `200 OK` HTTP Status code and then encode the SIM +specific error information in the Response Body. + +====== =========== ================================ +Status Code Description +------ ----------- -------------------------------- +200 OK Successful execution +400 Bad Request Request body is malformed +404 Not Found Specified SIM Slot doesn't exist +410 Gone No SIM card inserted in slot +====== =========== ================================ + +Response Body +############# + +The response body is a JSON document, either + +#. a successful outcome; encoding RES, CK, IK as hex-encoded string +#. a sync failure; encoding AUTS as hex-encoded string +#. errors + #. authentication error (incorrect MAC) + #. authentication error (security context not supported) + #. key freshness failure + #. unspecified card error + +Example (succcess): +:: + + { + "successful_3g_authentication": { + "res": "b15379540ec93985", + "ck": "713fde72c28cbd282a4cd4565f3d6381", + "ik": "2e641727c95781f1020d319a0594f31a", + "kc": "771a2c995172ac42" + } + } + +Example (re-sync case): +:: + + { + "synchronisation_failure": { + "auts": "dc2a591fe072c92d7c46ecfe97e5" + } + } + +Concrete example using the included sysmoISIM-SJA2 +-------------------------------------------------- + +This was tested using SIMs ending in IMSI numbers 45890...45899 + +The following command were executed successfully: + +Slot 0 +:: + + $ /usr/local/src/pysim/contrib/sim-rest-client.py -c 1 -n 0 -k 841EAD87BC9D974ECA1C167409357601 -o 3211CACDD64F51C3FD3013ECD9A582A0 + -> {'rand': 'fb195c7873b20affa278887920b9dd57', 'autn': 'd420895a6aa2000089cd016f8d8ae67c'} + <- {'successful_3g_authentication': {'res': '131004db2ff1ce8e', 'ck': 'd42eb5aa085307903271b2422b698bad', 'ik': '485f81e6fd957fe3cad374adf12fe1ca', 'kc': '64d3f2a32f801214'}} + +Slot 1 +:: + + $ /usr/local/src/pysim/contrib/sim-rest-client.py -c 1 -n 1 -k 5C2CE9633FF9B502B519A4EACD16D9DF -o 9834D619E71A02CD76F00CC7AA34FB32 + -> {'rand': '433dc5553db95588f1d8b93870930b66', 'autn': '126bafdcbe9e00000026a208da61075d'} + <- {'successful_3g_authentication': {'res': '026d7ac42d379207', 'ck': '83a90ba331f47a95c27a550b174c4a1f', 'ik': '31e1d10329ffaf0ca1684a1bf0b0a14a', 'kc': 'd15ac5b0fff73ecc'}} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c471cac9500db063a0c8f5c5eb7b6861b3234ed Gerrit-Change-Number: 38939 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 4 weeks

1
0
0 0

[M] Change in pysim[master]: docs: Add documentation about contrib/sim-rest-{server,client}

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38939?usp=email ) Change subject: docs: Add documentation about contrib/sim-rest-{server,client} ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File docs/sim-rest.rst: https://gerrit.osmocom.org/c/pysim/+/38939/comment/f495f283_96689a78?usp=em… : PS3, Line 102: 45890 > Is it ok to revile keys of these sim cards here? valid point. I presume I was using cards that I only used for my internal development at the time this documentation was written (years ago, just never as part of this manual). As the change is now in gerrit, it's too late now anyway... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c471cac9500db063a0c8f5c5eb7b6861b3234ed Gerrit-Change-Number: 38939 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 26 Nov 2024 20:28:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38912?usp=email ) Change subject: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I14157a7b62ccd9b5b42de9b8060f2ebc5f91ebb3 Gerrit-Change-Number: 38912 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 20:26:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 4 weeks

1
0
0 0

[S] Change in pysim[master]: docs/shell: Fix documentation for eUICC ISD-R specific commands

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38961?usp=email ) Change subject: docs/shell: Fix documentation for eUICC ISD-R specific commands ...................................................................... docs/shell: Fix documentation for eUICC ISD-R specific commands Back in January 2024 in change 7ba09f9392c8023842a7b5576936cb21ff85c6c0 we migrate dthe commands from 'class ADF_ISDR' to CardApplicationISDR without updating the sphinx-argparse references in the documentation. Let's fix that, making the syntax reference for those commands re-appear in the documentation. Change-Id: I1d7e2d1a5dfbdcc11b1fdb3e89845787f7cddbfc --- M docs/shell.rst 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/38961/1 diff --git a/docs/shell.rst b/docs/shell.rst index b70555d..31689fd 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -1118,7 +1118,7 @@ .. argparse:: :module: pySim.euicc - :func: ADF_ISDR.AddlShellCommands.es10x_store_data_parser + :func: CardApplicationISDR.AddlShellCommands.es10x_store_data_parser get_euicc_configured_addresses ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -1137,7 +1137,7 @@ .. argparse:: :module: pySim.euicc - :func: ADF_ISDR.AddlShellCommands.set_def_dp_addr_parser + :func: CardApplicationISDR.AddlShellCommands.set_def_dp_addr_parser get_euicc_challenge ~~~~~~~~~~~~~~~~~~~ @@ -1280,7 +1280,7 @@ .. argparse:: :module: pySim.euicc - :func: ADF_ISDR.AddlShellCommands.rem_notif_parser + :func: CardApplicationISDR.AddlShellCommands.rem_notif_parser Example:: @@ -1329,7 +1329,7 @@ .. argparse:: :module: pySim.euicc - :func: ADF_ISDR.AddlShellCommands.en_prof_parser + :func: CardApplicationISDR.AddlShellCommands.en_prof_parser Example (successful):: @@ -1351,7 +1351,7 @@ .. argparse:: :module: pySim.euicc - :func: ADF_ISDR.AddlShellCommands.dis_prof_parser + :func: CardApplicationISDR.AddlShellCommands.dis_prof_parser Example (successful):: @@ -1365,7 +1365,7 @@ .. argparse:: :module: pySim.euicc - :func: ADF_ISDR.AddlShellCommands.del_prof_parser + :func: CardApplicationISDR.AddlShellCommands.del_prof_parser Example:: @@ -1392,7 +1392,7 @@ .. argparse:: :module: pySim.euicc - :func: ADF_ISDR.AddlShellCommands.set_nickname_parser + :func: CardApplicationISDR.AddlShellCommands.set_nickname_parser Example:: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d7e2d1a5dfbdcc11b1fdb3e89845787f7cddbfc Gerrit-Change-Number: 38961 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: es2p_client: Print the activation code after confirmOrder success

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38960?usp=email ) Change subject: es2p_client: Print the activation code after confirmOrder success ...................................................................... es2p_client: Print the activation code after confirmOrder success Change-Id: I92608ff0cdc35b184edff0c656221644ba36f257 --- M contrib/es2p_client.py 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/38960/1 diff --git a/contrib/es2p_client.py b/contrib/es2p_client.py index 1353006..8eda6d0 100755 --- a/contrib/es2p_client.py +++ b/contrib/es2p_client.py @@ -17,7 +17,7 @@ import copy import argparse -from pySim.esim import es2p +from pySim.esim import es2p, ActivationCode EID_HELP='EID of the eUICC for which eSIM shall be made available' ICCID_HELP='The ICCID of the eSIM that shall be made available' @@ -73,6 +73,11 @@ res = peer.call_downloadOrder(data) elif opts.command == 'confirm-order': res = peer.call_confirmOrder(data) + matchingId = res.get('matchingId', None) + smdpAddress = res.get('smdpAddress', None) + if matchingId: + ac = ActivationCode(smdpAddress, matchingId, cc_required=bool(opts.confirmationCode)) + print("Activation Code: '%s'" % ac.to_string()) elif opts.command == 'cancel-order': res = peer.call_cancelOrder(data) elif opts.command == 'release-profile': -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92608ff0cdc35b184edff0c656221644ba36f257 Gerrit-Change-Number: 38960 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

6 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024