November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: gsm23.003: make the header self-contained
by pespin 26 Nov '24

26 Nov '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email ) Change subject: gsm23.003: make the header self-contained ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b Gerrit-Change-Number: 38949 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 26 Nov 2024 11:17:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gsm23.003: make the header self-contained
by lynxis lazus 26 Nov '24

26 Nov '24

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email ) Change subject: gsm23.003: make the header self-contained ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/gsm23003.h: https://gerrit.osmocom.org/c/libosmocore/+/38949/comment/d8370027_093ce972?… : PS1, Line 5: #include <ctype.h> > man size_t says: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b Gerrit-Change-Number: 38949 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Nov 2024 11:10:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm23.003: make the header self-contained
by lynxis lazus 26 Nov '24

26 Nov '24

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gsm23.003: make the header self-contained ...................................................................... gsm23.003: make the header self-contained size_t was undefined. Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b --- M include/osmocom/gsm/gsm23003.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/38949/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b Gerrit-Change-Number: 38949 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmocore[master]: gsm23.003: add RNC Id
by lynxis lazus 26 Nov '24

26 Nov '24

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gsm23.003: add RNC Id ...................................................................... gsm23.003: add RNC Id The RNC is similar to the GUMMEI, but for 3G. Change-Id: I0768c99b4c42b0948e7574d05b70e1b7bdb8a55a --- M include/osmocom/gsm/gsm23003.h M src/gsm/gsm23003.c M src/gsm/libosmogsm.map 3 files changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/38948/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0768c99b4c42b0948e7574d05b70e1b7bdb8a55a Gerrit-Change-Number: 38948 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: gsm23.003: make the header self-contained
by pespin 26 Nov '24

26 Nov '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email ) Change subject: gsm23.003: make the header self-contained ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/gsm23003.h: https://gerrit.osmocom.org/c/libosmocore/+/38949/comment/e7c6a172_0d0cfd36?… : PS1, Line 5: #include <ctype.h> man size_t says: "#include <stddef.h>" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b Gerrit-Change-Number: 38949 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 26 Nov 2024 09:50:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: gsm23.003: add RNC Id
by pespin 26 Nov '24

26 Nov '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email ) Change subject: gsm23.003: add RNC Id ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: +1 when you fix the linter thing. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0768c99b4c42b0948e7574d05b70e1b7bdb8a55a Gerrit-Change-Number: 38948 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 26 Nov 2024 09:49:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: gsm23.003: add RNC Id
by Jenkins Builder 26 Nov '24

26 Nov '24

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email ) Change subject: gsm23.003: add RNC Id ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/gsm23003.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20230): https://gerrit.osmocom.org/c/libosmocore/+/38948/comment/15e75b0b_4e828af0?… : PS1, Line 60: struct osmo_plmn_id plmn ; space prohibited before semicolon -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0768c99b4c42b0948e7574d05b70e1b7bdb8a55a Gerrit-Change-Number: 38948 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Nov 2024 23:26:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: gsm23.003: make the header self-contained
by lynxis lazus 26 Nov '24

26 Nov '24

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email ) Change subject: gsm23.003: make the header self-contained ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b Gerrit-Change-Number: 38949 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 23:26:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: gsm23.003: make the header self-contained
by lynxis lazus 26 Nov '24

26 Nov '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email ) Change subject: gsm23.003: make the header self-contained ...................................................................... gsm23.003: make the header self-contained size_t was undefined. Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b --- M include/osmocom/gsm/gsm23003.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/38949/1 diff --git a/include/osmocom/gsm/gsm23003.h b/include/osmocom/gsm/gsm23003.h index 3e203a8..2da3288 100644 --- a/include/osmocom/gsm/gsm23003.h +++ b/include/osmocom/gsm/gsm23003.h @@ -2,6 +2,7 @@ #pragma once +#include <ctype.h> #include <stdint.h> #include <stdbool.h> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5952f5746f7ee9093d9c5c7eaef76952e2c4107b Gerrit-Change-Number: 38949 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmocore[master]: gsm23.003: add RNC Id
by lynxis lazus 26 Nov '24

26 Nov '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email ) Change subject: gsm23.003: add RNC Id ...................................................................... gsm23.003: add RNC Id The RNC is similar to the GUMMEI, but for 3G. Change-Id: I0768c99b4c42b0948e7574d05b70e1b7bdb8a55a --- M include/osmocom/gsm/gsm23003.h M src/gsm/gsm23003.c M src/gsm/libosmogsm.map 3 files changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/38948/1 diff --git a/include/osmocom/gsm/gsm23003.h b/include/osmocom/gsm/gsm23003.h index 8b9bcfb..3e203a8 100644 --- a/include/osmocom/gsm/gsm23003.h +++ b/include/osmocom/gsm/gsm23003.h @@ -55,6 +55,12 @@ uint16_t ci; }; +/* 12.4 */ +struct osmo_rnc_id { + struct osmo_plmn_id plmn ; + uint16_t rnc_id; +}; + /* 12.5 */ struct osmo_service_area_id { struct osmo_location_area_id lai; @@ -137,6 +143,9 @@ const char *osmo_cgi_ps_name2(const struct osmo_cell_global_id_ps *cgi_ps); char *osmo_cgi_ps_name_buf(char *buf, size_t buf_len, const struct osmo_cell_global_id_ps *cgi_ps); char *osmo_cgi_ps_name_c(const void *ctx, const struct osmo_cell_global_id_ps *cgi_ps); +const char *osmo_rnc_id_name(const struct osmo_rnc_id *rnc_id); +char *osmo_rnc_id_name_buf(char *buf, size_t buf_len, const struct osmo_rnc_id *rnc_id); +char *osmo_rnc_id_name_c(const void *ctx, const struct osmo_rnc_id *rnc_id); const char *osmo_sai_name(const struct osmo_service_area_id *sai); const char *osmo_sai_name2(const struct osmo_service_area_id *sai); char *osmo_sai_name_buf(char *buf, size_t buf_len, const struct osmo_service_area_id *sai); @@ -167,6 +176,7 @@ int osmo_rai_cmp(const struct osmo_routing_area_id *a, const struct osmo_routing_area_id *b); int osmo_cgi_cmp(const struct osmo_cell_global_id *a, const struct osmo_cell_global_id *b); int osmo_cgi_ps_cmp(const struct osmo_cell_global_id_ps *a, const struct osmo_cell_global_id_ps *b); +int osmo_rnc_id_cmp(const struct osmo_rnc_id *a, const struct osmo_rnc_id *b); int osmo_mme_id_cmp(const struct osmo_mme_id *a, const struct osmo_mme_id *b); int osmo_gummei_cmp(const struct osmo_gummei *a, const struct osmo_gummei *b); diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c index 0f4c301..b0bac93 100644 --- a/src/gsm/gsm23003.c +++ b/src/gsm/gsm23003.c @@ -357,6 +357,44 @@ return osmo_cgi_ps_name_buf(buf, sizeof(buf), cgi_ps); } +/*! Return string representation of RNC in caller-provided output buffer. + * \param[out] buf pointer to caller-provided output buffer + * \param[in] buf_len size of buf in bytes + * \param[in] rnc RNC to be stringified + * \returns buf + */ +char *osmo_rnc_id_name_buf(char *buf, size_t buf_len, const struct osmo_rnc_id *rnc) +{ + char plmn[16]; + snprintf(buf, buf_len, "%s-%d", osmo_plmn_name_buf(plmn, sizeof(plmn), &rnc->plmn), + rnc->rnc_id); + return buf; +} + +/*! Return string representation of RNC in static output buffer. + * \param[in] rnc RNC to be stringified + * \returns pointer to static output buffer + */ +const char *osmo_rnc_id_name(const struct osmo_rnc_id *rnc) +{ + static __thread char buf[32]; + return osmo_rnc_id_name_buf(buf, sizeof(buf), rnc); +} + +/*! Return string representation of RNC in static output buffer. + * \param[out] buf pointer to caller-provided output buffer + * \param[in] buf_len size of buf in bytes + * \param[in] rnc RNC to be stringified + * \returns pointer to static output buffer + */ +char *osmo_rnc_id_name_c(const void *ctx, const struct osmo_rnc_id *rnc) +{ + char *buf = talloc_size(ctx, 32); + if (!buf) + return NULL; + return osmo_rnc_id_name_buf(buf, 32, rnc); +} + /*! Return MCC-MNC-LAC-RAC-CI as string, in a talloc-allocated output buffer. * \param[in] ctx talloc context from which to allocate output buffer * \param[in] cgi_ps CGI-PS to encode. @@ -656,6 +694,24 @@ return 0; } +/* Compare two RNC Ids + * The order of comparison is PLMN, RNCId. + * \param a[in] "Left" side RNC Id. + * \param b[in] "Right" side RNC Id. + * \returns 0 if the RNC Ids are equal, -1 if a < b, 1 if a > b. */ +int osmo_rnc_id_cmp(const struct osmo_rnc_id *a, const struct osmo_rnc_id *b) +{ + int rc = osmo_plmn_cmp(&a->plmn, &b->plmn); + if (rc) + return rc; + + if (a->rnc_id < b->rnc_id) + return -1; + if (a->rnc_id > b->rnc_id) + return 1; + return 0; +} + /* Compare two MME Ids * The order of comparison is MME GroupId, MME Code. * \param a[in] "Left" side MME Id. diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 7c78347..78e0385 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -500,6 +500,10 @@ osmo_cgi_ps_name_buf; osmo_cgi_ps_name_c; osmo_cgi_ps_name2; +osmo_rnc_id_name; +osmo_rnc_id_name_buf; +osmo_rnc_id_name_c; +osmo_rnc_id_cmp; osmo_gummei_name; osmo_gummei_name_buf; osmo_gummei_name_c; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0768c99b4c42b0948e7574d05b70e1b7bdb8a55a Gerrit-Change-Number: 38948 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2025

2024

2023

2022

gerrit-log November 2024