November 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: sigtran: Constify osmo_ss7_instance ptr in several APIs

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38662?usp=email ) Change subject: sigtran: Constify osmo_ss7_instance ptr in several APIs ...................................................................... sigtran: Constify osmo_ss7_instance ptr in several APIs Change-Id: I3be025d4a26d12aa305efe0bf2b3955ca5af3da1 --- M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 4aa1e1c..898c903 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -23,9 +23,9 @@ int osmo_ss7_init(void); int osmo_ss7_find_free_rctx(struct osmo_ss7_instance *inst); -bool osmo_ss7_pc_is_local(struct osmo_ss7_instance *inst, uint32_t pc); -int osmo_ss7_pointcode_parse(struct osmo_ss7_instance *inst, const char *str); -int osmo_ss7_pointcode_parse_mask_or_len(struct osmo_ss7_instance *inst, const char *in); +bool osmo_ss7_pc_is_local(const struct osmo_ss7_instance *inst, uint32_t pc); +int osmo_ss7_pointcode_parse(const struct osmo_ss7_instance *inst, const char *str); +int osmo_ss7_pointcode_parse_mask_or_len(const struct osmo_ss7_instance *inst, const char *in); const char *osmo_ss7_pointcode_print_buf(char *buf, size_t buf_len, const struct osmo_ss7_instance *inst, uint32_t pc); const char *osmo_ss7_pointcode_print(const struct osmo_ss7_instance *inst, uint32_t pc); const char *osmo_ss7_pointcode_print2(const struct osmo_ss7_instance *inst, uint32_t pc); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 8f6d417..65fff7c 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -205,7 +205,7 @@ /* parse a point code according to the structure configured for this * ss7_instance */ -int osmo_ss7_pointcode_parse(struct osmo_ss7_instance *inst, const char *str) +int osmo_ss7_pointcode_parse(const struct osmo_ss7_instance *inst, const char *str) { unsigned int component[3]; const struct osmo_ss7_pc_fmt *pc_fmt = inst ? &inst->cfg.pc_fmt : &default_pc_fmt; @@ -277,7 +277,7 @@ return osmo_ss7_pointcode_print_buf(buf, sizeof(buf), inst, pc); } -int osmo_ss7_pointcode_parse_mask_or_len(struct osmo_ss7_instance *inst, const char *in) +int osmo_ss7_pointcode_parse_mask_or_len(const struct osmo_ss7_instance *inst, const char *in) { unsigned int width = osmo_ss7_pc_width(inst ? &inst->cfg.pc_fmt : &default_pc_fmt); @@ -778,7 +778,7 @@ return osmo_ss7_xua_server_find2(inst, trans_proto, proto, local_port); } -bool osmo_ss7_pc_is_local(struct osmo_ss7_instance *inst, uint32_t pc) +bool osmo_ss7_pc_is_local(const struct osmo_ss7_instance *inst, uint32_t pc) { OSMO_ASSERT(ss7_initialized); if (osmo_ss7_pc_is_valid(inst->cfg.primary_pc) && pc == inst->cfg.primary_pc) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3be025d4a26d12aa305efe0bf2b3955ca5af3da1 Gerrit-Change-Number: 38662 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: tests: Fix missing LIBOSMONETIF_CFLAGS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38646?usp=email ) Change subject: tests: Fix missing LIBOSMONETIF_CFLAGS ...................................................................... tests: Fix missing LIBOSMONETIF_CFLAGS Change-Id: Ica2d3c487779a1e7c79a5fbcea43c92a1ff08df7 --- M tests/ss7/Makefile.am M tests/xua/Makefile.am 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/tests/ss7/Makefile.am b/tests/ss7/Makefile.am index ecc69e0..236e846 100644 --- a/tests/ss7/Makefile.am +++ b/tests/ss7/Makefile.am @@ -1,5 +1,5 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) +AM_CFLAGS=-Wall $(LIBOSMONETIF_CFLAGS) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) AM_LDFLAGS = -static -no-install LDADD = $(top_builddir)/src/libosmo-sigtran.la \ diff --git a/tests/xua/Makefile.am b/tests/xua/Makefile.am index 546039c..edff329 100644 --- a/tests/xua/Makefile.am +++ b/tests/xua/Makefile.am @@ -1,5 +1,5 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) +AM_CFLAGS=-Wall $(LIBOSMONETIF_CFLAGS) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) AM_LDFLAGS = -static -no-install LDADD = $(top_builddir)/src/libosmo-sigtran.la \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ica2d3c487779a1e7c79a5fbcea43c92a1ff08df7 Gerrit-Change-Number: 38646 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: sigtran: Split osmo_ss7_instance allocation into its own function

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663?usp=email ) Change subject: sigtran: Split osmo_ss7_instance allocation into its own function ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663/comment/0ae20b3d_2f432… : PS2, Line 7: Split > Why? Are you planning to use it somewhere else? It just follows the usual object structure where you have an _alloc() and a _free()/_destroy() function. Makes it a lot easier to find out stuff. Also, it allows separating the lookup from the allocation, which really has nothing to do. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I38f9f19bb43d29999c4a7ba1a537403d1d58e880 Gerrit-Change-Number: 38663 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 19:48:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_instance_get_name()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38651?usp=email ) Change subject: sigtran: Add API osmo_ss7_instance_get_name() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I521b0b140c600dbd8d32721329ea02668ceac576 Gerrit-Change-Number: 38651 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 19:47:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_instance_get_id()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38648?usp=email ) Change subject: sigtran: Add API osmo_ss7_instance_get_id() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38648?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id7b6f23a1a223fb232238b624eb4f3295790bcb1 Gerrit-Change-Number: 38648 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 19:47:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: sigtran: Split osmo_ss7_instance allocation into its own function

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663?usp=email ) Change subject: sigtran: Split osmo_ss7_instance allocation into its own function ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663/comment/12b42451_c413e… : PS2, Line 7: Split Why? Are you planning to use it somewhere else? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I38f9f19bb43d29999c4a7ba1a537403d1d58e880 Gerrit-Change-Number: 38663 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 19:46:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: Update titan.ProtocolEmulations.SCCP to upstream master

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38686?usp=email ) Change subject: deps: Update titan.ProtocolEmulations.SCCP to upstream master ...................................................................... deps: Update titan.ProtocolEmulations.SCCP to upstream master Until now we were using our own fork with an extra patch with a fix for SCCP conn id 0. This patch, together with other patches was merged upstream today. Hence, update our dependency to point to current upstream master. Related: OS#6185 Change-Id: I8ba6cec24205337f19bac951d9a8d4f5d4d476ad --- M deps/Makefile 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index e210dcd..b98fc1e 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -20,6 +20,7 @@ ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ titan.ProtocolEmulations.M3UA \ + titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSAPP_v7.3.0 \ titan.ProtocolModules.DIAMETER_ProtocolModule_Generator \ titan.ProtocolModules.DNS \ @@ -86,7 +87,7 @@ # file changed. titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da titan.ProtocolEmulations.M3UA_commit= b58f92046e48a7b1ed531e243a2319ebca53bf4c -titan.ProtocolEmulations.SCCP_commit= f8a44f2cdef44d0c3adf787ab3184c293a9a58be +titan.ProtocolEmulations.SCCP_commit= 750a3e836831e58eae59d4757ef5d0c759f9ca5d titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a titan.ProtocolModules.BSSMAP_commit= 4acb6ab5f058477f0b90c2da182d52054e3614b0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ba6cec24205337f19bac951d9a8d4f5d4d476ad Gerrit-Change-Number: 38686 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: Update titan.ProtocolEmulations.SCCP to upstream master

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38686?usp=email ) Change subject: deps: Update titan.ProtocolEmulations.SCCP to upstream master ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Just did a 1 test run for HNBGW_Tests and everything seems fine, merging so I can remove the branch in our fork. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ba6cec24205337f19bac951d9a8d4f5d4d476ad Gerrit-Change-Number: 38686 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 19:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: Update titan.ProtocolEmulations.SCCP to upstream master

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38686?usp=email ) Change subject: deps: Update titan.ProtocolEmulations.SCCP to upstream master ...................................................................... deps: Update titan.ProtocolEmulations.SCCP to upstream master Until now we were using our own fork with an extra patch with a fix for SCCP conn id 0. This patch, together with other patches was merged upstream today. Hence, update our dependency to point to current upstream master. Related: OS#6185 Change-Id: I8ba6cec24205337f19bac951d9a8d4f5d4d476ad --- M deps/Makefile 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/38686/1 diff --git a/deps/Makefile b/deps/Makefile index e210dcd..b98fc1e 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -20,6 +20,7 @@ ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ titan.ProtocolEmulations.M3UA \ + titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSAPP_v7.3.0 \ titan.ProtocolModules.DIAMETER_ProtocolModule_Generator \ titan.ProtocolModules.DNS \ @@ -86,7 +87,7 @@ # file changed. titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da titan.ProtocolEmulations.M3UA_commit= b58f92046e48a7b1ed531e243a2319ebca53bf4c -titan.ProtocolEmulations.SCCP_commit= f8a44f2cdef44d0c3adf787ab3184c293a9a58be +titan.ProtocolEmulations.SCCP_commit= 750a3e836831e58eae59d4757ef5d0c759f9ca5d titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a titan.ProtocolModules.BSSMAP_commit= 4acb6ab5f058477f0b90c2da182d52054e3614b0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ba6cec24205337f19bac951d9a8d4f5d4d476ad Gerrit-Change-Number: 38686 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: sigtran: Constify osmo_ss7_instance ptr in several APIs

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38662?usp=email ) Change subject: sigtran: Constify osmo_ss7_instance ptr in several APIs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3be025d4a26d12aa305efe0bf2b3955ca5af3da1 Gerrit-Change-Number: 38662 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 19:43:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024