Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email )
Change subject: Make compatible with private sigtran structs
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-msc/msc_main.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38733/comment/33244bd7_10cbf3e7?usp… :
PS1, Line 814: osmo_ss7_instance_get_name(ss7));
> Anyway, this is left for an older release, so let's merge as is.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: osmith/1.12.2
Gerrit-Change-Id: I6c7d5119174de8d37d1ebe2b47793f9b89cc903c
Gerrit-Change-Number: 38733
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Nov 2024 12:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email )
Change subject: Make compatible with private sigtran structs
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
Patchset:
PS2:
updated the logic in configure.ac, so it also finds the function if it the headerfile is in a non-standard includedir, such as it is the case with the CI "build" jobs using stow.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: osmith/1.12.2
Gerrit-Change-Id: I6c7d5119174de8d37d1ebe2b47793f9b89cc903c
Gerrit-Change-Number: 38733
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Nov 2024 12:17:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email )
Change subject: Add osmo_ss7 APIs
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/hnbgw/hnbgw.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736/comment/a5e48833_d65acf84?u… :
PS1, Line 339: #ifdef SIGTRAN_PRIVATE_STRUCTS
> Did you think about actually defining the APIs here as static inline instead? […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: osmith/1.6.2
Gerrit-Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e
Gerrit-Change-Number: 38736
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Nov 2024 12:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: neels, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38735?usp=email )
Change subject: Make compatible with private pfcp structs
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-hnbgw/context_map_sccp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/38735/comment/0496aa43_d5c2249d?u… :
PS1, Line 244: #ifdef PFCP_PRIVATE_STRUCTS
> We had a meeting this morning to discuss this, and the outcome was that we wanted to at least prolon […]
Acknowledged
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38735?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: osmith/1.6.2
Gerrit-Change-Id: I188e76307deadd9328430afff54dc287eda51370
Gerrit-Change-Number: 38735
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Nov 2024 12:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: neels, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38735?usp=email )
Change subject: Make compatible with private pfcp structs
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38735?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: osmith/1.6.2
Gerrit-Change-Id: I188e76307deadd9328430afff54dc287eda51370
Gerrit-Change-Number: 38735
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Nov 2024 12:14:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/38737?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Bump version: 1.6.1.3-a4f2 → 1.6.2
......................................................................
Bump version: 1.6.1.3-a4f2 → 1.6.2
Change-Id: Ib471306b4ff201f790c2a17a849da408ad62d6b5
---
M debian/changelog
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/37/38737/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38737?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: osmith/1.6.2
Gerrit-Change-Id: Ib471306b4ff201f790c2a17a849da408ad62d6b5
Gerrit-Change-Number: 38737
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified-1 by Jenkins Builder
Change subject: Add osmo_ss7 APIs
......................................................................
Add osmo_ss7 APIs
Prepare OsmoHNBGW to work with newer versions of libosmo-sigtran, where
struct osmo_ss7_instance was made private. Ensure the APIs are always
present even if building with older libosmo-sigtran, so we can apply a
patch that switches over to using these APIs instead of accessing the
struct directly.
Related: OS#6617
Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e
---
M configure.ac
M include/osmocom/hnbgw/hnbgw.h
2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/36/38736/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: osmith/1.6.2
Gerrit-Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e
Gerrit-Change-Number: 38736
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>