Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38461?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: library/GTPv1C_Templates: Lots of improvements in template declarations
......................................................................
library/GTPv1C_Templates: Lots of improvements in template declarations
Also most the compiler warnings are fixed, only some which require
special more complex attention are left as is.
Change-Id: I38a4b1c5874fda173a7b89122c84cb83ac71a036
---
M library/GTPv1C_Templates.ttcn
M mme/MME_Tests.ttcn
M sgsn/SGSN_Tests.ttcn
3 files changed, 287 insertions(+), 176 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/38461/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38461?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I38a4b1c5874fda173a7b89122c84cb83ac71a036
Gerrit-Change-Number: 38461
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458?usp=email )
Change subject: ggsn: README: document how to run with testenv
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Oh I didn't know about that.
We should simply move "ggsn_tests" to ggsn at some point (not now, I'm myself writing patches there :P)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I49421151b199fa6536da784b6c412b03f3fdbd05
Gerrit-Change-Number: 38458
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Oct 2024 13:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458?usp=email )
Change subject: ggsn: README: document how to run with testenv
......................................................................
Patch Set 1:
(1 comment)
File ggsn_tests/README.md:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458/comment/c4ff046c_7483… :
PS1, Line 27: $ ./testenv.py run ggsn -c osmo_ggsn_all
> shouldn't this (and all lines below) be "ggsn_tests"?
both work, and ggsn is shorter: https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/commit/f7ad820eb83bd92…
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I49421151b199fa6536da784b6c412b03f3fdbd05
Gerrit-Change-Number: 38458
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Oct 2024 13:22:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458?usp=email )
Change subject: ggsn: README: document how to run with testenv
......................................................................
Patch Set 1:
(1 comment)
File ggsn_tests/README.md:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458/comment/d0d57d35_353b… :
PS1, Line 27: $ ./testenv.py run ggsn -c osmo_ggsn_all
shouldn't this (and all lines below) be "ggsn_tests"?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38458?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I49421151b199fa6536da784b6c412b03f3fdbd05
Gerrit-Change-Number: 38458
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Oct 2024 11:38:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No