October 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: global_platform: ensure ArgumentParser gets a list for choices
by laforge 25 Oct '24

25 Oct '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38542?usp=email ) Change subject: global_platform: ensure ArgumentParser gets a list for choices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I165fefd8feb0d96cedc15d036fb32da381f711b3 Gerrit-Change-Number: 38542 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 14:44:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: Add some comments with spec references
by laforge 25 Oct '24

25 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38549?usp=email ) Change subject: cosmetic: Add some comments with spec references ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I131dca5be9313d3beb51ec9d5f507552ae6c9d84 Gerrit-Change-Number: 38549 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 14:43:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_iei_names: s/Cause/SCCP Cause/
by laforge 25 Oct '24

25 Oct '24

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email ) Change subject: sua: sua_iei_names: s/Cause/SCCP Cause/ ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I106baa8d181ebfa1616cdd7efab2897dd78fc8e6 Gerrit-Change-Number: 38548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 14:43:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: tun: Use OSMO_STRLCPY_ARRAY
by pespin 25 Oct '24

25 Oct '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email ) Change subject: tun: Use OSMO_STRLCPY_ARRAY ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ggsn/+/38547/comment/e9f5fc8a_7a4e92e1?us… : PS1, Line 7: _TR > _STR Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40b370f4152748d5acf6ee576462e54c9a46a8a3 Gerrit-Change-Number: 38547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 14:32:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ggsn[master]: tun: Use OSMO_STRLCPY_ARRAY
by pespin 25 Oct '24

25 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email ) Change subject: tun: Use OSMO_STRLCPY_ARRAY ...................................................................... tun: Use OSMO_STRLCPY_ARRAY tun->devname buffer is already IFNAMSIZ bytes long, so simplify the code. Change-Id: I40b370f4152748d5acf6ee576462e54c9a46a8a3 --- M lib/tun.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/lib/tun.c b/lib/tun.c index 89fe292..60d9b5e 100644 --- a/lib/tun.c +++ b/lib/tun.c @@ -44,6 +44,7 @@ #include <linux/if_tun.h> #include <osmocom/core/msgb.h> +#include <osmocom/core/utils.h> #include "tun.h" #include "syserr.h" @@ -107,8 +108,7 @@ tun->addrs = 0; tun->tundev.fd = -1; - osmo_strlcpy(tun->devname, devname, IFNAMSIZ); - tun->devname[IFNAMSIZ - 1] = 0; + OSMO_STRLCPY_ARRAY(tun->devname, devname); return tun; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40b370f4152748d5acf6ee576462e54c9a46a8a3 Gerrit-Change-Number: 38547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ggsn[master]: tun: Use OSMO_STRLCPY_ARRAY
by pespin 25 Oct '24

25 Oct '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email ) Change subject: tun: Use OSMO_STRLCPY_ARRAY ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40b370f4152748d5acf6ee576462e54c9a46a8a3 Gerrit-Change-Number: 38547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2024 14:32:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: tun: Use OSMO_STRLCPY_ARRAY
by pespin 25 Oct '24

25 Oct '24

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith Change subject: tun: Use OSMO_STRLCPY_ARRAY ...................................................................... tun: Use OSMO_STRLCPY_ARRAY tun->devname buffer is already IFNAMSIZ bytes long, so simplify the code. Change-Id: I40b370f4152748d5acf6ee576462e54c9a46a8a3 --- M lib/tun.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/47/38547/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40b370f4152748d5acf6ee576462e54c9a46a8a3 Gerrit-Change-Number: 38547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: Add some comments with spec references
by pespin 25 Oct '24

25 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38549?usp=email ) Change subject: cosmetic: Add some comments with spec references ...................................................................... cosmetic: Add some comments with spec references Change-Id: I131dca5be9313d3beb51ec9d5f507552ae6c9d84 --- M include/osmocom/sccp/sccp_types.h M include/osmocom/sigtran/protocol/sua.h 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/49/38549/1 diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index 17018d2..bc11258 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -189,6 +189,7 @@ SCCP_PROTOCOL_RETURN_MESSAGE = 8, }; +/* ITU-T Q.713, Section 3.11 Release cause */ enum sccp_release_cause { SCCP_RELEASE_CAUSE_END_USER_ORIGINATED = 0, SCCP_RELEASE_CAUSE_END_USER_CONGESTION = 1, @@ -209,6 +210,7 @@ SCCP_RELEASE_CAUSE_SCCP_FAILURE = 16, }; +/* ITU-T Q.713, Section 3.12 Return cause */ enum sccp_return_cause { SCCP_RETURN_CAUSE_NO_TRANSLATION_NATURE = 0, SCCP_RETURN_CAUSE_NO_TRANSLATION = 1, @@ -227,6 +229,7 @@ SCCP_RETURN_CAUSE_SEGMENTATION_FAILURE = 14 }; +/* ITU-T Q.713, Section 3.13 Reset cause */ enum sccp_reset_cause { SCCP_RESET_CAUSE_END_USER_ORIGINATED = 0, SCCP_RESET_CAUSE_SCCP_USER_ORIGINATED = 1, @@ -242,6 +245,7 @@ SCCP_RESET_CAUSE_RESERVED = 11, }; +/* ITU-T Q.713, Section 3.14 Error cause */ enum sccp_error_cause { SCCP_ERROR_LRN_MISMATCH_UNASSIGNED = 0, /* local reference number */ SCCP_ERROR_LRN_MISMATCH_INCONSISTENT = 1, @@ -250,7 +254,7 @@ SCCP_ERROR_UNQUALIFIED = 4, }; -/* ITU=T Q.713 Section 3.15 */ +/* ITU-T Q.713 Section 3.15 Refusal cause */ enum sccp_refusal_cause { SCCP_REFUSAL_END_USER_ORIGINATED = 0, SCCP_REFUSAL_END_USER_CONGESTION = 1, diff --git a/include/osmocom/sigtran/protocol/sua.h b/include/osmocom/sigtran/protocol/sua.h index 70c16ba..4ce88f9 100644 --- a/include/osmocom/sigtran/protocol/sua.h +++ b/include/osmocom/sigtran/protocol/sua.h @@ -130,6 +130,7 @@ #define SUA_RI_HOST 3 #define SUA_RI_SSN_IP 4 +/* 3.10.6. SCCP Cause: Cause Type */ #define SUA_CAUSE_T_MASK 0xff00 #define SUA_CAUSE_T_RETURN 0x0100 #define SUA_CAUSE_T_REFUSAL 0x0200 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I131dca5be9313d3beb51ec9d5f507552ae6c9d84 Gerrit-Change-Number: 38549 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_iei_names: s/Cause/SCCP Cause/
by pespin 25 Oct '24

25 Oct '24

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: sua: sua_iei_names: s/Cause/SCCP Cause/ ...................................................................... sua: sua_iei_names: s/Cause/SCCP Cause/ This is how the field is named in RFC 3868 section 3.10. This also helps identifying it from other existing field "User/Cause". Change-Id: I106baa8d181ebfa1616cdd7efab2897dd78fc8e6 --- M src/sua.c M tests/xua/xua_test.ok 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/48/38548/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I106baa8d181ebfa1616cdd7efab2897dd78fc8e6 Gerrit-Change-Number: 38548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: sua_iei_names: s/Cause/SCCP Cause/
by pespin 25 Oct '24

25 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email ) Change subject: sua: sua_iei_names: s/Cause/SCCP Cause/ ...................................................................... sua: sua_iei_names: s/Cause/SCCP Cause/ This is how the field is named in RFC 3868 section 3.10. This also helps identifying it from other existing field "User/Cause". Change-Id: I106baa8d181ebfa1616cdd7efab2897dd78fc8e6 --- M src/sua.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/48/38548/1 diff --git a/src/sua.c b/src/sua.c index 3d9d7ec..2753cfe 100644 --- a/src/sua.c +++ b/src/sua.c @@ -89,7 +89,7 @@ { SUA_IEI_DEST_ADDR, "Destination Address" }, { SUA_IEI_SRC_REF, "Source Reference" }, { SUA_IEI_DEST_REF, "Destination Reference" }, - { SUA_IEI_CAUSE, "Cause" }, + { SUA_IEI_CAUSE, "SCCP Cause" }, { SUA_IEI_SEQ_NR, "Sequence Number" }, { SUA_IEI_RX_SEQ_NR, "Receive Sequence Number" }, { SUA_IEI_ASP_CAPA, "ASP Capability" }, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I106baa8d181ebfa1616cdd7efab2897dd78fc8e6 Gerrit-Change-Number: 38548 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0