October 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: Fix 'update route' vty command
by fixeria 07 Oct '24

07 Oct '24

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email ) Change subject: Fix 'update route' vty command ...................................................................... Patch Set 3: (2 comments) File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348/comment/f84ac248_1fd87… : PS3, Line 344: linkset LS_NAME [priority] [PRIO] [qos-class] [(CLASS|default)] Something is still wrong with the interactive help: ``` OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 ? linkset Point Code Length OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset ? LS_NAME Specify Destination Linkset OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass ? [priority] Linkset Name OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority ? [PRIO] Specify Priority OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 42 ? [qos-class] Priority OsmoSTP(config-cs7-rt)# update route 3.2.1 7.255.7 linkset my-ass priority 42 qos-class ? [CLASS] Specify QoS Class [default] QoS Class ``` https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348/comment/e6e376ff_7063c… : PS3, Line 397: return CMD_WARNING; print an error here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28d3b587ae5d6ca7f494221e2bfc39357a45736d Gerrit-Change-Number: 38348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:52:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: Fix 'update route' vty command
by pespin 07 Oct '24

07 Oct '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email ) Change subject: Fix 'update route' vty command ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28d3b587ae5d6ca7f494221e2bfc39357a45736d Gerrit-Change-Number: 38348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:51:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: tests/vty: Add vty-transcript-test for osmo-stp
by pespin 07 Oct '24

07 Oct '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email ) Change subject: tests/vty: Add vty-transcript-test for osmo-stp ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If2f069b9d724038c326f5c35848faa1e9c216fd5 Gerrit-Change-Number: 38347 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:51:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: tests/vty: Add vty-transcript-test for osmo-stp
by pespin 07 Oct '24

07 Oct '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email ) Change subject: tests/vty: Add vty-transcript-test for osmo-stp ...................................................................... Patch Set 3: (1 comment) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347/comment/d92e4a3f_0edaa… : PS3, Line 104: description .TEXT > This is a generic command from libosmovty (`cfg_description_cmd`), are you sure it should be tested […] I just copied the file from ss7_asp_test.vty to have similar testing for both asp and sg. So I think this is really orthogonal to the patch at hand. I can submit an extra commit removing it from both files. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If2f069b9d724038c326f5c35848faa1e9c216fd5 Gerrit-Change-Number: 38347 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:49:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Fix 'update route' vty command
by fixeria 07 Oct '24

07 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email ) Change subject: Fix 'update route' vty command ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28d3b587ae5d6ca7f494221e2bfc39357a45736d Gerrit-Change-Number: 38348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:36:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: tests/vty: Add vty-transcript-test for osmo-stp
by fixeria 07 Oct '24

07 Oct '24

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email ) Change subject: tests/vty: Add vty-transcript-test for osmo-stp ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347/comment/21fa68d6_b406a… : PS3, Line 104: description .TEXT This is a generic command from libosmovty (`cfg_description_cmd`), are you sure it should be tested here? I am not strictly against this, but we have had several cases when a change in libosmovty was causing VTY transcript tests to fail in various projects. Likewise below. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If2f069b9d724038c326f5c35848faa1e9c216fd5 Gerrit-Change-Number: 38347 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 15:34:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: move ggsn testsuite
by pespin 07 Oct '24

07 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: move ggsn testsuite ...................................................................... Patch Set 2: (1 comment) File jobs/ttcn3-testsuites-testenv.yml: https://gerrit.osmocom.org/c/osmo-ci/+/38346/comment/a4b98cce_f6b17582?usp=… : PS2, Line 284: wget -q -O .linux "https://jenkins.osmocom.org/jenkins/job/build-kernel-$KERNEL/lastSuccessful…" Why not getting this file using jenkins infrastructure? At least in jenkins UI you can obtain latest artifiact from another job before running the job. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5b70944bd1fa9c90c5ad51b9026fdcd969bfc8a8 Gerrit-Change-Number: 38346 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 14:57:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-ci[master]: jobs/build-kernels-testenv: new jobs
by pespin 07 Oct '24

07 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38345?usp=email ) Change subject: jobs/build-kernels-testenv: new jobs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id64a1a778fa38eec20498c36b390332f75d7d3f5 Gerrit-Change-Number: 38345 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 14:55:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: ggsn: testenv: support running osmo-ggsn in QEMU
by pespin 07 Oct '24

07 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38344?usp=email ) Change subject: ggsn: testenv: support running osmo-ggsn in QEMU ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f9db4325d5928c809cc99bc82d9cb82bf9e71eb Gerrit-Change-Number: 38344 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 14:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: testenv: support running SUT in QEMU
by pespin 07 Oct '24

07 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38343?usp=email ) Change subject: testenv: support running SUT in QEMU ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9cb7092fd029b7ba530fc755b5d4d73a9d86350 Gerrit-Change-Number: 38343 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 14:54:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0