October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-msc[master]: vlr: make vlr_parq_fsm_init() private
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38412?usp=email ) Change subject: vlr: make vlr_parq_fsm_init() private ...................................................................... vlr: make vlr_parq_fsm_init() private All other fsm initialisation are internal to the libvlr code. Change-Id: I3b4cfc01e6dd5434c74b4fa24a3e0945668b2a74 --- M include/osmocom/vlr/vlr.h M src/libvlr/vlr_access_req_fsm.h 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/12/38412/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index 1a2ef9e..8a5b956 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -475,8 +475,6 @@ enum osmo_fsm_term_cause fsm_cause, enum gsm48_reject_value gsm48_cause); -void vlr_parq_fsm_init(void); - int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, diff --git a/src/libvlr/vlr_access_req_fsm.h b/src/libvlr/vlr_access_req_fsm.h index 1c4db24..772923c 100644 --- a/src/libvlr/vlr_access_req_fsm.h +++ b/src/libvlr/vlr_access_req_fsm.h @@ -16,4 +16,5 @@ PR_ARQ_S_DONE, }; +void vlr_parq_fsm_init(void); void vlr_parq_fsm_set_loglevel(int log_level); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3b4cfc01e6dd5434c74b4fa24a3e0945668b2a74 Gerrit-Change-Number: 38412 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-msc[master]: vlr: add a logging layer
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email ) Change subject: vlr: add a logging layer ...................................................................... vlr: add a logging layer To prepare the split off into a separate library, the logging can't use log category from a define. Use the same strategy as all the other osmo libraries and use a global array which is set on initialisation to define the logging categories. Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b --- M include/osmocom/vlr/vlr.h M src/libmsc/msc_net_init.c M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_access_req_fsm.h M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_lu_fsm.c M src/libvlr/vlr_lu_fsm.h M src/libvlr/vlr_sgs.c M src/libvlr/vlr_sgs_fsm.c M src/libvlr/vlr_sgs_fsm.h 11 files changed, 106 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/10/38410/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index 6d5c71c..1a2ef9e 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -17,12 +17,6 @@ #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/vlr/vlr_sgs.h> -#define LOGGSUPP(level, gsup, fmt, args...) \ - LOGP(DVLR, level, "GSUP(%s) " fmt, (gsup)->imsi, ## args) - -#define LOGVSUBP(level, vsub, fmt, args...) \ - LOGP(DVLR, level, "SUBSCR(%s) " fmt, vlr_subscr_name(vsub), ## args) - struct log_target; struct osmo_mobile_identity; @@ -498,3 +492,24 @@ enum gsm48_reject_value vlr_gmm_cause_to_reject_cause_domain(enum gsm48_gmm_cause gmm_cause, bool is_cs); enum gsm48_reject_value vlr_reject_causes_cs(enum gsm48_reject_value reject_cause); enum gsm48_reject_value vlr_reject_causes_ps(enum gsm48_reject_value reject_cause); + +/* logging */ +enum osmo_vlr_cat { + OSMO_VLR_LOGC_VLR, + OSMO_VLR_LOGC_SGS, + _OSMO_VLR_LOGC_MAX, +}; + +void osmo_vlr_set_log_cat(enum osmo_vlr_cat logc, int logc_num); + +extern int g_vlr_log_cat[_OSMO_VLR_LOGC_MAX]; + +#define LOGVLR(lvl, fmt, args...) LOGP(g_vlr_log_cat[OSMO_VLR_LOGC_VLR], lvl, fmt, ## args) +#define LOGSGS(lvl, fmt, args...) LOGP(g_vlr_log_cat[OSMO_VLR_LOGC_SGS], lvl, fmt, ## args) + +#define LOGGSUPP(level, gsup, fmt, args...) \ + LOGVLR(level, "GSUP(%s) " fmt, (gsup)->imsi, ## args) + +#define LOGVSUBP(level, vsub, fmt, args...) \ + LOGVLR(level, "SUBSCR(%s) " fmt, vlr_subscr_name(vsub), ## args) + diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index ad0c19a..21f68cf 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -28,6 +28,7 @@ #include <osmocom/msc/gsm_data.h> #include <osmocom/vlr/vlr.h> +#include <osmocom/msc/debug.h> #include <osmocom/msc/gsup_client_mux.h> #include <osmocom/msc/gsm_04_11_gsup.h> #include <osmocom/msc/gsm_09_11.h> @@ -107,6 +108,8 @@ /* Allocate net->vlr so that the VTY may configure the VLR's data structures */ int msc_vlr_alloc(struct gsm_network *net) { + osmo_vlr_set_log_cat(OSMO_VLR_LOGC_VLR, DVLR); + osmo_vlr_set_log_cat(OSMO_VLR_LOGC_SGS, DSGS); net->vlr = vlr_alloc(net, &msc_vlr_ops); if (!net->vlr) return -ENOMEM; diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 81429bb..3aa5a5e 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -454,7 +454,7 @@ { llist_del(&vsub->list); vlr_stat_item_dec(vsub->vlr, VLR_STAT_SUBSCRIBER_COUNT); - DEBUGP(DVLR, "freeing VLR subscr %s (max total use count was %d)\n", vlr_subscr_name(vsub), + LOGVLR(LOGL_DEBUG, "freeing VLR subscr %s (max total use count was %d)\n", vlr_subscr_name(vsub), vsub->max_total_use_count); /* Make sure SGs timer Ts5 is removed */ @@ -478,7 +478,7 @@ for (tried = 0; tried < 100; tried++) { rc = osmo_get_rand_id((uint8_t *) &tmsi, sizeof(tmsi)); if (rc < 0) { - LOGP(DVLR, LOGL_ERROR, "osmo_get_rand_id() failed: %s\n", strerror(-rc)); + LOGVLR(LOGL_ERROR, "osmo_get_rand_id() failed: %s\n", strerror(-rc)); return rc; } @@ -486,7 +486,7 @@ int16_t nri_v; osmo_tmsi_nri_v_limit_by_ranges(&tmsi, vlr->cfg.nri_ranges, vlr->cfg.nri_bitlen); osmo_tmsi_nri_v_get(&nri_v, tmsi, vlr->cfg.nri_bitlen); - LOGP(DVLR, LOGL_DEBUG, "New NRI from range [%s] = 0x%x --> TMSI 0x%08x\n", + LOGVLR(LOGL_DEBUG, "New NRI from range [%s] = 0x%x --> TMSI 0x%08x\n", osmo_nri_ranges_to_str_c(OTC_SELECT, vlr->cfg.nri_ranges), nri_v, tmsi); } @@ -515,7 +515,7 @@ return 0; } - LOGP(DVLR, LOGL_ERROR, "subscr %s: unable to generate valid TMSI" + LOGVLR(LOGL_ERROR, "subscr %s: unable to generate valid TMSI" " after %d tries\n", vlr_subscr_name(vsub), tried); return -1; } @@ -544,7 +544,7 @@ return NULL; vlr_subscr_get_src(vsub, use, file, line); vlr_subscr_set_imsi(vsub, imsi); - LOGP(DVLR, LOGL_INFO, "New subscr, IMSI: %s\n", vsub->imsi); + LOGVLR(LOGL_INFO, "New subscr, IMSI: %s\n", vsub->imsi); if (created) *created = true; return vsub; @@ -574,7 +574,7 @@ return NULL; vlr_subscr_get_src(vsub, use, file, line); vsub->tmsi = tmsi; - LOGP(DVLR, LOGL_INFO, "New subscr, TMSI: 0x%08x\n", vsub->tmsi); + LOGVLR(LOGL_INFO, "New subscr, TMSI: 0x%08x\n", vsub->tmsi); if (created) *created = true; return vsub; @@ -585,7 +585,7 @@ struct vlr_instance *vlr = exists->vlr; int i; int j; - LOGP(DVLR, LOGL_NOTICE, + LOGVLR(LOGL_NOTICE, "There is an existing subscriber for IMSI %s used by %s, replacing with new VLR subscr: %s used by %s\n", exists->imsi, osmo_use_count_to_str_c(OTC_SELECT, &exists->use_count), vlr_subscr_name(vsub), @@ -638,13 +638,13 @@ /* Set the IMSI on the new subscriber, here. */ if (OSMO_STRLCPY_ARRAY(vsub->imsi, imsi) >= sizeof(vsub->imsi)) { - LOGP(DVLR, LOGL_NOTICE, "IMSI was truncated: full IMSI=%s, truncated IMSI=%s\n", + LOGVLR(LOGL_NOTICE, "IMSI was truncated: full IMSI=%s, truncated IMSI=%s\n", imsi, vsub->imsi); /* XXX Set truncated IMSI anyway, we currently cannot return an error from here. */ } vsub->id = atoll(vsub->imsi); - DEBUGP(DVLR, "set IMSI on subscriber; IMSI=%s id=%llu\n", + LOGVLR(LOGL_DEBUG, "set IMSI on subscriber; IMSI=%s id=%llu\n", vsub->imsi, vsub->id); } @@ -653,7 +653,7 @@ if (!vsub) return; OSMO_STRLCPY_ARRAY(vsub->imei, imei); - DEBUGP(DVLR, "set IMEI on subscriber; IMSI=%s IMEI=%s\n", + LOGVLR(LOGL_DEBUG, "set IMEI on subscriber; IMSI=%s IMEI=%s\n", vsub->imsi, vsub->imei); } @@ -662,7 +662,7 @@ if (!vsub) return; OSMO_STRLCPY_ARRAY(vsub->imeisv, imeisv); - DEBUGP(DVLR, "set IMEISV on subscriber; IMSI=%s IMEISV=%s\n", + LOGVLR(LOGL_DEBUG, "set IMEISV on subscriber; IMSI=%s IMEISV=%s\n", vsub->imsi, vsub->imeisv); /* Copy IMEISV to IMEI (additional SV digits get cut off) */ @@ -675,7 +675,7 @@ if (!vsub) return; OSMO_STRLCPY_ARRAY(vsub->msisdn, msisdn); - DEBUGP(DVLR, "set MSISDN on subscriber; IMSI=%s MSISDN=%s\n", + LOGVLR(LOGL_DEBUG, "set MSISDN on subscriber; IMSI=%s MSISDN=%s\n", vsub->imsi, vsub->msisdn); } @@ -690,7 +690,7 @@ } else { vsub->sgs.last_eutran_plmn_present = false; } - DEBUGP(DVLR, "set Last E-UTRAN PLMN ID on subscriber: %s\n", + LOGVLR(LOGL_DEBUG, "set Last E-UTRAN PLMN ID on subscriber: %s\n", vsub->sgs.last_eutran_plmn_present ? osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : "(none)"); @@ -723,7 +723,7 @@ int vlr_subscr_changed(struct vlr_subscr *vsub) { /* FIXME */ - LOGP(DVLR, LOGL_ERROR, "Not implemented: %s\n", __func__); + LOGVLR(LOGL_ERROR, "Not implemented: %s\n", __func__); return 0; } @@ -735,7 +735,7 @@ if (osmo_clock_gettime(CLOCK_MONOTONIC, &now) == 0) { vsub->expire_lu = now.tv_sec + vlr_timer(vsub->vlr, 3212); } else { - LOGP(DVLR, LOGL_ERROR, + LOGVLR(LOGL_ERROR, "%s: Could not enable Location Update expiry: unable to read current time\n", vlr_subscr_name(vsub)); /* Disable LU expiry for this subscriber. This subscriber will only be freed after an explicit IMSI detach. */ vsub->expire_lu = VLR_SUBSCRIBER_NO_EXPIRATION; @@ -757,7 +757,7 @@ goto done; if (osmo_clock_gettime(CLOCK_MONOTONIC, &now) != 0) { - LOGP(DVLR, LOGL_ERROR, "Skipping Location Update expiry: Could not read current time\n"); + LOGVLR(LOGL_ERROR, "Skipping Location Update expiry: Could not read current time\n"); goto done; } @@ -765,7 +765,7 @@ if (vsub->expire_lu == VLR_SUBSCRIBER_NO_EXPIRATION || vsub->expire_lu > now.tv_sec) continue; - LOGP(DVLR, LOGL_DEBUG, "%s: Location Update expired\n", vlr_subscr_name(vsub)); + LOGVLR(LOGL_DEBUG, "%s: Location Update expired\n", vlr_subscr_name(vsub)); vlr_rate_ctr_inc(vlr, VLR_CTR_DETACH_BY_T3212); vlr_subscr_detach(vsub); } @@ -843,20 +843,20 @@ const struct osmo_gsup_message *gsup_msg) { if (OSMO_GSUP_IS_MSGT_REQUEST(gsup_msg->message_type)) { - LOGP(DVLR, LOGL_NOTICE, + LOGVLR(LOGL_NOTICE, "Unknown IMSI %s, discarding GSUP request " "of type 0x%02x\n", gsup_msg->imsi, gsup_msg->message_type); gsup_client_mux_tx_error_reply(vlr->gcm, gsup_msg, GMM_CAUSE_IMSI_UNKNOWN); } else if (OSMO_GSUP_IS_MSGT_ERROR(gsup_msg->message_type)) { - LOGP(DVLR, LOGL_NOTICE, + LOGVLR(LOGL_NOTICE, "Unknown IMSI %s, discarding GSUP error " "of type 0x%02x, cause '%s' (%d)\n", gsup_msg->imsi, gsup_msg->message_type, get_value_string(gsm48_gmm_cause_names, gsup_msg->cause), gsup_msg->cause); } else { - LOGP(DVLR, LOGL_NOTICE, + LOGVLR(LOGL_NOTICE, "Unknown IMSI %s, discarding GSUP response " "of type 0x%02x\n", gsup_msg->imsi, gsup_msg->message_type); @@ -1028,13 +1028,13 @@ gsm48_decode_bcd_number2(vsub->msisdn, sizeof(vsub->msisdn), gsup_msg->msisdn_enc, gsup_msg->msisdn_enc_len, 0); - LOGP(DVLR, LOGL_DEBUG, "IMSI:%s has MSISDN:%s\n", + LOGVLR(LOGL_DEBUG, "IMSI:%s has MSISDN:%s\n", vsub->imsi, vsub->msisdn); } if (gsup_msg->hlr_enc) { if (gsup_msg->hlr_enc_len > sizeof(vsub->hlr.buf)) { - LOGP(DVLR, LOGL_ERROR, "HLR-Number too long (%zu)\n", + LOGVLR(LOGL_ERROR, "HLR-Number too long (%zu)\n", gsup_msg->hlr_enc_len); vsub->hlr.len = 0; } else { @@ -1047,7 +1047,7 @@ if (gsup_msg->pdp_info_compl) { rc = vlr_subscr_pdp_data_clear(vsub); if (rc > 0) - LOGP(DVLR, LOGL_INFO, "Cleared existing PDP info\n"); + LOGVLR(LOGL_INFO, "Cleared existing PDP info\n"); } for (idx = 0; idx < gsup_msg->num_pdp_infos; idx++) { @@ -1689,3 +1689,25 @@ } else target->filter_map &= ~(1 << LOG_FLT_VLR_SUBSCR); } + +int g_vlr_log_cat[_OSMO_VLR_LOGC_MAX]; + +void osmo_vlr_set_log_cat(enum osmo_vlr_cat logc, int logc_num) +{ + if (logc <= OSMO_VLR_LOGC_VLR || logc >= _OSMO_VLR_LOGC_MAX) + return; + + g_vlr_log_cat[logc] = logc_num; + + switch (logc) { + case OSMO_VLR_LOGC_VLR: + vlr_auth_fsm.log_subsys = logc_num; + vlr_lu_fsm_set_loglevel(logc_num); + break; + case OSMO_VLR_LOGC_SGS: + vlr_sgs_fsm_set_loglevel(logc_num); + break; + default: + break; + } +} diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index c2e185b..3b46ddb 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -650,7 +650,7 @@ .num_states = ARRAY_SIZE(proc_arq_vlr_states), .allstate_event_mask = 0, .allstate_action = NULL, - .log_subsys = DVLR, + .log_subsys = DLGLOBAL, .event_names = proc_arq_vlr_event_names, .cleanup = proc_arq_vlr_cleanup, }; @@ -809,3 +809,8 @@ //OSMO_ASSERT(osmo_fsm_register(&upd_loc_child_vlr_fsm) == 0); OSMO_ASSERT(osmo_fsm_register(&proc_arq_vlr_fsm) == 0); } + +void vlr_parq_fsm_set_loglevel(int log_level) +{ + proc_arq_vlr_fsm.log_subsys = log_level; +} diff --git a/src/libvlr/vlr_access_req_fsm.h b/src/libvlr/vlr_access_req_fsm.h index 8386da6..1c4db24 100644 --- a/src/libvlr/vlr_access_req_fsm.h +++ b/src/libvlr/vlr_access_req_fsm.h @@ -15,3 +15,5 @@ PR_ARQ_S_WAIT_CECK_CONF, PR_ARQ_S_DONE, }; + +void vlr_parq_fsm_set_loglevel(int log_level); diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index 3a74ec1..3b398dd 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -610,7 +610,7 @@ .num_states = ARRAY_SIZE(auth_fsm_states), .allstate_event_mask = 0, .allstate_action = NULL, - .log_subsys = DVLR, + .log_subsys = DLGLOBAL, .event_names = fsm_auth_event_names, .cleanup = auth_fsm_cleanup, }; diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index b26eed7..1279801 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -150,7 +150,7 @@ .num_states = ARRAY_SIZE(upd_hlr_vlr_states), .allstate_event_mask = 0, .allstate_action = NULL, - .log_subsys = DVLR, + .log_subsys = DLGLOBAL, .event_names = upd_hlr_vlr_event_names, }; @@ -262,7 +262,7 @@ .num_states = ARRAY_SIZE(sub_pres_vlr_states), .allstate_event_mask = 0, .allstate_action = NULL, - .log_subsys = DVLR, + .log_subsys = DLGLOBAL, .event_names = sub_pres_vlr_event_names, }; @@ -601,7 +601,7 @@ .num_states = ARRAY_SIZE(lu_compl_vlr_states), .allstate_event_mask = 0, .allstate_action = NULL, - .log_subsys = DVLR, + .log_subsys = DLGLOBAL, .event_names = lu_compl_vlr_event_names, }; @@ -1492,7 +1492,7 @@ .num_states = ARRAY_SIZE(vlr_lu_fsm_states), .allstate_event_mask = 0, .allstate_action = NULL, - .log_subsys = DVLR, + .log_subsys = DLGLOBAL, .event_names = fsm_lu_event_names, .cleanup = fsm_lu_cleanup, }; @@ -1595,3 +1595,11 @@ OSMO_ASSERT(osmo_fsm_register(&sub_pres_vlr_fsm) == 0); OSMO_ASSERT(osmo_fsm_register(&lu_compl_vlr_fsm) == 0); } + +void vlr_lu_fsm_set_loglevel(int log_level) +{ + vlr_lu_fsm.log_subsys = log_level; + upd_hlr_vlr_fsm.log_subsys = log_level; + sub_pres_vlr_fsm.log_subsys = log_level; + lu_compl_vlr_fsm.log_subsys = log_level; +} diff --git a/src/libvlr/vlr_lu_fsm.h b/src/libvlr/vlr_lu_fsm.h index b5c4a5e..29cc24a 100644 --- a/src/libvlr/vlr_lu_fsm.h +++ b/src/libvlr/vlr_lu_fsm.h @@ -17,3 +17,4 @@ }; void vlr_lu_fsm_init(void); +void vlr_lu_fsm_set_loglevel(int log_level); diff --git a/src/libvlr/vlr_sgs.c b/src/libvlr/vlr_sgs.c index a0147c0..ace2c5d 100644 --- a/src/libvlr/vlr_sgs.c +++ b/src/libvlr/vlr_sgs.c @@ -51,7 +51,7 @@ OSMO_ASSERT(vlr); - LOGP(DVLR, LOGL_INFO, "dropping all SGs associations.\n"); + LOGSGS(LOGL_INFO, "dropping all SGs associations.\n"); llist_for_each_entry(vsub, &vlr->subscribers, list) { osmo_fsm_inst_dispatch(vsub->sgs_fsm, SGS_UE_E_RX_RESET_FROM_MME, NULL); @@ -85,7 +85,7 @@ vsub = vlr_subscr_find_or_create_by_imsi(vlr, imsi, VSUB_USE_SGS_LU, NULL); if (!vsub) { - LOGP(DSGS, LOGL_ERROR, "VLR subscriber allocation failed\n"); + LOGSGS(LOGL_ERROR, "VLR subscriber allocation failed\n"); return -EINVAL; } @@ -168,7 +168,7 @@ evt = SGS_UE_E_RX_DETACH_IND_FROM_MME; break; default: - LOGP(DSGS, LOGL_ERROR, "(sub %s) invalid SGS IMSI detach type, detaching anyway...\n", + LOGSGS(LOGL_ERROR, "(sub %s) invalid SGS IMSI detach type, detaching anyway...\n", vlr_subscr_msisdn_or_name(vsub)); evt = SGS_UE_E_RX_DETACH_IND_FROM_MME; break; @@ -206,7 +206,7 @@ evt = SGS_UE_E_RX_DETACH_IND_FROM_MME; break; default: - LOGP(DSGS, LOGL_ERROR, "(sub %s) invalid SGS IMSI detach type, detaching anyway...\n", + LOGSGS(LOGL_ERROR, "(sub %s) invalid SGS IMSI detach type, detaching anyway...\n", vlr_subscr_msisdn_or_name(vsub)); evt = SGS_UE_E_RX_DETACH_IND_FROM_MME; break; @@ -253,7 +253,7 @@ /* On the reception of a paging rej the VLR is supposed to stop Ts5, also 3GPP TS 29.118, chapter 5.1.2.4 */ osmo_timer_del(&vsub->sgs.Ts5); - LOGP(DSGS, LOGL_DEBUG, "(sub %s) Paging via SGs interface rejected by MME, %s stopped, cause: %s!\n", + LOGSGS(LOGL_DEBUG, "(sub %s) Paging via SGs interface rejected by MME, %s stopped, cause: %s!\n", vlr_subscr_msisdn_or_name(vsub), vlr_sgs_state_timer_name(SGS_STATE_TS5), sgsap_sgs_cause_name(cause)); osmo_fsm_inst_dispatch(vsub->sgs_fsm, SGS_UE_E_RX_PAGING_FAILURE, &cause); @@ -295,7 +295,7 @@ /* On the reception of an UE unreachable the VLR is supposed to stop * Ts5, also 3GPP TS 29.118, chapter 5.1.2.5 */ osmo_timer_del(&vsub->sgs.Ts5); - LOGP(DSGS, LOGL_DEBUG, + LOGSGS(LOGL_DEBUG, "(sub %s) Paging via SGs interface not possible, UE unreachable, %s stopped, cause: %s\n", vlr_subscr_msisdn_or_name(vsub), vlr_sgs_state_timer_name(SGS_STATE_TS5), sgsap_sgs_cause_name(cause)); @@ -313,7 +313,7 @@ * failed. Other actions may check the status of Ts5 to see if a paging * is still ongoing or not. */ - LOGP(DSGS, LOGL_ERROR, "(sub %s) Paging via SGs interface timed out (%s expired)!\n", + LOGSGS(LOGL_ERROR, "(sub %s) Paging via SGs interface timed out (%s expired)!\n", vlr_subscr_msisdn_or_name(vsub), vlr_sgs_state_timer_name(SGS_STATE_TS5)); /* Balance ref count increment from vlr_sgs_pag() */ diff --git a/src/libvlr/vlr_sgs_fsm.c b/src/libvlr/vlr_sgs_fsm.c index c7a9fdd..4cea056 100644 --- a/src/libvlr/vlr_sgs_fsm.c +++ b/src/libvlr/vlr_sgs_fsm.c @@ -355,7 +355,7 @@ S(SGS_UE_E_RX_LU_FROM_A_IU_GS), .allstate_action = sgs_ue_fsm_allstate, .timer_cb = sgs_ue_fsm_timer_cb, - .log_subsys = DSGS, + .log_subsys = DLGLOBAL, .event_names = sgs_ue_fsm_event_names, }; @@ -366,6 +366,12 @@ OSMO_ASSERT(osmo_fsm_register(&sgs_ue_fsm) == 0); } +/*! Set the log level of the fsm */ +void vlr_sgs_fsm_set_loglevel(int log_level) +{ + sgs_ue_fsm.log_subsys = log_level; +} + /*! Crate SGs FSM in struct vlr_subscr. * \param[in] vsub VLR subscriber for which the SGs FSM should be created. */ void vlr_sgs_fsm_create(struct vlr_subscr *vsub) diff --git a/src/libvlr/vlr_sgs_fsm.h b/src/libvlr/vlr_sgs_fsm.h index 6a09433..3dd84c3 100644 --- a/src/libvlr/vlr_sgs_fsm.h +++ b/src/libvlr/vlr_sgs_fsm.h @@ -39,6 +39,7 @@ }; void vlr_sgs_fsm_init(void); +void vlr_sgs_fsm_set_loglevel(int log_level); void vlr_sgs_fsm_create(struct vlr_subscr *vsub); void vlr_sgs_fsm_remove(struct vlr_subscr *vsub); void vlr_sgs_fsm_update_id(struct vlr_subscr *vsub); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b Gerrit-Change-Number: 38410 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: vlr: vlr_auth_fsm: make the fsm instance private
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38413?usp=email ) Change subject: vlr: vlr_auth_fsm: make the fsm instance private ...................................................................... vlr: vlr_auth_fsm: make the fsm instance private Like all the other libvlr fsm, they are private to their own files, keep the vlr_auth_fsm the same and be consistant. Change-Id: Iec85f299cd99879475ab094998433d935e980394 --- M src/libvlr/vlr.c M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_auth_fsm.h 3 files changed, 15 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/13/38413/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 65cbad6..50b60c5 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1545,7 +1545,7 @@ osmo_tdefs_reset(msc_tdefs_vlr); /* osmo_auth_fsm.c */ - OSMO_ASSERT(osmo_fsm_register(&vlr_auth_fsm) == 0); + vlr_auth_fsm_init(); /* osmo_lu_fsm.c */ vlr_lu_fsm_init(); /* vlr_access_request_fsm.c */ @@ -1693,7 +1693,7 @@ switch (logc) { case OSMO_VLR_LOGC_VLR: - vlr_auth_fsm.log_subsys = logc_num; + vlr_auth_fsm_set_loglevel(logc_num); vlr_lu_fsm_set_loglevel(logc_num); break; case OSMO_VLR_LOGC_SGS: diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index 07e6e9e..2a806e0 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -603,7 +603,7 @@ }, }; -struct osmo_fsm vlr_auth_fsm = { +static struct osmo_fsm vlr_auth_fsm = { .name = "VLR_Authenticate", .states = auth_fsm_states, .num_states = ARRAY_SIZE(auth_fsm_states), @@ -614,6 +614,16 @@ .cleanup = auth_fsm_cleanup, }; +void vlr_auth_fsm_init(void) +{ + OSMO_ASSERT(osmo_fsm_register(&vlr_auth_fsm) == 0); +} + +void vlr_auth_fsm_set_loglevel(int log_level) +{ + vlr_auth_fsm.log_subsys = log_level; +} + /*********************************************************************** * User API (for SGSN/MSC code) ***********************************************************************/ diff --git a/src/libvlr/vlr_auth_fsm.h b/src/libvlr/vlr_auth_fsm.h index 441a8ca..bb4e192 100644 --- a/src/libvlr/vlr_auth_fsm.h +++ b/src/libvlr/vlr_auth_fsm.h @@ -29,8 +29,6 @@ VLR_AUTH_E_MS_ID_IMSI, }; -extern struct osmo_fsm vlr_auth_fsm; - struct osmo_fsm_inst *auth_fsm_start(struct vlr_subscr *vsub, struct osmo_fsm_inst *parent, uint32_t parent_event_success, @@ -39,4 +37,6 @@ bool is_r99, bool is_utran); +void vlr_auth_fsm_init(void); +void vlr_auth_fsm_set_loglevel(int log_level); bool auth_try_reuse_tuple(struct vlr_subscr *vsub, uint8_t key_seq); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iec85f299cd99879475ab094998433d935e980394 Gerrit-Change-Number: 38413 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: vlr: add the location update type to the callbacks tx_lu_acc/tx_lu_rej
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38407?usp=email ) Change subject: vlr: add the location update type to the callbacks tx_lu_acc/tx_lu_rej ...................................................................... vlr: add the location update type to the callbacks tx_lu_acc/tx_lu_rej The location update type (IMSI attach, periodic, location area change) is required when the SGSN is using the vlr code to send back the correct PDU to the MS. The MSC always sends Location Update Accept/Reject, but the SGSN has to transmit either Routing Area Accept/Reject or Attach Accept/Reject. Change-Id: I980a637333e92b15f2d516683feeaded910105b6 --- M include/osmocom/vlr/vlr.h M src/libmsc/gsm_04_08.c M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_tests.c 4 files changed, 21 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/07/38407/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index 2df8246..6d5c71c 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -242,8 +242,8 @@ /* encode + transmit an IDENTITY REQUEST towards the MS */ int (*tx_id_req)(void *msc_conn_ref, uint8_t mi_type); - int (*tx_lu_acc)(void *msc_conn_ref, uint32_t send_tmsi); - int (*tx_lu_rej)(void *msc_conn_ref, enum gsm48_reject_value cause); + int (*tx_lu_acc)(void *msc_conn_ref, uint32_t send_tmsi, enum vlr_lu_type lu_type); + int (*tx_lu_rej)(void *msc_conn_ref, enum gsm48_reject_value cause, enum vlr_lu_type lu_type); int (*tx_cm_serv_acc)(void *msc_conn_ref, enum osmo_cm_service_type cm_service_type); int (*tx_cm_serv_rej)(void *msc_conn_ref, enum osmo_cm_service_type cm_service_type, enum gsm48_reject_value cause); @@ -301,7 +301,7 @@ uint32_t parent_event_failure, void *parent_event_data, struct vlr_instance *vlr, void *msc_conn_ref, - enum vlr_lu_type type, uint32_t tmsi, const char *imsi, + enum vlr_lu_type lu_type, uint32_t tmsi, const char *imsi, const struct osmo_location_area_id *old_lai, const struct osmo_location_area_id *new_lai, bool authentication_required, diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 34f7b76..cf3df48 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -1474,14 +1474,14 @@ } /* VLR asks us to transmit a Location Update Accept */ -static int msc_vlr_tx_lu_acc(void *msc_conn_ref, uint32_t send_tmsi) +static int msc_vlr_tx_lu_acc(void *msc_conn_ref, uint32_t send_tmsi, enum vlr_lu_type lu_type) { struct msc_a *msc_a = msc_conn_ref; return gsm0408_loc_upd_acc(msc_a, send_tmsi); } /* VLR asks us to transmit a Location Update Reject */ -static int msc_vlr_tx_lu_rej(void *msc_conn_ref, enum gsm48_reject_value cause) +static int msc_vlr_tx_lu_rej(void *msc_conn_ref, enum gsm48_reject_value cause, enum vlr_lu_type lu_type) { struct msc_a *msc_a = msc_conn_ref; return gsm0408_loc_upd_rej(msc_a, cause); diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index d622baa..b26eed7 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -339,6 +339,7 @@ enum vlr_fsm_result result; uint8_t cause; bool assign_tmsi; + enum vlr_lu_type lu_type; }; static inline struct lu_compl_vlr_priv *lu_compl_vlr_fi_priv(struct osmo_fsm_inst *fi); @@ -434,7 +435,7 @@ osmo_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_WAIT_TMSI_CNF, vlr_timer(vlr, 3250), 3250); - vlr->ops.tx_lu_acc(lcvp->msc_conn_ref, vsub->tmsi_new); + vlr->ops.tx_lu_acc(lcvp->msc_conn_ref, vsub->tmsi_new, lcvp->lu_type); } /* After completion of Subscriber_Present_VLR */ @@ -473,7 +474,7 @@ vsub->tmsi = GSM_RESERVED_TMSI; /* Location Updating Accept */ - vlr->ops.tx_lu_acc(lcvp->msc_conn_ref, GSM_RESERVED_TMSI); + vlr->ops.tx_lu_acc(lcvp->msc_conn_ref, GSM_RESERVED_TMSI, lcvp->lu_type); vlr_lu_compl_fsm_success(fi); } @@ -520,7 +521,7 @@ vsub->tmsi = GSM_RESERVED_TMSI; /* No TMSI needed, accept now. */ - vlr->ops.tx_lu_acc(lcvp->msc_conn_ref, GSM_RESERVED_TMSI); + vlr->ops.tx_lu_acc(lcvp->msc_conn_ref, GSM_RESERVED_TMSI, lcvp->lu_type); vlr_lu_compl_fsm_success(fi); } @@ -616,7 +617,8 @@ void *msc_conn_ref, uint32_t parent_event_success, uint32_t parent_event_failure, - bool assign_tmsi) + bool assign_tmsi, + enum vlr_lu_type lu_type) { struct osmo_fsm_inst *fi; struct lu_compl_vlr_priv *lcvp; @@ -632,6 +634,7 @@ lcvp->parent_event_success = parent_event_success; lcvp->parent_event_failure = parent_event_failure; lcvp->assign_tmsi = assign_tmsi; + lcvp->lu_type = lu_type; fi->priv = lcvp; return fi; @@ -675,7 +678,7 @@ enum vlr_fsm_result result; uint8_t rej_cause; - enum vlr_lu_type type; + enum vlr_lu_type lu_type; bool lu_by_tmsi; char imsi[16]; uint32_t tmsi; @@ -762,7 +765,7 @@ static void lu_fsm_failure(struct osmo_fsm_inst *fi, enum gsm48_reject_value rej_cause) { struct lu_fsm_priv *lfp = lu_fsm_fi_priv(fi); - lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, rej_cause ? : GSM48_REJECT_NETWORK_FAILURE); + lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, rej_cause ? : GSM48_REJECT_NETWORK_FAILURE, lfp->lu_type); _lu_fsm_done(fi, VLR_FSM_RESULT_FAILURE); } @@ -773,7 +776,8 @@ lu_compl_vlr_proc_alloc(fi, lfp->vsub, lfp->msc_conn_ref, VLR_ULA_E_LU_COMPL_SUCCESS, VLR_ULA_E_LU_COMPL_FAILURE, - lfp->assign_tmsi); + lfp->assign_tmsi, + lfp->lu_type); osmo_fsm_inst_dispatch(lfp->lu_compl_vlr_fsm, LU_COMPL_VLR_E_START, NULL); } @@ -1106,7 +1110,7 @@ /* See 3GPP TS 23.012, procedure Retrieve_IMEISV_If_Required */ if ((!vlr->cfg.retrieve_imeisv_early) - || (lfp->type == VLR_LU_TYPE_PERIODIC && lfp->vsub->imeisv[0])) { + || (lfp->lu_type == VLR_LU_TYPE_PERIODIC && lfp->vsub->imeisv[0])) { /* R_IMEISV_IR1 passed */ _start_lu_main(fi); } else { @@ -1307,7 +1311,7 @@ /* TODO: Notify_gsmSCF 23.078 */ /* TODO: Authenticated Radio Contact Established -> ARC */ - if (lfp->type == VLR_LU_TYPE_IMSI_ATTACH) + if (lfp->lu_type == VLR_LU_TYPE_IMSI_ATTACH) lfp->vlr->ops.tx_mm_info(lfp->msc_conn_ref); lu_fsm_success(fi); @@ -1529,7 +1533,7 @@ lfp->vlr = vlr; lfp->msc_conn_ref = msc_conn_ref; lfp->tmsi = tmsi; - lfp->type = type; + lfp->lu_type = type; lfp->old_lai = *old_lai; lfp->new_lai = *new_lai; lfp->lu_by_tmsi = true; diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index 062d8a3..7bf975c 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -934,7 +934,7 @@ osmo_fsm_inst_dispatch(cl->fi, CALL_LEG_EV_RTP_STREAM_ADDR_AVAILABLE, cl->rtp[dir]); } -static int fake_vlr_tx_lu_acc(void *msc_conn_ref, uint32_t send_tmsi) +static int fake_vlr_tx_lu_acc(void *msc_conn_ref, uint32_t send_tmsi, enum vlr_lu_type lu_type) { struct msc_a *msc_a = msc_conn_ref; if (send_tmsi == GSM_RESERVED_TMSI) @@ -946,7 +946,7 @@ return 0; } -static int fake_vlr_tx_lu_rej(void *msc_conn_ref, enum gsm48_reject_value cause) +static int fake_vlr_tx_lu_rej(void *msc_conn_ref, enum gsm48_reject_value cause, enum vlr_lu_type lu_type) { struct msc_a *msc_a = msc_conn_ref; btw("sending LU Reject for %s, cause %u", msc_a->c.fi->id, cause); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I980a637333e92b15f2d516683feeaded910105b6 Gerrit-Change-Number: 38407 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: libvlr: set the correct CN domain
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email ) Change subject: libvlr: set the correct CN domain ...................................................................... libvlr: set the correct CN domain In preparation of splitting up the libvlr code, set the CN domain on all required GSUP messages which allow the CN domain to be present. The test cases expect the exact GSUP message. The additional TLV is 280102 (IE: CN domain, length 1, CS (2)). Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1 --- M src/libvlr/vlr.c M tests/msc_vlr/msc_vlr_test_gsm_authen.c M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_test_umts_authen.err 5 files changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/38406/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 866a63d..81429bb 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -429,6 +429,8 @@ gsup_msg.hlr_enc_len = vsub->hlr.len; gsup_msg.hlr_enc = vsub->hlr.buf; + gsup_msg.cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; + return vlr_subscr_tx_gsup_message(vsub, &gsup_msg); } @@ -886,7 +888,7 @@ vlr_rate_ctr_inc(vsub->vlr, VLR_CTR_GSUP_TX_UL_REQ); gsup_msg.message_type = OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST; - gsup_msg.cn_domain = vsub->vlr->cfg.is_ps ? OSMO_GSUP_CN_DOMAIN_PS : OSMO_GSUP_CN_DOMAIN_CS; + gsup_msg.cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; rc = vlr_subscr_tx_gsup_message(vsub, &gsup_msg); return rc; @@ -903,7 +905,7 @@ gsup_msg.message_type = OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST; gsup_msg.auts = auts; gsup_msg.rand = auts_rand; - gsup_msg.cn_domain = OSMO_GSUP_CN_DOMAIN_CS; + gsup_msg.cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; return vlr_subscr_tx_gsup_message(vsub, &gsup_msg); } @@ -940,6 +942,7 @@ struct osmo_gsup_message gsup_msg = { .message_class = OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT, .message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT, + .cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS, }; vlr_rate_ctr_inc(vsub->vlr, VLR_CTR_GSUP_TX_AUTH_FAIL_REP); @@ -1284,6 +1287,7 @@ "update procedure" : "subscription withdraw"); gsup_reply.message_type = OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT; + gsup_reply.cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; rc = vlr_subscr_tx_gsup_message(vsub, &gsup_reply); vlr_subscr_cancel_attach_fsm(vsub, fsm_cause, vlr_gmm_cause_to_reject_cause_domain(gsup_msg->cause, true)); diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.c b/tests/msc_vlr/msc_vlr_test_gsm_authen.c index 6d7e88a..3be928c 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_authen.c +++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.c @@ -1170,7 +1170,7 @@ VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); btw("MS sends Authen Response with too short SRES data, auth is thwarted."); - gsup_expect_tx("0b010809710000004026f0" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ + gsup_expect_tx("0b010809710000004026f0280102" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ expect_bssap_clear(); ms_sends_msg("05542d8b2c"); VERBOSE_ASSERT(lu_result_sent, == RES_REJECT, "%d"); diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.err b/tests/msc_vlr/msc_vlr_test_gsm_authen.err index 94c1694..44c0a53 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_authen.err +++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.err @@ -3273,7 +3273,7 @@ DVLR SUBSCR(IMSI-901700000004620) AUTH SRES/RES missing DVLR VLR_Authenticate(IMSI-901700000004620:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: Authentication terminating with result FAILURE, cause ILLEGAL_MS DVLR VLR_Authenticate(IMSI-901700000004620:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: state_chg to VLR_SUB_AS_AUTH_FAILED -GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000004026f00a0101 +GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000004026f02801020a0101 DVLR VLR_Authenticate(IMSI-901700000004620:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DVLR VLR_Authenticate(IMSI-901700000004620:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Removing from parent vlr_lu_fsm(IMSI-901700000004620:GERAN-A:LU) DVLR vlr_lu_fsm(IMSI-901700000004620:GERAN-A:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_FAILURE diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.c b/tests/msc_vlr/msc_vlr_test_umts_authen.c index 0a2a446..0f09491 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.c +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.c @@ -704,7 +704,7 @@ VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); btw("MS sends Authen Response of wrong RES size, VLR thwarts"); - gsup_expect_tx("0b010809710000000156f0" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ + gsup_expect_tx("0b010809710000000156f0280102" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ expect_release_clear(via_ran); ms_sends_msg("0554" "e229c19e" "2103" "791f2e" /* nipped one byte */); VERBOSE_ASSERT(lu_result_sent, == RES_REJECT, "%d"); @@ -804,7 +804,7 @@ VERBOSE_ASSERT(lu_result_sent, == RES_NONE, "%d"); btw("MS sends Authen Response of wrong RES size, VLR thwarts"); - gsup_expect_tx("0b010809710000000156f0" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ + gsup_expect_tx("0b010809710000000156f0280102" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ expect_release_clear(via_ran); ms_sends_msg("0554" "e229c19e" "2105" "791f2e4123" /* added one byte */); VERBOSE_ASSERT(lu_result_sent, == RES_REJECT, "%d"); @@ -909,7 +909,7 @@ else btw("MS sends Authen Response of wrong RES size, VLR thwarts:" " UTRAN disallows GSM AKA altogether"); - gsup_expect_tx("0b010809710000000156f0" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ + gsup_expect_tx("0b010809710000000156f0280102" VLR_TO_HLR); /* OSMO_GSUP_MSGT_AUTH_FAIL_REPORT */ expect_release_clear(via_ran); ms_sends_msg("0554" "e229c19e" /* Only the SRES half of the RES */); VERBOSE_ASSERT(lu_result_sent, == RES_REJECT, "%d"); diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.err b/tests/msc_vlr/msc_vlr_test_umts_authen.err index aacff39..cf402cc 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.err +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.err @@ -2649,7 +2649,7 @@ DVLR SUBSCR(IMSI-901700000010650) AUTH SRES/RES has invalid length: 7. Expected either 4 (GSM AKA) or 8 (UMTS AKA) DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: Authentication terminating with result FAILURE, cause ILLEGAL_MS DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: state_chg to VLR_SUB_AS_AUTH_FAILED -GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f00a0101 +GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f02801020a0101 DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:GERAN-A:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:GERAN-A:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_FAILURE @@ -2765,7 +2765,7 @@ DVLR SUBSCR(IMSI-901700000010650) AUTH RES has invalid length: 7. Expected 8 (UMTS AKA) DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_WAIT_RESP}: Authentication terminating with result FAILURE, cause ILLEGAL_MS DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_WAIT_RESP}: state_chg to VLR_SUB_AS_AUTH_FAILED -GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f00a0101 +GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f02801020a0101 DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTH_FAILED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTH_FAILED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_FAILURE @@ -2881,7 +2881,7 @@ DVLR SUBSCR(IMSI-901700000010650) AUTH SRES/RES has invalid length: 9. Expected either 4 (GSM AKA) or 8 (UMTS AKA) DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: Authentication terminating with result FAILURE, cause ILLEGAL_MS DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: state_chg to VLR_SUB_AS_AUTH_FAILED -GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f00a0101 +GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f02801020a0101 DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:GERAN-A:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:GERAN-A:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_FAILURE @@ -2997,7 +2997,7 @@ DVLR SUBSCR(IMSI-901700000010650) AUTH RES has invalid length: 9. Expected 8 (UMTS AKA) DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_WAIT_RESP}: Authentication terminating with result FAILURE, cause ILLEGAL_MS DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_WAIT_RESP}: state_chg to VLR_SUB_AS_AUTH_FAILED -GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f00a0101 +GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f02801020a0101 DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTH_FAILED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTH_FAILED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_FAILURE @@ -3113,7 +3113,7 @@ DVLR SUBSCR(IMSI-901700000010650) GSM AUTH failure: mismatching sres (expected sres=9b 36 ef df ) DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: Authentication terminating with result FAILURE, cause ILLEGAL_MS DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_WAIT_RESP}: state_chg to VLR_SUB_AS_AUTH_FAILED -GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f00a0101 +GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f02801020a0101 DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DVLR VLR_Authenticate(IMSI-901700000010650:GERAN-A:LU){VLR_SUB_AS_AUTH_FAILED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:GERAN-A:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:GERAN-A:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_FAILURE @@ -3229,7 +3229,7 @@ DVLR SUBSCR(IMSI-901700000010650) AUTH via UTRAN, cannot allow GSM AKA (MS is R99 capable, vec has UMTS AKA tokens, res_len=4 is INVALID on UTRAN) DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_WAIT_RESP}: Authentication terminating with result FAILURE, cause ILLEGAL_MS DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_WAIT_RESP}: state_chg to VLR_SUB_AS_AUTH_FAILED -GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f00a0101 +GSUP --> HLR: OSMO_GSUP_MSGT_AUTH_FAIL_REPORT: 0b010809710000000156f02801020a0101 DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTH_FAILED}: Terminating (cause = OSMO_FSM_TERM_REGULAR) DVLR VLR_Authenticate(IMSI-901700000010650:UTRAN-Iu:LU){VLR_SUB_AS_AUTH_FAILED}: Removing from parent vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU) DVLR vlr_lu_fsm(IMSI-901700000010650:UTRAN-Iu:LU){VLR_ULA_S_WAIT_AUTH}: Received Event VLR_ULA_E_AUTH_FAILURE -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1 Gerrit-Change-Number: 38406 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: libvlr: add defines for vlr_is_cs() vlr_is_ps()
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email ) Change subject: libvlr: add defines for vlr_is_cs() vlr_is_ps() ...................................................................... libvlr: add defines for vlr_is_cs() vlr_is_ps() Make the code more readable when checking for cs or ps. Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d --- M include/osmocom/vlr/vlr.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/05/38405/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index 90147ba..2df8246 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -118,6 +118,9 @@ #define VLR_NAME_LENGTH 160 +#define vlr_is_cs(vlr) (!vlr->cfg.is_ps) +#define vlr_is_ps(vlr) (vlr->cfg.is_ps) + /* The VLR subscriber is the part of the GSM subscriber state in VLR (CS) or * SGSN (PS), particularly while interacting with the HLR via GSUP */ struct vlr_subscr { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d Gerrit-Change-Number: 38405 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-sgsn[master]: move gsm48_gmm_att_tlvdef into gprs_gmm_util
by lynxis lazus 11 Oct '24

11 Oct '24

Attention is currently required from: daniel, fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email ) Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ...................................................................... Patch Set 18: (6 comments) File include/osmocom/sgsn/gprs_gmm_util.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/a1839f7a_bcc5ee8a?us… : PS15, Line 1: #ifndef _GPRS_GMM_UTIL_H > `#pragma once` If this is a rule, we should add this to the checkpatch. I'm changing it to #pragma. https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/34c42696_cfc012e0?us… : PS15, Line 6: struct msgb; > Why adding it here? it is a refactoring left over. the next commit is requiring it. I'll move this into the next commit. https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/62a7eda5_b6a2c099?us… : PS15, Line 6: struct msgb; > Why adding it here? most likely because a commit later in this chain will File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/ffee5ea3_4f2869b7?us… : PS15, Line 9: Author: Alexander Couzens <lynxis(a)fe80.eu> > `git-blame` tells me that Harald and Pau are the authors of code you're moving here. Not sure if this is even be good enough for any copyright until I add more code to it. This is only simple tlv. @laforge@gnumonks.org what is the right solution here? What should I add here? How should the copyright look like? https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/2d0004ec_a740b6ec?us… : PS15, Line 9: Author: Alexander Couzens <lynxis(a)fe80.eu> > `git-blame` tells me that Harald and Pau are the authors of code you're moving here. Yes you're right, but on the other side, I don't care. I would argue here, this code isn't high enough to cover any copyright until I add more code in here from another commit. https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/e64c3ce7_14b0b4fd?us… : PS15, Line 25: #include <osmocom/gsm/gsm48.h> > Unneeded import? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d Gerrit-Change-Number: 37868 Gerrit-PatchSet: 18 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 20:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: GMM: split parsing of a RA Update Request in a separate file
by lynxis lazus 11 Oct '24

11 Oct '24

Attention is currently required from: daniel, lynxis lazus. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email to look at the new patch set (#21). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... GMM: split parsing of a RA Update Request in a separate file gprs_gmm.c is huge. Further split the general validation and parsing of the message into an own function. Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d --- M include/osmocom/sgsn/gprs_gmm_util.h M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_util.c 3 files changed, 104 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/69/37869/21 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 21 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: Use %d instead of %i
by lynxis lazus 11 Oct '24

11 Oct '24

Attention is currently required from: dexter, lynxis lazus. Hello Jenkins Builder, dexter, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Use %d instead of %i ...................................................................... Use %d instead of %i %d and %i has the same meaning when used in format string for printf. The linter will warn when using %i. %i was only added to provide symmetry between scanf() and printf(). Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf --- M src/sgsn/gprs_ranap.c M src/sgsn/slhc.c M tests/slhc/slhc_test.c M tests/sndcp_xid/sndcp_xid_test.c M tests/v42bis/v42bis_test.c M tests/xid/xid_test.c 6 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/38281/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf Gerrit-Change-Number: 38281 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Refactor diffing same GMM messages
by lynxis lazus 11 Oct '24

11 Oct '24

Attention is currently required from: daniel, fixeria, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email to look at the new patch set (#19). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Refactor diffing same GMM messages ...................................................................... Refactor diffing same GMM messages gprs_gmm_attach_req_ies() isn't specific for the attach request. It also did not cover the full message because of a fixed message length when comparing both messages. A diff of the old and new GMM message is required to figure out if the MS/UE is retransmitting an old message or starting a new procedure. Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 --- M include/osmocom/sgsn/gprs_gmm.h M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_attach.c 3 files changed, 7 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/67/37867/19 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 Gerrit-Change-Number: 37867 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0