Attention is currently required from: daniel, lynxis lazus.
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email
to look at the new patch set (#20).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: GMM: split parsing of a RA Update Request in a separate file
......................................................................
GMM: split parsing of a RA Update Request in a separate file
gprs_gmm.c is huge. Further split the general validation
and parsing of the message into an own function.
Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d
---
M include/osmocom/sgsn/gprs_gmm_util.h
M src/sgsn/gprs_gmm.c
M src/sgsn/gprs_gmm_util.c
3 files changed, 102 insertions(+), 44 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/69/37869/20
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d
Gerrit-Change-Number: 37869
Gerrit-PatchSet: 20
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, lynxis lazus, pespin.
Hello Jenkins Builder, daniel, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email
to look at the new patch set (#19).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util
......................................................................
move gsm48_gmm_att_tlvdef into gprs_gmm_util
The gprs_gmm.c is huge. Move message parsing into gprs_gmm_util.c.
Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d
---
M include/osmocom/sgsn/Makefile.am
A include/osmocom/sgsn/gprs_gmm_util.h
M src/sgsn/Makefile.am
M src/sgsn/gprs_gmm.c
A src/sgsn/gprs_gmm_util.c
M tests/gprs_routing_area/Makefile.am
M tests/sgsn/Makefile.am
7 files changed, 62 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/68/37868/19
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d
Gerrit-Change-Number: 37868
Gerrit-PatchSet: 19
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: dexter, lynxis lazus.
Hello Jenkins Builder, dexter, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Use %d instead of %i
......................................................................
Use %d instead of %i
%d and %i has the same meaning when used in format string for printf.
The linter will warn when using %i. %i was only added to provide
symmetry between scanf() and printf().
Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf
---
M src/sgsn/gprs_ranap.c
M src/sgsn/slhc.c
M tests/slhc/slhc_test.c
M tests/sndcp_xid/sndcp_xid_test.c
M tests/v42bis/v42bis_test.c
M tests/xid/xid_test.c
6 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/38281/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38281?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf
Gerrit-Change-Number: 38281
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: daniel, fixeria.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email )
Change subject: Refactor diffing same GMM messages
......................................................................
Patch Set 18:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/5a7c087b_5eb62126?us… :
PS15, Line 9: isn'nt
> typo: isn't
Done
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/7f61dc5f_33830793?us… :
PS15, Line 1435: return 1/-1 following memcmp()
> This is not true. From `man memcmp`: […]
I'll remove this comment. Doesn't seems to be such useful.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6
Gerrit-Change-Number: 37867
Gerrit-PatchSet: 18
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Oct 2024 19:09:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email )
Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI
......................................................................
SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI
The IMEI might be requested when the GMM Attach happen.
Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6
---
M sgsn/BSSGP_ConnHdlr.ttcn
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/38398/1
diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn
index 4bd16bb..6cfc17e 100644
--- a/sgsn/BSSGP_ConnHdlr.ttcn
+++ b/sgsn/BSSGP_ConnHdlr.ttcn
@@ -533,6 +533,7 @@
var RoutingAreaIdentificationV old_ra_val;
var template (value) PDU_L3_MS_SGSN attach_req;
var PDU_L3_SGSN_MS l3_mt;
+ var default di;
if (istemplatekind(old_ra, "omit")) {
old_ra_val := f_random_RAI();
@@ -553,6 +554,9 @@
/* Expect SGSN to perform LU with HLR */
as_gmm_gsup_lu_isd();
+ /* In case IMEI get requested */
+ di := activate(as_mm_identity(ran_index));
+
l3_mt := f_receive_l3(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?), ran_index);
f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept, ran_index);
@@ -570,6 +574,7 @@
* arrived before it. This results in a test case failure.
* Delay execution by 50 ms
*/
+ deactivate(di);
f_sleep(0.05);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6
Gerrit-Change-Number: 38398
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38400?usp=email )
Change subject: SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change
......................................................................
SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change
After an attach, the periodic RA would be the correct.
Change-Id: Ic33687c55915d883b6d9a9a0d640a11588e1d1a0
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/38400/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 1572db0..5b4882f 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -893,9 +893,9 @@
/* first perform regular attach */
f_TC_attach(id);
- f_routing_area_update(g_pars.ra);
-
+ f_routing_area_update(g_pars.ra, GPRS_UPD_T_PERIODIC, Tval := 10.0);
}
+
testcase TC_attach_rau() runs on test_CT {
var BSSGP_ConnHdlr vc_conn;
f_init();
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38400?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic33687c55915d883b6d9a9a0d640a11588e1d1a0
Gerrit-Change-Number: 38400
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email )
Change subject: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request
......................................................................
SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request
This test case simulates a MS which ignores Identity Requests. To ensure
the SGSN will ask for the IMSI, do an Attach Request with id TMSI.
Later this ID Request (type IMSI) will be ignored and the test case
expect a Attach Reject.
Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/38401/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 5b4882f..9613ae8 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -650,6 +650,8 @@
private function f_TC_attach_auth_id_timeout(charstring id) runs on BSSGP_ConnHdlr {
var RoutingAreaIdentificationV old_ra := f_random_RAI();
+ g_pars.p_tmsi := 'c000004a'O;
+
f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit));
alt {
[] BSSGP[0].receive(tr_GMM_ID_REQ(?)) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef
Gerrit-Change-Number: 38401
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>