October 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: GMM: fix off-by-one error in ServiceType IE
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38392?usp=email ) Change subject: L3_Templates: GMM: fix off-by-one error in ServiceType IE ...................................................................... L3_Templates: GMM: fix off-by-one error in ServiceType IE The ServiceType IE is used in the GMM Service Request. Change-Id: I79337fa31ffa82f766c6a1f238739c5e10773823 --- M library/L3_Templates.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 4c9a2f6..f4de9a3 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -46,11 +46,11 @@ /* TS 24.008 10.5.5.20 Service type */ type enumerated ServiceType { - SERVICE_TYPE_Signalling ('001'B), - SERVICE_TYPE_Data ('010'B), - SERVICE_TYPE_Paging_Response ('011'B), - SERVICE_TYPE_MBMS_Multicast_Service_Reception ('100'B), - SERVICE_TYPE_MBMS_Broadcast_Service_Reception ('101'B) + SERVICE_TYPE_Signalling ('000'B), + SERVICE_TYPE_Data ('001'B), + SERVICE_TYPE_Paging_Response ('010'B), + SERVICE_TYPE_MBMS_Multicast_Service_Reception ('011'B), + SERVICE_TYPE_MBMS_Broadcast_Service_Reception ('100'B) } template ML3_Cause_TLV ts_ML3_Cause(BIT7 cause, BIT4 loc := '0001'B, BIT2 std := '11'B) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79337fa31ffa82f766c6a1f238739c5e10773823 Gerrit-Change-Number: 38392 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Replace libosmo-sccp references with libosmo-sigtran
by fixeria 11 Oct '24

11 Oct '24

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38391?usp=email ) Change subject: Replace libosmo-sccp references with libosmo-sigtran ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8556a9eb4e111340e2415c5adf0ad91927ce53ec Gerrit-Change-Number: 38391 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 16:25:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: _testenv: Avoid running make check when building IUT
by pespin 11 Oct '24

11 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email ) Change subject: _testenv: Avoid running make check when building IUT ...................................................................... _testenv: Avoid running make check when building IUT In here we want to build stuff to run ttcn3 tests, not unit tests. Change-Id: I1b5dd0947a1bd937775a74bceb88dcf3bbcf914b --- M _testenv/testenv/osmo_dev.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/38393/1 diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index d3f7a1c..4dd581a 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -75,6 +75,7 @@ cmd = [ "./gen_makefile.py", "--build-debug", + "--no-make-check", "--make-dir", make_dir, "--no-ldconfig", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b5dd0947a1bd937775a74bceb88dcf3bbcf914b Gerrit-Change-Number: 38393 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Replace libosmo-sccp references with libosmo-sigtran
by pespin 11 Oct '24

11 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38391?usp=email ) Change subject: Replace libosmo-sccp references with libosmo-sigtran ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @osmith@sysmocom.de please review this is fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8556a9eb4e111340e2415c5adf0ad91927ce53ec Gerrit-Change-Number: 38391 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 16:05:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: GMM: fix off-by-one error in ServiceType IE
by pespin 11 Oct '24

11 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38392?usp=email ) Change subject: L3_Templates: GMM: fix off-by-one error in ServiceType IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79337fa31ffa82f766c6a1f238739c5e10773823 Gerrit-Change-Number: 38392 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 16:02:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: GMM: fix off-by-one error in ServiceType IE
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38392?usp=email ) Change subject: L3_Templates: GMM: fix off-by-one error in ServiceType IE ...................................................................... L3_Templates: GMM: fix off-by-one error in ServiceType IE The ServiceType IE is used in the GMM Service Request. Change-Id: I79337fa31ffa82f766c6a1f238739c5e10773823 --- M library/L3_Templates.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/38392/1 diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 4c9a2f6..f4de9a3 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -46,11 +46,11 @@ /* TS 24.008 10.5.5.20 Service type */ type enumerated ServiceType { - SERVICE_TYPE_Signalling ('001'B), - SERVICE_TYPE_Data ('010'B), - SERVICE_TYPE_Paging_Response ('011'B), - SERVICE_TYPE_MBMS_Multicast_Service_Reception ('100'B), - SERVICE_TYPE_MBMS_Broadcast_Service_Reception ('101'B) + SERVICE_TYPE_Signalling ('000'B), + SERVICE_TYPE_Data ('001'B), + SERVICE_TYPE_Paging_Response ('010'B), + SERVICE_TYPE_MBMS_Multicast_Service_Reception ('011'B), + SERVICE_TYPE_MBMS_Broadcast_Service_Reception ('100'B) } template ML3_Cause_TLV ts_ML3_Cause(BIT7 cause, BIT4 loc := '0001'B, BIT2 std := '11'B) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79337fa31ffa82f766c6a1f238739c5e10773823 Gerrit-Change-Number: 38392 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: vlr: use correct types for vlr_timer
by pespin 11 Oct '24

11 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email ) Change subject: vlr: use correct types for vlr_timer ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38356/comment/fd98a2a0_cf02fad1?usp… : PS1, Line 427: unsigned long vlr_timer(struct vlr_instance *vlr, int timer); so the point here is that this function actually returns the timer value right? Can we please rename it to "vlr_timer_val()", "vlr_timer_val_secs()" or alike? Otherwise it's difficult to understand what is it returning... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic46ddb578962619fc08bd63645c76852e676fcc9 Gerrit-Change-Number: 38356 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 15:50:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: vlr: fix typo in comment
by pespin 11 Oct '24

11 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38355?usp=email ) Change subject: vlr: fix typo in comment ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38355?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I06baf0494fde1d0c8eb6aaf72f5ce6e9134f3905 Gerrit-Change-Number: 38355 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 15:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: vlr: refactor the reject cause codes
by pespin 11 Oct '24

11 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38128?usp=email ) Change subject: vlr: refactor the reject cause codes ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib269e9f865cd23f9f2c0a1bac0e17c95974c1c9f Gerrit-Change-Number: 38128 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 15:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: Implement correct Routing Area based paging
by lynxis lazus 11 Oct '24

11 Oct '24

Attention is currently required from: daniel, fixeria. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email ) Change subject: Implement correct Routing Area based paging ...................................................................... Patch Set 15: (1 comment) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/5b00d79d_ef7006bf?us… : PS14, Line 869: rate_ctr_inc(rate_ctr_group_get_ctr(mm->ctrg, GMM_CTR_PAGING_PS)); : > Why not doing this inside of `sgsn_ra_geran_page_ra()`? […] In general yes. I think the reason here was not to modify so much. I'll move it into it. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f Gerrit-Change-Number: 37866 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Oct 2024 15:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0