October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication
by pespin 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email ) Change subject: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12 Gerrit-Change-Number: 38399 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 22:11:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI
by pespin 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI ...................................................................... Patch Set 1: (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/e71866a2_7b2c… : PS1, Line 577: deactivate(di); shouldn't this happen before receiving attach accept? meaning you can deactivate this after f_process_attach_accept() above. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id49c9e6ef7517a6a831315ac1f9915c50b88beb6 Gerrit-Change-Number: 38398 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 22:09:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct
by pespin 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/5a007fa3_d4cf… : PS1, Line 680: altstep as_service_request(boolean ue_in_pmm_idle := true, integer ran_index := 0) runs on BSSGP_ConnHdlr { I'd leave this as "boolean exp_service_acc". Leave the "state" information to the caller wishing to call this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29237997e414aea80f254247da54f909410a4b36 Gerrit-Change-Number: 38397 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 22:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: optional expect an authent...
by pespin 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: optional expect an authentication ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 11 Oct 2024 22:00:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: vlr: set the correct CN domain on GSUP messages
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email ) Change subject: vlr: set the correct CN domain on GSUP messages ...................................................................... vlr: set the correct CN domain on GSUP messages In preparation of splitting up the libvlr code, set the CN domain on all required GSUP messages which allow the CN domain to be present. The test cases expect the exact GSUP message. The additional TLV is 280102 (IE: CN domain, length 1, CS (2)). Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1 --- M src/libvlr/vlr.c M tests/msc_vlr/msc_vlr_test_gsm_authen.c M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_umts_authen.c M tests/msc_vlr/msc_vlr_test_umts_authen.err 5 files changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/38406/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1 Gerrit-Change-Number: 38406 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: vlr: drop msc/debug.h header
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/38411?usp=email ) Change subject: vlr: drop msc/debug.h header ...................................................................... vlr: drop msc/debug.h header Since logging is done different, remove the MSC specific header. Also drop some reference counting logging by a generic DEBUG handler. Change-Id: I8fa2f16c07ef54be3a125c19e0990a68c4d5d2cf --- M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_lu_fsm.c M src/libvlr/vlr_sgs.c M src/libvlr/vlr_sgs_fsm.c 6 files changed, 1 insertion(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/38411/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8fa2f16c07ef54be3a125c19e0990a68c4d5d2cf Gerrit-Change-Number: 38411 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: vlr: add defines for vlr_is_cs() vlr_is_ps()
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email ) Change subject: vlr: add defines for vlr_is_cs() vlr_is_ps() ...................................................................... vlr: add defines for vlr_is_cs() vlr_is_ps() Make the code more readable when checking for cs or ps. Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d --- M include/osmocom/vlr/vlr.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/05/38405/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d Gerrit-Change-Number: 38405 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: vlr_auth_fsm: fix missing space
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38408?usp=email ) Change subject: vlr_auth_fsm: fix missing space ...................................................................... vlr_auth_fsm: fix missing space Change-Id: I8976221ca7e314cc655f43c3ccffd9f15364cc0e --- M src/libvlr/vlr_auth_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/08/38408/1 diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index 5c16946..3a74ec1 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -473,7 +473,7 @@ case VLR_AUTH_E_HLR_SAI_NACK: auth_fsm_term(fi, AUTH_FSM_FAILURE, - gsup->cause == GMM_CAUSE_IMSI_UNKNOWN? + gsup->cause == GMM_CAUSE_IMSI_UNKNOWN ? GSM48_REJECT_IMSI_UNKNOWN_IN_HLR : GSM48_REJECT_NETWORK_FAILURE); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8976221ca7e314cc655f43c3ccffd9f15364cc0e Gerrit-Change-Number: 38408 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: msc_net_init: replace spaces with tabs as indention
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38409?usp=email ) Change subject: msc_net_init: replace spaces with tabs as indention ...................................................................... msc_net_init: replace spaces with tabs as indention Change-Id: I9290cc585601dbadda3a85eddd50ccd0354b0b0b --- M src/libmsc/msc_net_init.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/09/38409/1 diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index 9b8a8b3..ad0c19a 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -107,20 +107,20 @@ /* Allocate net->vlr so that the VTY may configure the VLR's data structures */ int msc_vlr_alloc(struct gsm_network *net) { - net->vlr = vlr_alloc(net, &msc_vlr_ops); - if (!net->vlr) - return -ENOMEM; - net->vlr->user_ctx = net; - return 0; + net->vlr = vlr_alloc(net, &msc_vlr_ops); + if (!net->vlr) + return -ENOMEM; + net->vlr->user_ctx = net; + return 0; } /* Launch the VLR, i.e. its GSUP connection */ int msc_vlr_start(struct gsm_network *net) { - OSMO_ASSERT(net->vlr); - OSMO_ASSERT(net->gcm); + OSMO_ASSERT(net->vlr); + OSMO_ASSERT(net->gcm); - return vlr_start(net->vlr, net->gcm); + return vlr_start(net->vlr, net->gcm); } int msc_gsup_client_start(struct gsm_network *net) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9290cc585601dbadda3a85eddd50ccd0354b0b0b Gerrit-Change-Number: 38409 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: libvlr: drop msc/debug.h header
by lynxis lazus 11 Oct '24

11 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38411?usp=email ) Change subject: libvlr: drop msc/debug.h header ...................................................................... libvlr: drop msc/debug.h header Since logging is done different, remove the MSC specific header. Also drop some reference counting logging by a generic DEBUG handler. Change-Id: I8fa2f16c07ef54be3a125c19e0990a68c4d5d2cf --- M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_lu_fsm.c M src/libvlr/vlr_sgs.c M src/libvlr/vlr_sgs_fsm.c 6 files changed, 1 insertion(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/38411/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 3aa5a5e..65cbad6 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -34,7 +34,6 @@ #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/vlr/vlr_sgs.h> #include <osmocom/vlr/vlr.h> -#include <osmocom/msc/debug.h> #include <osmocom/msc/gsup_client_mux.h> #include <osmocom/msc/paging.h> @@ -352,20 +351,13 @@ struct vlr_subscr *vsub = e->use_count->talloc_object; char buf[128]; int32_t total; - int level; if (!e->use) return -EINVAL; total = osmo_use_count_total(&vsub->use_count); - if (total == 0 - || (total == 1 && old_use_count == 0 && e->count == 1)) - level = LOGL_INFO; - else - level = LOGL_DEBUG; - - LOGPSRC(DREF, level, file, line, "VLR subscr %s %s %s: now used by %s\n", + LOGPSRC(g_vlr_log_cat[OSMO_VLR_LOGC_VLR], LOGL_DEBUG, file, line, "VLR subscr %s %s %s: now used by %s\n", vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, osmo_use_count_name_buf(buf, sizeof(buf), e->use_count)); diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index 3b46ddb..dd9a4e9 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -23,7 +23,6 @@ #include <osmocom/gsm/gsup.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/vlr/vlr.h> -#include <osmocom/msc/debug.h> #include "vlr_core.h" #include "vlr_auth_fsm.h" diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index 3b398dd..07e6e9e 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -24,7 +24,6 @@ #include <osmocom/core/utils.h> #include <osmocom/gsm/gsup.h> #include <osmocom/vlr/vlr.h> -#include <osmocom/msc/debug.h> #include "vlr_core.h" #include "vlr_auth_fsm.h" diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 1279801..24423fa 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -22,7 +22,6 @@ #include <osmocom/core/fsm.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/vlr/vlr.h> -#include <osmocom/msc/debug.h> #include "vlr_core.h" #include "vlr_auth_fsm.h" diff --git a/src/libvlr/vlr_sgs.c b/src/libvlr/vlr_sgs.c index ace2c5d..7333c04 100644 --- a/src/libvlr/vlr_sgs.c +++ b/src/libvlr/vlr_sgs.c @@ -22,7 +22,6 @@ #include <osmocom/core/utils.h> #include <osmocom/core/fsm.h> -#include <osmocom/msc/debug.h> #include <osmocom/vlr/vlr.h> #include <osmocom/vlr/vlr_sgs.h> #include "vlr_sgs_fsm.h" diff --git a/src/libvlr/vlr_sgs_fsm.c b/src/libvlr/vlr_sgs_fsm.c index 4cea056..4fa0483 100644 --- a/src/libvlr/vlr_sgs_fsm.c +++ b/src/libvlr/vlr_sgs_fsm.c @@ -21,7 +21,6 @@ #include <osmocom/core/utils.h> #include <osmocom/core/fsm.h> #include <osmocom/gsm/gsm48.h> -#include <osmocom/msc/debug.h> #include <osmocom/vlr/vlr.h> #include <osmocom/vlr/vlr_sgs.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8fa2f16c07ef54be3a125c19e0990a68c4d5d2cf Gerrit-Change-Number: 38411 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0