Attention is currently required from: daniel, fixeria, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email to look at the new patch set (#19). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Refactor diffing same GMM messages ...................................................................... Refactor diffing same GMM messages gprs_gmm_attach_req_ies() isn't specific for the attach request. It also did not cover the full message because of a fixed message length when comparing both messages. A diff of the old and new GMM message is required to figure out if the MS/UE is retransmitting an old message or starting a new procedure. Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 --- M include/osmocom/sgsn/gprs_gmm.h M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_attach.c 3 files changed, 7 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/67/37867/19 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 Gerrit-Change-Number: 37867 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de>