October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email ) Change subject: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef Gerrit-Change-Number: 38401 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:56:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38400?usp=email ) Change subject: SGSN: f_TC_attach_rau: do a periodic RA update instead of RA change ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic33687c55915d883b6d9a9a0d640a11588e1d1a0 Gerrit-Change-Number: 38400 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:56:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email ) Change subject: SGSN: f_TC_attach_timeout_after_pdp_act: allow authentication ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Like in the other patch, I'm not a fan of widening the expectations of our test cases. IMHO, if we know that the current VLR doesn't and the new one does, then we should introduce some kind of variable/module_parm and change that once we merge the VLR code to osmo-sgsn. A test should always be as narrow as possible. Otherwise we risk a future behavioural change of the implementation (potential regression) passing unnoticed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11c628ecebbe7c4c1b2c28e63133a33cfc171e12 Gerrit-Change-Number: 38399 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:55:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29237997e414aea80f254247da54f909410a4b36 Gerrit-Change-Number: 38397 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:53:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: optional expect an authent...
by laforge 12 Oct '24

12 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: optional expect an authentication ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Ideally we'd not widen the test expectations but execute two different tests by somehow triggering the two different situations. In each situation, we should then tightly expect only one of the two behaviours. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:53:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: upgrade gerrit to 3.9.5
by laforge 12 Oct '24

12 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/38419?usp=email ) Change subject: upgrade gerrit to 3.9.5 ...................................................................... upgrade gerrit to 3.9.5 Change-Id: I5d82853c8c533f055ff0590bfef343e601280520 --- M gerrit/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/gerrit/Dockerfile b/gerrit/Dockerfile index c1c3777..175a58b 100644 --- a/gerrit/Dockerfile +++ b/gerrit/Dockerfile @@ -1,4 +1,4 @@ -FROM gerritcodereview/gerrit:3.8.6 +FROM gerritcodereview/gerrit:3.9.5 USER root RUN yum -y install zip unzip patch -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5d82853c8c533f055ff0590bfef343e601280520 Gerrit-Change-Number: 38419 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in docker-playground[master]: redmine: upgrade our docker container to redmine 5.1.3
by laforge 12 Oct '24

12 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/38418?usp=email ) Change subject: redmine: upgrade our docker container to redmine 5.1.3 ...................................................................... redmine: upgrade our docker container to redmine 5.1.3 Change-Id: Ie65cfa0cfb4b1914966525be0d8db77dc98b7fa0 --- M redmine/Dockerfile R redmine/commitlog-references-oshash-5.1.3.diff D redmine/hmac.diff 3 files changed, 9 insertions(+), 31 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/redmine/Dockerfile b/redmine/Dockerfile index d6125cb..d48977f 100644 --- a/redmine/Dockerfile +++ b/redmine/Dockerfile @@ -1,4 +1,4 @@ -FROM redmine:4.2-passenger +FROM redmine:5.1.3 RUN apt-get update && \ apt-get -y upgrade && \ @@ -9,16 +9,15 @@ patch && \ apt-get clean -# no longer needed after ruby-openid-2.9.2 is used -#ADD hmac.diff /tmp/hmac.diff -#RUN cd / && patch -p0 < /tmp/hmac.diff +# needed after 5.0.0 removes openID [client] support +RUN gem install ruby-openid rack-openid ADD openid_server_length_empty.diff /tmp/openid_server_length_empty.diff RUN cd /usr/local/bundle/gems/ruby-openid-2.9.2 && patch -p1 < /tmp/openid_server_length_empty.diff -ADD commitlog-references-oshash.diff /tmp/commitlog-references-oshash.diff -RUN cd /usr/src/redmine && patch -p1 < /tmp/commitlog-references-oshash.diff +ADD commitlog-references-oshash-5.1.3.diff /tmp/commitlog-references-oshash-5.1.3.diff +RUN cd /usr/src/redmine && patch -p1 < /tmp/commitlog-references-oshash-5.1.3.diff ADD docker-entrypoint-osmo.sh / ENTRYPOINT ["/docker-entrypoint-osmo.sh"] -CMD ["passenger", "start"] +CMD ["rails", "server", "-b", "0.0.0.0"] diff --git a/redmine/commitlog-references-oshash.diff b/redmine/commitlog-references-oshash-5.1.3.diff similarity index 82% rename from redmine/commitlog-references-oshash.diff rename to redmine/commitlog-references-oshash-5.1.3.diff index e7b4cf8..11004c7 100644 --- a/redmine/commitlog-references-oshash.diff +++ b/redmine/commitlog-references-oshash-5.1.3.diff @@ -1,5 +1,5 @@ diff --git a/app/models/changeset.rb b/app/models/changeset.rb -index f1580ce33..748c66ddc 100644 +index 9ee758128..cc92217e5 100644 --- a/app/models/changeset.rb +++ b/app/models/changeset.rb @@ -136,7 +136,7 @@ class Changeset < ActiveRecord::Base @@ -15,8 +15,8 @@ refs = match[3] next unless action.present? || ref_keywords_any -- refs.scan(/#(\d+)(\s+(a)#{TIMELOG_RE})?/).each do |m| -+ refs.scan(/OS#(\d+)(\s+(a)#{TIMELOG_RE})?/).each do |m| +- refs.scan(/#(\d+)(\s+(a)#{TIMELOG_RE})?/o).each do |m| ++ refs.scan(/OS#(\d+)(\s+(a)#{TIMELOG_RE})?/o).each do |m| issue = find_referenced_issue_by_id(m[0].to_i) hours = m[2] if issue && !issue_linked_to_same_commit?(issue) diff --git a/redmine/hmac.diff b/redmine/hmac.diff deleted file mode 100644 index 197960b..0000000 --- a/redmine/hmac.diff +++ /dev/null @@ -1,21 +0,0 @@ ---- usr/local/bundle/gems/ruby-openid-2.3.0/lib/openid/cryptutil.rb.old 2018-10-07 08:53:33.612724431 +0000 -+++ usr/local/bundle/gems/ruby-openid-2.3.0/lib/openid/cryptutil.rb 2018-10-07 08:54:03.016525355 +0000 -@@ -39,6 +39,6 @@ - def CryptUtil.hmac_sha1(key, text) -- if Digest.const_defined? :HMAC -- Digest::HMAC.new(key,Digest::SHA1).update(text).digest -+ if defined? OpenSSL -+ OpenSSL::HMAC.digest(OpenSSL::Digest::SHA1.new, key, text) - else - return HMAC::SHA1.digest(key, text) - end -@@ -50,7 +50,7 @@ - - def CryptUtil.hmac_sha256(key, text) -- if Digest.const_defined? :HMAC -- Digest::HMAC.new(key,Digest::SHA256).update(text).digest -+ if defined? OpenSSL -+ OpenSSL::HMAC.digest(OpenSSL::Digest::SHA256.new, key, text) - else - return HMAC::SHA256.digest(key, text) - end -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie65cfa0cfb4b1914966525be0d8db77dc98b7fa0 Gerrit-Change-Number: 38418 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in docker-playground[master]: redmine: upgrade our docker container to redmine 5.1.3
by laforge 12 Oct '24

12 Oct '24

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/38418?usp=email ) Change subject: redmine: upgrade our docker container to redmine 5.1.3 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie65cfa0cfb4b1914966525be0d8db77dc98b7fa0 Gerrit-Change-Number: 38418 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:49:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: redmine: upgrade our docker container to redmine 5.1.3
by laforge 12 Oct '24

12 Oct '24

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/38418?usp=email ) Change subject: redmine: upgrade our docker container to redmine 5.1.3 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie65cfa0cfb4b1914966525be0d8db77dc98b7fa0 Gerrit-Change-Number: 38418 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:48:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: upgrade gerrit to 3.9.5
by laforge 12 Oct '24

12 Oct '24

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/38419?usp=email ) Change subject: upgrade gerrit to 3.9.5 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5d82853c8c533f055ff0590bfef343e601280520 Gerrit-Change-Number: 38419 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 12 Oct 2024 16:48:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0