Attention is currently required from: matanp.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/35745?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: ctrl: Add lchan node
......................................................................
ctrl: Add lchan node
Change-Id: Ibf2786f668ee7e4f5b6a9ef43f2141cd2d79b4e2
---
M include/osmocom/ctrl/control_cmd.h
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/35745/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35745?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf2786f668ee7e4f5b6a9ef43f2141cd2d79b4e2
Gerrit-Change-Number: 35745
Gerrit-PatchSet: 2
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: matanp.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35745?usp=email )
Change subject: ctrl: Add lchan node
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
You need to add append it to the others, not in the middle, otherwise you shift the old values doing weird stuff on the ABI.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35745?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf2786f668ee7e4f5b6a9ef43f2141cd2d79b4e2
Gerrit-Change-Number: 35745
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-Comment-Date: Tue, 30 Jan 2024 16:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35745?usp=email )
Change subject: ctrl: Add lchan node
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> why is this being added alone?
In order to support change I6f556b66011be6126d6bac31a14101ba37f81cc4 in osmo-bsc
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35745?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibf2786f668ee7e4f5b6a9ef43f2141cd2d79b4e2
Gerrit-Change-Number: 35745
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jan 2024 16:13:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: matanp.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email
to look at the new patch set (#3).
Change subject: ctrl: Add ms power
......................................................................
ctrl: Add ms power
Depends: libosmocore.git Ibf2786f668ee7e4f5b6a9ef43f2141cd2d79b4e2
Change-Id: I6f556b66011be6126d6bac31a14101ba37f81cc4
---
M include/osmocom/bsc/ctrl.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_ctrl_lookup.c
M src/osmo-bsc/bts_trx_ts_ctrl.c
A src/osmo-bsc/bts_trx_ts_lchan_ctrl.c
5 files changed, 102 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/35747/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6f556b66011be6126d6bac31a14101ba37f81cc4
Gerrit-Change-Number: 35747
Gerrit-PatchSet: 3
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: newpatchset
