January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-cbc[master]: build: include debian/ into the release tarball
by fixeria 26 Jan '24

26 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/35708?usp=email ) Change subject: build: include debian/ into the release tarball ...................................................................... build: include debian/ into the release tarball Change-Id: I54b092ac3c8b25a7511531253c1ec13098629b41 --- M Makefile.am 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/08/35708/1 diff --git a/Makefile.am b/Makefile.am index f291c8a..c7933e1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -12,6 +12,7 @@ README.md \ git-version-gen \ contrib/osmo-cbc.spec.in \ + debian \ cbc.schema.json \ smscb.schema.json \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/35708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I54b092ac3c8b25a7511531253c1ec13098629b41 Gerrit-Change-Number: 35708 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: build: include README.md into the release tarball
by fixeria 26 Jan '24

26 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35707?usp=email ) Change subject: build: include README.md into the release tarball ...................................................................... build: include README.md into the release tarball Change-Id: I1dc8e6c4faca2761ae8caf73b1ee83233ed2c1e1 --- M Makefile.am 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/35707/1 diff --git a/Makefile.am b/Makefile.am index 3a2d56f..0deeb1e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -19,6 +19,7 @@ BUILT_SOURCES = $(top_srcdir)/.version EXTRA_DIST = \ .version \ + README.md \ contrib/osmo-bsc.spec.in \ debian \ git-version-gen \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1dc8e6c4faca2761ae8caf73b1ee83233ed2c1e1 Gerrit-Change-Number: 35707 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libsmpp34[master]: build: include git-version-gen into the release tarball
by fixeria 26 Jan '24

26 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/35706?usp=email ) Change subject: build: include git-version-gen into the release tarball ...................................................................... build: include git-version-gen into the release tarball Change-Id: I3d1c8c905f1acca6256eba51f6ee78214419e97a --- M Makefile.am 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/06/35706/1 diff --git a/Makefile.am b/Makefile.am index 4b1006e..9f85801 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,7 +22,9 @@ README.md \ .version \ debian \ - contrib/libsmpp34.spec.in + contrib/libsmpp34.spec.in \ + git-version-gen \ + $(NULL) @RELMAKE@ -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/35706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I3d1c8c905f1acca6256eba51f6ee78214419e97a Gerrit-Change-Number: 35706 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-sccp[master]: build: include README.md into the release tarball
by fixeria 26 Jan '24

26 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35705?usp=email ) Change subject: build: include README.md into the release tarball ...................................................................... build: include README.md into the release tarball Change-Id: I4ffd3738b3230d7b2cb4f8ebfa5d59f9e6dca27f --- M Makefile.am 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/05/35705/1 diff --git a/Makefile.am b/Makefile.am index 31b920c..bece371 100644 --- a/Makefile.am +++ b/Makefile.am @@ -8,6 +8,7 @@ EXTRA_DIST = \ .version \ + README.md \ contrib/libosmo-sccp.spec.in \ debian \ git-version-gen \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4ffd3738b3230d7b2cb4f8ebfa5d59f9e6dca27f Gerrit-Change-Number: 35705 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-netif[master]: build: include git-version-gen into the release tarball
by fixeria 26 Jan '24

26 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35704?usp=email ) Change subject: build: include git-version-gen into the release tarball ...................................................................... build: include git-version-gen into the release tarball Change-Id: I6abf594cbe1677f53e99ceb046ed69d68b7528ba --- M Makefile.am 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/04/35704/1 diff --git a/Makefile.am b/Makefile.am index 0497895..f1b8046 100644 --- a/Makefile.am +++ b/Makefile.am @@ -11,6 +11,7 @@ README.md \ contrib/libosmo-netif.spec.in \ debian \ + git-version-gen \ $(NULL) @RELMAKE@ -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6abf594cbe1677f53e99ceb046ed69d68b7528ba Gerrit-Change-Number: 35704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: build: include README.md into the release tarball
by fixeria 26 Jan '24

26 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35703?usp=email ) Change subject: build: include README.md into the release tarball ...................................................................... build: include README.md into the release tarball Change-Id: If690f02753fdb7b27f303901cbb0d6c7b1a71f5b --- M Makefile.am 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/03/35703/1 diff --git a/Makefile.am b/Makefile.am index 2c727b0..a1b8003 100644 --- a/Makefile.am +++ b/Makefile.am @@ -25,6 +25,7 @@ BUILT_SOURCES = $(top_srcdir)/.version EXTRA_DIST = \ .version \ + README.md \ contrib/libosmo-gprs.spec.in \ git-version-gen \ debian \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If690f02753fdb7b27f303901cbb0d6c7b1a71f5b Gerrit-Change-Number: 35703 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: build: include git-version-gen into the release tarball
by fixeria 26 Jan '24

26 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35702?usp=email ) Change subject: build: include git-version-gen into the release tarball ...................................................................... build: include git-version-gen into the release tarball Change-Id: I4100459461c04e57cbdfa072dcf1c771f0c0b798 --- M Makefile.am 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/02/35702/1 diff --git a/Makefile.am b/Makefile.am index d55eace..22ecc50 100644 --- a/Makefile.am +++ b/Makefile.am @@ -17,6 +17,7 @@ README.md \ contrib/libosmo-abis.spec.in \ debian \ + git-version-gen \ $(NULL) @RELMAKE@ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4100459461c04e57cbdfa072dcf1c771f0c0b798 Gerrit-Change-Number: 35702 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Validate IPCP identifier in answer matches the one in the request
by osmith 26 Jan '24

26 Jan '24

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35701?usp=email ) Change subject: ggsn: Validate IPCP identifier in answer matches the one in the request ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e0cefaeb303b4e284173011231170554e225561 Gerrit-Change-Number: 35701 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Jan 2024 16:19:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Validate IPCP identifier in answer matches the one in the request
by pespin 26 Jan '24

26 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35701?usp=email ) Change subject: ggsn: Validate IPCP identifier in answer matches the one in the request ...................................................................... ggsn: Validate IPCP identifier in answer matches the one in the request Related: https://github.com/open5gs/open5gs/pull/2920 Related: SYS#6582 Change-Id: I0e0cefaeb303b4e284173011231170554e225561 --- M ggsn_tests/GGSN_Tests.ttcn M library/GTP_Templates.ttcn 2 files changed, 22 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/35701/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index d7de443..c949dc9 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -1489,8 +1489,9 @@ f_init(); var OCT4 ggsn_ip4_dns1 := f_inet_addr(m_ggsn_ip4_dns1); var OCT4 ggsn_ip4_dns2 := f_inet_addr(m_ggsn_ip4_dns2); + var uint8_t ipcp_req_id := oct2int(f_rnd_octstring(1)); var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), "1234", c_ApnInternet, valueof(t_EuaIPv4Dyn))); - ctx.pco_req := valueof(ts_PCO_IPv4_DNS_IPCP); + ctx.pco_req := valueof(ts_PCO_IPv4_DNS_IPCP(ipcp_req_id)); f_pdp_ctx_act(ctx); f_PCO_ensure_no_duplicates(ctx.pco_neg); /* verify IPCP is at all contained */ @@ -1499,9 +1500,13 @@ } /* verify IPCP contains both primary and secondary DNS */ var IpcpPacket ipcp := dec_IpcpPacket(f_PCO_extract_proto(ctx.pco_neg, '8021'O)); - if (not match(ipcp, tr_IPCP_Ack_DNS(0, ggsn_ip4_dns1, ggsn_ip4_dns2))) { - if (not match(ipcp, tr_IPCP_Ack_DNS(0))) { - setverdict(fail, "Primary/Secondary DNS PCO IPCP option not found"); + if (not match(ipcp, tr_IPCP_Ack_DNS(ipcp_req_id, ggsn_ip4_dns1, ggsn_ip4_dns2))) { + if (not match(ipcp, tr_IPCP_Ack_DNS(ipcp_req_id))) { + if (not match(ipcp, tr_IPCP_Ack_DNS(?))) { + setverdict(fail, "Primary/Secondary DNS PCO IPCP option not found"); + } else { + setverdict(fail, "Primary/Secondary DNS PCO IPCP option found but not matching expected identifier"); + } } else { setverdict(fail, "Primary/Secondary DNS PCO IPCP option found but not matching expected values"); } diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 3788725..30346d4 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -973,13 +973,13 @@ } } - template (value) ProtConfigOptions ts_PCO_IPv4_DNS_IPCP modifies ts_PCO := { + template (value) ProtConfigOptions ts_PCO_IPv4_DNS_IPCP(uint8_t ipcp_req_id := 0) modifies ts_PCO := { protocols := { /* dummy PAP entry to check if our parser in the GGSN can properly iterate over * the list of protocols, see Change-Id Icc2e6716c33d78d3c3e000f529806228d8aa155e */ { protocolID := 'C023'O, lengthProtoID := 0, protoIDContents := ''O }, { protocolID := '8021'O, lengthProtoID := 16, protoIDContents := - enc_IpcpPacket(valueof(ts_IPCP_ReqDNS)) } + enc_IpcpPacket(valueof(ts_IPCP_ReqDNS(ipcp_req_id))) } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e0cefaeb303b4e284173011231170554e225561 Gerrit-Change-Number: 35701 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ggsn[master]: pco: Improve IPCP spec reference documentation
by osmith 26 Jan '24

26 Jan '24

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35700?usp=email ) Change subject: pco: Improve IPCP spec reference documentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/35700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1dd4a41bae491c61197e8e307efcfc8c63945a71 Gerrit-Change-Number: 35700 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Jan 2024 15:16:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0