laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email )
Change subject: saip.personalization: Also drop any fillFileOffset
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
Gerrit-Change-Number: 35729
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 28 Jan 2024 21:05:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email )
Change subject: saip.personalization: Also drop any fillFileOffset
......................................................................
saip.personalization: Also drop any fillFileOffset
When replacing a file's contents, we must not just remove any
fillFileContent tuples, but also the fillFileOffset.
Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
---
M pySim/esim/saip/personalization.py
1 file changed, 15 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/35729/1
diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py
index 32a53e6..bde7ce6 100644
--- a/pySim/esim/saip/personalization.py
+++ b/pySim/esim/saip/personalization.py
@@ -20,13 +20,13 @@
from pySim.esim.saip import ProfileElement, ProfileElementSequence
-def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_key:str) -> List[Tuple]:
+def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_keys: List[str]) -> List[Tuple]:
"""In a list of tuples, remove all tuples whose first part equals 'unwanted_key'."""
- return list(filter(lambda x: x[0] != unwanted_key, l))
+ return list(filter(lambda x: x[0] not in unwanted_keys, l))
def file_replace_content(file: List[Tuple], new_content: bytes):
"""Completely replace all fillFileContent of a decoded 'File' with the new_content."""
- file = remove_unwanted_tuples_from_list(file, 'fillFileContent')
+ file = remove_unwanted_tuples_from_list(file, ['fillFileContent', 'fillFileOffset'])
file.append(('fillFileContent', new_content))
return file
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
Gerrit-Change-Number: 35729
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35728?usp=email )
Change subject: tests/Makefile.am: do not add files to EXTRA_DIST conditionally
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35728?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8f530d6157b00907dd1b438100bb0fb300dfcd22
Gerrit-Change-Number: 35728
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 28 Jan 2024 19:42:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email )
Change subject: osmo-release.sh: make it a bit more user friendly
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File osmo-release.sh:
https://gerrit.osmocom.org/c/libosmocore/+/35725/comment/0e55e4aa_8ce0df92
PS1, Line 240: echo "After making changes, add modified file(s) to the index using git-add."
"using git-add and try again"?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8574cb00de820ab477eb5c4abd05d8e546ca89cc
Gerrit-Change-Number: 35725
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 28 Jan 2024 19:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment