laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35724?usp=email )
Change subject: [cosmetic] ara_m: Give a spec reference for the PERM-AR-DO
......................................................................
[cosmetic] ara_m: Give a spec reference for the PERM-AR-DO
PERM-AR-DO actually originates in a different spec than all other parts
of the ara_m.py, so let's explicitly mention that.
Change-Id: I6e0014c323f605860d0f70cd0c04d7e461e8a9de
---
M pySim/ara_m.py
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/35724/1
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index a2eaa33..7631d07 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -116,6 +116,7 @@
class PermArDO(BER_TLV_IE, tag=0xdb):
# Android UICC Carrier Privileges specific extension, see https://source.android.com/devices/tech/config/uicc
+ # based on Table 6-8 of GlobalPlatfomr Device API Access Control v1.0
_construct = Struct('permissions'/HexAdapter(Bytes(8)))
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35724?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6e0014c323f605860d0f70cd0c04d7e461e8a9de
Gerrit-Change-Number: 35724
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35723?usp=email )
Change subject: runtime: Reset selected_file_fcp[_hex] if SELECT returns no data
......................................................................
runtime: Reset selected_file_fcp[_hex] if SELECT returns no data
In case SELECT doesn't return any response data, we must reset
the lchan.selected_file_fcp* members to None to prevent pySim-shell
preventing stale data from the previously selected file.
Change-Id: Ia04b8634e328e604e8df7e8d59b7fd532242d2ca
---
M pySim/runtime.py
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/35723/1
diff --git a/pySim/runtime.py b/pySim/runtime.py
index f836ec8..3aeaab1 100644
--- a/pySim/runtime.py
+++ b/pySim/runtime.py
@@ -304,6 +304,9 @@
if select_resp_data:
self.selected_file_fcp_hex = select_resp_data
self.selected_file_fcp = self.selected_file.decode_select_response(select_resp_data)
+ else:
+ self.selected_file_fcp_hex = None
+ self.selected_file_fcp = None
# register commands of new file
if cmd_app and self.selected_file.shell_commands:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia04b8634e328e604e8df7e8d59b7fd532242d2ca
Gerrit-Change-Number: 35723
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email )
Change subject: Bump version: 1.5.0.5-aa34 → 1.5.1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> You are missing updating the revision (middle field) in LIBVERSION for both libraries: […]
AFAICT, we did not add/modify API since the last release. Shall I still bump those?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I88b987d714a88728b62f74a60c44d9c3532b5686
Gerrit-Change-Number: 35720
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 27 Jan 2024 18:43:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email )
Change subject: Convert README to README.md and expand like in other projects
......................................................................
Patch Set 2:
(1 comment)
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/a504d852_2cafe0c9
PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent
> I am certainly not an expert in English grammar, but I think it should be `an` because `M` in `MGCP` […]
Ack, I remember discussuing and looking at it previously with Daniel and it seems the sound is the one actually marking whether it's "an" or "n", not the letter.
since MGCP is pronunced EM... hence a vowel sound, it should use "an".
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 27 Jan 2024 18:32:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email )
Change subject: Convert README to README.md and expand like in other projects
......................................................................
Patch Set 2:
(1 comment)
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/03384690_72d38d42
PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent
> I intentionally switched all 'an' to 'a' since M is not a vowel?
I am certainly not an expert in English grammar, but I think it should be `an` because `M` in `MGCP` acronym, while being not a vowel, is a _vowel sound_ `em`. This is not the case if you automatically expand the acronyms when reading them ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Jan 2024 21:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email )
Change subject: Convert README to README.md and expand like in other projects
......................................................................
Patch Set 2:
(2 comments)
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/909b843e_b6f569d5
PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent
> AFAICS, not addressed: `s/a/an/`.
I intentionally switched all 'an' to 'a' since M is not a vowel?
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/40f58cba_01f92034
PS2, Line 9: MGPC
> wait, it's MGCP, right?
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Jan 2024 21:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment