January 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-mgw[master]: Convert README to README.md and expand like in other projects
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: daniel, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email ) Change subject: Convert README to README.md and expand like in other projects ...................................................................... Patch Set 2: (1 comment) File README.md: https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/23aa6840_99d45423 PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent > Ack, I remember discussuing and looking at it previously with Daniel and it seems the sound is the o […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c Gerrit-Change-Number: 35718 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:16:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: Convert README to README.md and expand like in other projects
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Convert README to README.md and expand like in other projects ...................................................................... Convert README to README.md and expand like in other projects Let's align with structure and content of README.md in other osmo-* projects. Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c --- M Makefile.am D README A README.md M contrib/osmo-mgw.spec.in 4 files changed, 116 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/18/35718/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c Gerrit-Change-Number: 35718 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-abis[master]: Bump version: 1.5.0.5-aa34 → 1.5.1
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email ) Change subject: Bump version: 1.5.0.5-aa34 → 1.5.1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I88b987d714a88728b62f74a60c44d9c3532b5686 Gerrit-Change-Number: 35720 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: doc/examples: fix missing config files in release tarballs
by laforge 29 Jan '24

29 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35726?usp=email ) Change subject: doc/examples: fix missing config files in release tarballs ...................................................................... doc/examples: fix missing config files in release tarballs All config file examples must be listed in EXTRA_DIST unconditionally. Adding them conditionally results in incomplete release tarballs, containing only 'osmo-bts-virtual.cfg' and failing to build. Change-Id: I167027afde3cee40a3b52adfaec7bde91ba896da Related: OS#6349 --- M doc/examples/Makefile.am 1 file changed, 30 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am index 25a2151..6a1ae95 100644 --- a/doc/examples/Makefile.am +++ b/doc/examples/Makefile.am @@ -1,16 +1,29 @@ -OSMOCONF_FILES = virtual/osmo-bts-virtual.cfg +# all config examples must be listed here unconditionally, so that +# all of them end up in the release tarball (see OS#6349) +EXTRA_DIST = \ + trx/osmo-bts-trx.cfg \ + trx/osmo-bts-trx-calypso.cfg \ + octphy/osmo-bts-trx2dsp1.cfg \ + octphy/osmo-bts-octphy.cfg \ + oc2g/osmo-bts-oc2g.cfg \ + oc2g/oc2gbts-mgr.cfg \ + sysmo/sysmobts-mgr.cfg \ + sysmo/osmo-bts-sysmo.cfg \ + litecell15/osmo-bts-lc15.cfg \ + litecell15/lc15bts-mgr.cfg \ + virtual/osmo-bts-virtual.cfg \ + $(NULL) doc_virtualdir = $(docdir)/examples/osmo-bts-virtual doc_virtual_DATA = \ virtual/osmo-bts-virtual.cfg -EXTRA_DIST = $(doc_virtual_DATA) +OSMOCONF_FILES = virtual/osmo-bts-virtual.cfg if ENABLE_SYSMOBTS doc_sysmodir = $(docdir)/examples/osmo-bts-sysmo doc_sysmo_DATA = \ sysmo/osmo-bts-sysmo.cfg \ sysmo/sysmobts-mgr.cfg -EXTRA_DIST += $(doc_sysmo_DATA) OSMOCONF_FILES += sysmo/osmo-bts-sysmo.cfg sysmo/sysmobts-mgr.cfg endif @@ -19,7 +32,6 @@ doc_trx_DATA = \ trx/osmo-bts-trx.cfg \ trx/osmo-bts-trx-calypso.cfg -EXTRA_DIST += $(doc_trx_DATA) OSMOCONF_FILES += trx/osmo-bts-trx.cfg endif @@ -28,7 +40,6 @@ doc_octphy_DATA = \ octphy/osmo-bts-trx2dsp1.cfg \ octphy/osmo-bts-octphy.cfg -EXTRA_DIST += $(doc_octphy_DATA) OSMOCONF_FILES += octphy/osmo-bts-octphy.cfg endif @@ -37,7 +48,6 @@ doc_lc15_DATA = \ litecell15/osmo-bts-lc15.cfg \ litecell15/lc15bts-mgr.cfg -EXTRA_DIST += $(doc_lc15_DATA) OSMOCONF_FILES += litecell15/osmo-bts-lc15.cfg litecell15/lc15bts-mgr.cfg endif @@ -46,7 +56,6 @@ doc_oc2g_DATA = \ oc2g/osmo-bts-oc2g.cfg \ oc2g/oc2gbts-mgr.cfg -EXTRA_DIST += $(doc_oc2g_DATA) OSMOCONF_FILES += oc2g/osmo-bts-oc2g.cfg oc2g/oc2gbts-mgr.cfg endif -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I167027afde3cee40a3b52adfaec7bde91ba896da Gerrit-Change-Number: 35726 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bts[master]: doc/examples: fix missing config files in release tarballs
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35726?usp=email ) Change subject: doc/examples: fix missing config files in release tarballs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I167027afde3cee40a3b52adfaec7bde91ba896da Gerrit-Change-Number: 35726 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:13:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: doc/examples: fix missing config files in release tarballs
by laforge 29 Jan '24

29 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35727?usp=email ) Change subject: doc/examples: fix missing config files in release tarballs ...................................................................... doc/examples: fix missing config files in release tarballs All config file examples must be listed in EXTRA_DIST unconditionally. Adding them conditionally results in incomplete release tarballs, containing only some '*.cfg' files and failing to build. Change-Id: Iffb6d7577de175fc5d14642f0af6852508d74e69 Related: OS#6349 --- M doc/examples/Makefile.am 1 file changed, 26 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am index 0b06130..ac87457 100644 --- a/doc/examples/Makefile.am +++ b/doc/examples/Makefile.am @@ -1,3 +1,15 @@ +# all config examples must be listed here unconditionally, so that +# all of them end up in the release tarball (see OS#6349) +EXTRA_DIST = \ + osmo-trx-uhd/osmo-trx-limesdr.cfg \ + osmo-trx-uhd/osmo-trx-usrp_b200.cfg \ + osmo-trx-uhd/osmo-trx-uhd.cfg \ + osmo-trx-uhd/osmo-trx-umtrx.cfg \ + osmo-trx-lms/osmo-trx-limesdr.cfg \ + osmo-trx-lms/osmo-trx-lms.cfg \ + osmo-trx-ipc/osmo-trx-ipc.cfg \ + $(NULL) + OSMOCONF_FILES = osmoconfdir = $(sysconfdir)/osmocom @@ -19,7 +31,6 @@ endif osmoconf_DATA = $(OSMOCONF_FILES) -EXTRA_DIST = $(OSMOCONF_FILES) CFG_FILES = find $(srcdir) -type f -name '*.cfg*' | sed -e 's,^$(srcdir),,' -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iffb6d7577de175fc5d14642f0af6852508d74e69 Gerrit-Change-Number: 35727 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-trx[master]: doc/examples: fix missing config files in release tarballs
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35727?usp=email ) Change subject: doc/examples: fix missing config files in release tarballs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iffb6d7577de175fc5d14642f0af6852508d74e69 Gerrit-Change-Number: 35727 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:13:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: tests/Makefile.am: do not add files to EXTRA_DIST conditionally
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35728?usp=email ) Change subject: tests/Makefile.am: do not add files to EXTRA_DIST conditionally ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: unrelated: maybe it's even possible to add all those files using wildcard expansion like *.ok ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f530d6157b00907dd1b438100bb0fb300dfcd22 Gerrit-Change-Number: 35728 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:12:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: osmo-release.sh: make it a bit more user friendly
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email ) Change subject: osmo-release.sh: make it a bit more user friendly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8574cb00de820ab477eb5c4abd05d8e546ca89cc Gerrit-Change-Number: 35725 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:11:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in pysim[master]: add SAIP template handling + v3.1 definitions
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35731?usp=email ) Change subject: add SAIP template handling + v3.1 definitions ...................................................................... Patch Set 1: (2 comments) File pySim/esim/saip/templates.py: https://gerrit.osmocom.org/c/pysim/+/35731/comment/340bdd2f_3d7eb992 PS1, Line 23: __init__ > cosmetic: too many params, may of which are optional. I would go for `**kw` here: […] i prefer if i can see the parameters in the method declaration and don't have to read through the body to see what kind of arguments are supported by a given method. https://gerrit.osmocom.org/c/pysim/+/35731/comment/7f39380d_b18f9491 PS1, Line 531: FilesUsimDf5GSv2 > duplicate definition yeah, actually the first definition above is the culprit, it should be FilesUsimDf5GS and this one remains v2. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8 Gerrit-Change-Number: 35731 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0