January 2024 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: esim.saip: Move OID to separate sub-module
by laforge 29 Jan '24

29 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35734?usp=email ) Change subject: esim.saip: Move OID to separate sub-module ...................................................................... esim.saip: Move OID to separate sub-module This helps us to prevent circular imports in follow-up code. Change-Id: I94f85f2257d4702376f4ba5eb995a544a2e53fd3 --- M pySim/esim/saip/__init__.py A pySim/esim/saip/oid.py 2 files changed, 84 insertions(+), 57 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/35734/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 9b182e5..251395f 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -25,63 +25,6 @@ asn1 = compile_asn1_subdir('saip') -class oid: - class OID: - @staticmethod - def intlist_from_str(instr: str) -> List[int]: - return [int(x) for x in instr.split('.')] - - def __init__(self, initializer): - if type(initializer) == str: - self.intlist = self.intlist_from_str(initializer) - else: - self.intlist = initializer - - def __str__(self): - return '.'.join([str(x) for x in self.intlist]) - - def __repr__(self): - return 'OID(%s)' % (str(self)) - - - class eOID(OID): - """OID helper for TCA eUICC prefix""" - __prefix = [2,23,143,1] - def __init__(self, initializer): - if type(initializer) == str: - initializer = self.intlist_from_str(initializer) - super().__init__(self.__prefix + initializer) - - MF = eOID("2.1") - DF_CD = eOID("2.2") - DF_TELECOM = eOID("2.3") - DF_TELECOM_v2 = eOID("2.3.2") - ADF_USIM_by_default = eOID("2.4") - ADF_USIM_by_default_v2 = eOID("2.4.2") - ADF_USIM_not_by_default = eOID("2.5") - ADF_USIM_not_by_default_v2 = eOID("2.5.2") - ADF_USIM_not_by_default_v3 = eOID("2.5.3") - DF_PHONEBOOK_ADF_USIM = eOID("2.6") - DF_GSM_ACCESS_ADF_USIM = eOID("2.7") - ADF_ISIM_by_default = eOID("2.8") - ADF_ISIM_not_by_default = eOID("2.9") - ADF_ISIM_not_by_default_v2 = eOID("2.9.2") - ADF_CSIM_by_default = eOID("2.10") - ADF_CSIM_by_default_v2 = eOID("2.10.2") - ADF_CSIM_not_by_default = eOID("2.11") - ADF_CSIM_not_by_default_v2 = eOID("2.11.2") - DF_EAP = eOID("2.12") - DF_5GS = eOID("2.13") - DF_5GS_v2 = eOID("2.13.2") - DF_5GS_v3 = eOID("2.13.3") - DF_5GS_v4 = eOID("2.13.4") - DF_SAIP = eOID("2.14") - DF_SNPN = eOID("2.15") - DF_5GProSe = eOID("2.16") - IoT_default = eOID("2.17") - IoT_default = eOID("2.18") - - class ProfileElement: def _fixup_sqnInit_dec(self): """asn1tools has a bug when working with SEQUENCE OF that have DEFAULT values. Let's work around diff --git a/pySim/esim/saip/oid.py b/pySim/esim/saip/oid.py new file mode 100644 index 0000000..8b2870e --- /dev/null +++ b/pySim/esim/saip/oid.py @@ -0,0 +1,73 @@ +# Implementation of SimAlliance/TCA Interoperable Profile OIDs +# +# (C) 2023-2024 by Harald Welte <laforge(a)osmocom.org> +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU Affero General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Affero General Public License for more details. +# +# You should have received a copy of the GNU Affero General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +from typing import List, Union + +class OID: + @staticmethod + def intlist_from_str(instr: str) -> List[int]: + return [int(x) for x in instr.split('.')] + + def __init__(self, initializer: Union[List[int], str]): + if type(initializer) == str: + self.intlist = self.intlist_from_str(initializer) + else: + self.intlist = initializer + + def __str__(self) -> str: + return '.'.join([str(x) for x in self.intlist]) + + def __repr__(self) -> str: + return 'OID(%s)' % (str(self)) + + +class eOID(OID): + """OID helper for TCA eUICC prefix""" + __prefix = [2,23,143,1] + def __init__(self, initializer): + if type(initializer) == str: + initializer = self.intlist_from_str(initializer) + super().__init__(self.__prefix + initializer) + +MF = eOID("2.1") +DF_CD = eOID("2.2") +DF_TELECOM = eOID("2.3") +DF_TELECOM_v2 = eOID("2.3.2") +ADF_USIM_by_default = eOID("2.4") +ADF_USIM_by_default_v2 = eOID("2.4.2") +ADF_USIM_not_by_default = eOID("2.5") +ADF_USIM_not_by_default_v2 = eOID("2.5.2") +ADF_USIM_not_by_default_v3 = eOID("2.5.3") +DF_PHONEBOOK_ADF_USIM = eOID("2.6") +DF_GSM_ACCESS_ADF_USIM = eOID("2.7") +ADF_ISIM_by_default = eOID("2.8") +ADF_ISIM_not_by_default = eOID("2.9") +ADF_ISIM_not_by_default_v2 = eOID("2.9.2") +ADF_CSIM_by_default = eOID("2.10") +ADF_CSIM_by_default_v2 = eOID("2.10.2") +ADF_CSIM_not_by_default = eOID("2.11") +ADF_CSIM_not_by_default_v2 = eOID("2.11.2") +DF_EAP = eOID("2.12") +DF_5GS = eOID("2.13") +DF_5GS_v2 = eOID("2.13.2") +DF_5GS_v3 = eOID("2.13.3") +DF_5GS_v4 = eOID("2.13.4") +DF_SAIP = eOID("2.14") +DF_SNPN = eOID("2.15") +DF_5GProSe = eOID("2.16") +IoT_default = eOID("2.17") +IoT_default = eOID("2.18") -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I94f85f2257d4702376f4ba5eb995a544a2e53fd3 Gerrit-Change-Number: 35734 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim.esim.saip: More type annotations
by laforge 29 Jan '24

29 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35735?usp=email ) Change subject: pySim.esim.saip: More type annotations ...................................................................... pySim.esim.saip: More type annotations Change-Id: Ib549817ee137bab610aea9c89a5ab86c2a7592ea --- M pySim/esim/saip/__init__.py 1 file changed, 20 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/35735/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 251395f..7bb2172 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -16,7 +16,7 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. import abc -from typing import Tuple, List, Optional, Dict +from typing import Tuple, List, Optional, Dict, Union import asn1tools @@ -26,7 +26,7 @@ asn1 = compile_asn1_subdir('saip') class ProfileElement: - def _fixup_sqnInit_dec(self): + def _fixup_sqnInit_dec(self) -> None: """asn1tools has a bug when working with SEQUENCE OF that have DEFAULT values. Let's work around this.""" if self.type != 'akaParameter': @@ -39,7 +39,7 @@ # SEQUENCE (SIZE (32)) OF OCTET STRING (SIZE (6)) self.decoded['sqnInit'] = [b'\x00'*6] * 32 - def _fixup_sqnInit_enc(self): + def _fixup_sqnInit_enc(self) -> None: """asn1tools has a bug when working with SEQUENCE OF that have DEFAULT values. Let's work around this.""" if self.type != 'akaParameter': @@ -53,7 +53,7 @@ # none of the fields were initialized with a non-default (non-zero) value, so we can skip it del self.decoded['sqnInit'] - def parse_der(self, der: bytes): + def parse_der(self, der: bytes) -> None: """Parse a sequence of PE and store the result in instance attributes.""" self.type, self.decoded = asn1.decode('ProfileElement', der) # work around asn1tools bug regarding DEFAULT for a SEQUENCE OF @@ -72,7 +72,7 @@ self._fixup_sqnInit_enc() return asn1.encode('ProfileElement', (self.type, self.decoded)) - def __str__(self): + def __str__(self) -> str: return self.type @@ -102,7 +102,7 @@ assert len(l) == 1 return l[0] - def parse_der(self, der: bytes): + def parse_der(self, der: bytes) -> None: """Parse a sequence of PE and store the result in self.pe_list.""" self.pe_list = [] remainder = der @@ -111,11 +111,11 @@ self.pe_list.append(ProfileElement.from_der(first_tlv)) self._process_pelist() - def _process_pelist(self): + def _process_pelist(self) -> None: self._rebuild_pe_by_type() self._rebuild_pes_by_naa() - def _rebuild_pe_by_type(self): + def _rebuild_pe_by_type(self) -> None: self.pe_by_type = {} # build a dict {pe_type: [pe, pe, pe]} for pe in self.pe_list: @@ -124,7 +124,7 @@ else: self.pe_by_type[pe.type] = [pe] - def _rebuild_pes_by_naa(self): + def _rebuild_pes_by_naa(self) -> None: """rebuild the self.pes_by_naa dict {naa: [ [pe, pe, pe], [pe, pe] ]} form, which basically means for every NAA there's a lsit of instances, and each consists of a list of a list of PEs.""" @@ -165,8 +165,8 @@ out += pe.to_der() return out - def __repr__(self): + def __repr__(self) -> str: return "PESequence(%s)" % ', '.join([str(x) for x in self.pe_list]) - def __iter__(self): + def __iter__(self) -> str: yield from self.pe_list -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib549817ee137bab610aea9c89a5ab86c2a7592ea Gerrit-Change-Number: 35735 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[L] Change in pysim[master]: add SAIP template handling + v3.1 definitions
by laforge 29 Jan '24

29 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35731?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add SAIP template handling + v3.1 definitions ...................................................................... add SAIP template handling + v3.1 definitions This adds classes for describing profile templates as well as derived classes defining the profile templates of the "Profile Interoperability Technical Specification", specifically it's "ANNEX A (Normative): File Structure Templates Definition" We need a machine-readable definition of those templates, so we can fully interpret an unprotected profile package (UPP), as the UPP usually only contains the increment/difference to a given teplate. Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8 --- A pySim/esim/saip/templates.py 1 file changed, 694 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/35731/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8 Gerrit-Change-Number: 35731 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: saip.personalization: Fix ICCID fillFileContent replacement
by laforge 29 Jan '24

29 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35730?usp=email ) Change subject: saip.personalization: Fix ICCID fillFileContent replacement ...................................................................... saip.personalization: Fix ICCID fillFileContent replacement Change-Id: Ic267fdde3b648b376ea6814783df1e90ea9bb9ad --- M pySim/esim/saip/personalization.py 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index bde7ce6..cb3edc1 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -26,7 +26,8 @@ def file_replace_content(file: List[Tuple], new_content: bytes): """Completely replace all fillFileContent of a decoded 'File' with the new_content.""" - file = remove_unwanted_tuples_from_list(file, ['fillFileContent', 'fillFileOffset']) + # use [:] to avoid making a copy, as we're doing in-place modification of the list here + file[:] = remove_unwanted_tuples_from_list(file, ['fillFileContent', 'fillFileOffset']) file.append(('fillFileContent', new_content)) return file @@ -54,9 +55,9 @@ name = 'iccid' def apply(self, pes: ProfileElementSequence): # patch the header; FIXME: swap nibbles! - pes.get_pe_by_type('header').decoded['iccid'] = self.value + pes.get_pe_for_type('header').decoded['iccid'] = self.value # patch MF/EF.ICCID - file_replace_content(pes.get_pe_by_type('mf').decoded['ef-iccid'], self.value) + file_replace_content(pes.get_pe_for_type('mf').decoded['ef-iccid'], bytes(self.value)) class Imsi(ConfigurableParameter): """Configurable IMSI. Expects value to be n EF.IMSI format.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic267fdde3b648b376ea6814783df1e90ea9bb9ad Gerrit-Change-Number: 35730 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: saip.personalization: Also drop any fillFileOffset
by laforge 29 Jan '24

29 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email ) Change subject: saip.personalization: Also drop any fillFileOffset ...................................................................... saip.personalization: Also drop any fillFileOffset When replacing a file's contents, we must not just remove any fillFileContent tuples, but also the fillFileOffset. Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800 --- M pySim/esim/saip/personalization.py 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 32a53e6..bde7ce6 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -20,13 +20,13 @@ from pySim.esim.saip import ProfileElement, ProfileElementSequence -def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_key:str) -> List[Tuple]: +def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_keys: List[str]) -> List[Tuple]: """In a list of tuples, remove all tuples whose first part equals 'unwanted_key'.""" - return list(filter(lambda x: x[0] != unwanted_key, l)) + return list(filter(lambda x: x[0] not in unwanted_keys, l)) def file_replace_content(file: List[Tuple], new_content: bytes): """Completely replace all fillFileContent of a decoded 'File' with the new_content.""" - file = remove_unwanted_tuples_from_list(file, 'fillFileContent') + file = remove_unwanted_tuples_from_list(file, ['fillFileContent', 'fillFileOffset']) file.append(('fillFileContent', new_content)) return file -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: requirements.txt: Switch to osmocom fork of asn1tools
by fixeria 29 Jan '24

29 Jan '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35732?usp=email ) Change subject: requirements.txt: Switch to osmocom fork of asn1tools ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id28fcf060f491bb3d76aa6d8026aa76058edb675 Gerrit-Change-Number: 35732 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Jan 2024 02:24:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in pysim[master]: add SAIP template handling + v3.1 definitions
by fixeria 29 Jan '24

29 Jan '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35731?usp=email ) Change subject: add SAIP template handling + v3.1 definitions ...................................................................... Patch Set 1: (2 comments) File pySim/esim/saip/templates.py: https://gerrit.osmocom.org/c/pysim/+/35731/comment/6ad8d394_7faa632d PS1, Line 23: __init__ cosmetic: too many params, may of which are optional. I would go for `**kw` here: ``` def __init__(self, fid:int, name:str, ftype: str, **kw): # ... self.foo = kw.get('foo') # defaults to None self.bar = kw.get('bar', True) # defaults to True ``` https://gerrit.osmocom.org/c/pysim/+/35731/comment/f66bf293_989183cf PS1, Line 531: FilesUsimDf5GSv2 duplicate definition -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8 Gerrit-Change-Number: 35731 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Jan 2024 02:24:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: saip.personalization: Fix ICCID fillFileContent replacement
by fixeria 29 Jan '24

29 Jan '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35730?usp=email ) Change subject: saip.personalization: Fix ICCID fillFileContent replacement ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic267fdde3b648b376ea6814783df1e90ea9bb9ad Gerrit-Change-Number: 35730 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Jan 2024 02:14:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: saip.personalization: Also drop any fillFileOffset
by fixeria 29 Jan '24

29 Jan '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email ) Change subject: saip.personalization: Also drop any fillFileOffset ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800 Gerrit-Change-Number: 35729 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Jan 2024 02:13:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: requirements.txt: Switch to osmocom fork of asn1tools
by laforge 28 Jan '24

28 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35732?usp=email ) Change subject: requirements.txt: Switch to osmocom fork of asn1tools ...................................................................... requirements.txt: Switch to osmocom fork of asn1tools This is sadly required as the Interoperable Profile format must process elements of an ASN.1 sequence in order, which doesn't work if the parser puts the elements in a python dict. The osmocom fork of asn1tools hence uses OrderedDict to work around this problem. Change-Id: Id28fcf060f491bb3d76aa6d8026aa76058edb675 --- M requirements.txt 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/35732/1 diff --git a/requirements.txt b/requirements.txt index 5b735f0..c12daf8 100644 --- a/requirements.txt +++ b/requirements.txt @@ -11,6 +11,6 @@ colorlog pycryptodomex cryptography -asn1tools +git+https://github.com/osmocom/asn1tools packaging git+https://github.com/hologram-io/smpp.pdu -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id28fcf060f491bb3d76aa6d8026aa76058edb675 Gerrit-Change-Number: 35732 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0