Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: gprs_rlcmac_sched: check if we really use direct phy
......................................................................
gprs_rlcmac_sched: check if we really use direct phy
In gprs_rlcmac_sched we have a flag to skip idle frames in case we do not
use the so called "direct phy access". A similar mechanism also exists
in pcu_l1_if.cpp in function pcu_rx_rts_req_ptcch().
Unfortunately the check is not done correctly. The flag gets set when
the ENABLE_DIRECT_PHY define constant is set. However, this does not say
much about whether we access a PHY directly or not. The define constant
is intended to be used to disable direct phy related code in
on platforms where no direct phy code is used or cannot be used.
In order to know if we actually accessing a PHY directly we must check
the presence of fl1h on the related TRX. (see also pcu_l1_if.cpp,
function pcu_l1if_tx_pdtch) Also since we do not have to guard any
platform depended function calls here, we may also remove the conditional
compiling.
Related: OS#6191
Change-Id: I0808950b1154bbb9a789c3f706ad9fb6618764ec
---
M src/gprs_rlcmac_sched.cpp
M src/pcu_l1_if.cpp
2 files changed, 35 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/34575/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0808950b1154bbb9a789c3f706ad9fb6618764ec
Gerrit-Change-Number: 34575
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34581?usp=email )
Change subject: Increase RR scheduler priority to 20, to avoid dropped bursts
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Is there any other process in sysmobts really running between rt_prio 11 and 20? Is this really make […]
There is no other process using RR prio, but there are kernel processes with nice level of -20.
It makes it change. The bursts are dropped with prio 11 and not with prio 20. I changed it several times and there was always a change in dropped bursts.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34581?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2394e6bbc00a1d47987dbe7b70f4b5cbedf69b10
Gerrit-Change-Number: 34581
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Sep 2023 13:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34577?usp=email )
Change subject: osmo_io: Only allow reading/writing if the relevant callback is set
......................................................................
osmo_io: Only allow reading/writing if the relevant callback is set
Allow the callbacks to be NULL, but then sending/receiving is disabled.
There are some cases where we only care about writing to or reading from
an fd.
Change-Id: I11ce072510b591f7881d09888524426579bd0169
---
M src/core/osmo_io.c
1 file changed, 43 insertions(+), 1 deletion(-)
Approvals:
daniel: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index c67787b..2b2b7dd 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -355,6 +355,12 @@
int osmo_iofd_write_msgb(struct osmo_io_fd *iofd, struct msgb *msg)
{
int rc;
+
+ if (OSMO_UNLIKELY(!iofd->io_ops.write_cb)) {
+ LOGPIO(iofd, LOGL_ERROR, "write_cb not set, Rejecting msgb\n");
+ return -EINVAL;
+ }
+
struct iofd_msghdr *msghdr = iofd_msghdr_alloc(iofd, IOFD_ACT_WRITE, msg);
if (!msghdr)
return -ENOMEM;
@@ -392,6 +398,10 @@
int rc;
OSMO_ASSERT(iofd->mode == OSMO_IO_FD_MODE_RECVFROM_SENDTO);
+ if (OSMO_UNLIKELY(!iofd->io_ops.sendto_cb)) {
+ LOGPIO(iofd, LOGL_ERROR, "sendto_cb not set, Rejecting msgb\n");
+ return -EINVAL;
+ }
struct iofd_msghdr *msghdr = iofd_msghdr_alloc(iofd, IOFD_ACT_SENDTO, msg);
if (!msghdr)
@@ -477,7 +487,8 @@
return rc;
IOFD_FLAG_UNSET(iofd, IOFD_FLAG_CLOSED);
- osmo_iofd_ops.read_enable(iofd);
+ if (iofd->io_ops.read_cb)
+ osmo_iofd_ops.read_enable(iofd);
if (iofd->tx_queue.current_length > 0)
osmo_iofd_ops.write_enable(iofd);
@@ -658,6 +669,24 @@
void osmo_iofd_set_ioops(struct osmo_io_fd *iofd, const struct osmo_io_ops *ioops)
{
iofd->io_ops = *ioops;
+
+ switch (iofd->mode) {
+ case OSMO_IO_FD_MODE_READ_WRITE:
+ if (iofd->io_ops.read_cb)
+ osmo_iofd_ops.read_enable(iofd);
+ else
+ osmo_iofd_ops.read_disable(iofd);
+ break;
+ case OSMO_IO_FD_MODE_RECVFROM_SENDTO:
+ if (iofd->io_ops.recvfrom_cb)
+ osmo_iofd_ops.read_enable(iofd);
+ else
+ osmo_iofd_ops.read_disable(iofd);
+ break;
+ case OSMO_IO_FD_MODE_SCTP_RECVMSG_SENDMSG:
+ default:
+ OSMO_ASSERT(0);
+ }
}
/*! Notify the user if/when the socket is connected.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34577?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I11ce072510b591f7881d09888524426579bd0169
Gerrit-Change-Number: 34577
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34577?usp=email )
Change subject: osmo_io: Only allow reading/writing if the relevant callback is set
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34577?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I11ce072510b591f7881d09888524426579bd0169
Gerrit-Change-Number: 34577
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Sep 2023 13:14:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34585?usp=email )
Change subject: rename sysmo_direct_dsp to direct_phy
......................................................................
rename sysmo_direct_dsp to direct_phy
The name sysmo_direct_dsp is not entirely correct. It should be just
"sysmo" if we follow the rules that the "PCU_IF_FLAG_" prefix is
supposed to be chopped off here.
In pcuif_proto.h, we have renamed PCU_IF_FLAG_SYSMO to
PCU_IF_FLAG_DIRECT_PHY. (see Depends), so let's rename the flag here to
"direct_phy".
Related: OS#6191
Depends: osmo-pcu.git I29b7b78a3a91d062b9ea3cd72623d30618cd3f0b
Change-Id: Ib67c4441d0077822d0f9cbf29338fedeb916f287
---
M library/PCUIF_Types.ttcn
1 file changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/34585/1
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 6be45df..8fb0be3 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -60,7 +60,7 @@
type record PCUIF_Flags {
boolean bts_active,
- boolean sysmo_direct_dsp,
+ boolean direct_phy,
BIT14 spare,
boolean cs1,
boolean cs2,
@@ -819,7 +819,7 @@
const PCUIF_Flags c_PCUIF_Flags_default := {
bts_active := true,
- sysmo_direct_dsp := false,
+ direct_phy := false,
spare := '00000000000000'B,
cs1 := true,
cs2 := true,
@@ -839,7 +839,7 @@
const PCUIF_Flags c_PCUIF_Flags_noMCS := {
bts_active := true,
- sysmo_direct_dsp := false,
+ direct_phy := false,
spare := '00000000000000'B,
cs1 := true,
cs2 := true,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34585?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib67c4441d0077822d0f9cbf29338fedeb916f287
Gerrit-Change-Number: 34585
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34584?usp=email )
Change subject: pcuif_proto: rename PCU_IF_FLAG_SYSMO to PCU_IF_FLAG_DIRECT_PHY
......................................................................
pcuif_proto: rename PCU_IF_FLAG_SYSMO to PCU_IF_FLAG_DIRECT_PHY
The PCUIF flag PCU_IF_FLAG_SYSMO was originally used by osmo-bts-sysmo
to signal to the PCU that the direct PHY access for the sysmo-bts DSP
should be enabled. With time, support for other BTS models was added and
the flag became a synonym for "direct PHY access", so it makes sense to
rename it to "PCU_IF_FLAG_DIRECT_PHY"
Related: OS#6191
Depends: osmo-pcu.git I29b7b78a3a91d062b9ea3cd72623d30618cd3f0b
Change-Id: Ib556a93f7d7d7dbe1e96c4a0802bc802241b2b2d
---
M include/osmo-bts/pcuif_proto.h
M src/common/pcu_sock.c
2 files changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/34584/1
diff --git a/include/osmo-bts/pcuif_proto.h b/include/osmo-bts/pcuif_proto.h
index b47dc75..a620993 100644
--- a/include/osmo-bts/pcuif_proto.h
+++ b/include/osmo-bts/pcuif_proto.h
@@ -40,7 +40,7 @@
/* flags */
#define PCU_IF_FLAG_ACTIVE (1 << 0)/* BTS is active */
-#define PCU_IF_FLAG_SYSMO (1 << 1)/* access PDCH of sysmoBTS directly */
+#define PCU_IF_FLAG_DIRECT_PHY (1 << 1)/* access PHY directly via dedicated hardware support */
#define PCU_IF_FLAG_CS1 (1 << 16)
#define PCU_IF_FLAG_CS2 (1 << 17)
#define PCU_IF_FLAG_CS3 (1 << 18)
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index f99c7d2..79b39c4 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -264,7 +264,7 @@
LOGP(DPCU, LOGL_INFO, "BTS is down\n");
if (pcu_direct)
- info_ind->flags |= PCU_IF_FLAG_SYSMO;
+ info_ind->flags |= PCU_IF_FLAG_DIRECT_PHY;
info_ind->bsic = bts->bsic;
/* RAI */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34584?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib556a93f7d7d7dbe1e96c4a0802bc802241b2b2d
Gerrit-Change-Number: 34584
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34583?usp=email )
Change subject: pcuif_proto: rename PCU_IF_FLAG_SYSMO to PCU_IF_FLAG_DIRECT_PHY
......................................................................
pcuif_proto: rename PCU_IF_FLAG_SYSMO to PCU_IF_FLAG_DIRECT_PHY
The PCUIF flag PCU_IF_FLAG_SYSMO was originally used by osmo-bts-sysmo
to signal to the PCU that the direct PHY access for the sysmo-bts DSP
should be enabled. With time, support for other BTS models was added and
the flag became a synonym for "direct PHY access", so it makes sense to
rename it to "PCU_IF_FLAG_DIRECT_PHY"
Related: OS#6191
Depends: osmo-pcu.git I29b7b78a3a91d062b9ea3cd72623d30618cd3f0b
Change-Id: I23df067df99b76048667131905c4448d32d80640
---
M include/osmocom/bsc/pcuif_proto.h
M src/osmo-bsc/pcu_sock.c
2 files changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/34583/1
diff --git a/include/osmocom/bsc/pcuif_proto.h b/include/osmocom/bsc/pcuif_proto.h
index cd2a298..9df85d9 100644
--- a/include/osmocom/bsc/pcuif_proto.h
+++ b/include/osmocom/bsc/pcuif_proto.h
@@ -46,7 +46,7 @@
/* flags */
#define PCU_IF_FLAG_ACTIVE (1 << 0)/* BTS is active */
-#define PCU_IF_FLAG_SYSMO (1 << 1)/* access PDCH of sysmoBTS directly */
+#define PCU_IF_FLAG_DIRECT_PHY (1 << 1)/* access PHY directly via dedicated hardware support */
#define PCU_IF_FLAG_CS1 (1 << 16)
#define PCU_IF_FLAG_CS2 (1 << 17)
#define PCU_IF_FLAG_CS3 (1 << 18)
diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c
index dc2b8e9..d279093 100644
--- a/src/osmo-bsc/pcu_sock.c
+++ b/src/osmo-bsc/pcu_sock.c
@@ -200,7 +200,7 @@
info_ind = &pcu_prim->u.info_ind;
info_ind->version = PCU_IF_VERSION;
info_ind->flags |= PCU_IF_FLAG_ACTIVE;
- info_ind->flags |= PCU_IF_FLAG_SYSMO;
+ info_ind->flags |= PCU_IF_FLAG_DIRECT_PHY;
/* RAI */
info_ind->mcc = bts->network->plmn.mcc;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34583?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I23df067df99b76048667131905c4448d32d80640
Gerrit-Change-Number: 34583
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34582?usp=email )
Change subject: pcuif_proto: rename PCU_IF_FLAG_SYSMO to PCU_IF_FLAG_DIRECT_PHY
......................................................................
pcuif_proto: rename PCU_IF_FLAG_SYSMO to PCU_IF_FLAG_DIRECT_PHY
The PCUIF flag PCU_IF_FLAG_SYSMO was originally used by osmo-bts-sysmo
to signal to the PCU that the direct PHY access for the sysmo-bts DSP
should be enabled. With time, support for other BTS models was added and
the flag became a synonym for "direct PHY access", so it makes sense to
rename it to "PCU_IF_FLAG_DIRECT_PHY"
Related: OS#6191
Change-Id: I29b7b78a3a91d062b9ea3cd72623d30618cd3f0b
---
M include/osmocom/pcu/pcuif_proto.h
M src/pcu_l1_if.cpp
2 files changed, 20 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/34582/1
diff --git a/include/osmocom/pcu/pcuif_proto.h b/include/osmocom/pcu/pcuif_proto.h
index cd2a298..9df85d9 100644
--- a/include/osmocom/pcu/pcuif_proto.h
+++ b/include/osmocom/pcu/pcuif_proto.h
@@ -46,7 +46,7 @@
/* flags */
#define PCU_IF_FLAG_ACTIVE (1 << 0)/* BTS is active */
-#define PCU_IF_FLAG_SYSMO (1 << 1)/* access PDCH of sysmoBTS directly */
+#define PCU_IF_FLAG_DIRECT_PHY (1 << 1)/* access PHY directly via dedicated hardware support */
#define PCU_IF_FLAG_CS1 (1 << 16)
#define PCU_IF_FLAG_CS2 (1 << 17)
#define PCU_IF_FLAG_CS3 (1 << 18)
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 4af6953..4fcec31 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -941,7 +941,7 @@
for (trx_nr = 0; trx_nr < ARRAY_SIZE(bts->trx); trx_nr++) {
bts->trx[trx_nr].arfcn = info_ind->trx[trx_nr].arfcn;
- if ((info_ind->flags & PCU_IF_FLAG_SYSMO)
+ if ((info_ind->flags & PCU_IF_FLAG_DIRECT_PHY)
&& info_ind->trx[trx_nr].hlayer1) {
#ifdef ENABLE_DIRECT_PHY
LOGP(DL1IF, LOGL_DEBUG, " TRX %d hlayer1=%x\n", trx_nr,
@@ -972,7 +972,7 @@
if (!pdch->is_enabled()) {
#ifdef ENABLE_DIRECT_PHY
if ((info_ind->flags &
- PCU_IF_FLAG_SYSMO))
+ PCU_IF_FLAG_DIRECT_PHY))
l1if_connect_pdch(
bts->trx[trx_nr].fl1h, ts_nr);
#endif
@@ -1003,7 +1003,7 @@
} else {
if (pdch->is_enabled()) {
#ifdef ENABLE_DIRECT_PHY
- if ((info_ind->flags & PCU_IF_FLAG_SYSMO))
+ if ((info_ind->flags & PCU_IF_FLAG_DIRECT_PHY))
l1if_disconnect_pdch(bts->trx[trx_nr].fl1h, ts_nr);
#endif
pcu_tx_act_req(bts, pdch, 0);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34582?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I29b7b78a3a91d062b9ea3cd72623d30618cd3f0b
Gerrit-Change-Number: 34582
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: daniel.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34577?usp=email )
Change subject: osmo_io: Only allow reading/writing if the relevant callback is set
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34577?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I11ce072510b591f7881d09888524426579bd0169
Gerrit-Change-Number: 34577
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Sep 2023 12:57:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34581?usp=email )
Change subject: Increase RR scheduler priority to 20, to avoid dropped bursts
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Is there any other process in sysmobts really running between rt_prio 11 and 20? Is this really make stuff change?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34581?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2394e6bbc00a1d47987dbe7b70f4b5cbedf69b10
Gerrit-Change-Number: 34581
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 29 Sep 2023 12:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment