September 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: abis_nm: parse feature flags in NM_ATT_IPACC_SUPP_FEATURES
by fixeria 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34323?usp=email ) Change subject: abis_nm: parse feature flags in NM_ATT_IPACC_SUPP_FEATURES ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I64cffa0bdead3617cc169c83b0f6ddf74f0866a7 Gerrit-Change-Number: 34323 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 17:28:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: bts_siemens_bs11: remove ip.access nanoBTS specific code
by fixeria 06 Sep '23

06 Sep '23

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email ) Change subject: bts_siemens_bs11: remove ip.access nanoBTS specific code ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bts_siemens_bs11.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34321/comment/06ae5859_7e4235e6 PS1, Line 466: GSM_BTS_TYPE_BS11 > you can also remove that check here in a similar manner. […] Done. I also confirmed that `nm_reconfig_bts()` is called upon receiving a signal, but the calling function `inp_sig_cb()` does check if `bts->type == GSM_BTS_TYPE_BS11`. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 Gerrit-Change-Number: 34321 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 17:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: abis_nm: separate parsing of osmo-bts features into a function
by fixeria 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34322?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: abis_nm: separate parsing of osmo-bts features into a function ...................................................................... abis_nm: separate parsing of osmo-bts features into a function This commit prepares for adding handling of additional attributes. The parse_attr_resp_info_attr() is already quite complex, so take a chance to simplify it a bit. Change-Id: Ia5919a8311cd6a7fc16d02d2196276881e96f4c5 --- M src/osmo-bsc/abis_nm.c 1 file changed, 61 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/22/34322/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34322?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia5919a8311cd6a7fc16d02d2196276881e96f4c5 Gerrit-Change-Number: 34322 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: bts_siemens_bs11: remove ip.access nanoBTS specific code
by fixeria 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: bts_siemens_bs11: remove ip.access nanoBTS specific code ...................................................................... bts_siemens_bs11: remove ip.access nanoBTS specific code This code is unreachable, because this file is all about Siemens BS11. Take a chance to remove redundant BTS type check in nm_reconfig_bts(). Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 --- M src/osmo-bsc/bts_siemens_bs11.c 1 file changed, 40 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/21/34321/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 Gerrit-Change-Number: 34321 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: bsc: Make socket queue max. length configurable
by pespin 06 Sep '23

06 Sep '23

Attention is currently required from: arehbein, dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email ) Change subject: bsc: Make socket queue max. length configurable ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b Gerrit-Change-Number: 33892 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 17:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: bsc: Make socket queue max. length configurable
by pespin 06 Sep '23

06 Sep '23

Attention is currently required from: arehbein, dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email ) Change subject: bsc: Make socket queue max. length configurable ...................................................................... Patch Set 5: (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/f1b86fe0_b6ddb256 PS4, Line 2486: net->pcu_state->upqueue.max_length = net->pcu_sock_wqueue_len_max; > use wqueue API which internally drops enqueued messages > max This API doesn't actually exist, so nevermind. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b Gerrit-Change-Number: 33892 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 17:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: bsc: Make socket queue max. length configurable
by arehbein 06 Sep '23

06 Sep '23

Attention is currently required from: dexter, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email ) Change subject: bsc: Make socket queue max. length configurable ...................................................................... Patch Set 5: (2 comments) This change is ready for review. Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/d745a971_59b85740 PS4, Line 7: bsc (WIP): Make socket queue max. length configurable > is the patch WIP? then it should be marked WIP in gerrit, imho. […] Done Patchset: PS2: > I think the problem is that you are storing the config value directly in the wqueue, and then when i […] The extra field is `net->pcu_sock_wqueue_len_max`, I wasn't storing it -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b Gerrit-Change-Number: 33892 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 17:08:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: fix commandline option -a (verify_adm)
by dexter 06 Sep '23

06 Sep '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34325?usp=email ) Change subject: pySim-shell: fix commandline option -a (verify_adm) ...................................................................... pySim-shell: fix commandline option -a (verify_adm) The commandline option -a, which does an ADM verification on startup, does no longer work since the verify_adm method is no longer available in the card base classes (cards.py). Let's use the verify_chv method from SimCardCommands instead. Related: RT#68294 Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c --- M pySim-shell.py 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/pySim-shell.py b/pySim-shell.py index af7dbca..c7b2607 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1049,7 +1049,7 @@ if not card: print("Card error, cannot do ADM verification with supplied ADM pin now.") try: - card.verify_adm(h2b(pin_adm)) + card._scc.verify_chv(card._adm_chv_num, h2b(pin_adm)) except Exception as e: print(e) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34325?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c Gerrit-Change-Number: 34325 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: pySim-shell: fix commandline option -a (verify_adm)
by fixeria 06 Sep '23

06 Sep '23

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34325?usp=email ) Change subject: pySim-shell: fix commandline option -a (verify_adm) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34325?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c Gerrit-Change-Number: 34325 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 14:03:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: abis_nm: separate parsing of osmo-bts features into a function
by laforge 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34322?usp=email ) Change subject: abis_nm: separate parsing of osmo-bts features into a function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34322?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia5919a8311cd6a7fc16d02d2196276881e96f4c5 Gerrit-Change-Number: 34322 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:46:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0