September 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: sim-reset-server: fix error printing sw_match_error
by dexter 06 Sep '23

06 Sep '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34155?usp=email ) Change subject: sim-reset-server: fix error printing sw_match_error ...................................................................... sim-reset-server: fix error printing sw_match_error In the last line of the if,elif,else branch, when we print the ApiError object, we pass the variable sw to str() instead passing it to ApiError() like we do it in the lines above. This is not correct and causes strange exceptions. Related: OS#67094 Change-Id: I5a1d19abeb00c2c9dc26517abc44a5c916f2d658 --- M contrib/sim-rest-server.py 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/sim-rest-server.py b/contrib/sim-rest-server.py index 83fb377..fc8afd9 100755 --- a/contrib/sim-rest-server.py +++ b/contrib/sim-rest-server.py @@ -101,7 +101,7 @@ elif sw == '6982': return str(ApiError("Security Status not satisfied - Card PIN enabled?", sw)) else: - return str(ApiError("Card Communication Error %s" % failure.value), sw) + return str(ApiError("Card Communication Error %s" % failure.value, sw)) @app.route('/sim-auth-api/v1/slot/<int:slot>') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a1d19abeb00c2c9dc26517abc44a5c916f2d658 Gerrit-Change-Number: 34155 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: Introduce new error scenario tests
by pespin 06 Sep '23

06 Sep '23

Attention is currently required from: daniel, fixeria, lynxis lazus, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email ) Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... Patch Set 2: (1 comment) File dia2gsup/DIA2GSUP_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/e250cbd3_4687… PS2, Line 249: 2 > add the GSUP cause enum to ttcn3 as well? We should not be investing more time than strictly necessary on this, so I'd merge it as it is. The GMM error cause is known from the number as well as the test name, so I'd go for merging as is. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Sep 2023 11:59:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: sim-reset-server: fix error printing sw_match_error
by osmith 06 Sep '23

06 Sep '23

Attention is currently required from: dexter, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34155?usp=email ) Change subject: sim-reset-server: fix error printing sw_match_error ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a1d19abeb00c2c9dc26517abc44a5c916f2d658 Gerrit-Change-Number: 34155 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 11:59:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: Introduce new error scenario tests
by osmith 06 Sep '23

06 Sep '23

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email ) Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... Patch Set 2: (2 comments) File dia2gsup/DIA2GSUP_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/38bebbb7_1a89… PS2, Line 249: 2 add the GSUP cause enum to ttcn3 as well? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/4cdc95a8_3288… PS2, Line 266: var D2G_ConnHdlr vc_conn; IMHO new lines between var blocks and f_init() would make this more readable -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Sep 2023 11:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: sim-reset-server: fix error printing sw_match_error
by fixeria 06 Sep '23

06 Sep '23

Attention is currently required from: dexter, laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34155?usp=email ) Change subject: sim-reset-server: fix error printing sw_match_error ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File contrib/sim-rest-server.py: https://gerrit.osmocom.org/c/pysim/+/34155/comment/bd1ea930_8ef50249 PS1, Line 104: failure.value > I think there is presumably a problem in the stuff that gets called by the __str__ method in the Api […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a1d19abeb00c2c9dc26517abc44a5c916f2d658 Gerrit-Change-Number: 34155 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 11:49:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule
by pespin 06 Sep '23

06 Sep '23

Attention is currently required from: Hoernchen, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33561?usp=email ) Change subject: ms: update osmocom-bb submodule ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5e1a5f385e7d5e041142e665181d68ad5bb22230 Gerrit-Change-Number: 33561 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 06 Sep 2023 11:45:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule
by pespin 06 Sep '23

06 Sep '23

Attention is currently required from: Hoernchen, laforge. pespin has uploaded a new patch set (#5) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-trx/+/33561?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: ms: update osmocom-bb submodule ...................................................................... ms: update osmocom-bb submodule Change-Id: I5e1a5f385e7d5e041142e665181d68ad5bb22230 --- M osmocom-bb 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/61/33561/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5e1a5f385e7d5e041142e665181d68ad5bb22230 Gerrit-Change-Number: 33561 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-trx[master]: ms: logging: print category, level, and extended timestamp
by pespin 06 Sep '23

06 Sep '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34320?usp=email ) Change subject: ms: logging: print category, level, and extended timestamp ...................................................................... ms: logging: print category, level, and extended timestamp Change-Id: I14da3c9e77681268e4f575a6ca7220eedbf2a7a5 Related: osmocom-bb.git Ie3d259f3255d8af80e6780f850b808fa243f97b4 --- M Transceiver52M/ms/ms_upper.cpp 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/Transceiver52M/ms/ms_upper.cpp b/Transceiver52M/ms/ms_upper.cpp index b161f4a..63c222f 100644 --- a/Transceiver52M/ms/ms_upper.cpp +++ b/Transceiver52M/ms/ms_upper.cpp @@ -35,7 +35,9 @@ #include "convolve.h" #include "convert.h" +#include <osmocom/core/application.h> #include <osmocom/gsm/gsm_utils.h> + #include <osmocom/bb/trxcon/trxcon.h> #include <osmocom/bb/trxcon/trxcon_fsm.h> #include <osmocom/bb/trxcon/l1ctl_server.h> @@ -424,6 +426,17 @@ msgb_talloc_ctx_init(tall_trxcon_ctx, 0); trxc_log_init(tall_trxcon_ctx); + /* Configure pretty logging */ + log_set_print_extended_timestamp(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, 0); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_level(osmo_stderr_target, 1); + + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_BASENAME); + log_set_print_filename_pos(osmo_stderr_target, LOG_FILENAME_POS_LINE_END); + + osmo_fsm_log_timeouts(true); + g_trxcon = trxcon_inst_alloc(tall_trxcon_ctx, 0); g_trxcon->gsmtap = nullptr; g_trxcon->phyif = nullptr; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I14da3c9e77681268e4f575a6ca7220eedbf2a7a5 Gerrit-Change-Number: 34320 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-trx[master]: ms: logging: print category, level, and extended timestamp
by pespin 06 Sep '23

06 Sep '23

Attention is currently required from: Hoernchen, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34320?usp=email ) Change subject: ms: logging: print category, level, and extended timestamp ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging now since it's going to do my life easier debugging the test setup. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I14da3c9e77681268e4f575a6ca7220eedbf2a7a5 Gerrit-Change-Number: 34320 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 11:43:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: struct gsm_bts_trx[_ts], gsm_abis_mo: drop unused nm_attr
by pespin 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34324?usp=email ) Change subject: struct gsm_bts_trx[_ts], gsm_abis_mo: drop unused nm_attr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I36c3aaefa0bd9ee946a53ed537cf5c3bd7e9761e Gerrit-Change-Number: 34324 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 11:35:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0