September 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: bts_siemens_bs11: remove ip.access nanoBTS specific code
by laforge 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: bts_siemens_bs11: remove ip.access nanoBTS specific code ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 Gerrit-Change-Number: 34321 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:46:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: bts_siemens_bs11: remove ip.access nanoBTS specific code
by laforge 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email ) Change subject: bts_siemens_bs11: remove ip.access nanoBTS specific code ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_siemens_bs11.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34321/comment/bb23f193_f8a8572f PS1, Line 466: GSM_BTS_TYPE_BS11 you can also remove that check here in a similar manner. I think the real cause of this is that we used to do this upon receiving a signal. And that signal would get sent to all of the BTS models/drivers, and each signal handler had to make sure it only cares about its matching BTSs. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 Gerrit-Change-Number: 34321 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:46:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: bts_siemens_bs11: remove ip.access nanoBTS specific code
by laforge 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email ) Change subject: bts_siemens_bs11: remove ip.access nanoBTS specific code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 Gerrit-Change-Number: 34321 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:44:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule
by laforge 06 Sep '23

06 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33561?usp=email ) Change subject: ms: update osmocom-bb submodule ...................................................................... ms: update osmocom-bb submodule Change-Id: I5e1a5f385e7d5e041142e665181d68ad5bb22230 --- M osmocom-bb 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/osmocom-bb b/osmocom-bb index 096a3cc..05ddc05 160000 --- a/osmocom-bb +++ b/osmocom-bb @@ -1 +1 @@ -Subproject commit 096a3cc6f3e982df09836b70a5adcd57a4b93ab9 +Subproject commit 05ddc05233100236d93c1268a1d851b14efc6fca -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5e1a5f385e7d5e041142e665181d68ad5bb22230 Gerrit-Change-Number: 33561 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: pySim-shell: fix commandline option -a (verify_adm)
by laforge 06 Sep '23

06 Sep '23

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34325?usp=email ) Change subject: pySim-shell: fix commandline option -a (verify_adm) ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > (FYI: We had a similar problem before, see also: Ic87e1bff221b10d33d36da32b589e2737f6ca9cd) well, all this tells me is that there is a lack of test coverage. We should add something to our test scripts to make sure we test that command line option during the pysim tester execution. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34325?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c Gerrit-Change-Number: 34325 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:43:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: fix commandline option -a (verify_adm)
by dexter 06 Sep '23

06 Sep '23

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34325?usp=email ) Change subject: pySim-shell: fix commandline option -a (verify_adm) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: (FYI: We had a similar problem before, see also: Ic87e1bff221b10d33d36da32b589e2737f6ca9cd) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34325?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c Gerrit-Change-Number: 34325 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:11:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: fix commandline option -a (verify_adm)
by dexter 06 Sep '23

06 Sep '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34325?usp=email ) Change subject: pySim-shell: fix commandline option -a (verify_adm) ...................................................................... pySim-shell: fix commandline option -a (verify_adm) The commandline option -a, which does an ADM verification on startup, does no longer work since the verify_adm method is no longer available in the card base classes (cards.py). Let's use the verify_chv method from SimCardCommands instead. Related: RT#68294 Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c --- M pySim-shell.py 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/34325/1 diff --git a/pySim-shell.py b/pySim-shell.py index af7dbca..c7b2607 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1049,7 +1049,7 @@ if not card: print("Card error, cannot do ADM verification with supplied ADM pin now.") try: - card.verify_adm(h2b(pin_adm)) + card._scc.verify_chv(card._adm_chv_num, h2b(pin_adm)) except Exception as e: print(e) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34325?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic1e54d0e9e722d64b3fbeb044134044d47946f7c Gerrit-Change-Number: 34325 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: Introduce new error scenario tests
by pespin 06 Sep '23

06 Sep '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email ) Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... dia2gsup: Introduce new error scenario tests Related: OS#5757 Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea --- M dia2gsup/DIA2GSUP_Tests.ttcn M library/DIAMETER_Templates.ttcn 2 files changed, 234 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/dia2gsup/DIA2GSUP_Tests.ttcn b/dia2gsup/DIA2GSUP_Tests.ttcn index 6a3f85c..673038c 100644 --- a/dia2gsup/DIA2GSUP_Tests.ttcn +++ b/dia2gsup/DIA2GSUP_Tests.ttcn @@ -214,8 +214,145 @@ setverdict(pass); } +private function f_DIA_AI_gsup_error(integer gsup_cause, template (present) GenericAVP err_avp) runs on D2G_ConnHdlr { + var PDU_DIAMETER rx_dia; + var UINT32 hbh_id := f_rnd_octstring(4); + var UINT32 ete_id := f_rnd_octstring(4); + var octetstring sess_id := char2oct("foobar"); + var OCT3 vplmn := '00F110'O; + + /* Unlike AIR, AIA contains no IMSI. Register ete_id in DIAMETER_Emulation, + * so AIA is forwarded back to us in DIAMETER port instead of MTC_CT.DIAMETER_UNIT. + */ + f_diameter_expect_eteid(ete_id); + + /* Send AIR to translator; expect it to show up on GSUP side */ + DIAMETER.send(ts_DIA_AIR(g_pars.imsi, vplmn, sess_id, hbh_id := hbh_id, ete_id := ete_id)); + GSUP.receive(tr_GSUP_SAI_REQ(g_pars.imsi)); + + /* Send an error response back to the translator; expect AIA */ + GSUP.send(ts_GSUP_SAI_ERR(g_pars.imsi, gsup_cause)); + + alt { + /* Unlike AIR, AIA contains no IMSI, hence it is received in DIAMETER_UNIT: */ + [] DIAMETER.receive(tr_DIA_AIA_ERR(err_avp)) { + setverdict(pass); + } + [] DIAMETER.receive(PDU_DIAMETER:?) -> value rx_dia { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected Diameter msg rx: ", rx_dia)); + } + } +} + +private function f_TC_authinfo_gsup_err_imsi_unknown(charstring id) runs on D2G_ConnHdlr { + var DIAMETER_ExperimentalResultcode res_code := DIAMETER_ERROR_USER_UNKNOWN; + f_DIA_AI_gsup_error(2, tr_AVP_ExperimentalResult(vendor_id_3GPP, int2oct(enum2int(res_code), 4))); +} +testcase TC_authinfo_gsup_err_imsi_unknown() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_imsi_unknown), pars); + vc_conn.done; + setverdict(pass); +} + +private function f_TC_authinfo_gsup_err_illegal_ms(charstring id) runs on D2G_ConnHdlr { + var DIAMETER_ExperimentalResultcode res_code := DIAMETER_ERROR_USER_UNKNOWN; + f_DIA_AI_gsup_error(3, tr_AVP_ExperimentalResult(vendor_id_3GPP, int2oct(enum2int(res_code), 4))); +} +testcase TC_authinfo_gsup_err_illegal_ms() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_illegal_ms), pars); + vc_conn.done; + setverdict(pass); +} + +private function f_TC_authinfo_gsup_err_plmn_not_allowed(charstring id) runs on D2G_ConnHdlr { + f_DIA_AI_gsup_error(11, tr_AVP_ResultCode(DIAMETER_UNABLE_TO_COMPLY)); +} +testcase TC_authinfo_gsup_err_plmn_not_allowed() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_plmn_not_allowed), pars); + vc_conn.done; + setverdict(pass); +} + +private function f_TC_authinfo_gsup_err_romaning_not_allowed(charstring id) runs on D2G_ConnHdlr { + var DIAMETER_ExperimentalResultcode res_code := DIAMETER_ERROR_ROAMING_NOT_ALLOWED; + f_DIA_AI_gsup_error(12, tr_AVP_ExperimentalResult(vendor_id_3GPP, int2oct(enum2int(res_code), 4))); +} +testcase TC_authinfo_gsup_err_romaning_not_allowed() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_romaning_not_allowed), pars); + vc_conn.done; + setverdict(pass); +} + +private function f_TC_authinfo_gsup_err_net_fail(charstring id) runs on D2G_ConnHdlr { + f_DIA_AI_gsup_error(17, tr_AVP_ResultCode(DIAMETER_UNABLE_TO_COMPLY)); +} +testcase TC_authinfo_gsup_err_net_fail() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_net_fail), pars); + vc_conn.done; + setverdict(pass); +} + +private function f_TC_authinfo_gsup_err_congestion(charstring id) runs on D2G_ConnHdlr { + f_DIA_AI_gsup_error(22, tr_AVP_ResultCode(DIAMETER_UNABLE_TO_COMPLY)); +} +testcase TC_authinfo_gsup_err_congestion() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_congestion), pars); + vc_conn.done; + setverdict(pass); +} + +private function f_TC_authinfo_gsup_err_auth_unacceptable(charstring id) runs on D2G_ConnHdlr { + f_DIA_AI_gsup_error(23, tr_AVP_ResultCode(DIAMETER_UNABLE_TO_COMPLY)); +} +testcase TC_authinfo_gsup_err_auth_unacceptable() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_auth_unacceptable), pars); + vc_conn.done; + setverdict(pass); +} + +private function f_TC_authinfo_gsup_err_proto_unspec(charstring id) runs on D2G_ConnHdlr { + f_DIA_AI_gsup_error(23, tr_AVP_ResultCode(DIAMETER_UNABLE_TO_COMPLY)); +} +testcase TC_authinfo_gsup_err_proto_unspec() runs on MTC_CT { + var D2G_ConnHdlrPars pars := f_init_pars(); + var D2G_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_gsup_err_proto_unspec), pars); + vc_conn.done; + setverdict(pass); +} + control { execute ( TC_authinfo_normal() ); + execute ( TC_authinfo_gsup_err_imsi_unknown() ); + execute ( TC_authinfo_gsup_err_illegal_ms() ); + execute ( TC_authinfo_gsup_err_plmn_not_allowed() ); + execute ( TC_authinfo_gsup_err_romaning_not_allowed() ); + execute ( TC_authinfo_gsup_err_net_fail() ); + execute ( TC_authinfo_gsup_err_congestion() ); + execute ( TC_authinfo_gsup_err_auth_unacceptable() ); + execute ( TC_authinfo_gsup_err_proto_unspec() ); } } diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 63db7fc..8bb53e0 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -101,6 +101,22 @@ DIAMETER_ERROR_EAP_CODE_UNKNOWN (5048) }; +/* 3GPP TS 29.272 section 7.4. Errors in Experimental-Result-Code */ +type enumerated DIAMETER_ExperimentalResultcode { + /* transient */ + DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE (4181), + DIAMETER_ERROR_CAMEL_SUBSCRIPTION_PRESENT (4182), + /* permanent */ + DIAMETER_ERROR_USER_UNKNOWN (5001), + DIAMETER_AUTHORIZATION_REJECTED (5003), + DIAMETER_ERROR_ROAMING_NOT_ALLOWED (5004), + DIAMETER_MISSING_AVP (5005), + DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION (5420), + DIAMETER_ERROR_RAT_NOT_ALLOWED (5421), + DIAMETER_ERROR_EQUIPMENT_UNKNOWN (5422), + DIAMETER_ERROR_UNKOWN_SERVING_NODE (5423) +} + /* Gy : 3GPP TS 32.299 7.1.6, RFC4006 3.1 */ const uint32_t c_DIAMETER_CREDIT_CONTROL_AID := 4; /* 3GPP TS 29.272 Section 7.1.8 */ @@ -338,6 +354,24 @@ } } } +private function f_tr_AVP_VendorId(template (present) Vendor_Id vendor_id) +return template (present) BASE_NONE_Vendor_Id { + if (istemplatekind(vendor_id, "?")) { + return ?; + } else { + var template (present) BASE_NONE_Vendor_Id c; + c := int2oct(enum2int(valueof(vendor_id)), 4); + return c; + } +} +template (present) GenericAVP tr_AVP_VendorId(template (present) Vendor_Id vendor_id) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Vendor_Id), + avp_data := { + avp_BASE_NONE_Vendor_Id := f_tr_AVP_VendorId(vendor_id) + } + } +} template (value) GenericAVP ts_AVP_ProductName(charstring name) := { avp := { @@ -451,6 +485,28 @@ } } +template (present) GenericAVP tr_AVP_ExperimentalResultCode(template (present) AVP_Unsigned32 n := ?) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Experimental_Result_Code), + avp_data := { + avp_BASE_NONE_Experimental_Result_Code := n + } + } +} + +template (present) GenericAVP tr_AVP_ExperimentalResult(template (present) Vendor_Id vendor_id := ?, + template (present) AVP_Unsigned32 err_code := ? + ) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Experimental_Result), + avp_data := { + avp_BASE_NONE_Experimental_Result := { + tr_AVP_VendorId(vendor_id), + tr_AVP_ExperimentalResultCode(err_code) + } + } + } +} template (value) GenericAVP ts_AVP_SuppVendorIdRaw(uint32_t vendor_id) := { avp := { @@ -471,11 +527,21 @@ } } } -template (present) GenericAVP tr_AVP_ResultCode(DIAMETER_Resultcode res_code) := { +private function f_tr_DIAMETER_Resultcode(template (present) DIAMETER_Resultcode res_code) +return template (present) BASE_NONE_Result_Code { + if (istemplatekind(res_code, "?")) { + return ?; + } else { + var template (present) BASE_NONE_Result_Code c; + c := int2oct(enum2int(valueof(res_code)), 4); + return c; + } +} +template (present) GenericAVP tr_AVP_ResultCode(template (present) DIAMETER_Resultcode res_code) := { avp := { avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Result_Code), avp_data := { - avp_BASE_NONE_Result_Code := int2oct(enum2int(res_code), 4) + avp_BASE_NONE_Result_Code := f_tr_DIAMETER_Resultcode(res_code) } } } @@ -1414,6 +1480,25 @@ tr_AVP_ResultCode(DIAMETER_SUCCESS), tr_AVP_3GPP_AuthInfo(auth_info_contents) )); +template (present) PDU_DIAMETER +tr_DIA_AIA_ERR(template (present) GenericAVP err_avp := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_AuthSessionState(NO_STATE_MAINTAINED), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + err_avp + )); /* TS 29.272 7.2.3 Update Location Request */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: Introduce new error scenario tests
by osmith 06 Sep '23

06 Sep '23

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email ) Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... Patch Set 2: (2 comments) File dia2gsup/DIA2GSUP_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/53428b8a_cd43… PS2, Line 249: 2 > We should not be investing more time than strictly necessary on this, so I'd merge it as it is. […] Ack https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/ef869de0_1e66… PS2, Line 266: var D2G_ConnHdlr vc_conn; > IMHO new lines between var blocks and f_init() would make this more readable resolving -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Sep 2023 12:01:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: Introduce new error scenario tests
by osmith 06 Sep '23

06 Sep '23

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email ) Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Sep 2023 12:00:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0