Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email ) Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... Patch Set 2: (2 comments) File dia2gsup/DIA2GSUP_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/53428b8a_cd435... PS2, Line 249: 2

We should not be investing more time than strictly necessary on this, so I'd merge it as it is. […] Ack

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/ef869de0_1e662... PS2, Line 266: var D2G_ConnHdlr vc_conn;

IMHO new lines between var blocks and f_init() would make this more readable resolving

-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 06 Sep 2023 12:01:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment