pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email )
Change subject: LAPDM: Use correct offset to short header on recevied frame
......................................................................
LAPDM: Use correct offset to short header on recevied frame
The offset of the short header on main DCCH is 0, not 2.
Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc
---
M src/gsm/lapdm.c
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c
index 9f795c6..86dc242 100644
--- a/src/gsm/lapdm.c
+++ b/src/gsm/lapdm.c
@@ -754,7 +754,7 @@
msg->l2h += 2;
} else {
/* A Short L3 header has both bits == 0. */
- if (LAPDm_ADDR_SHORT_L2(msg->l2h[2]) == 0) {
+ if (LAPDm_ADDR_SHORT_L2(msg->l2h[0]) == 0) {
mctx.lapdm_fmt = LAPDm_FMT_Bter;
n201 = N201_Bter_SDCCH;
sapi = 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc
Gerrit-Change-Number: 34362
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email )
Change subject: ASCI: Add BCC call state definitions
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gsm/protocol/gsm_44_068.h:
https://gerrit.osmocom.org/c/libosmocore/+/34361/comment/929591d5_e5ede9f2
PS1, Line 69: OSMO_GSM44068_CSTATE_U2sl_U2
> So, you're changing public API here. […]
There is no API user except for osmocom-bb implementation of voice group calls, which is not yet released.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2180b43b940542565188f52c554c960858fe2a95
Gerrit-Change-Number: 34361
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Sep 2023 10:40:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment