Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email )
Change subject: tbf_dl_fsm: Fix assert hit due to EV_MAX_N3105 received in ST_RELEASING
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/tbf_dl_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/34425/comment/47a55147_d902265e
PS1, Line 314: tbf_dl_fsm_state_chg
> missing `break`, so the flow still reaches `OSMO_ASSERT(0)`
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I27e61dc4b3396360327dcd377d171daa30684d23
Gerrit-Change-Number: 34425
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Sep 2023 22:09:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by fixeria, Verified+1 by Jenkins Builder
Change subject: tbf_dl_fsm: Fix assert hit due to EV_MAX_N3105 received in ST_RELEASING
......................................................................
tbf_dl_fsm: Fix assert hit due to EV_MAX_N3105 received in ST_RELEASING
That code path was incorrectly removed a few commits back, re-add it.
Fixes: 40a297f3b0c8e1670d46a4974750dd3335bc7885
Change-Id: I27e61dc4b3396360327dcd377d171daa30684d23
---
M src/tbf_dl_fsm.c
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/25/34425/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I27e61dc4b3396360327dcd377d171daa30684d23
Gerrit-Change-Number: 34425
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34428?usp=email )
Change subject: gsm_12_21.h: add NM_IPAC_MASK_* macros for convenience
......................................................................
Abandoned
It's better to define these macros in osmo-bts.git where they needed
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34428?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic05d3fef8fc70970568c5c0966f9e77251b7f46d
Gerrit-Change-Number: 34428
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: abandon
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/34428?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: gsm_12_21.h: add NM_IPAC_MASK_* macros for convenience
......................................................................
gsm_12_21.h: add NM_IPAC_MASK_* macros for convenience
Change-Id: Ic05d3fef8fc70970568c5c0966f9e77251b7f46d
Related: OS#4505
---
M include/osmocom/gsm/protocol/gsm_12_21.h
1 file changed, 58 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/28/34428/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34428?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic05d3fef8fc70970568c5c0966f9e77251b7f46d
Gerrit-Change-Number: 34428
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email )
Change subject: tbf_dl_fsm: Fix assert hit due to EV_MAX_N3105 received in ST_RELEASING
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/tbf_dl_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/34425/comment/b7ac7c1f_b6367f2b
PS1, Line 314: tbf_dl_fsm_state_chg
missing `break`, so the flow still reaches `OSMO_ASSERT(0)`
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I27e61dc4b3396360327dcd377d171daa30684d23
Gerrit-Change-Number: 34425
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Sep 2023 19:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34426?usp=email )
Change subject: tbf: Log poll timeout reason
......................................................................
tbf: Log poll timeout reason
Change-Id: Ie0339b55e6d617a3e788972c3b226eef64124d2b
---
M src/tbf.cpp
M tests/tbf/TbfTest.err
2 files changed, 41 insertions(+), 31 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/26/34426/1
diff --git a/src/tbf.cpp b/src/tbf.cpp
index b708d73..840a1f7 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -484,8 +484,9 @@
gprs_rlcmac_ul_tbf *ul_tbf;
gprs_rlcmac_dl_tbf *dl_tbf;
- LOGPTBF(this, LOGL_NOTICE, "poll timeout for FN=%d, TS=%d (curr FN %d)\n",
- poll_fn, pdch->ts_no, bts_current_frame_number(bts));
+ LOGPTBF(this, LOGL_NOTICE, "poll timeout for FN=%d, TS=%d (curr FN %d), reason=%s\n",
+ poll_fn, pdch->ts_no, bts_current_frame_number(bts),
+ get_value_string(pdch_ulc_tbf_poll_reason_names, reason));
switch (reason) {
case PDCH_ULC_POLL_UL_ACK:
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index 02cefe2..42ce499 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -2703,7 +2703,7 @@
PDCH(bts=0,trx=0,ts=7) Timeout for registered USF (FN=2654283): TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW}
TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} N3101 1 => 2 (< MAX 10)
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654292, reason=DL_ACK): TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}
-TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} poll timeout for FN=2654292, TS=7 (curr FN 2654292)
+TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} poll timeout for FN=2654292, TS=7 (curr FN 2654292), reason=DL_ACK
TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on PACCH|No downlink ACK received yet|
TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}: Received Event DL_ACKNACK_MISS
@@ -2772,7 +2772,7 @@
TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} N3101 2 => 3 (< MAX 10)
PDCH(bts=0,trx=0,ts=7) Expiring FN=2654348 but previous FN=2654309 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654309, reason=DL_ACK): TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}
-TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} poll timeout for FN=2654309, TS=7 (curr FN 2654348)
+TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} poll timeout for FN=2654309, TS=7 (curr FN 2654348), reason=DL_ACK
TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on PACCH|No downlink ACK received yet|
TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}: Received Event DL_ACKNACK_MISS
@@ -4100,7 +4100,7 @@
PDCH(bts=0,trx=0,ts=7) Timeout for registered USF (FN=2654374): TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){RELEASING}
TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){RELEASING} N3101 22 => 23 (< MAX 10)
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654379, reason=DL_ACK): TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}
-TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} poll timeout for FN=2654379, TS=7 (curr FN 2654379)
+TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} poll timeout for FN=2654379, TS=7 (curr FN 2654379), reason=DL_ACK
TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on PACCH|No downlink ACK received yet|
TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FINISHED}: Received Event DL_ACKNACK_MISS
@@ -5173,18 +5173,18 @@
Detected FN jump! 4 -> 169 (expected 8, delta 165)
PDCH(bts=0,trx=0,ts=4) Expiring FN=169 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=169 but previous FN=99 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=99, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=99, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=99, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=169 but previous FN=117 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=117, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=117, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=117, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 2 => 3 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -5453,13 +5453,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 20, MCS-2): 0f 00 05 12 6f 86 80 03 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 00
PDCH(bts=0,trx=0,ts=4) Expiring FN=147 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=147 but previous FN=95 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=95, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=95, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=95, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -5688,13 +5688,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 15, MCS-3): 0f c0 03 06 93 86 80 03 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 00
PDCH(bts=0,trx=0,ts=4) Expiring FN=121 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=121 but previous FN=73 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=73, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=73, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=73, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -5907,13 +5907,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 13, MCS-4): 0f 40 03 00 af 86 80 03 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 56 00
PDCH(bts=0,trx=0,ts=4) Expiring FN=117 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=117 but previous FN=65 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=65, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=65, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=65, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -6110,13 +6110,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 11, MCS-5): 0f c0 02 e8 db 10 70 c0 ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca 0a
PDCH(bts=0,trx=0,ts=4) Expiring FN=108 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=108 but previous FN=56 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=56, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=56, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=56, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -6289,13 +6289,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 8, MCS-6): 0f 00 02 e0 e4 10 70 c0 ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca 0a
PDCH(bts=0,trx=0,ts=4) Expiring FN=95 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=95 but previous FN=43 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=43, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=43, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=43, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -6478,13 +6478,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 11, MCS-5): 0f c0 02 e8 db 10 70 c0 ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca 0a
PDCH(bts=0,trx=0,ts=4) Expiring FN=91 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=91 but previous FN=39 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=39, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=39, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=39, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -6659,13 +6659,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 9, MCS-8): 0f 40 02 00 60 1e 0e 01 07 ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac ac 78 38 04 1c b0 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 b2 02
PDCH(bts=0,trx=0,ts=4) Expiring FN=82 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=82 but previous FN=34 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=34, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=34, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=34, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -6828,13 +6828,13 @@
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} msg block (BSN 8, MCS-6): 0f 00 02 e0 e4 10 70 c0 ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca ca 0a
PDCH(bts=0,trx=0,ts=4) Expiring FN=82 but previous FN=13 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=13, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=13, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} Timeout for polling PACKET DOWNLINK ACK: |Assignment was on CCCH|Downlink ACK was received|
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 0 => 1 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
PDCH(bts=0,trx=0,ts=4) Expiring FN=82 but previous FN=30 is still reserved!
PDCH(bts=0,trx=0,ts=4) Timeout for registered POLL (FN=30, reason=DL_ACK): TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED}
-TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=30, TS=4 (curr FN 169)
+TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} poll timeout for FN=30, TS=4 (curr FN 169), reason=DL_ACK
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} N3105 1 => 2 (< MAX 8)
DL_TBF(DL:TFI-0-0-0:E){FINISHED}: Received Event DL_ACKNACK_MISS
TBF(DL:TFI-0-0-0:E:TLLI-0xffeeddcc){FINISHED} downlink acknowledge
@@ -11044,7 +11044,7 @@
MS(TLLI-0xffeeddcd:TA-7:MSCLS-11-11:UL): - rcv_resource_request: now used by 1 (tbf)
PDCH(bts=0,trx=0,ts=7) Expiring FN=56 but previous FN=2654231 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN}
-TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 56)
+TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 56), reason=UL_ASS
UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_ACK}: Received Event ASS_POLL_TIMEOUT
TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} Timeout for polling PACKET CONTROL ACK for PACKET UPLINK ASSIGNMENT: |Assignment was on PACCH|No uplink data received yet|
UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_ACK}: state_chg to SEND_ASS
@@ -11101,7 +11101,7 @@
MS(TLLI-0xffeeddce:TA-7:MSCLS-11-11:UL): - rcv_resource_request: now used by 1 (tbf)
PDCH(bts=0,trx=0,ts=7) Expiring FN=60 but previous FN=2654231 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN}
-TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 60)
+TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 60), reason=UL_ASS
UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_ACK}: Received Event ASS_POLL_TIMEOUT
TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} Timeout for polling PACKET CONTROL ACK for PACKET UPLINK ASSIGNMENT: |Assignment was on PACCH|No uplink data received yet|
UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_ACK}: state_chg to SEND_ASS
@@ -11158,7 +11158,7 @@
MS(TLLI-0xffeeddcf:TA-7:MSCLS-11-11:UL): - rcv_resource_request: now used by 1 (tbf)
PDCH(bts=0,trx=0,ts=7) Expiring FN=65 but previous FN=2654231 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN}
-TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 65)
+TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 65), reason=UL_ASS
UL_ASS_TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){WAIT_ACK}: Received Event ASS_POLL_TIMEOUT
TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN} Timeout for polling PACKET CONTROL ACK for PACKET UPLINK ASSIGNMENT: |Assignment was on PACCH|No uplink data received yet|
UL_ASS_TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){WAIT_ACK}: state_chg to SEND_ASS
@@ -11215,7 +11215,7 @@
MS(TLLI-0xffeeddd0:TA-7:MSCLS-11-11:UL): - rcv_resource_request: now used by 1 (tbf)
PDCH(bts=0,trx=0,ts=7) Expiring FN=69 but previous FN=2654231 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN}
-TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 69)
+TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 69), reason=UL_ASS
UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_ACK}: Received Event ASS_POLL_TIMEOUT
TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){ASSIGN} Timeout for polling PACKET CONTROL ACK for PACKET UPLINK ASSIGNMENT: |Assignment was on PACCH|No uplink data received yet|
UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xffeeddcc){WAIT_ACK}: state_chg to SEND_ASS
@@ -11272,7 +11272,7 @@
MS(TLLI-0xffeeddd1:TA-7:MSCLS-11-11:UL): - rcv_resource_request: now used by 1 (tbf)
PDCH(bts=0,trx=0,ts=7) Expiring FN=73 but previous FN=2654231 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(UL:TFI-0-0-2:E:TLLI-0xffeeddce){ASSIGN}
-TBF(UL:TFI-0-0-2:E:TLLI-0xffeeddce){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 73)
+TBF(UL:TFI-0-0-2:E:TLLI-0xffeeddce){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 73), reason=UL_ASS
UL_ASS_TBF(UL:TFI-0-0-2:E:TLLI-0xffeeddce){WAIT_ACK}: Received Event ASS_POLL_TIMEOUT
TBF(UL:TFI-0-0-2:E:TLLI-0xffeeddce){ASSIGN} Timeout for polling PACKET CONTROL ACK for PACKET UPLINK ASSIGNMENT: |Assignment was on PACCH|No uplink data received yet|
UL_ASS_TBF(UL:TFI-0-0-2:E:TLLI-0xffeeddce){WAIT_ACK}: state_chg to SEND_ASS
@@ -11329,7 +11329,7 @@
MS(TLLI-0xffeeddd2:TA-7:MSCLS-11-11:UL): - rcv_resource_request: now used by 1 (tbf)
PDCH(bts=0,trx=0,ts=7) Expiring FN=78 but previous FN=2654231 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN}
-TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 78)
+TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 78), reason=UL_ASS
UL_ASS_TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){WAIT_ACK}: Received Event ASS_POLL_TIMEOUT
TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){ASSIGN} Timeout for polling PACKET CONTROL ACK for PACKET UPLINK ASSIGNMENT: |Assignment was on PACCH|No uplink data received yet|
UL_ASS_TBF(UL:TFI-0-0-1:E:TLLI-0xffeeddcd){WAIT_ACK}: state_chg to SEND_ASS
@@ -11382,7 +11382,7 @@
MS(TLLI-0xffeeddd3:TA-7:MSCLS-11-11:UL): - rcv_resource_request: now used by 1 (tbf)
PDCH(bts=0,trx=0,ts=7) Expiring FN=82 but previous FN=2654231 is still reserved!
PDCH(bts=0,trx=0,ts=7) Timeout for registered POLL (FN=2654231, reason=UL_ASS): TBF(UL:TFI-0-0-3:E:TLLI-0xffeeddcf){ASSIGN}
-TBF(UL:TFI-0-0-3:E:TLLI-0xffeeddcf){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 82)
+TBF(UL:TFI-0-0-3:E:TLLI-0xffeeddcf){ASSIGN} poll timeout for FN=2654231, TS=7 (curr FN 82), reason=UL_ASS
UL_ASS_TBF(UL:TFI-0-0-3:E:TLLI-0xffeeddcf){WAIT_ACK}: Received Event ASS_POLL_TIMEOUT
TBF(UL:TFI-0-0-3:E:TLLI-0xffeeddcf){ASSIGN} Timeout for polling PACKET CONTROL ACK for PACKET UPLINK ASSIGNMENT: |Assignment was on PACCH|No uplink data received yet|
UL_ASS_TBF(UL:TFI-0-0-3:E:TLLI-0xffeeddcf){WAIT_ACK}: state_chg to SEND_ASS
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34426?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie0339b55e6d617a3e788972c3b226eef64124d2b
Gerrit-Change-Number: 34426
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email )
Change subject: tbf_dl_fsm: Fix assert hit due to EV_MAX_N3105 received in ST_RELEASING
......................................................................
tbf_dl_fsm: Fix assert hit due to EV_MAX_N3105 received in ST_RELEASING
That code path was incorrectly removed a few commits back, re-add it.
Fixes: 40a297f3b0c8e1670d46a4974750dd3335bc7885
Change-Id: I27e61dc4b3396360327dcd377d171daa30684d23
---
M src/tbf_dl_fsm.c
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/25/34425/1
diff --git a/src/tbf_dl_fsm.c b/src/tbf_dl_fsm.c
index 8d95d14..cf656bc 100644
--- a/src/tbf_dl_fsm.c
+++ b/src/tbf_dl_fsm.c
@@ -305,6 +305,13 @@
* already ACKED since we left ST_FINISHED. This happens due to
* fn-advance scheduling several DL blocks in advance. */
break;
+ case TBF_EV_MAX_N3105:
+ /* Triggered potentially by a poll timeout of PKT UL/DL TBF ASS.
+ * Reached N3105, the MS is not responding, so stop attempting
+ * using the TBF for DL assignment and change to ST_RELEASING in
+ * order to simply wait until resources can be reused (see
+ * st_releasing_on_enter()). */
+ tbf_dl_fsm_state_chg(fi, TBF_ST_RELEASING);
default:
OSMO_ASSERT(0);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34425?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I27e61dc4b3396360327dcd377d171daa30684d23
Gerrit-Change-Number: 34425
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange