September 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: abis_nm: fix bts->nr vs bts->bts_nr

by fixeria

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34443?usp=email to look at the new patch set (#2). Change subject: abis_nm: fix bts->nr vs bts->bts_nr ...................................................................... abis_nm: fix bts->nr vs bts->bts_nr Using bts->nr on the wire is wrong because: * bts->nr is a BTS number in the BSC's config file, * bts->bts_nr is a BTS number within the SITE-MANAGER MO. The problem does not show up if there exists only one BTS node in osmo-bsc.cfg. Otherwise, the Software Load and BTS Restart procedures are broken for nanoBTS. Change-Id: I99d9c72752e55c4553e2e9c60df5caa8343b7be0 --- M src/osmo-bsc/abis_nm.c 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/34443/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I99d9c72752e55c4553e2e9c60df5caa8343b7be0 Gerrit-Change-Number: 34443 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[S] Change in osmo-bsc[master]: abis_nm: fix bts->nr vs bts->bts_nr

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34443?usp=email ) Change subject: abis_nm: fix bts->nr vs bts->bts_nr ...................................................................... abis_nm: fix bts->nr vs bts->bts_nr * bts->nr is a BTS number in the BSC's config file, * bts->bts_nr is a BTS number within the SITE-MANAGER MO Change-Id: I99d9c72752e55c4553e2e9c60df5caa8343b7be0 --- M src/osmo-bsc/abis_nm.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/34443/1 diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 90b28eb..81a0272 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -1693,7 +1693,7 @@ break; case GSM_BTS_TYPE_NANOBTS: sw->obj_class = NM_OC_BASEB_TRANSC; - sw->obj_instance[0] = sw->bts->nr; + sw->obj_instance[0] = sw->bts->bts_nr; sw->obj_instance[1] = sw->trx_nr; sw->obj_instance[2] = 0xff; break; @@ -3102,7 +3102,7 @@ oh = (struct abis_om_hdr *) msgb_put(msg, ABIS_OM_FOM_HDR_SIZE); fill_om_fom_hdr(oh, 0, NM_MT_IPACC_RESTART, NM_OC_BASEB_TRANSC, - trx->bts->nr, trx->nr, 0xff); + trx->bts->bts_nr, trx->nr, 0xff); return abis_nm_sendmsg_direct(trx->bts, msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I99d9c72752e55c4553e2e9c60df5caa8343b7be0 Gerrit-Change-Number: 34443 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[S] Change in osmo-bsc[master]: oml: ipacc: fix copy-pasted talloc chunk names

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34358?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: oml: ipacc: fix copy-pasted talloc chunk names ...................................................................... oml: ipacc: fix copy-pasted talloc chunk names Change-Id: Ib0858c0d84b9bd2d3a4d732cfedb045862d2efed Related: OS#4505 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 20 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index df0e89e..83c5a30 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -99,7 +99,8 @@ struct msgb *msgb; uint8_t buf[256]; int rlt; - msgb = msgb_alloc(1024, "nanobts_attr_bts"); + + msgb = msgb_alloc(1024, __func__); if (!msgb) return NULL; @@ -183,7 +184,8 @@ struct abis_nm_ipacc_att_ns_cfg ns_cfg; struct abis_nm_ipacc_att_bssgp_cfg bssgp_cfg; struct gsm_bts *bts = gsm_bts_sm_get_bts(bts_sm); - msgb = msgb_alloc(1024, "nanobts_attr_bts"); + + msgb = msgb_alloc(1024, __func__); if (!msgb) return NULL; @@ -229,7 +231,8 @@ struct abis_nm_ipacc_att_rlc_cfg rlc_cfg; struct abis_nm_ipacc_att_rlc_cfg_2 rlc_cfg_2; uint8_t buf[2]; - msgb = msgb_alloc(1024, "nanobts_attr_bts"); + + msgb = msgb_alloc(1024, __func__); if (!msgb) return NULL; @@ -293,7 +296,8 @@ { struct msgb *msgb; uint8_t buf[256]; - msgb = msgb_alloc(1024, "nanobts_attr_bts"); + + msgb = msgb_alloc(1024, __func__); if (!msgb) return NULL; @@ -338,7 +342,8 @@ { struct msgb *msgb; uint8_t buf[256]; - msgb = msgb_alloc(1024, "nanobts_attr_bts"); + + msgb = msgb_alloc(1024, __func__); if (!msgb) return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib0858c0d84b9bd2d3a4d732cfedb045862d2efed Gerrit-Change-Number: 34358 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

[S] Change in osmo-bsc[master]: oml: ipacc: log supported features using LOGL_INFO

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34429?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: oml: ipacc: log supported features using LOGL_INFO ...................................................................... oml: ipacc: log supported features using LOGL_INFO Change-Id: Ie0b05bc9e3739b5a38b32a676641e64f2cf698ac Related: OS#4505 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index c65b701..df0e89e 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -51,7 +51,7 @@ u32 |= e->val[i] << (i * 8); for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { if (u32 & vs->value) - LOGPFOH(DNM, LOGL_DEBUG, foh, "%s '%s' is supported\n", text, vs->str); + LOGPFOH(DNM, LOGL_INFO, foh, "%s '%s' is supported\n", text, vs->str); } return u32; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie0b05bc9e3739b5a38b32a676641e64f2cf698ac Gerrit-Change-Number: 34429 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: osmo-bsc: Have PCU socket connection use osmo_wqueue

by arehbein

Attention is currently required from: dexter, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email ) Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/6ab89185_d3a8938b PS2, Line 725: "%u messages waiting). Closing connection\n", > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Sep 2023 20:12:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: osmo-bsc: Have PCU socket connection use osmo_wqueue

by arehbein

Attention is currently required from: arehbein, dexter, laforge, pespin. Hello Jenkins Builder, dexter, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by pespin, Code-Review+2 by arehbein, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... osmo-bsc: Have PCU socket connection use osmo_wqueue Close PCU socket on write queue overflow. Related: OS#5774 Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 --- M include/osmocom/bsc/pcu_if.h M src/osmo-bsc/pcu_sock.c 2 files changed, 56 insertions(+), 69 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/33891/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: osmo-bsc: Have PCU socket connection use osmo_wqueue

by arehbein

Attention is currently required from: dexter, laforge. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email ) Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Sep 2023 20:07:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-bts[master]: ASCI: Ignore LAPD frames from MS, while the uplink is not active

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email ) Change subject: ASCI: Ignore LAPD frames from MS, while the uplink is not active ...................................................................... Patch Set 1: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/ae57d9e3_a38ed1b0 PS1, Line 1814: rsl_chan_rt_is_asci I am wondering if the new check you added can be integrated here as follows: ``` if (rsl_chan_rt_is_asci(lchan->rsl_chan_rt) { if (lchan->asci.talker_active == VGCS_TALKER_WAIT_FRAME) vgcs_talker_frame(lchan); if (lchan->asci.talker_active != VGCS_TALKER_ACTIVE) return 0; } } ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3 Gerrit-Change-Number: 34423 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 15 Sep 2023 19:58:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-msc[master]: ASCI: Remove duplicated CLEAR COMMAND from VGCS/VBS channel handling

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33967?usp=email ) Change subject: ASCI: Remove duplicated CLEAR COMMAND from VGCS/VBS channel handling ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5e4891091c2ce56d4fd4a7f5f67156a94ade852d Gerrit-Change-Number: 33967 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 15 Sep 2023 18:54:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-bts[master]: nm: delay RSL connect until BBTRANSC object is OPSTARTed

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34442?usp=email ) Change subject: nm: delay RSL connect until BBTRANSC object is OPSTARTed ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/common/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/34442/comment/41ae1aa5_0d7f19fe PS1, Line 143: Disabled because osmo-bsc doesn't send SetAttr on BB_TRANSC object If I read 3GPP TS 52.021 correctly, there exists no `Set Attributes` procedure for the `Baseband Transceiver` object at all, so this code chunk should be removed. Unrelated to this patch, just mentioning. https://gerrit.osmocom.org/c/osmo-bts/+/34442/comment/a23ccaf6_d1dea33d PS1, Line 157: LOGL_NOTICE `LOGL_ERROR` maybe? Ah, you're just moving the existing code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idefc65a8812abd49fb5f0cd7b0bef423536b86e0 Gerrit-Change-Number: 34442 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Sep 2023 18:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023