August 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-hnbgw-latest: fixup for cnpool: bind CTRL to 0.0.0.0

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34097 ) Change subject: ttcn3-hnbgw-latest: fixup for cnpool: bind CTRL to 0.0.0.0 ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70c8d8fc61830cb46dcc580b7e344425f7c6c26d Gerrit-Change-Number: 34097 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Aug 2023 05:45:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-hnbgw-latest: fixup for cnpool: bind CTRL to 0.0.0.0

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34097 ) Change subject: ttcn3-hnbgw-latest: fixup for cnpool: bind CTRL to 0.0.0.0 ...................................................................... ttcn3-hnbgw-latest: fixup for cnpool: bind CTRL to 0.0.0.0 Change-Id: I70c8d8fc61830cb46dcc580b7e344425f7c6c26d --- M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw-legacy.cfg 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/97/34097/1 diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw-legacy.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw-legacy.cfg index 329ea7d..7ccbc7b 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw-legacy.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw-legacy.cfg @@ -19,6 +19,8 @@ line vty no login bind 0.0.0.0 +ctrl + bind 0.0.0.0 ! cs7 instance 0 asp asp-clnt-msc-0 2905 2905 m3ua -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70c8d8fc61830cb46dcc580b7e344425f7c6c26d Gerrit-Change-Number: 34097 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34096 ) Change subject: hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg ...................................................................... hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg Change-Id: Ib6175eee69a7f37f987f996049351b9e1a545f58 --- M ttcn3-hnbgw-test/osmo-stp.cfg 1 file changed, 17 insertions(+), 8 deletions(-) Approvals: neels: Looks good to me, approved; Verified diff --git a/ttcn3-hnbgw-test/osmo-stp.cfg b/ttcn3-hnbgw-test/osmo-stp.cfg index fedf6a8..8d94b75 100644 --- a/ttcn3-hnbgw-test/osmo-stp.cfg +++ b/ttcn3-hnbgw-test/osmo-stp.cfg @@ -41,8 +41,8 @@ routing-key 1 0.23.4 asp virt-msc1-0 23907 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-msc1 m3ua @@ -50,8 +50,8 @@ routing-key 3 0.0.2 asp virt-msc2-0 23909 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-msc2 m3ua @@ -68,8 +68,8 @@ routing-key 2 0.23.1 asp virt-sgsn1-0 23908 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-sgsn1 m3ua @@ -77,8 +77,8 @@ routing-key 4 0.1.2 asp virt-sgsn2-0 23910 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-sgsn2 m3ua -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib6175eee69a7f37f987f996049351b9e1a545f58 Gerrit-Change-Number: 34096 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34096 ) Change subject: hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib6175eee69a7f37f987f996049351b9e1a545f58 Gerrit-Change-Number: 34096 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Aug 2023 05:12:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34096 ) Change subject: hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg ...................................................................... hnbgw: fixup for cnpool: fix ASP IP addresses in osmo-stp.cfg Change-Id: Ib6175eee69a7f37f987f996049351b9e1a545f58 --- M ttcn3-hnbgw-test/osmo-stp.cfg 1 file changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/34096/1 diff --git a/ttcn3-hnbgw-test/osmo-stp.cfg b/ttcn3-hnbgw-test/osmo-stp.cfg index fedf6a8..8d94b75 100644 --- a/ttcn3-hnbgw-test/osmo-stp.cfg +++ b/ttcn3-hnbgw-test/osmo-stp.cfg @@ -41,8 +41,8 @@ routing-key 1 0.23.4 asp virt-msc1-0 23907 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-msc1 m3ua @@ -50,8 +50,8 @@ routing-key 3 0.0.2 asp virt-msc2-0 23909 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-msc2 m3ua @@ -68,8 +68,8 @@ routing-key 2 0.23.1 asp virt-sgsn1-0 23908 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-sgsn1 m3ua @@ -77,8 +77,8 @@ routing-key 4 0.1.2 asp virt-sgsn2-0 23910 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.1 + local-ip 172.18.35.200 + remote-ip 172.18.35.203 role sg sctp-role server as virt-sgsn2 m3ua -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib6175eee69a7f37f987f996049351b9e1a545f58 Gerrit-Change-Number: 34096 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: adjust with-pfcp cfg like without-pfcp

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34095 ) Change subject: hnbgw: fixup: adjust with-pfcp cfg like without-pfcp ...................................................................... hnbgw: fixup: adjust with-pfcp cfg like without-pfcp Change-Id: Ice5aa8a6db512edad3535a55c5dba841670837ec --- M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: neels: Looks good to me, approved; Verified diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg index b56ac14..377fad8 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -8,17 +8,20 @@ ! log stderr logging filter all 1 - logging color 1 - logging print category-hex 1 + logging color 0 + logging print category-hex 0 logging print category 1 + logging print level 1 logging print thread-id 0 logging print extended-timestamp 1 - logging print file 1 + logging print file basename last logging level set-all debug ! line vty no login bind 0.0.0.0 +ctrl + bind 0.0.0.0 ! cs7 instance 0 asp asp-clnt-msc-0 2905 2905 m3ua @@ -68,13 +71,8 @@ mgcp mgw local-ip 172.18.35.20 mgw remote-ip 172.18.35.203 - pfcp - remote-addr 172.18.35.203 - local-addr 172.18.35.20 - # so far HNBGW_Tests.ttcn does not heed the port an Assoc Setup Req came from, it always responds to port 8805 - local-port 8805 - # send PFCP Assoc Setup Req more often - timer pfcp x26 5 + # don't spam RANAP RESET messages for up to eight CN links across all tests + timer hnbgw T4 60 msc 0 remote-addr msc-naught -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ice5aa8a6db512edad3535a55c5dba841670837ec Gerrit-Change-Number: 34095 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: Fix VTY command to set IMEISV.

by jolly

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33836 ) Change subject: Fix VTY command to set IMEISV. ...................................................................... Fix VTY command to set IMEISV. The pointer and size must given for the SV portion of the character array only. Fixes: CID#314049, CID#314048 Change-Id: Ieff4ca886dec71aae1b6ecf2b623d600426580da --- M src/host/layer23/src/common/vty.c 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/common/vty.c b/src/host/layer23/src/common/vty.c index 526db6f..dd80a14 100644 --- a/src/host/layer23/src/common/vty.c +++ b/src/host/layer23/src/common/vty.c @@ -819,7 +819,8 @@ OSMO_STRLCPY_ARRAY(set->imei, argv[0]); OSMO_STRLCPY_ARRAY(set->imeisv, argv[0]); - OSMO_STRLCPY_ARRAY(set->imeisv + 15, sv); + osmo_strlcpy(set->imeisv + GSM23003_IMEI_NUM_DIGITS, sv, + sizeof(set->imeisv) - GSM23003_IMEI_NUM_DIGITS); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ieff4ca886dec71aae1b6ecf2b623d600426580da Gerrit-Change-Number: 33836 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: adjust with-pfcp cfg like without-pfcp

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34095 ) Change subject: hnbgw: fixup: adjust with-pfcp cfg like without-pfcp ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ice5aa8a6db512edad3535a55c5dba841670837ec Gerrit-Change-Number: 34095 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Aug 2023 04:30:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup: adjust with-pfcp cfg like without-pfcp

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34095 ) Change subject: hnbgw: fixup: adjust with-pfcp cfg like without-pfcp ...................................................................... hnbgw: fixup: adjust with-pfcp cfg like without-pfcp Change-Id: Ice5aa8a6db512edad3535a55c5dba841670837ec --- M ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 1 file changed, 17 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/95/34095/1 diff --git a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg index b56ac14..377fad8 100644 --- a/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg @@ -8,17 +8,20 @@ ! log stderr logging filter all 1 - logging color 1 - logging print category-hex 1 + logging color 0 + logging print category-hex 0 logging print category 1 + logging print level 1 logging print thread-id 0 logging print extended-timestamp 1 - logging print file 1 + logging print file basename last logging level set-all debug ! line vty no login bind 0.0.0.0 +ctrl + bind 0.0.0.0 ! cs7 instance 0 asp asp-clnt-msc-0 2905 2905 m3ua @@ -68,13 +71,8 @@ mgcp mgw local-ip 172.18.35.20 mgw remote-ip 172.18.35.203 - pfcp - remote-addr 172.18.35.203 - local-addr 172.18.35.20 - # so far HNBGW_Tests.ttcn does not heed the port an Assoc Setup Req came from, it always responds to port 8805 - local-port 8805 - # send PFCP Assoc Setup Req more often - timer pfcp x26 5 + # don't spam RANAP RESET messages for up to eight CN links across all tests + timer hnbgw T4 60 msc 0 remote-addr msc-naught -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ice5aa8a6db512edad3535a55c5dba841670837ec Gerrit-Change-Number: 34095 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in docker-playground[master]: hnbgw: fixup for cnpool: re-add lost MGCP cfg

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34094 ) Change subject: hnbgw: fixup for cnpool: re-add lost MGCP cfg ...................................................................... hnbgw: fixup for cnpool: re-add lost MGCP cfg Change-Id: I3491e2f9a675b737c12d84484f6d0219e8db0900 --- M ttcn3-hnbgw-test/osmo-hnbgw.cfg 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved; Verified diff --git a/ttcn3-hnbgw-test/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/osmo-hnbgw.cfg index 37bd01c..377fad8 100644 --- a/ttcn3-hnbgw-test/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/osmo-hnbgw.cfg @@ -68,6 +68,9 @@ local-ip 172.18.35.20 local-port 29169 hnbap-allow-tmsi 1 + mgcp + mgw local-ip 172.18.35.20 + mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3491e2f9a675b737c12d84484f6d0219e8db0900 Gerrit-Change-Number: 34094 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023