July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: ASCI: Allow usage of rtp_stream with other FSM
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: jolly, neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33500 ) Change subject: ASCI: Allow usage of rtp_stream with other FSM ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/33500/comment/b20e38b7_722a205e PS6, Line 13: Drop the unused parent_call_leg member. > Removing the parant_call_leg is part of the patch, so it does not depend on call_leg anymore. […] Is it really worth sparing me from having to discern different stuff while I review all your patches? IMHO yes of course 😊 let's merge this one as is, but I'd be glad if you take it into consideration for next patches :) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0991927b6d00da08dfd455980645e68281a73a9e Gerrit-Change-Number: 33500 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Jul 2023 12:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: ASCI: rtp_stream_commit(): Also update MGW on conn mode change
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33499 ) Change subject: ASCI: rtp_stream_commit(): Also update MGW on conn mode change ...................................................................... Patch Set 7: (1 comment) File src/libmsc/rtp_stream.c: https://gerrit.osmocom.org/c/osmo-msc/+/33499/comment/d301e420_a1400002 PS7, Line 440: if (rtps->crcx_conn_mode != mode) This really needs to be moved to the top of the function, and early return in order to trigger all the stuff below it. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7a5637d0a7f1df13133e522fc78ba75eeeb2873e Gerrit-Change-Number: 33499 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 12:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: Store "Channel rate and type" from RSL Channel Mode IE in BTS
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33291 ) Change subject: Store "Channel rate and type" from RSL Channel Mode IE in BTS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6d531bf528bcb81f44d91336471a46ef790d7646 Gerrit-Change-Number: 33291 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 11:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: validate RSL "channel rate and type" against VGCS/VBS flags
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33290 ) Change subject: validate RSL "channel rate and type" against VGCS/VBS flags ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/33290/comment/cca8106f_d4195fc2 PS2, Line 782: int bts_supports_cm(const struct gsm_bts *bts, iiuc this function actually returns a bool? do you mind submitting an extra patch returning bool and using true/false? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5e7f65b44cef6e2f7ad4f152f80a1686a4f511e3 Gerrit-Change-Number: 33290 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 11:39:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-bts[master]: ASCI: NCH / NOTIFICATION support
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33289 ) Change subject: ASCI: NCH / NOTIFICATION support ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/common/paging.c: https://gerrit.osmocom.org/c/osmo-bts/+/33289/comment/3d3b1f1e_54842166 PS2, Line 705: /* TODO: check if we can include a notification */ ASCI notification https://gerrit.osmocom.org/c/osmo-bts/+/33289/comment/2b1422f6_45e55988 PS2, Line 714: /* TODO: check if we can include a notification */ ASCI notification -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6f6f72d9a0123cb519b341d72a124aaa2117370e Gerrit-Change-Number: 33289 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Jul 2023 11:37:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: Add ASCI (advanced speech call items) log sub-system
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33288 ) Change subject: Add ASCI (advanced speech call items) log sub-system ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33288 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8ea3e61df35175bd74110b2f41994c99da3e2858 Gerrit-Change-Number: 33288 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 11:33:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: paging: Add support for generating NLN/NLN-Status in P1 Rest Octets
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33287 ) Change subject: paging: Add support for generating NLN/NLN-Status in P1 Rest Octets ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I961842c3fec151e149f72a4f36279ce4b979795e Gerrit-Change-Number: 33287 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 11:33:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-bts[master]: Add test cases for rest octets of Paging Requests
by jolly 06 Jul '23

06 Jul '23

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33450 ) Change subject: Add test cases for rest octets of Paging Requests ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifa5be8998b671160e38af1be707e040b00d407b8 Gerrit-Change-Number: 33450 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 11:29:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: ASCI: Repeat UPLINK FREE message until uplink becomes busy
by jolly 06 Jul '23

06 Jul '23

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33449 ) Change subject: ASCI: Repeat UPLINK FREE message until uplink becomes busy ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia23c59f5e9a73bbc384fbc317a2cfcf707e3c28f Gerrit-Change-Number: 33449 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 11:29:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: ASCI: Add Notification/FACCH support
by jolly 06 Jul '23

06 Jul '23

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33448 ) Change subject: ASCI: Add Notification/FACCH support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3ed14fa54a907891e492a7ada8e745a2c56cd46d Gerrit-Change-Number: 33448 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 11:29:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0