July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: print length of received TCH payloads
by laforge 09 Jul '23

09 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33643 ) Change subject: BTS_Tests: print length of received TCH payloads ...................................................................... BTS_Tests: print length of received TCH payloads Change-Id: I5848bd8acd220c1c4d2db01b71bb57e785dc9de7 --- M bts/BTS_Tests.ttcn 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index f59cc89..b8c4118 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2219,7 +2219,8 @@ private altstep as_l1_tch_loop() runs on ConnHdlr { var L1ctlMessage l1_dl; [] L1CTL.receive(tr_L1CTL_TRAFFIC_IND(g_chan_nr)) -> value l1_dl { - log("TCH received: ", l1_dl.payload.traffic_ind.data); + var octetstring data := l1_dl.payload.traffic_ind.data; + log("TCH received (len=", lengthof(data), "): ", data); /* occasionaly inject FACCH frames into the uplink */ if (g_pars.l1_pars.facch_enabled == true and l1_dl.dl_info.frame_nr mod 5 == 0) { @@ -8319,7 +8320,8 @@ Td.start(2.0); alt { [] L1CTL.receive(tr_L1CTL_TRAFFIC_IND(g_chan_nr, frame := pl)) -> value l1_dl { - log("TCH received: ", l1_dl.payload.traffic_ind.data); + var octetstring data := l1_dl.payload.traffic_ind.data; + log("TCH received (len=", lengthof(data), "): ", data); L1CTL.send(ts_L1CTL_TRAFFIC_REQ(g_chan_nr, l1_dl.dl_info.link_id, l1_dl.payload.traffic_ind.data)); setverdict(pass); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5848bd8acd220c1c4d2db01b71bb57e785dc9de7 Gerrit-Change-Number: 33643 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: print length of received TCH payloads
by laforge 09 Jul '23

09 Jul '23

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33643 ) Change subject: BTS_Tests: print length of received TCH payloads ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5848bd8acd220c1c4d2db01b71bb57e785dc9de7 Gerrit-Change-Number: 33643 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:54:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: TC_lu_and_mt_csd: reduce call open time
by laforge 09 Jul '23

09 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33631 ) Change subject: TC_lu_and_mt_csd: reduce call open time ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie733028f7953d5d9fa1907efdb19485dee93ece9 Gerrit-Change-Number: 33631 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:54:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnHdlr: f_mt_call: unregister IMSI
by laforge 09 Jul '23

09 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33594 ) Change subject: msc/BSC_ConnHdlr: f_mt_call: unregister IMSI ...................................................................... msc/BSC_ConnHdlr: f_mt_call: unregister IMSI Fix the missing call to f_ran_unregister_imsi when running f_mt_call. This is in preparation for calling f_mt_call multiple times during one test, to test various CSD bearer services. Without this patch, it will result in a "No space left in ImsiTable" error. I've also considered adding it to f_call_hangup instead, but this gets called by f_mo_call (mo instead of mt) as well, which does not run f_ran_register_imsi. Related: OS#4394 Change-Id: Ie9b180b95348d7e84650c14a331c5091a1e67d1f --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 8c9f63f..76702d4 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1851,6 +1851,9 @@ log("Hangup"); f_call_hangup(cpars, true); + /* Unregister the IMSI that was registered in f_mt_call_establish */ + f_ran_unregister_imsi(g_pars.imsi); + setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9b180b95348d7e84650c14a331c5091a1e67d1f Gerrit-Change-Number: 33594 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RAN_Emulation: testcase.stop -> mtc.stop
by laforge 09 Jul '23

09 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 ) Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop ...................................................................... library/RAN_Emulation: testcase.stop -> mtc.stop Stop the MTC (main test component) on error, otherwise some tests don't stop here and keep going forever. MSC_Test_0-RAN(106)@7e006c664067: Unable to find to-be-destroyed IMSI in ImsiTable MSC_Test_0-RAN(106)@7e006c664067: Dynamic test case error: testcase.stop MSC_Test_0-RAN(106)@7e006c664067: setverdict(error): none -> error MSC_Test_0-RAN(106)@7e006c664067: Final verdict of PTC: error MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Rx:{ msg_type := IPAC_MSGT_PING (0), u := omit } MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Tx:{ msg_type := IPAC_MSGT_PONG (1), u := omit } MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Rx:{ msg_type := IPAC_MSGT_PING (0), u := omit } MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Tx:{ msg_type := IPAC_MSGT_PONG (1), u := omit } … Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab --- M library/RAN_Emulation.ttcnpp 1 file changed, 30 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index 6a1f784..2fba50a 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -406,7 +406,8 @@ return; } } - testcase.stop("RAN Connection table full!"); + setverdict(fail, "RAN Connection table full!"); + mtc.stop; } private function f_conn_table_del(integer sccp_conn_id) @@ -1449,7 +1450,8 @@ return; } } - testcase.stop("No space left in ExpectTable"); + setverdict(fail, "No space left in ExpectTable"); + mtc.stop; } private function f_create_imsi(hexstring imsi, OCT4 tmsi, RAN_ConnHdlr hdlr) @@ -1463,7 +1465,8 @@ return; } } - testcase.stop("No space left in ImsiTable"); + setverdict(fail, "No space left in ImsiTable"); + mtc.stop; } private function f_destroy_imsi(hexstring imsi, RAN_ConnHdlr hdlr) @@ -1477,7 +1480,8 @@ return; } } - testcase.stop("Unable to find to-be-destroyed IMSI in ImsiTable"); + setverdict(fail, "Unable to find to-be-destroyed IMSI in ImsiTable"); + mtc.stop; } private function f_expect_table_init() -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab Gerrit-Change-Number: 33630 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnHdlr: f_mt_call: unregister IMSI
by laforge 09 Jul '23

09 Jul '23

Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33594 ) Change subject: msc/BSC_ConnHdlr: f_mt_call: unregister IMSI ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9b180b95348d7e84650c14a331c5091a1e67d1f Gerrit-Change-Number: 33594 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:53:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RAN_Emulation: testcase.stop -> mtc.stop
by laforge 09 Jul '23

09 Jul '23

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 ) Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab Gerrit-Change-Number: 33630 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:53:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Receive messages from MSC-A role related to VGCS/VBS
by laforge 09 Jul '23

09 Jul '23

Attention is currently required from: jolly, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33515 ) Change subject: ASCI: Receive messages from MSC-A role related to VGCS/VBS ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie68eedb8fcb064a55cd71b58630d7a8c8b5f29ad Gerrit-Change-Number: 33515 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Clear VGCS call and channel on SCCP reset
by laforge 09 Jul '23

09 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33514 ) Change subject: ASCI: Clear VGCS call and channel on SCCP reset ...................................................................... Patch Set 14: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/33514/comment/dc6fd4df_3c578505 PS14, Line 9: SCCP BSSMAP Reset, I suppose? There's no SCCP Reset. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib0b309150b82148098d05cfb1fb18767283e654e Gerrit-Change-Number: 33514 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:52:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ASCI: Add reception of UPLINK RELEASE on dedicated channel
by laforge 09 Jul '23

09 Jul '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33513 ) Change subject: ASCI: Add reception of UPLINK RELEASE on dedicated channel ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie8f7338da18eaaefbb022c09b96f18a3d78f8a95 Gerrit-Change-Number: 33513 Gerrit-PatchSet: 14 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:51:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0