July 2023 - gerrit-log - lists.osmocom.org

[L] Change in dahdi-linux[master]: Introduce virtual DAHDI trunk device
by laforge 29 Jul '23

29 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/34010 ) Change subject: Introduce virtual DAHDI trunk device ...................................................................... Introduce virtual DAHDI trunk device This virtual trunk device is a new character device. Contrary to the per-channel devices, this is a per-span device for virtual E1 spans. Userspace reads and writes 32-byte E1 frames on it. ioctl's are added to create and delete such virtual trunk devices at runtime. Each virtual trunk device is limited to one span. Opening trunkdev is similar to opening channels via /dev/dahd/chanw works: All users open the same generic device node but then issue an ioctl to specify which (named) trundev they actually want to open. This avoids having to dynamically register minor device ids, creating device nodes, etc. The trunkdev is in RED + LOS alarm after creation. Only once a userspace process opens the E1 frame side, those alarms cease. Change-Id: Iffd9a1a09d835b29927acd374364cab56745fb74 --- M drivers/dahdi/Kbuild M drivers/dahdi/Kconfig M drivers/dahdi/dahdi-base.c A drivers/dahdi/trunkdev/Kbuild A drivers/dahdi/trunkdev/frame_fifo.c A drivers/dahdi/trunkdev/frame_fifo.h A drivers/dahdi/trunkdev/trunkdev.c M include/dahdi/kernel.h M include/dahdi/user.h 9 files changed, 939 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/10/34010/1 diff --git a/drivers/dahdi/Kbuild b/drivers/dahdi/Kbuild index 3332bf6..c3ec58e 100644 --- a/drivers/dahdi/Kbuild +++ b/drivers/dahdi/Kbuild @@ -6,6 +6,8 @@ obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_DYNAMIC_ETHMF) += dahdi_dynamic_ethmf.o obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_TRANSCODE) += dahdi_transcode.o +obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_TRUNKDEV) += trunkdev/ + ifdef CONFIG_USB obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_ICE1USB) += icE1usb/ endif diff --git a/drivers/dahdi/Kconfig b/drivers/dahdi/Kconfig index e8f33b0..14c49bd 100644 --- a/drivers/dahdi/Kconfig +++ b/drivers/dahdi/Kconfig @@ -262,6 +262,24 @@ If unsure, say Y. +config DAHDI_TRUNKDEV + tristate "Virtual trunk device support" + depends on DAHDI + default DAHDI + ---help--- + This driver provides support for spans via a virtual trunk device. + In this driver, DAHDI basically only acts as a compability layer to + multiplex and de-multiplex samples from the individual channels + (timeslots) to/from E1 frames, which are provided/consumed from a + new /dev/dahdi/trunkdev character device. Actual interfacing with + real or physical hardware is then performed by some userspace process. + + To compile this driver as a module, choose M here: the + module will be called dahdi-trunkdev. + + If unsure, say Y. + + source "drivers/dahdi/xpp/Kconfig" diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 7bcbda6..d8e6268 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -105,6 +105,7 @@ #define UNIT(file) MINOR(file->f_path.dentry->d_inode->i_rdev) EXPORT_SYMBOL(dahdi_transcode_fops); +EXPORT_SYMBOL(dahdi_trunkdev_fops); EXPORT_SYMBOL(dahdi_init_tone_state); EXPORT_SYMBOL(dahdi_mf_tone); EXPORT_SYMBOL(__dahdi_mulaw); @@ -181,6 +182,7 @@ static struct dahdi_span *master_span; struct file_operations *dahdi_transcode_fops = NULL; +struct file_operations *dahdi_trunkdev_fops = NULL; #ifdef CONFIG_DAHDI_CONFLINK @@ -524,6 +526,30 @@ return found; } +static struct dahdi_span *_find_span_by_name(const char *name) +{ + struct dahdi_span *s; + list_for_each_entry(s, &span_list, spans_node) { + if (!strcmp(s->name, name)) { + return s; + } + } + return NULL; +} + +struct dahdi_span *dahdi_span_find_by_name_and_get(const char *name) +{ + struct dahdi_span *found; + + mutex_lock(&registration_mutex); + found = _find_span_by_name(name); + if (found && !get_span(found)) + found = NULL; + mutex_unlock(&registration_mutex); + return found; +} +EXPORT_SYMBOL(dahdi_span_find_by_name_and_get); + static unsigned int span_count(void) { unsigned int count = 0; @@ -3328,6 +3354,24 @@ } return -ENXIO; } + if (unit == DAHDI_TRUNKDEV) { + if (!dahdi_trunkdev_fops) { + if (request_module("dahdi_trunkdev")) { + return -ENXIO; + } + } + if (!try_module_get(dahdi_trunkdev_fops->owner)) { + return -ENXIO; + } + if (dahdi_trunkdev_fops && dahdi_trunkdev_fops->open) { + return dahdi_trunkdev_fops->open(inode, file); + } else { + /* dahdi_trunkdev module should have exported a + * file_operations table. */ + WARN_ON(1); + } + return -ENXIO; + } if (unit == DAHDI_TIMER) { if (can_open_timer()) { return dahdi_timer_open(file); diff --git a/drivers/dahdi/trunkdev/Kbuild b/drivers/dahdi/trunkdev/Kbuild new file mode 100644 index 0000000..934153b --- /dev/null +++ b/drivers/dahdi/trunkdev/Kbuild @@ -0,0 +1,3 @@ +obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_TRUNKDEV) += dahdi-trunkdev.o + +dahdi-trunkdev-objs := trunkdev.o frame_fifo.o diff --git a/drivers/dahdi/trunkdev/frame_fifo.c b/drivers/dahdi/trunkdev/frame_fifo.c new file mode 100644 index 0000000..19b6dba --- /dev/null +++ b/drivers/dahdi/trunkdev/frame_fifo.c @@ -0,0 +1,158 @@ +/* + * frame_fifo.c (copied from osmo-e1d) + * + * (C) 2022 by Harald Welte <laforge(a)osmocom.org> + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/types.h> +#include <linux/errno.h> +#include <linux/string.h> + +#include "frame_fifo.h" + + +/*********************************************************************** + * Frame FIFO + ***********************************************************************/ + +void fifo_dump(struct frame_fifo *fifo) +{ + printk(KERN_DEBUG "buf=%p, size=%zu, next_in=%lu, next_out=%lu\n", fifo->buf, sizeof(fifo->buf), + fifo->next_in - fifo->buf, fifo->next_out - fifo->buf); +} + +/*! Initialize a frame FIFO. + * \param fifo Caller-allocated memory for FIFO data structure + * \param threshold After how many available frames shall we call threshold_cb + * \param threshold_cb Optional call-back to call whenever FIFO contains more than 'threshold' frames + * \param priv Opaque pointer passed to threshold_cb */ +void frame_fifo_init(struct frame_fifo *fifo, unsigned int threshold, + void (*threshold_cb)(struct frame_fifo *fifo, unsigned int frames, void *priv), + void *priv) +{ + memset(fifo->buf, 0xff, sizeof(fifo->buf)); + fifo->next_in = fifo->buf; + fifo->next_out = fifo->buf; + fifo->threshold = threshold; + fifo->threshold_cb = threshold_cb; + fifo->priv = priv; + spin_lock_init(&fifo->lock); +} + +#define FIFO_BUF_END(f) ((f)->buf + sizeof((f)->buf)) + +/*! put one received frames into the FIFO. + * \param fifo The FIFO to which we want to put (append) multiple frames + * \param frame Pointer to memory containing the frame data + * \param count Number of frames to put into FIFO. + * \returns 0 on success; -1 on error (overflow */ +int frame_fifo_in(struct frame_fifo *fifo, const uint8_t *frame) +{ + unsigned long flags; + + spin_lock_irqsave(&fifo->lock, flags); +#if 0 + /* FIXME: detect overflow */ + if (fifo->next_in == fifo->next_out) { + spin_unlock_irqrestore(&fifo->lock, flags); + return -ENOSPC; + } +#endif + BUG_ON(fifo->next_in + BYTES_PER_FRAME > FIFO_BUF_END(fifo)); + memcpy(fifo->next_in, frame, BYTES_PER_FRAME); + fifo->next_in += BYTES_PER_FRAME; + if (fifo->next_in >= FIFO_BUF_END(fifo)) + fifo->next_in -= sizeof(fifo->buf); + spin_unlock_irqrestore(&fifo->lock, flags); + + if (fifo->threshold_cb) { + unsigned int frames_avail = frame_fifo_frames(fifo); + if (frames_avail >= fifo->threshold) + fifo->threshold_cb(fifo, frames_avail, fifo->priv); + } + + return 0; +} + +/*! put (append) multiple received frames into the FIFO. + * \param fifo The FIFO to which we want to put (append) multiple frames + * \param frame Pointer to memory containing the frame data + * \param count Number of frames to put into FIFO. + * \returns Number of frames actually put to FIFO; can be less than 'count' */ +int frame_fifo_in_multi(struct frame_fifo *fifo, const uint8_t *frame, size_t count) +{ + const uint8_t *cur = frame; + unsigned int i; + int rc; + + for (i = 0; i < count; i++) { + rc = frame_fifo_in(fifo, cur); + /* abort on the first failing frame, there's no point in trying further */ + if (rc < 0) + return (int) i; + cur += BYTES_PER_FRAME; + } + return (int) i; +} + +/*! pull one frames out of the FIFO. + * \param fifo The FIFO from which we want to pull frames + * \param out Caller-allocated output buffer + * \returns 0 on success; -1 on error (no frame available) */ +int frame_fifo_out(struct frame_fifo *fifo, uint8_t *out) +{ + unsigned long flags; + + spin_lock_irqsave(&fifo->lock, flags); + + if (__frame_fifo_frames(fifo) < 1) { + spin_unlock_irqrestore(&fifo->lock, flags); + return -1; + } + + memcpy(out, fifo->next_out, BYTES_PER_FRAME); + fifo->next_out += BYTES_PER_FRAME; + + if (fifo->next_out >= FIFO_BUF_END(fifo)) + fifo->next_out -= sizeof(fifo->buf); + + spin_unlock_irqrestore(&fifo->lock, flags); + + return 0; +} + +/*! pull multiple frames out of the FIFO. + * \param fifo The FIFO from which we want ot pull frames + * \param out Caller-allocated output buffer + * \param count Number of frames to pull + * \returns number of frames pulled; can be 0 or less than count */ +int frame_fifo_out_multi(struct frame_fifo *fifo, uint8_t *out, size_t count) +{ + uint8_t *cur = out; + unsigned int i; + int rc = 0; + + for (i = 0; i < count; i++) { + rc = frame_fifo_out(fifo, cur); + /* if there's no data in the FIFO, return number of frames + * pulled so far, could be 0. */ + if (rc < 0) + return (int) i; + cur += BYTES_PER_FRAME; + } + return (int) i; +} diff --git a/drivers/dahdi/trunkdev/frame_fifo.h b/drivers/dahdi/trunkdev/frame_fifo.h new file mode 100644 index 0000000..af02811 --- /dev/null +++ b/drivers/dahdi/trunkdev/frame_fifo.h @@ -0,0 +1,56 @@ +#pragma once + +#include <linux/spinlock.h> + +#define BYTES_PER_FRAME 32 +#define FRAMES_PER_FIFO 800 /* 100ms @ 8000 frames per second */ + +struct frame_fifo { + spinlock_t lock; + uint8_t *next_in; /* where to write next input into FIFO */ + uint8_t *next_out; /* where to read next output from FIFO */ + uint8_t threshold; /* number of frames that should trigger */ + void (*threshold_cb)(struct frame_fifo *fifo, unsigned int frames, void *priv); + void *priv; + + uint8_t buf[BYTES_PER_FRAME * FRAMES_PER_FIFO]; +}; + +void frame_fifo_init(struct frame_fifo *fifo, unsigned int threshold, + void (*threshold_cb)(struct frame_fifo *fifo, unsigned int frames, void *priv), + void *priv); + +/* number of frames currently available in FIFO */ +static inline unsigned int __frame_fifo_frames(struct frame_fifo *fifo) +{ + return ((fifo->next_in + sizeof(fifo->buf) - fifo->next_out) % sizeof(fifo->buf)) / BYTES_PER_FRAME; +} +static inline unsigned int frame_fifo_frames(struct frame_fifo *fifo) +{ + unsigned long flags; + unsigned int ret; + + spin_lock_irqsave(&fifo->lock, flags); + ret = __frame_fifo_frames(fifo); + spin_unlock_irqrestore(&fifo->lock, flags); + + return ret; +} + +/* for how many frames do we have space in the FIFO? */ +static inline unsigned int frame_fifo_space(struct frame_fifo *fifo) +{ + return FRAMES_PER_FIFO - frame_fifo_frames(fifo); +} + +/* put a received frame into the FIFO */ +int frame_fifo_in(struct frame_fifo *fifo, const uint8_t *frame); + +/* put multiple received frames into the FIFO */ +int frame_fifo_in_multi(struct frame_fifo *fifo, const uint8_t *frame, size_t count); + +/* pull one frame out of the FIFO */ +int frame_fifo_out(struct frame_fifo *fifo, uint8_t *out); + +/* pull multiple frames out of the FIFO */ +int frame_fifo_out_multi(struct frame_fifo *fifo, uint8_t *out, size_t count); diff --git a/drivers/dahdi/trunkdev/trunkdev.c b/drivers/dahdi/trunkdev/trunkdev.c new file mode 100644 index 0000000..8375c86 --- /dev/null +++ b/drivers/dahdi/trunkdev/trunkdev.c @@ -0,0 +1,607 @@ +/* DAHDI Virtual Trunk device driver. + * (C) 2022 by Harald Welte <laforge(a)osmocom.org> + * for Osmocom retronetworking project + * + */ + +/* This virtual trunk device is a new character device. Contrary to + the per-channel devices, this is a per-span device for virtual E1 + spans. Userspace reads and writes 32-byte E1 frames on it. + + ioctl's are added to create and delete such virtual trunk devices + at runtime. Each virtual trunk device is limited to one span. + + Opening trunkdev is similar to opening channels via /dev/dahd/chanw + works: All users open the same generic device node but then issue + an ioctl to specify which (named) trundev they actually want to open. + + This avoids having to dynamically register minor device ids, creating + device nodes, etc. + + The trunkdev is in RED + LOS alarm after creation. Only once a userspace + process opens the E1 frame side, those alarms cease. +*/ + + +#include <linux/kernel.h> +#include <linux/errno.h> +#include <linux/module.h> +#include <linux/init.h> +#include <linux/kmod.h> +#include <linux/wait.h> +#include <linux/spinlock.h> + +#include <dahdi/kernel.h> + +#include "frame_fifo.h" +#include "../dahdi.h" + +#define TRUNKDEV_FMT "trunkdev/%s/0" + +#define ALL_RY_ALARMS (DAHDI_ALARM_RED | DAHDI_ALARM_YELLOW | \ + DAHDI_ALARM_LFA | DAHDI_ALARM_LMFA) + +struct dahdi_trunkdev { + /* pointer to 'file' _if_ somebody has opened us via DAHDI_TRUNKDEV_OPEM */ + struct file *file; + + /* the two E1 frame FIFOs between trunk-device and DAHDI code */ + struct frame_fifo from_trunk; + struct frame_fifo to_trunk; + + /* wait-queue for blocking read on trunk device */ + wait_queue_head_t waitq; + + struct { + struct dahdi_device *dev; + struct dahdi_span span; + struct dahdi_chan *chans[31]; + /* [next rx byte] offset into chan[i]->readchunk */ + unsigned int readchunk_idx; + /* [next tx byte] offset into chan[i]->writechunk */ + unsigned int writechunk_idx; + } dahdi; +}; + +/* process one incoming E1 frame (32 bytes; one for each TS) */ +static void _span_demux_one_frame(struct dahdi_trunkdev *td, const uint8_t *data) +{ + struct dahdi_span *dspan = &td->dahdi.span; + unsigned int i; + + /* TODO: TS0 handling */ + + /* de-multiplex one byte to each channel */ + for (i = 0; i < ARRAY_SIZE(td->dahdi.chans); i++) { + struct dahdi_chan *chan = td->dahdi.chans[i]; + chan->readchunk[td->dahdi.readchunk_idx] = data[1+i]; + } + td->dahdi.readchunk_idx++; + + /* DAHDI_CHUNKSIZE is 8, meaning every channel (timeslot) wants data for 8 + * bytes (PCM samples) every time _dahdi_receive() is called */ + if (td->dahdi.readchunk_idx == DAHDI_CHUNKSIZE) { + dahdi_receive(dspan); + td->dahdi.readchunk_idx = 0; + } +} + +/* multiplex one E1 frame (32 bytes) and write it to 'out' */ +static void _span_mux_one_frame(struct dahdi_trunkdev *td, uint8_t *out) +{ + struct dahdi_span *dspan = &td->dahdi.span; + unsigned int i; + + out[0] = 0; /* TODO: TS0 handling */ + + /* multiplex one byte of each channel into a frame */ + for (i = 0; i < ARRAY_SIZE(td->dahdi.chans); i++) { + struct dahdi_chan *chan = td->dahdi.chans[i]; + out[1+i] = chan->writechunk[td->dahdi.writechunk_idx]; + } + td->dahdi.writechunk_idx++; + + /* DAHDI_CHUNKSIZE is 8, meaning every channel (timeslot) has data for 8 + * bytes (PCM samples) every time _dahdi_transmit() is called */ + if (td->dahdi.writechunk_idx == DAHDI_CHUNKSIZE) { + dahdi_transmit(dspan); + td->dahdi.writechunk_idx = 0; + } +} + + + + +/************************************************************************* + * DAHDI driver integration + *************************************************************************/ + +/* configuration of the span itself */ +static int td_d_spanconfig(struct file *file, struct dahdi_span *span, + struct dahdi_lineconfig *lc) +{ + struct dahdi_trunkdev *td = container_of(span, struct dahdi_trunkdev, dahdi.span); + unsigned int i; + + if (lc->sync < 0) + lc->sync = 0; + if (lc->sync > 1) { + // TODO: log + lc->sync = 0; + } + + /* (re-)set some sane defaults */ + for (i = 0; i < span->channels; i++) { + struct dahdi_chan *const chan = td->dahdi.chans[i]; + chan->sigcap = DAHDI_SIG_CLEAR | DAHDI_SIG_MTP2 | DAHDI_SIG_SF; + } + + return 0; +} + +/* configuration of a single channel within the span */ +static int td_d_chanconfig(struct file *file, struct dahdi_chan *chan, int sigtype) +{ + return 0; +} + +/* start the span */ +static int td_d_startup(struct file *file, struct dahdi_span *span) +{ + struct dahdi_trunkdev *td = container_of(span, struct dahdi_trunkdev, dahdi.span); + /* TODO: set alarms if trunkdev not open? */ + return 0; +} + +/* shut down / stop the span */ +static int td_d_shutdown(struct dahdi_span *span) +{ + struct dahdi_trunkdev *td = container_of(span, struct dahdi_trunkdev, dahdi.span); + /* TODO: should trunkdev continue to read/write even if the dahdi side is shutdown */ + return 0; +} + +/* called in hard_irq context with chan_lock held */ +static void td_d_sync_tick(struct dahdi_span *span, int is_master) +{ + struct dahdi_trunkdev *td = container_of(span, struct dahdi_trunkdev, dahdi.span); + unsigned int i; + + /* we must have some other clock source than this span, due to the way + * how DAHDI works internally: This very sync_tick function is called when the + * master device receives data via _dahdi_receive(). As we are calling + * _dahdi_receive() via _span_demux_one_frame(), this would lead to re-entrancy */ + BUG_ON(is_master); + + /* trigger transmission + reception of E1 frames */ + for (i = 0; i < DAHDI_CHUNKSIZE; i++) { + uint8_t frame[32]; + int rc; + + /* Trunk -> DAHDI direction */ + rc = frame_fifo_out(&td->from_trunk, frame); + if (rc >= 0) + _span_demux_one_frame(td, frame); + + /* Trunk <- DAHDI direction */ + _span_mux_one_frame(td, frame); + frame_fifo_in(&td->to_trunk, frame); + } + /* wake up any processes doing blocking read or waiting in poll */ + wake_up_interruptible(&td->waitq); +} + +static const struct dahdi_span_ops trunkdev_span_ops = { + .owner = THIS_MODULE, + .spanconfig = td_d_spanconfig, + .chanconfig = td_d_chanconfig, + .startup = td_d_startup, + .shutdown = td_d_shutdown, + //.maint = td_d_maint, + .sync_tick = td_d_sync_tick, +}; + + +static void trunkdev_free_channels(struct dahdi_trunkdev *td) +{ + unsigned int i; + for (i = 0; i < ARRAY_SIZE(td->dahdi.chans); i++) { + kfree(td->dahdi.chans[i]); + td->dahdi.chans[i] = NULL; + } +} + +static int trunkdev_alloc_channels(struct dahdi_trunkdev *td) +{ + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(td->dahdi.chans); i++) { + struct dahdi_chan *chan; + kfree(td->dahdi.chans[i]); + chan = td->dahdi.chans[i] = kzalloc(sizeof(*chan), GFP_KERNEL); + if (!chan) { + trunkdev_free_channels(td); + return -ENOMEM; + } + chan->pvt = td; + snprintf(chan->name, sizeof(chan->name)-1, "%s/%u", + td->dahdi.span.name, i+1); + chan->chanpos = i+1; + chan->sigcap = DAHDI_SIG_CLEAR | DAHDI_SIG_MTP2 | DAHDI_SIG_SF; + } + return 0; +} + +static int trunkdev_create(const char *name) +{ + struct dahdi_trunkdev *td; + struct dahdi_device *ddev; + struct dahdi_span *dspan; + int ret = -EINVAL; + int rc; + + td = kzalloc(sizeof(*td), GFP_KERNEL); + if (!td) + return -ENOMEM; + + frame_fifo_init(&td->from_trunk, 0, NULL, td); + frame_fifo_init(&td->to_trunk, 0, NULL, td); + init_waitqueue_head(&td->waitq); + + td->dahdi.dev = dahdi_create_device(); + if (!td->dahdi.dev) { + printk(KERN_ERR "Error in dahdi_create_device()\b"); + goto error; + } + ddev = td->dahdi.dev; + dev_set_name(&ddev->dev, "trunkdev_%s", name); + ddev->manufacturer = "Osmocom"; + ddev->devicetype = "Virtual Trunk"; + ddev->hardware_id = "none"; + //ddev->location = FIXME; + + dspan = &td->dahdi.span; + snprintf(dspan->name, sizeof(dspan->name), TRUNKDEV_FMT, name); + snprintf(dspan->desc, sizeof(dspan->desc), "Virtual trunk %s span 0", name); + dspan->channels = 31; + dspan->spantype = SPANTYPE_DIGITAL_E1; + dspan->deflaw = DAHDI_LAW_ALAW; + dspan->linecompat = DAHDI_CONFIG_HDB3 | DAHDI_CONFIG_CCS | DAHDI_CONFIG_CRC4; + dspan->alarms = DAHDI_ALARM_RED | DAHDI_ALARM_LOS; + dspan->chans = td->dahdi.chans; + dspan->flags = 0; + dspan->offset = 0; + dspan->ops = &trunkdev_span_ops; + dspan->cannot_provide_timing = 1; + + rc = trunkdev_alloc_channels(td); + if (rc) { + ret = -ENOMEM; + goto err_free_tdev; + } + + list_add_tail(&dspan->device_node, &ddev->spans); + + rc = dahdi_register_device(td->dahdi.dev, NULL); + if (rc) { + printk(KERN_ERR "Error in dahdi_register_device()\n"); + goto err_free_chans; + } + + return dspan->spanno; + +err_free_chans: + trunkdev_free_channels(td); +err_free_tdev: + dahdi_free_device(td->dahdi.dev); +error: + kfree(td); + return ret; +} + +static void trunkdev_free(struct dahdi_trunkdev *td) +{ + if (td->file) + td->file->private_data = NULL; + + /* will in turn call td_d_shutdown() */ + dahdi_unregister_device(td->dahdi.dev); + trunkdev_free_channels(td); + kfree(td); +} + + +/************************************************************************* + * /dev/dahdi/trunkdev character device handling for a full trunk + *************************************************************************/ + +/* user has opened a trunkdev device */ +static int dahdi_trunkdev_open(struct inode *inode, struct file *file) +{ + const struct file_operations *original_fops; + + printk(KERN_DEBUG "%s\n", __func__); + + /* use our own file operations for this file, not the generic dahdi ones */ + original_fops = file->f_op; + file->f_op = dahdi_trunkdev_fops; + file->private_data = NULL; + /* Under normal operation, this releases the reference on the DAHDI + * module that was created when the file was opened. dahdi_open is + * responsible for taking a reference out on this module before + * calling this function. */ + module_put(original_fops->owner); + + /* nothing else to do here, we wait for ioctls() to create new trunkdev + * or to associate the file handle with existing ones */ + return 0; +} + +/* user has closed the trunkdev device */ +static int dahdi_trunkdev_release(struct inode *inode, struct file *file) +{ + struct dahdi_trunkdev *td = file->private_data; + struct dahdi_span *dspan; + unsigned long flags; + + printk(KERN_DEBUG "%s\n", __func__); + + if (unlikely(!td)) + return -ENXIO; + + dspan = &td->dahdi.span; + /* signal RED alarm once the trunkdev user is gone */ + spin_lock_irqsave(&dspan->lock, flags); + dspan->alarms &= ~ALL_RY_ALARMS; + dspan->alarms |= DAHDI_ALARM_RED | DAHDI_ALARM_LOS; + dahdi_alarm_notify(dspan); + spin_unlock_irqrestore(&dspan->lock, flags); + + /* drop the reference taken during DAHDI_TRUNKDEV_OPEN */ + put_span(dspan); + + td->file = NULL; + file->private_data = NULL; + + return 0; +} + +static long dahdi_unlocked_ioctl(struct file *file, unsigned int cmd, unsigned long data) +{ + struct dahdi_trunkdev_create create; + struct dahdi_trunkdev_delete delete; + struct dahdi_trunkdev_open open; + char name[40]; + struct dahdi_trunkdev *td; + struct dahdi_span *span; + unsigned long flags; + int res; + + printk(KERN_DEBUG "%s(cmd=%u)\n", __func__, cmd); + + switch (cmd) { + case DAHDI_TRUNKDEV_CREATE: /* create an new trunkdev/span */ + printk(KERN_DEBUG "%s(cmd=DAHDI_TRUNKDEV_CREATE)\n", __func__); + if (copy_from_user(&create, (__user const void *) data, sizeof(create))) + return -EFAULT; + res = trunkdev_create(create.name); + if (res < 0) + return res; + create.spanno = res; + if (copy_to_user((__user void *) data, &create, sizeof(create))) { + trunkdev_free(td); + return -EFAULT; + } + /* increase module reference count to avoid module unload until all + * trunkdev have been deleted again */ + if (!try_module_get(THIS_MODULE)) { + trunkdev_free(td); + return -ENXIO; + } + return 0; + + case DAHDI_TRUNKDEV_DELETE: /* destroy an existing trunkdev/span */ + printk(KERN_DEBUG "%s(cmd=DAHDI_TRUNKDEV_DELETE)\n", __func__); + if (copy_from_user(&delete, (__user const void *) data, sizeof(delete))) + return -EFAULT; + snprintf(name, sizeof(name), TRUNKDEV_FMT, delete.name); + span = dahdi_span_find_by_name_and_get(name); + if (!span) + return -ENODEV; + if (span->ops != &trunkdev_span_ops) { + /* the span with this name is not a trunkdev span */ + put_span(span); + return -EINVAL; + } + td = container_of(span, struct dahdi_trunkdev, dahdi.span); + if (td->file) { + /* some other file already opened this span */ + put_span(span); + return -EBUSY; + } + /* FIXME: some kind of mutex required? */ + /* release the reference we obtained above before free'ing underlying memory */ + put_span(span); + trunkdev_free(td); + /* drop the reference we hold from TRUNKDEV_CREATE time */ + module_put(THIS_MODULE); + return 0; + + case DAHDI_TRUNKDEV_OPEN: /* open a trunkdev/span */ + printk(KERN_DEBUG "%s(cmd=DAHDI_TRUNKDEV_OPEN)\n", __func__); + if (unlikely(file->private_data)) + return -EBUSY; + if (copy_from_user(&open, (__user const void *) data, sizeof(open))) + return -EFAULT; + snprintf(name, sizeof(name), TRUNKDEV_FMT, open.name); + span = dahdi_span_find_by_name_and_get(name); + if (!span) + return -ENODEV; + if (span->ops != &trunkdev_span_ops) { + /* the span with this name is not a trunkdev span */ + put_span(span); + return -EINVAL; + } + td = container_of(span, struct dahdi_trunkdev, dahdi.span); + if (td->file) { + /* some other file already opened this span */ + put_span(span); + return -EBUSY; + } + /* FIXME: some kind of mutex required? */ + file->private_data = td; + td->file = file; + /* remove all alarms */ + spin_lock_irqsave(&span->lock, flags); + span->alarms &= ~(ALL_RY_ALARMS|DAHDI_ALARM_LOS); + dahdi_alarm_notify(span); + spin_unlock_irqrestore(&span->lock, flags); + + open.spanno = span->spanno; + if (copy_to_user((__user void *) data, &open, sizeof(open))) + return -EFAULT; + return 0; + default: + printk(KERN_ERR "%s(invalid cmd=0x%x)\n", __func__, cmd); + return -EINVAL; + } +} + +static ssize_t dahdi_trunkdev_read(struct file *file, char __user *usrbuf, + size_t count, loff_t *ppos) +{ + struct dahdi_trunkdev *td = file->private_data; + size_t copied = 0; + + if (unlikely(!td)) + return -ENODEV; + + if (unlikely(count < 1)) + return -EINVAL; + + if (unlikely(count % BYTES_PER_FRAME)) + return -EINVAL; + + while (copied < count) { + uint8_t frame[BYTES_PER_FRAME]; + int rc; + + rc = frame_fifo_out(&td->to_trunk, frame); + if (rc < 0) { + /* insufficient data available */ + if (file->f_flags & O_NONBLOCK) { + if (copied == 0) + return -EAGAIN; + else + return copied; + } + /* blocking wait for frames in FIFO or for device disappearing */ + rc = wait_event_interruptible(td->waitq, + (frame_fifo_frames(&td->to_trunk) || !file->private_data)); + if (rc) + return rc; + /* device has disappeared */ + if (!file->private_data) + return -ENODEV; + } + if (copy_to_user(usrbuf + copied, frame, sizeof(frame))) + return -EFAULT; + copied += sizeof(frame); + } + + return copied; +} + +static ssize_t dahdi_trunkdev_write(struct file *file, const char __user *usrbuf, size_t count, loff_t *ppos) +{ + struct dahdi_trunkdev *td = file->private_data; + size_t copied = 0; + + if (unlikely(!td)) + return -ENODEV; + + if (unlikely(count < 1)) + return -EINVAL; + + if (unlikely(count % BYTES_PER_FRAME)) + return -EINVAL; + + while (copied < count) { + uint8_t frame[BYTES_PER_FRAME]; + + if (copy_from_user(frame, usrbuf + copied, sizeof(frame))) + return -EFAULT; + + frame_fifo_in(&td->from_trunk, frame); + copied += sizeof(frame); + /* TODO: we could detect overflow and start blocking? */ + } + + return copied; +} + +static unsigned int dahdi_trunkdev_poll(struct file *file, struct poll_table_struct *wait_table) +{ + struct dahdi_trunkdev *td = file->private_data; + unsigned int ret = 0; + + if (unlikely(!td)) + return POLLERR | POLLHUP | POLLRDHUP | POLLNVAL | POLLPRI; + + poll_wait(file, &td->waitq, wait_table); + + if (frame_fifo_frames(&td->to_trunk)) + ret |= POLLIN | POLLRDNORM; + + /* we currently always allow write to the fifo, as we don't detect overflows yet */ + ret |= POLLOUT | POLLWRNORM; + + return ret; +} + +static const struct file_operations __dahdi_trunkdev_fops = { + .owner = THIS_MODULE, + .open = dahdi_trunkdev_open, + .release = dahdi_trunkdev_release, + .unlocked_ioctl = dahdi_unlocked_ioctl, + .read = dahdi_trunkdev_read, + .write = dahdi_trunkdev_write, + .poll = dahdi_trunkdev_poll, +}; + +static struct dahdi_chardev trunkdev_chardev = { + .name = "trunkdev", + .minor = DAHDI_TRUNKDEV, +}; + +static int __init dahdi_trunkdev_init(void) +{ + int res; + + if (dahdi_trunkdev_fops) { + printk(KERN_WARNING "dahdi_trunkdev_fops already set.\n"); + return -EBUSY; + } + + if ((res = dahdi_register_chardev(&trunkdev_chardev))) + return res; + + dahdi_trunkdev_fops = (struct file_operations *) &__dahdi_trunkdev_fops; + + printk(KERN_INFO "%s: Loaded.\n", THIS_MODULE->name); + return 0; +} + +static void __exit dahdi_trunkdev_cleanup(void) +{ + dahdi_unregister_chardev(&trunkdev_chardev); + dahdi_trunkdev_fops = NULL; + printk(KERN_INFO "%s: Unloaded.\n", THIS_MODULE->name); +} + +MODULE_DESCRIPTION("DAHDI virtual trunk device"); +MODULE_AUTHOR("Harald Welte <laforge(a)osmocom.org>"); +MODULE_LICENSE("GPL"); + +module_init(dahdi_trunkdev_init); +module_exit(dahdi_trunkdev_cleanup); diff --git a/include/dahdi/kernel.h b/include/dahdi/kernel.h index 0df4f5e..0a25854 100644 --- a/include/dahdi/kernel.h +++ b/include/dahdi/kernel.h @@ -1216,6 +1216,9 @@ void dahdi_free_device(struct dahdi_device *ddev); void dahdi_init_span(struct dahdi_span *span); +/*! Find a span by its name and get a reference */ +struct dahdi_span *dahdi_span_find_by_name_and_get(const char *name); + /*! Allocate / free memory for a transcoder */ struct dahdi_transcoder *dahdi_transcoder_alloc(int numchans); void dahdi_transcoder_free(struct dahdi_transcoder *ztc); @@ -1295,6 +1298,7 @@ } extern struct file_operations *dahdi_transcode_fops; +extern struct file_operations *dahdi_trunkdev_fops; int dahdi_get_auto_assign_spans(void); @@ -1592,6 +1596,7 @@ #define DAHDI_CTL 0 #define DAHDI_TRANSCODE 250 +#define DAHDI_TRUNKDEV 252 #define DAHDI_TIMER 253 #define DAHDI_CHANNEL 254 #define DAHDI_PSEUDO 255 diff --git a/include/dahdi/user.h b/include/dahdi/user.h index d69dc91..17e7a0e 100644 --- a/include/dahdi/user.h +++ b/include/dahdi/user.h @@ -1225,4 +1225,24 @@ *dst = '\0'; } +struct dahdi_trunkdev_create { + char name[40]; /* name of the to-be-created span */ + //int numchans; + int spanno; /* Span number (filled in by DAHDI) */ +}; +#define DAHDI_TRUNKDEV_CREATE _IOWR(DAHDI_CODE, 255, struct dahdi_trunkdev_create) + +struct dahdi_trunkdev_delete { + char name[40]; /* name of the to-be-opened span */ +}; +#define DAHDI_TRUNKDEV_DELETE _IOWR(DAHDI_CODE, 254, struct dahdi_trunkdev_delete) + +struct dahdi_trunkdev_open { + char name[40]; /* name of the to-be-opened span */ + int spanno; /* Span number (filled in by DAHDI) */ +}; +#define DAHDI_TRUNKDEV_OPEN _IOWR(DAHDI_CODE, 253, struct dahdi_trunkdev_open) + + + #endif /* _DAHDI_USER_H */ -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/34010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Iffd9a1a09d835b29927acd374364cab56745fb74 Gerrit-Change-Number: 34010 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in dahdi-linux[master]: xpp_usb: Fix for 32bit architectures: use div_s64()
by laforge 29 Jul '23

29 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/34009 ) Change subject: xpp_usb: Fix for 32bit architectures: use div_s64() ...................................................................... xpp_usb: Fix for 32bit architectures: use div_s64() Change-Id: Ib5cef80c018f800cc0a0cd08a51d6cb7afd584c6 --- M drivers/dahdi/xpp/xpp_usb.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/09/34009/1 diff --git a/drivers/dahdi/xpp/xpp_usb.c b/drivers/dahdi/xpp/xpp_usb.c index 65f646a..0660de3 100644 --- a/drivers/dahdi/xpp/xpp_usb.c +++ b/drivers/dahdi/xpp/xpp_usb.c @@ -886,7 +886,7 @@ usec = 0; /* System clock jumped */ if (usec > xusb->max_tx_delay) xusb->max_tx_delay = usec; - i = usec / USEC_BUCKET; + i = div_s64(usec, USEC_BUCKET); if (i >= NUM_BUCKETS) i = NUM_BUCKETS - 1; xusb->usb_tx_delay[i]++; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/34009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ib5cef80c018f800cc0a0cd08a51d6cb7afd584c6 Gerrit-Change-Number: 34009 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-tetra[master]: Added keyfile parsing code and various crypto improvements
by wbokslag 29 Jul '23

29 Jul '23

Attention is currently required from: laforge. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33997 ) Change subject: Added keyfile parsing code and various crypto improvements ...................................................................... Patch Set 2: (1 comment) File src/tetra-rx.c: https://gerrit.osmocom.org/c/osmo-tetra/+/33997/comment/6bac42b9_f522ca10 PS2, Line 96: talloc > again, just FYI: talloc is hieararchical. […] Sorry, I was unfamiliar with that structure, I'll change it in a next patch then. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c7afeeb2dcf97ece44bb4b604f44ba88882b93f Gerrit-Change-Number: 33997 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 29 Jul 2023 15:03:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[L] Change in osmo-trx[master]: ms/va: add test tool and data
by fixeria 29 Jul '23

29 Jul '23

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33945 ) Change subject: ms/va: add test tool and data ...................................................................... Patch Set 12: Code-Review-1 (4 comments) File utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/7e68a9c5_9fa1e24d PS12, Line 9: osmo_prbs_tool_CPPFLAGS = $(LIBOSMOCODING_CFLAGS) : osmo_prbs_tool_CFLAGS = -Wall Things are still messed up here: * `CPPFLAGS` is for the preprocessor flags, like `-I PATH` and `-DHAVE_FOO_BAR`; * `CFLAGS` is for the compiler flags, like `$(LIBOSMOCODING_CFLAGS)` in this case. So can we just keep the `AM_CFLAGS = -Wall` line above unchanged, and put `$(LIBOSMOCODING_CFLAGS)` into the proper place (`osmo_prbs_tool_CFLAGS`)? https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/cf09bad8_830121f7 PS12, Line 18: ../Transceiver52M `${top_srcdir}/Transceiver52M/libtransceiver_common.la` https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/746963f3_c2118e29 PS12, Line 26: UHD_CFLAGS `UHD_CFLAGS` should be in `osmo_burst_gen_CXXFLAGS` (C++ compiler flags). https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/55581a69_764d766f PS12, Line 26: $(UHD_CFLAGS) "No newline at end of right file." -- please do not remove NLs, they're added on purpose. A programming friendly editor should add them automatically, and git is known to complain about missing NLs. https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-n… https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a… -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie38ed4996134e84ad0481872a743299bb442b3db Gerrit-Change-Number: 33945 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Jul 2023 13:49:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-trx[master]: ms: restructure the va code to add rach support
by fixeria 29 Jul '23

29 Jul '23

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33944 ) Change subject: ms: restructure the va code to add rach support ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4a5cedc8c9a3289c75ce7b914eac286e601ebed0 Gerrit-Change-Number: 33944 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Jul 2023 13:36:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-trx[master]: ms: restructure the va code to add rach support
by fixeria 29 Jul '23

29 Jul '23

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33944 ) Change subject: ms: restructure the va code to add rach support ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4a5cedc8c9a3289c75ce7b914eac286e601ebed0 Gerrit-Change-Number: 33944 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Jul 2023 13:36:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-trx[master]: ms: update osmocom-bb
by fixeria 29 Jul '23

29 Jul '23

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33927 ) Change subject: ms: update osmocom-bb ...................................................................... Patch Set 6: (1 comment) File Transceiver52M/ms/logging.c: https://gerrit.osmocom.org/c/osmo-trx/+/33927/comment/4a850512_ac7fda1b PS6, Line 46: DTRXC Neither `DTRXC` nor `DTRXD` is really needed here, since osmo-trx-ms does not speak TRXC/TRXD. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6f9fca7a4d6a02e82bf406fd136c5bde96bb93af Gerrit-Change-Number: 33927 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 29 Jul 2023 13:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-tetra[master]: Added functions that prepare for decryption
by wbokslag 29 Jul '23

29 Jul '23

Attention is currently required from: laforge. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/34001 ) Change subject: Added functions that prepare for decryption ...................................................................... Patch Set 5: (3 comments) Patchset: PS5: Updated as requested File src/crypto/tetra_crypto.c: https://gerrit.osmocom.org/c/osmo-tetra/+/34001/comment/73bf6935_5014110e PS2, Line 207: case KSG_TEA1: : tea1_stub(iv, eck, num_bytes, ks_bytes); : break; : case KSG_TEA2: : tea2_stub(iv, eck, num_bytes, ks_bytes); : break; : case KSG_TEA3: : tea3_stub(iv, eck, num_bytes, ks_bytes); : break; > I think it's a bit weird to add the stub functions that don't do anything in a commit here. […] Done https://gerrit.osmocom.org/c/osmo-tetra/+/34001/comment/73ff2637_1bea21c5 PS2, Line 305: / > we typically prefer /* */ comments. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 Gerrit-Change-Number: 34001 Gerrit-PatchSet: 5 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 29 Jul 2023 11:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmo-tetra[master]: Added functions that prepare for decryption
by wbokslag 29 Jul '23

29 Jul '23

Attention is currently required from: wbokslag. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 to look at the new patch set (#5). Change subject: Added functions that prepare for decryption ...................................................................... Added functions that prepare for decryption Added functions that will eventually allow for mac resource decryption, voice/traffic decryption and identity decryption. Calls to the true TEA keystream generator functions and TA61 identity decryption function will need to be added in a later patch. Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 --- M src/crypto/tetra_crypto.c M src/crypto/tetra_crypto.h 2 files changed, 131 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/01/34001/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 Gerrit-Change-Number: 34001 Gerrit-PatchSet: 5 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-tetra[master]: Added functions that prepare for decryption functionality
by wbokslag 29 Jul '23

29 Jul '23

Attention is currently required from: wbokslag. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 to look at the new patch set (#4). Change subject: Added functions that prepare for decryption functionality ...................................................................... Added functions that prepare for decryption functionality Added functions that will eventually allow for mac resource decryption, voice/traffic decryption and identity decryption. Calls to the true TEA keystream generator functions and TA61 identity decryption function will need to be added in a later patch. Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 --- M src/crypto/tetra_crypto.c M src/crypto/tetra_crypto.h 2 files changed, 131 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/01/34001/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1 Gerrit-Change-Number: 34001 Gerrit-PatchSet: 4 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newpatchset

1 0