Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/33945 ) Change subject: ms/va: add test tool and data ...................................................................... Patch Set 12: Code-Review-1 (4 comments) File utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/7e68a9c5_9fa1e24d PS12, Line 9: osmo_prbs_tool_CPPFLAGS = $(LIBOSMOCODING_CFLAGS) : osmo_prbs_tool_CFLAGS = -Wall Things are still messed up here: * `CPPFLAGS` is for the preprocessor flags, like `-I PATH` and `-DHAVE_FOO_BAR`; * `CFLAGS` is for the compiler flags, like `$(LIBOSMOCODING_CFLAGS)` in this case. So can we just keep the `AM_CFLAGS = -Wall` line above unchanged, and put `$(LIBOSMOCODING_CFLAGS)` into the proper place (`osmo_prbs_tool_CFLAGS`)? https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/cf09bad8_830121f7 PS12, Line 18: ../Transceiver52M `${top_srcdir}/Transceiver52M/libtransceiver_common.la` https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/746963f3_c2118e29 PS12, Line 26: UHD_CFLAGS `UHD_CFLAGS` should be in `osmo_burst_gen_CXXFLAGS` (C++ compiler flags). https://gerrit.osmocom.org/c/osmo-trx/+/33945/comment/55581a69_764d766f PS12, Line 26: $(UHD_CFLAGS) "No newline at end of right file." -- please do not remove NLs, they're added on purpose. A programming friendly editor should add them automatically, and git is known to complain about missing NLs. https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-no... https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie38ed4996134e84ad0481872a743299bb442b3db Gerrit-Change-Number: 33945 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Comment-Date: Sat, 29 Jul 2023 13:49:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment