Attention is currently required from: Hoernchen.

Patch set 12:Code-Review -1

4 comments:

File utils/Makefile.am:
- Patch Set #12, Line 9:
```
osmo_prbs_tool_CPPFLAGS = $(LIBOSMOCODING_CFLAGS)
osmo_prbs_tool_CFLAGS = -Wall
```
  Things are still messed up here:
  - `CPPFLAGS` is for the preprocessor flags, like `-I PATH` and `-DHAVE_FOO_BAR`;
  - `CFLAGS` is for the compiler flags, like `$(LIBOSMOCODING_CFLAGS)` in this case.
  So can we just keep the `AM_CFLAGS = -Wall` line above unchanged,
  and put `$(LIBOSMOCODING_CFLAGS)` into the proper place (`osmo_prbs_tool_CFLAGS`)?
- Patch Set #12, Line 18: ../Transceiver52M
  `${top_srcdir}/Transceiver52M/libtransceiver_common.la`
- Patch Set #12, Line 26: UHD_CFLAGS
  `UHD_CFLAGS` should be in `osmo_burst_gen_CXXFLAGS` (C++ compiler flags).
- Patch Set #12, Line 26: $(UHD_CFLAGS)
  "No newline at end of right file." -- please do not remove NLs, they're added on purpose. A programming friendly editor should add them automatically, and git is known to complain about missing NLs.
  https://stackoverflow.com/questions/5813311/whats-the-significance-of-the-no-newline-at-end-of-file-log
  https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

To view, visit change 33945. To unsubscribe, or for help writing mail filters, visit settings.