Attention is currently required from: laforge.
wbokslag has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-tetra/+/34001 )
Change subject: Added functions that prepare for decryption
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5:
Updated as requested
File src/crypto/tetra_crypto.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/34001/comment/73bf6935_5014110e
PS2, Line 207: case KSG_TEA1:
: tea1_stub(iv, eck, num_bytes, ks_bytes);
: break;
: case KSG_TEA2:
: tea2_stub(iv, eck, num_bytes, ks_bytes);
: break;
: case KSG_TEA3:
: tea3_stub(iv, eck, num_bytes, ks_bytes);
: break;
I think it's a bit weird to add the stub functions
that don't do anything in a commit here. […]
Done
https://gerrit.osmocom.org/c/osmo-tetra/+/34001/comment/73ff2637_1bea21c5
PS2, Line 305: /
we typically prefer /* */ comments. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-tetra/+/34001
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I4e6147f206ad6046f32e08015ec9721b64382ca1
Gerrit-Change-Number: 34001
Gerrit-PatchSet: 5
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 29 Jul 2023 11:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment