Attention is currently required from: falconia, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32970 )
Change subject: all models, HR1 codec: select RTP output format via vty option
......................................................................
Patch Set 4:
(1 comment)
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/f5676108_5b5d8b90
PS4, Line 388: switch (bts->variant) {
This should go inside each bts_model_init() implementation. Feel free to set bts->emit_hr_rfc5993 = true before calling bts_model_init(), and in bts_osmo_* change it to false.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32970
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I168191874a062429a57904511a1e89e3f588732e
Gerrit-Change-Number: 32970
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 26 May 2023 10:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: matanp.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32712 )
Change subject: Add FPLMN read and program
......................................................................
Patch Set 5:
(1 comment)
File pysim-testdata/sysmoUSIM-SJS1.ok:
https://gerrit.osmocom.org/c/pysim/+/32712/comment/2e2cbfe8_c5cc2083
PS5, Line 108: 62f201 # MCC: 262 MNC: 010
I wonder how the 2 digit and 3 digit mnc is differentiated.
In this example those are 2 digit mncs.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32712
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b
Gerrit-Change-Number: 32712
Gerrit-PatchSet: 5
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-Comment-Date: Fri, 26 May 2023 08:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment