May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: layer23: modem: sndcp: Properly inform SNDCP layer of ownsership tran...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32593 ) Change subject: layer23: modem: sndcp: Properly inform SNDCP layer of ownsership transfer ...................................................................... layer23: modem: sndcp: Properly inform SNDCP layer of ownsership transfer Change-Id: Icc3351f360e41d4a95e056b4fd797c7d133e8a83 --- M src/host/layer23/src/modem/sndcp.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/93/32593/1 diff --git a/src/host/layer23/src/modem/sndcp.c b/src/host/layer23/src/modem/sndcp.c index fd6aada..b36073c 100644 --- a/src/host/layer23/src/modem/sndcp.c +++ b/src/host/layer23/src/modem/sndcp.c @@ -146,6 +146,7 @@ case OSMO_PRIM(OSMO_GPRS_SM_SMREG_PDP_ACTIVATE, PRIM_OP_RESPONSE): LOGP(DSNDCP, LOGL_INFO, "%s(): Rx %s\n", __func__, npdu_name); rc = osmo_gprs_sm_prim_sndcp_upper_down(sndcp_prim); + rc = 1; /* Tell SNDCP layer we took msgb ownsership and transfer it to SM */ break; default: LOGP(DSNDCP, LOGL_ERROR, "%s(): Unexpected Rx %s\n", __func__, npdu_name); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icc3351f360e41d4a95e056b4fd797c7d133e8a83 Gerrit-Change-Number: 32593 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Activate PDP Context of APN after GPRS attach

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32590 ) Change subject: layer23: modem: gmm: Activate PDP Context of APN after GPRS attach ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icb667a6a3359267d2eb20e11a40eb27a8c3f7e2d Gerrit-Change-Number: 32590 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 12:51:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32589 ) Change subject: layer23: modem: grr: Log ignored CCCH ImmAss ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaecd2616733d84f35a825916fe888142800b426b Gerrit-Change-Number: 32589 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 12:50:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: sm: Properly inform SM layer of ownsership transfer

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32588 ) Change subject: layer23: modem: sm: Properly inform SM layer of ownsership transfer ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32588/comment/282c6286_5999cfed PS1, Line 7: ownsership ownership -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I95ed63fe6442369ab3afb75cbd9908b87addbb3e Gerrit-Change-Number: 32588 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 12:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: sndcp: Forward LL-XID.req SNDCP->LLC

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32587 ) Change subject: layer23: modem: sndcp: Forward LL-XID.req SNDCP->LLC ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icbc033cd0659bba75bb280a3d46e76edd2e20226 Gerrit-Change-Number: 32587 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 12:47:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: modem: Delay GPRS attach at startup until modem is ready

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32567 ) Change subject: layer23: modem: Delay GPRS attach at startup until modem is ready ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/host/layer23/include/osmocom/bb/modem/modem.h: https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/821942a9_eb7ee836 PS1, Line 12: }; what's the rationale behind not using a full osmo_fsm? File src/host/layer23/src/modem/app_modem.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/1a22237b_074e3276 PS1, Line 83: LOGP(DRLCMAC, LOGL_INFO, "Delaying GPRS attach, waiting for:%s%s%s%s%s%s\n", How about moving this log message into modem_gprs_attach_if_needed()? From the function names this would make more sense IMHO. Not critical. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5029d9e8a47b8544b3b803c4db6352269bac3c0e Gerrit-Change-Number: 32567 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 12:46:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: sndcp: Allow cb users taking ownership of primitives

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32586 to look at the new patch set (#2). Change subject: sndcp: Allow cb users taking ownership of primitives ...................................................................... sndcp: Allow cb users taking ownership of primitives Change-Id: Ie3ddc835d8393e934d3f357108c81f639247c485 --- M src/sndcp/sndcp_prim.c 1 file changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/86/32586/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie3ddc835d8393e934d3f357108c81f639247c485 Gerrit-Change-Number: 32586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: sm: Fix pdp_act_cnf.accepted flag value swapped

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32592 ) Change subject: sm: Fix pdp_act_cnf.accepted flag value swapped ...................................................................... sm: Fix pdp_act_cnf.accepted flag value swapped Change-Id: Ieb7b4ce7121b82c40dbd16a50981390b47d94c82 --- M src/sm/sm.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/92/32592/1 diff --git a/src/sm/sm.c b/src/sm/sm.c index 4e07f94..1f87f4e 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -208,7 +208,7 @@ sm_prim_tx = gprs_sm_prim_alloc_smreg_pdp_act_cnf(); sm_prim_tx->smreg.ms_id = sme->ms->ms_id; - sm_prim_tx->smreg.pdp_act_cnf.accepted = (cause != 0); + sm_prim_tx->smreg.pdp_act_cnf.accepted = (cause == 0); sm_prim_tx->smreg.pdp_act_cnf.nsapi = sme->nsapi; sm_prim_tx->smreg.pdp_act_cnf.pco_len = sme->pco_len; if (sme->pco_len) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ieb7b4ce7121b82c40dbd16a50981390b47d94c82 Gerrit-Change-Number: 32592 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: modem: Resolve auth requests coming from GMM layer

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32551 ) Change subject: layer23: modem: Resolve auth requests coming from GMM layer ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I75dc3fe3e4d9e23443fb778e36ca024f1bc46641 Gerrit-Change-Number: 32551 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 May 2023 12:35:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmo-gprs[master]: sndcp: Initiate LL-XID.req only if we have something to send at L3

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32591 ) Change subject: sndcp: Initiate LL-XID.req only if we have something to send at L3 ...................................................................... sndcp: Initiate LL-XID.req only if we have something to send at L3 Change-Id: I324d841ae4d725d55d2807067cdd56c4457fa941 --- M src/sndcp/sndcp_prim.c M tests/sndcp/sndcp_prim_test.ok 2 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/91/32591/1 diff --git a/src/sndcp/sndcp_prim.c b/src/sndcp/sndcp_prim.c index 9281784..42fbe0f 100644 --- a/src/sndcp/sndcp_prim.c +++ b/src/sndcp/sndcp_prim.c @@ -634,9 +634,14 @@ * return rc; */ - /* TS 24.007 C.6 "LLC link exists already, only XID exchange" */ - sne->xid_req_in_transit_orig_snsm_activate_ind = true; - rc = gprs_sndcp_sne_submit_llc_ll_xid_req(sne); + if (sne->l3xid_req && sne->l3xid_req_len > 0) { + /* TS 24.007 C.6 "LLC link exists already, only XID exchange" */ + sne->xid_req_in_transit_orig_snsm_activate_ind = true; + rc = gprs_sndcp_sne_submit_llc_ll_xid_req(sne); + } else { + /* TS 24.007 C.6 "LLC link exists already, no XID exchange"*/ + rc = gprs_sndcp_sne_submit_snsm_activate_rsp(sne); + } return rc; } diff --git a/tests/sndcp/sndcp_prim_test.ok b/tests/sndcp/sndcp_prim_test.ok index 621aea7..9476e44 100644 --- a/tests/sndcp/sndcp_prim_test.ok +++ b/tests/sndcp/sndcp_prim_test.ok @@ -5,7 +5,6 @@ test_sndcp_prim_down_cb(): Rx LL-UNITDATA.request TLLI=0xe1c5d364 SAPI=SNDCP3 L3=[65 00 00 00 73 6f 6d 65 2d 6e 70 64 75 2d 64 61 74 61 2d 6c 69 6b 65 2d 61 6e 2d 69 70 2d 70 6b 74 00 ] ==== test_sndcp_prim_net() [end] ==== ==== test_sndcp_prim_ms() [start] ==== -test_sndcp_prim_down_cb(): Rx LL-XID.request test_sndcp_prim_snsm_cb(): Rx SNSM-ACTIVATE.response test_sndcp_prim_down_cb(): Rx LL-XID.request test_sndcp_prim_up_cb(): Rx SN-XID.confirm -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I324d841ae4d725d55d2807067cdd56c4457fa941 Gerrit-Change-Number: 32591 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023