Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31659 )
Change subject: mobile: log MCC/MNC of the network while registering
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I'd have printed the MCC-MNC in numeric version (too), but that's a matter of taste.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31659
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I114eade36303f161fea171745a1a9b05e461e349
Gerrit-Change-Number: 31659
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 05 Mar 2023 17:48:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31666 )
Change subject: libosmocore.map: Add two missing entries for gsmtap*2() API
......................................................................
libosmocore.map: Add two missing entries for gsmtap*2() API
Those functions were introduced in I51b3604ba79e42c474aa17007e7e308a12afcea8
but the recent introduction of libosmocore.map didn't list them
Change-Id: I4ac14aae13ff60c110444da989761cd1e86f8925
Fixes: I13169c00a59fb59513dfc598de5a71d094492422
---
M src/core/libosmocore.map
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map
index 984046b..bd1b3d9 100644
--- a/src/core/libosmocore.map
+++ b/src/core/libosmocore.map
@@ -49,7 +49,9 @@
gsmtap_source_add_sink_fd;
gsmtap_source_free;
gsmtap_source_init;
+gsmtap_source_init2;
gsmtap_source_init_fd;
+gsmtap_source_init_fd2;
gsmtap_type_names;
log_add_target;
log_category_name;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4ac14aae13ff60c110444da989761cd1e86f8925
Gerrit-Change-Number: 31666
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31666 )
Change subject: libosmocore.map: Add two missing entries for gsmtap*2() API
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4ac14aae13ff60c110444da989761cd1e86f8925
Gerrit-Change-Number: 31666
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 05 Mar 2023 17:47:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31666 )
Change subject: libosmocore.map: Add two missing entries for gsmtap*2() API
......................................................................
libosmocore.map: Add two missing entries for gsmtap*2() API
Those functions were introduced in I51b3604ba79e42c474aa17007e7e308a12afcea8
but the recent introduction of libosmocore.map didn't list them
Change-Id: I4ac14aae13ff60c110444da989761cd1e86f8925
Fixes: I13169c00a59fb59513dfc598de5a71d094492422
---
M src/core/libosmocore.map
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/31666/1
diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map
index 984046b..bd1b3d9 100644
--- a/src/core/libosmocore.map
+++ b/src/core/libosmocore.map
@@ -49,7 +49,9 @@
gsmtap_source_add_sink_fd;
gsmtap_source_free;
gsmtap_source_init;
+gsmtap_source_init2;
gsmtap_source_init_fd;
+gsmtap_source_init_fd2;
gsmtap_type_names;
log_add_target;
log_category_name;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4ac14aae13ff60c110444da989761cd1e86f8925
Gerrit-Change-Number: 31666
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31173 )
Change subject: Add libosmocore.map
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Patchset:
PS3:
> maybe check again that no new symbols were introduced between the time of writing this patch and the […]
it appears this was not done (or some things were overlooked). Then the patch was merged on a friday, creating build fall-out for all osmo-bts* jobs over the weekend with nobody fixing them while users notice and report it on IRC :/
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31173
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I13169c00a59fb59513dfc598de5a71d094492422
Gerrit-Change-Number: 31173
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 05 Mar 2023 17:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31659 )
Change subject: mobile: log MCC/MNC of the network while registering
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31659
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I114eade36303f161fea171745a1a9b05e461e349
Gerrit-Change-Number: 31659
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 05 Mar 2023 17:12:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment