March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: contrib/talloc_count.sh: improve hexadecimal masking
by neels 13 Mar '23

13 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31873 ) Change subject: contrib/talloc_count.sh: improve hexadecimal masking ...................................................................... contrib/talloc_count.sh: improve hexadecimal masking Also mask hexadecimal without leading 0x. But take care to not match on every letter a-f,A-F in normal words and names. before: 10 map_rua(NffffNfNecN-example-com-RUA-N)[N] 10 map_sccp(NffffNfNecN-example-com-SCCP-N)[N] 17 map_rua(NffffNcN-example-com-RUA-N)[N] 17 map_sccp(NffffNcN-example-com-SCCP-N)[N] 18 map_rua(NffffNeNbN-example-com-RUA-N)[N] 18 map_sccp(NffffNeNbN-example-com-SCCP-N)[N] 82 map_rua(NffffNfNdN-example-com-RUA-N)[N] 82 map_sccp(NffffNfNdN-example-com-SCCP-N)[N] 85 map_rua(NffffNfN-example-com-RUA-N)[N] 85 map_sccp(NffffNfN-example-com-SCCP-N)[N] 224 struct hnbgw_context_map after: 224 map_rua(N-example-com-RUA-N)[N] 224 map_sccp(N-example-com-SCCP-N)[N] 224 struct hnbgw_context_map Change-Id: I1b42ce3e67c7ed2d38d3e5c9cbfa90ba185a07b7 --- M contrib/talloc_count.sh 1 file changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/73/31873/1 diff --git a/contrib/talloc_count.sh b/contrib/talloc_count.sh index 3b03585..61aa3f5 100755 --- a/contrib/talloc_count.sh +++ b/contrib/talloc_count.sh @@ -35,6 +35,7 @@ | grep -v '^$' \ | grep -v '^[0-9]\+$' \ | sed 's/0x[0-9a-fA-F]\+/N/g' \ + | sed 's/\<[0-9a-fA-F]\+\>/N/g' \ | sed 's/[0-9]\+/N/g' \ | sort \ > "$mangled" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b42ce3e67c7ed2d38d3e5c9cbfa90ba185a07b7 Gerrit-Change-Number: 31873 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: fix 'make vty-test' for --disable-external-tests --enable-gb
by neels 13 Mar '23

13 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31872 ) Change subject: fix 'make vty-test' for --disable-external-tests --enable-gb ...................................................................... fix 'make vty-test' for --disable-external-tests --enable-gb Change-Id: I80ac270bfb563a769a7746d8fbceac09e267ce03 --- M utils/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/31872/1 diff --git a/utils/Makefile.am b/utils/Makefile.am index c068ee2..8937ad9 100644 --- a/utils/Makefile.am +++ b/utils/Makefile.am @@ -31,6 +31,7 @@ SUBDIRS = \ osmo-stat-dummy \ $(NULL) +endif if ENABLE_GB noinst_PROGRAMS += osmo-ns-dummy @@ -41,4 +42,3 @@ $(top_builddir)/src/ctrl/libosmoctrl.la \ $(NULL) endif -endif -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I80ac270bfb563a769a7746d8fbceac09e267ce03 Gerrit-Change-Number: 31872 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: fix 'make vty-test' for --disable-gb
by neels 13 Mar '23

13 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31871 ) Change subject: fix 'make vty-test' for --disable-gb ...................................................................... fix 'make vty-test' for --disable-gb Change-Id: Ib6aec784d3b20cd56cb6bfab9ff17da35a282406 --- M tests/Makefile.am 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/31871/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 275cf5f..55124ca 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -701,6 +701,7 @@ # pass -u to osmo_verify_transcript_vty.py by doing: # make vty-test U=-u +if ENABLE_GB vty-test-ns2: $(MAKE) -C $(top_builddir)/utils osmo-ns-dummy osmo_verify_transcript_vty.py -v \ @@ -709,6 +710,10 @@ $(U) $(srcdir)/gb/gprs_ns2*.vty osmotestvty.py -p $(abs_top_srcdir)/tests/gb -w $(abs_top_builddir)/tests/gb -v osmotestconfig.py -p $(abs_top_srcdir)/tests/gb -w $(abs_top_builddir)/tests/gb -v +else +vty-test-ns2: + echo "Not running vty-test-ns2 because osmo-ns-dummy is not built (--disable-gb)" +endif vty-test-logging: osmo_verify_transcript_vty.py -v \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib6aec784d3b20cd56cb6bfab9ff17da35a282406 Gerrit-Change-Number: 31871 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by pespin 13 Mar '23

13 Mar '23

Attention is currently required from: osmith, neels, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 13: (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/7996a975_08dc03f7 PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src); > I've manually checked and I've also submitted the changes to facilitate this check as a separate pat […] Fine if you checked manually then. "No idea what's wrong with the grep command you've posted" well, this code here relates to logging through gsmtap, and the test you modified in the next patch seems to be doing nothing with gsmtap logging? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 16:38:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by msuraev 13 Mar '23

13 Mar '23

Attention is currently required from: osmith, neels, pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 13: (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/ceb21a93_c62bbce5 PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src); > But afaiu the test you are extending there doesn't seem to be using gsmtap at all? […] I've manually checked and I've also submitted the changes to facilitate this check as a separate patch. No idea what's wrong with the grep command you've posted - you can manually verify it by opening corresponding file from Files tab in web UI. It's supposed to be part of the review process anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 16:36:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: logging: print talloc report on exit from vty test
by msuraev 13 Mar '23

13 Mar '23

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31868 ) Change subject: logging: print talloc report on exit from vty test ...................................................................... Patch Set 3: (1 comment) File tests/logging/logging_vty_test.c: https://gerrit.osmocom.org/c/libosmocore/+/31868/comment/604722d5_8a043d88 PS3, Line 288: talloc_report(tall_vty_ctx, stderr); > So I assumed since you didn't change the .ok and . […] There's neither .err nor .ok associated with the file I've changed - the corresponding test is ran as part of external tests, the report is printed to stderr and ignored as expected. It's also printed just fine during manual tests. So, nope - nothing weird :) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31868 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5739bceb90d36164fd4cbf21242bbe26bd1e7075 Gerrit-Change-Number: 31868 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 16:32:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by pespin 13 Mar '23

13 Mar '23

Attention is currently required from: osmith, neels, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 13: (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/5bd0a965_df689775 PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src); > See - https://gerrit.osmocom. […] But afaiu the test you are extending there doesn't seem to be using gsmtap at all? $ grep -rIc gsmtap libosmocore/tests/logging libosmocore/tests/logging/logging_test.ok:0 libosmocore/tests/logging/logging_test.c:0 libosmocore/tests/logging/logging_test.err:0 libosmocore/tests/logging/logging_vty_test.c:0 libosmocore/tests/logging/logging_vty_test.vty:0 In any case, I was basically asking if you can look that you checked and made sure the pointer was not allocated already in any of the functions called before it being assigned here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 16:17:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: logging: print talloc report on exit from vty test
by pespin 13 Mar '23

13 Mar '23

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31868 ) Change subject: logging: print talloc report on exit from vty test ...................................................................... Patch Set 3: (1 comment) File tests/logging/logging_vty_test.c: https://gerrit.osmocom.org/c/libosmocore/+/31868/comment/1abe3805_6827de56 PS3, Line 288: talloc_report(tall_vty_ctx, stderr); So I assumed since you didn't change the .ok and .err file, that nothing is printed and hence nothing is allocated? Sounds weird doesn't it? :/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31868 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5739bceb90d36164fd4cbf21242bbe26bd1e7075 Gerrit-Change-Number: 31868 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 16:13:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by pespin 13 Mar '23

13 Mar '23

Attention is currently required from: osmith, neels, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 13: (1 comment) File utils/osmo-stat-dummy/osmo-stat-dummy.cfg: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/27980e14_4b714106 PS4, Line 1: log gsmtap 127.0.0.69 127.6.9.1 > The purpose is described in the README - it's to test statsd and rate counters. […] "Having any kind of logging setup does not affect it in any way." That's precisely my point. No need in having this setting in there. It does not improve the default config in any way. In my opinion it worses it, as per what users would expect by default when a socket is created. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 16:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: bsc_subscriber: Mark functions used only internally as static
by pespin 13 Mar '23

13 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31870 ) Change subject: bsc_subscriber: Mark functions used only internally as static ...................................................................... bsc_subscriber: Mark functions used only internally as static Change-Id: I846af993905aee0be75aa3021460b130362c6d3d --- M include/osmocom/bsc/bsc_subscriber.h M src/osmo-bsc/bsc_subscriber.c 2 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/31870/1 diff --git a/include/osmocom/bsc/bsc_subscriber.h b/include/osmocom/bsc/bsc_subscriber.h index da2115f..a86ea5f 100644 --- a/include/osmocom/bsc/bsc_subscriber.h +++ b/include/osmocom/bsc/bsc_subscriber.h @@ -31,9 +31,6 @@ struct bsc_subscr *bsc_subscr_find_or_create_by_imsi(struct llist_head *list, const char *imsi, const char *use_token); -struct bsc_subscr *bsc_subscr_find_or_create_by_imei(struct llist_head *list, - const char *imei, - const char *use_token); struct bsc_subscr *bsc_subscr_find_or_create_by_tmsi(struct llist_head *list, uint32_t tmsi, const char *use_token); @@ -43,12 +40,6 @@ struct bsc_subscr *bsc_subscr_find_by_imsi(struct llist_head *list, const char *imsi, const char *use_token); -struct bsc_subscr *bsc_subscr_find_by_imei(struct llist_head *list, - const char *imei, - const char *use_token); -struct bsc_subscr *bsc_subscr_find_by_tmsi(struct llist_head *list, - uint32_t tmsi, - const char *use_token); void bsc_subscr_set_imsi(struct bsc_subscr *bsub, const char *imsi); void bsc_subscr_set_imei(struct bsc_subscr *bsub, const char *imei); diff --git a/src/osmo-bsc/bsc_subscriber.c b/src/osmo-bsc/bsc_subscriber.c index 31dfc05..6815ab5 100644 --- a/src/osmo-bsc/bsc_subscriber.c +++ b/src/osmo-bsc/bsc_subscriber.c @@ -103,9 +103,9 @@ return NULL; } -struct bsc_subscr *bsc_subscr_find_by_imei(struct llist_head *list, - const char *imei, - const char *use_token) +static struct bsc_subscr *bsc_subscr_find_by_imei(struct llist_head *list, + const char *imei, + const char *use_token) { struct bsc_subscr *bsub; @@ -121,9 +121,9 @@ return NULL; } -struct bsc_subscr *bsc_subscr_find_by_tmsi(struct llist_head *list, - uint32_t tmsi, - const char *use_token) +static struct bsc_subscr *bsc_subscr_find_by_tmsi(struct llist_head *list, + uint32_t tmsi, + const char *use_token) { struct bsc_subscr *bsub; @@ -169,9 +169,9 @@ return bsub; } -struct bsc_subscr *bsc_subscr_find_or_create_by_imei(struct llist_head *list, - const char *imei, - const char *use_token) +static struct bsc_subscr *bsc_subscr_find_or_create_by_imei(struct llist_head *list, + const char *imei, + const char *use_token) { struct bsc_subscr *bsub; bsub = bsc_subscr_find_by_imei(list, imei, use_token); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I846af993905aee0be75aa3021460b130362c6d3d Gerrit-Change-Number: 31870 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0