March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: osmoappdesc.py: add more config files for testing
by laforge 31 Mar '23

31 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32132 ) Change subject: osmoappdesc.py: add more config files for testing ...................................................................... osmoappdesc.py: add more config files for testing Change-Id: I9199f3e39c677dfd6e3936b9cf4897a070156b03 --- M osmoappdesc.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/osmoappdesc.py b/osmoappdesc.py index 08c3252..4565a22 100644 --- a/osmoappdesc.py +++ b/osmoappdesc.py @@ -15,7 +15,10 @@ # along with this program. If not, see <http://www.gnu.org/licenses/> app_configs = { + # TODO: doc/examples/osmo-bsc/{ericsson,nokia,siemens} "osmo-bsc": ["doc/examples/osmo-bsc/osmo-bsc.cfg", + "doc/examples/osmo-bsc/osmo-bsc-minimal.cfg", + "doc/examples/osmo-bsc/osmo-bsc-4trx.cfg", "doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg"] } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9199f3e39c677dfd6e3936b9cf4897a070156b03 Gerrit-Change-Number: 32132 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc
by laforge 31 Mar '23

31 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32116 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc Change-Id: I640dd2cd599707ad6bc661e7bea08372d85b47df --- M tests/Makefile.am 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index 8ee8bec..aac237a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -47,14 +47,14 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: $(top_builddir)/src/osmo-bsc/osmo-bsc $(MAKE) vty-test osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif @@ -64,7 +64,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-test U=-u -vty-test: +vty-test: $(top_builddir)/src/osmo-bsc/osmo-bsc osmo_verify_transcript_vty.py -v \ -n OsmoBSC -p 4242 \ -r "$(top_builddir)/src/osmo-bsc/osmo-bsc -c $(top_srcdir)/doc/examples/osmo-bsc/osmo-bsc-minimal.cfg" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I640dd2cd599707ad6bc661e7bea08372d85b47df Gerrit-Change-Number: 32116 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-bsc[master]: osmoappdesc.py: add more config files for testing
by laforge 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32132 ) Change subject: osmoappdesc.py: add more config files for testing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9199f3e39c677dfd6e3936b9cf4897a070156b03 Gerrit-Change-Number: 32132 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 10:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc
by laforge 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32116 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-bsc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I640dd2cd599707ad6bc661e7bea08372d85b47df Gerrit-Change-Number: 32116 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 10:45:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg
by laforge 31 Mar '23

31 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32136 ) Change subject: osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg ...................................................................... osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg Change-Id: Ib6d0b0cdcfad165ad34d304069843c71f6eb06de --- M osmoappdesc.py 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/osmoappdesc.py b/osmoappdesc.py index 6c1bafa..2fdce25 100644 --- a/osmoappdesc.py +++ b/osmoappdesc.py @@ -1,7 +1,8 @@ #!/usr/bin/env python3 app_configs = { - "osmo-stp": ["doc/examples/osmo-stp.cfg"], + "osmo-stp": ["doc/examples/osmo-stp.cfg", + "doc/examples/osmo-stp-multihome.cfg"], } apps = [(4239, "stp/osmo-stp", "OsmoSTP", "osmo-stp"), -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ib6d0b0cdcfad165ad34d304069843c71f6eb06de Gerrit-Change-Number: 32136 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-stp
by laforge 31 Mar '23

31 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32115 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-stp ...................................................................... tests: $(BUILT_SOURCES) is not defined, depend on osmo-stp Change-Id: I4864f4d78095187f566bcde772b71665fa6e4729 --- M tests/vty/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index 9ed31b0..df5a64c 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -22,7 +22,7 @@ echo "Not running python-based external tests (determined at configure-time)" endif -vty-python-test: $(BUILT_SOURCES) +vty-python-test: $(top_builddir)/stp/osmo-stp $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v # To update the VTY script from current application behavior, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4864f4d78095187f566bcde772b71665fa6e4729 Gerrit-Change-Number: 32115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: tests: execute osmotest{vty,config}.py against osmo-stp
by laforge 31 Mar '23

31 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32135 ) Change subject: tests: execute osmotest{vty,config}.py against osmo-stp ...................................................................... tests: execute osmotest{vty,config}.py against osmo-stp Change-Id: Idd57757f251dd1c4d1c74d275b4c5d8beff304e5 --- M tests/vty/Makefile.am 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/tests/vty/Makefile.am b/tests/vty/Makefile.am index df5a64c..7f67d75 100644 --- a/tests/vty/Makefile.am +++ b/tests/vty/Makefile.am @@ -15,8 +15,10 @@ ss7_asp_vty_test_SOURCES = ss7_asp_vty_test.c if ENABLE_EXT_TESTS -ext-tests: +ext-tests: $(top_builddir)/stp/osmo-stp $(MAKE) vty-test + osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v else ext-tests: echo "Not running python-based external tests (determined at configure-time)" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idd57757f251dd1c4d1c74d275b4c5d8beff304e5 Gerrit-Change-Number: 32135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg
by laforge 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32136 ) Change subject: osmoappdesc.py: also test doc/examples/osmo-stp-multihome.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ib6d0b0cdcfad165ad34d304069843c71f6eb06de Gerrit-Change-Number: 32136 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 10:45:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: tests: execute osmotest{vty,config}.py against osmo-stp
by laforge 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32135 ) Change subject: tests: execute osmotest{vty,config}.py against osmo-stp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idd57757f251dd1c4d1c74d275b4c5d8beff304e5 Gerrit-Change-Number: 32135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 10:45:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: tests: $(BUILT_SOURCES) is not defined, depend on osmo-stp
by laforge 31 Mar '23

31 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32115 ) Change subject: tests: $(BUILT_SOURCES) is not defined, depend on osmo-stp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4864f4d78095187f566bcde772b71665fa6e4729 Gerrit-Change-Number: 32115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Mar 2023 10:45:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0