Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27392 )
Change subject: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
what is the status here? various code review but never any follow-up on it? and by now of course merge conflict
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd201a2749009a4644a29bd77e1d0fc0c124a9d
Gerrit-Change-Number: 27392
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Feb 2023 11:37:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27391 )
Change subject: Revert "mgcp_codec: do not differentiate between oa and bwe when comparing codec"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
what is the status of this patch, pmaier? At the time it had sufficient votes but by now it ended up in a merge conflict.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27391
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0b2854ef2397f38606fab3425be586a3d0ca27d1
Gerrit-Change-Number: 27391
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Feb 2023 11:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30307 )
Change subject: fsms: use configurable timers instead of T23042
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
what is holding this change back from getting rebased + merged?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id0d4d0788f609f3272fc81c80a754383dde25c16
Gerrit-Change-Number: 30307
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Feb 2023 11:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31205 )
Change subject: MGCP_Test: Test ts101318 rfc5993 conversation with fmtp
......................................................................
Patch Set 1:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31205/comment/ea5c2a53_3ae4…
PS1, Line 2312: testcase TC_ts101318_rfc5993_rtp_conversion() runs on dummy_CT {
> maybe use const octetstring definining the strings below containing RTP bytes? This way it's also ea […]
agreeing with pespin.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31205
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I14421f780c4ef9e4c7e91182154070617852e957
Gerrit-Change-Number: 31205
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Feb 2023 11:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/31219 )
Change subject: README.md: Add some basic information in absence of documentation
......................................................................
README.md: Add some basic information in absence of documentation
Change-Id: I4a2955c148f3bf011b96924b7d036e7f118e1e02
---
M README.md
A contrib/osmo-uecups-example.pcap
2 files changed, 81 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/README.md b/README.md
index fc41569..d7dfa10 100644
--- a/README.md
+++ b/README.md
@@ -37,7 +37,87 @@
Documentation
-------------
-FIXME
+Please check the PGW test suite we have at
+https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/branch/master/pgw
+for a full example. This test suite implements the signaling plane of
+simulating UE/MME/SGW towards a PGW (device under test). It uses
+osmo-uecups to simulate the user plane and start commands like "ping"
+within the netns of the simulated UE.
+
+The interface between test suite and osmo-uecups is using
+JSON-serialized commands via a SCTP socket on SCTP port 4268.
+
+JSON Examples from the above PGW tests suite execution look like below. You can find a pcap file containing this example communication in contrib/osmo-uecups-example.pcap
+
+### Initial reset of state:
+
+Request to osmo-uecups:
+```
+{"reset_all_state":{}}
+```
+
+Response from osmo-uecups:
+```
+{"reset_all_state_res": {"result": "OK"}}
+```
+
+### Creating a GTP tunnel / UE with its own tun-device in its own netns
+
+Request to osmo-uecups:
+```
+{
+ "create_tun" : {
+ "local_gtp_ep" : {
+ "Port" : 2152,
+ "addr_type" : "IPV4",
+ "ip" : "AC121B14"
+ },
+ "remote_gtp_ep" : {
+ "Port" : 2152,
+ "addr_type" : "IPV4",
+ "ip" : "AC121B07"
+ },
+ "rx_teid" : 2029948341,
+ "tun_dev_name" : "tun23",
+ "tun_netns_name" : "tun23",
+ "tx_teid" : 6,
+ "user_addr" : "0A2D0003",
+ "user_addr_type" : "IPV4"
+ }
+}
+```
+
+Response from osmo-uecups:
+```
+{"create_tun_res": {"result": "OK"}}
+```
+
+### Running a test program (here "ping") inside that netns, just as if the command was executed on the UE
+
+
+Request to osmo-uecups:
+```
+{
+ "start_program" : {
+ "command" : "ping -c 10 -i 1 -I 10.45.0.3 10.45.0.1 1>>/data/TC_createSession_ping4.prog.stdout 2>>/data/TC_createSession_ping4.prog.stderr",
+ "environment" : [],
+ "run_as_user" : "osmocom",
+ "tun_netns_name" : "tun23"
+ }
+}
+```
+
+Initial Response from osmo-uecups (program was started):
+```
+{"start_program_res": {"pid": 12, "result": "OK"}}
+```
+
+Final response from osmo-uecups (program terminated):
+```
+{"program_term_ind": {"exit_code": 0, "pid": 12}}
+```
+
+
Mailing List
------------
diff --git a/contrib/osmo-uecups-example.pcap b/contrib/osmo-uecups-example.pcap
new file mode 100644
index 0000000..f61ee51
--- /dev/null
+++ b/contrib/osmo-uecups-example.pcap
Binary files differ
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/31219
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I4a2955c148f3bf011b96924b7d036e7f118e1e02
Gerrit-Change-Number: 31219
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/31219 )
Change subject: README.md: Add some basic information in absence of documentation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/31219
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I4a2955c148f3bf011b96924b7d036e7f118e1e02
Gerrit-Change-Number: 31219
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Feb 2023 11:28:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment