February 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30726 ) Change subject: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE ...................................................................... Abandoned This patch is abandonned since we have found a different approach. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id53ebebdf987fc59cf4e38bcddb75663fd7bb8fc Gerrit-Change-Number: 30726 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

[M] Change in osmo-bts[master]: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30629 ) Change subject: rsl: allow configuration of HR GSM RTP format via CHANNEL ACTIVATE ...................................................................... Abandoned This patch is abandonned since we have found a different approach. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id53ebebdf987fc59cf4e38bcddb75663fd7bb8fc Gerrit-Change-Number: 30629 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

[S] Change in osmo-bts[master]: rsl.adoc: add info about RSL_IE_OSMO_HR_GSM_RTP_FMT

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30728 ) Change subject: rsl.adoc: add info about RSL_IE_OSMO_HR_GSM_RTP_FMT ...................................................................... Abandoned This has been abandonned since we have found a different approach that does not need the additional IEI -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1d40f688ad1729efffee846e7f9efd06cf64ce28 Gerrit-Change-Number: 30728 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

[M] Change in osmo-bsc[master]: abis_rsl: signal HR GSM RTP format to BTS via RSL

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30630 ) Change subject: abis_rsl: signal HR GSM RTP format to BTS via RSL ...................................................................... Abandoned This is abandonned since we have found a better approach. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I16804364d95da9e1f5ac3b831c31079a7409e58d Gerrit-Change-Number: 30630 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: open5gs-latest: install missing packages for ttcn3-pgw-test

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31412 ) Change subject: open5gs-latest: install missing packages for ttcn3-pgw-test ...................................................................... open5gs-latest: install missing packages for ttcn3-pgw-test These are present in open5gs-master, but missing in open5gs-latest. Change-Id: Ic9227033d65d621e7f6c5e196a9a8d6a1b73d5da Related: OS#5913 --- M open5gs-latest/Dockerfile 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/12/31412/1 diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile index 683f7c7..870a170 100644 --- a/open5gs-latest/Dockerfile +++ b/open5gs-latest/Dockerfile @@ -11,6 +11,11 @@ apt-get install -y --no-install-recommends \ ca-certificates \ gnupg \ + iproute2 \ + iputils-ping \ + libcap2-bin \ + net-tools \ + sudo \ wget RUN echo "deb [signed-by=$OPEN5GS_KEY] $OPEN5GS_REPO/ ./" \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic9227033d65d621e7f6c5e196a9a8d6a1b73d5da Gerrit-Change-Number: 31412 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: open5gs-latest: add osmocom user for ttcn3-pgw-test

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31413 ) Change subject: open5gs-latest: add osmocom user for ttcn3-pgw-test ...................................................................... open5gs-latest: add osmocom user for ttcn3-pgw-test In ttcn3-pgw-test we're running open5gs-upfd as a non-root user. We do have this user in open5gs-master, but not in open5gs-latest. Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079 Related: OS#5913 --- M open5gs-latest/Dockerfile 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/13/31413/1 diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile index 870a170..724268c 100644 --- a/open5gs-latest/Dockerfile +++ b/open5gs-latest/Dockerfile @@ -30,3 +30,9 @@ apt-get install -y \ mongodb-org \ open5gs + +# crate user +ARG username=osmocom +RUN useradd -m --uid=1000 ${username} && \ + echo "${username} ALL=(root) NOPASSWD:ALL" > /etc/sudoers.d/${username} && \ + chmod 0440 /etc/sudoers.d/${username} -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9139fc52fa6973cf495559d3c4202d9f804a2079 Gerrit-Change-Number: 31413 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in docker-playground[master]: osmo-uecups-latest: install missing iputils-ping

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31411 ) Change subject: osmo-uecups-latest: install missing iputils-ping ...................................................................... osmo-uecups-latest: install missing iputils-ping ping is needed for ttcn3-pgw-test. In the case of osmo-uecups-master it's available from the parent $DISTRO-build image, but for the -latest it needs to be installed by the inherited image itself. Change-Id: Ia1b9124f09203c7dcf6d26dee78b09d5a139a04f Related: OS#5913 --- M osmo-uecups-latest/Dockerfile 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/11/31411/1 diff --git a/osmo-uecups-latest/Dockerfile b/osmo-uecups-latest/Dockerfile index a46ce06..9546720 100644 --- a/osmo-uecups-latest/Dockerfile +++ b/osmo-uecups-latest/Dockerfile @@ -9,6 +9,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ + iputils-ping \ osmo-uecups && \ apt-get clean \ ;; \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia1b9124f09203c7dcf6d26dee78b09d5a139a04f Gerrit-Change-Number: 31411 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsm_08_58: add IEI to signal HR GSM RTP format via RSL

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30724 ) Change subject: gsm_08_58: add IEI to signal HR GSM RTP format via RSL ...................................................................... Abandoned We have found a better approach, so the IEI is not needed. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8 Gerrit-Change-Number: 30724 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

2 years, 4 months

1
0
0 0

[L] Change in libosmocore[master]: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31356 ) Change subject: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/ ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I70cc21bf25a7081070738abacb409ed19094c3b2 Gerrit-Change-Number: 31356 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 14:23:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmo-netif[master]: fix msgb leak on OSMO_STREAM_SRV_F_FLUSH_DESTROY

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/31368 ) Change subject: fix msgb leak on OSMO_STREAM_SRV_F_FLUSH_DESTROY ...................................................................... fix msgb leak on OSMO_STREAM_SRV_F_FLUSH_DESTROY In osmo_stream_srv_send(), call msgb_free() if the msgb is not enqueued. Before this, osmo_stream_srv_send() enqueues a msgb, assuming the queue will free it. But if OSMO_STREAM_SRV_F_FLUSH_DESTROY is set, it just returns and drops the msgb. There is no rc, so the caller cannot know. Change-Id: I994c5e06a9030cfbf4fca8ab42588c61f7121cee --- M src/stream.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/stream.c b/src/stream.c index 172a299..cbf0b27 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1507,6 +1507,7 @@ OSMO_ASSERT(msg); if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) { LOGP(DLINP, LOGL_DEBUG, "Connection is being flushed and closed; ignoring new outgoing message\n"); + msgb_free(msg); return; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/31368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I994c5e06a9030cfbf4fca8ab42588c61f7121cee Gerrit-Change-Number: 31368 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023